D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dhaumann wrote in kateviewhelpers.cpp:1963
> This is true. But in this case a non-answer: Maybe QIcon::paint does it 
> correct as well. In other words, the code can very likely be improved, but 
> also ok as is.

@anthonyfieroni Why exactly do you think these calls should be kept, and how?

From what I understood the old code to do and tested before & after I had 
changed the code in the updated patch to now use QIcon::paint() instead of 
doing an own scaled QPixmap, the old logic used the devicePixelRatioF() calls 
as needed to match Qt's HiDPI support with internally bigger actual pixmaps. 
Whereas QIcon cares for that now, also in the case where the QIcon is created 
from a single pixmap set via `setMarkPixmap()` in the backward-compat case. So 
there is nothing to be done on our side anymore: we just estimate the "normal" 
size of the icon to be painted, and QIcon will do the actual painting matching 
whatever the HiDPI settings are, like it does in all other places QIcon is used.

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann
Cc: anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, 
sars

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[Anthony Fieroni]

anthonyfieroni accepted this revision.
anthonyfieroni added a comment.
This revision is now accepted and ready to land.


  No, just to not reviewed only by me.

REPOSITORY
  R252 Framework Integration

BRANCH
  messagewidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks, aacid, anthonyfieroni
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27614: build: fix the build where install prefix is not user-writable

[Luca Beltrame]

lbeltrame added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27614

To: bshah, ngraham, lbeltrame
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27614: build: fix the build where install prefix is not user-writable

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: ngraham, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bshah requested review of this revision.

REVISION SUMMARY
  - Validate only the files and symlinks
  - Fix target names, they were swapped
  - generate the icons in build-dir and then install it

TEST PLAN
  done make and make install and verified install_manifest.txt looks sane

REPOSITORY
  R266 Breeze Icons

BRANCH
  bshah/fix-build

REVISION DETAIL
  https://phabricator.kde.org/D27614

AFFECTED FILES
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt
  validate_svg.sh

To: bshah, ngraham, lbeltrame
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Seems FreeBSD has an issue with the generation code. Please check 
https://build.kde.org/view/Failing/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/135/console

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27591

To: alex, elvisangelaccio, #frameworks, mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

[Aleix Pol Gonzalez]

apol added a comment.


  Don't we need an if Qt 5.13 elseif Qt 5.14?
  
  In other Qt versions it won't be in the assets...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27596

To: vkrause
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27594: Remove unused KDBusConnectionPool include

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27594

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Meh, right. I guess it doesn't matter that much.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  polish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27597: KRunner: Refactor deprecated toSet() method

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense. It would be ideal to have a way to do an unsorted comparison 
without having to create 2 temporary sets every time, although I guess it's out 
of scope here.

REPOSITORY
  R308 KRunner

BRANCH
  deprecation_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27597

To: alex, mlaurent, apol, #plasma
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27607: Deprecate KDBusConnectionPool

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:45
> +DEPRECATION_VERSIONS 5.68
> +EXCLUDE_DEPRECATED_BEFORE_AND_AT ${EXCLUDE_DEPRECATED_BEFORE_AND_AT}
> +)

`${EXCLUDE_DEPRECATED_BEFORE_AND_AT}` is not defined by default.

You want to add an option (or actually cached cmake var) in the toplevel 
CMakeLists.txt, lke mentioned in the docs: 
https://api.kde.org/ecm/module/ECMGenerateExportHeader.html
Both to document this flag, as also ensure there the variable is set (did cmake 
not fail for you?):

  set(EXCLUDE_DEPRECATED_BEFORE_AND_AT 0 CACHE STRING "Control the range of 
deprecated API excluded from the build [default=0].")

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D27607

To: vkrause
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27476: [KDBusConnectionPool] Handle the case of no qApp

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Also fixed by D27607 

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D27476

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27591

To: alex, elvisangelaccio, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27607: Deprecate KDBusConnectionPool

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  As per T12722  this is no longer needed, 
QDBusConnection now behaves
  correctly in a multi-threaded scenario.
  
  All uses found by lxr have either been ported already, or have patches
  in review.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27607

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdbusconnectionpool.cpp
  src/kdbusconnectionpool.h
  src/kdeinitinterface.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 251 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/251/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Feb 2020 18:55:14 +
 Build duration:
2 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(231/300)58%
(105/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)78%
(191/245)58%
(95/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 143 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/143/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 23 Feb 2020 18:55:14 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(231/300)58%
(105/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)78%
(191/245)58%
(95/164)

D27586: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 76236.
kossebau marked an inline comment as done.
kossebau added a comment.


  remove unwanted change in KAboutData copyright string

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27586?vs=76194=76236

BRANCH
  spdxlicensefortemplate

REVISION DETAIL
  https://phabricator.kde.org/D27586

AFFECTED FILES
  templates/kpartsapp/LICENSES/GPL-2.0-or-later.txt
  templates/kpartsapp/src/part/%{APPNAMELC}part.cpp
  templates/kpartsapp/src/part/%{APPNAMELC}part.h
  templates/kpartsapp/src/shell/%{APPNAMELC}shell.cpp
  templates/kpartsapp/src/shell/%{APPNAMELC}shell.h
  templates/kpartsapp/src/shell/main.cpp

To: kossebau, cordlandwehr, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27586: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau marked an inline comment as done.
kossebau added inline comments.

INLINE COMMENTS

> cordlandwehr wrote in main.cpp:31
> I do not think that we should change this

Hmpf, that slipped me. The regular expression overdoing its job :)
I guess that will be hit in more KAboutData instances. Perhaps ignoring hits 
which are enclosed by " might filter this properly?
Also should no space be added possibly if  is missing?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27586

To: kossebau, cordlandwehr, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 136 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/136/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 23 Feb 2020 18:55:14 +
 Build duration:
23 sec and counting
   CONSOLE OUTPUT
  [...truncated 134 lines...][2020-02-23T18:55:33.187Z] SHLVL = '0'[2020-02-23T18:55:33.187Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-23T18:55:33.187Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-23T18:55:33.187Z] PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-23T18:55:33.187Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2020-02-23T18:55:33.187Z] XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'[2020-02-23T18:55:33.187Z] QT_SELECT = 'qt5'[2020-02-23T18:55:33.187Z] LANG  = 'en_US.UTF-8'[2020-02-23T18:55:33.187Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-23T18:55:33.187Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-23T18:55:33.187Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-23T18:55:33.187Z] [2020-02-23T18:55:33.187Z] [2020-02-23T18:55:33.187Z] == Commencing Configuration:[2020-02-23T18:55:33.187Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13"[2020-02-23T18:55:33.187Z] -- The C compiler identification is Clang 8.0.1[2020-02-23T18:55:33.443Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-23T18:55:33.443Z] -- Check for working C compiler: /usr/bin/cc[2020-02-23T18:55:33.443Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-23T18:55:33.443Z] -- Detecting C compiler ABI info[2020-02-23T18:55:33.443Z] -- Detecting C compiler ABI info - done[2020-02-23T18:55:33.443Z] -- Detecting C compile features[2020-02-23T18:55:33.443Z] -- Detecting C compile features - done[2020-02-23T18:55:33.443Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-23T18:55:33.443Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-23T18:55:33.443Z] -- Detecting CXX compiler ABI info[2020-02-23T18:55:33.702Z] -- Detecting CXX compiler ABI info - done[2020-02-23T18:55:33.702Z] -- Detecting CXX compile features[2020-02-23T18:55:33.702Z] -- Detecting CXX compile features - done[2020-02-23T18:55:33.702Z] -- [2020-02-23T18:55:33.702Z] [2020-02-23T18:55:33.702Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-23T18:55:33.702Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-23T18:55:33.702Z] -- Looking for __GLIBC__[2020-02-23T18:55:33.702Z] -- Looking for __GLIBC__ - not found[2020-02-23T18:55:33.702Z] -- Performing Test _OFFT_IS_64BIT[2020-02-23T18:55:33.702Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-23T18:55:33.702Z] -- Performing Test HAVE_DATE_TIME[2020-02-23T18:55:33.957Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-23T18:55:34.213Z] -- The following REQUIRED packages have been found:[2020-02-23T18:55:34.213Z] [2020-02-23T18:55:34.213Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-23T18:55:34.213Z]  * Qt5Core[2020-02-23T18:55:34.213Z]  * Qt5Test[2020-02-23T18:55:34.213Z]  * Qt5 (required version >= 5.12.0)[2020-02-23T18:55:34.213Z] [2020-02-23T18:55:34.213Z] -- Configuring done[2020-02-23T18:55:35.140Z] -- Generating done[2020-02-23T18:55:35.140Z] CMake Warning:[2020-02-23T18:55:35.140Z]   Manually-specified variables were not used by the project:[2020-02-23T18:55:35.140Z] [2020-02-23T18:55:35.140Z] BUILD_QCH[2020-02-23T18:55:35.140Z] [2020-02-23T18:55:35.140Z] [2020-02-23T18:55:35.140Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-23T18:55:36.698Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-02-23T18:55:36.698Z] Scanning dependencies of target qrcAlias_autogen[2020-02-23T18:55:36.698Z] Scanning dependencies of target symlink_autogen[2020-02-23T18:55:36.698Z] Scanning dependencies of target breeze-generate-24px-versions-dark[2020-02-23T18:55:36.698Z] Scanning dependencies of target breeze-icons-dark-mkdir[2020-02-23T18:55:36.698Z] Scanning dependencies of target breeze-validate-svg[2020-02-23T18:55:36.698Z] Scanning dependencies of target 

D27605: Also auto-generate 24@2x compatibility symlinks

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:67f60a7322ac: Also auto-generate 24@2x compatibility 
symlinks (authored by ngraham, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27605?vs=76230=76235

REVISION DETAIL
  https://phabricator.kde.org/D27605

AFFECTED FILES
  generate-24px-versions.sh
  icons-dark/actions/24@2x
  icons/actions/24@2x

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27588: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R308:1db8ad9e2a2a: templates: Convert license statements to 
SPDX headers (authored by kossebau).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27588?vs=76196=76234

REVISION DETAIL
  https://phabricator.kde.org/D27588

AFFECTED FILES
  templates/runner/LICENSES/LGPL-2.1-or-later.txt
  templates/runner/src/%{APPNAMELC}.cpp
  templates/runner/src/%{APPNAMELC}.h

To: kossebau, cordlandwehr, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27587: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:fdd98f815ace: templates: Convert license statements to 
SPDX headers (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27587?vs=76195=76233

REVISION DETAIL
  https://phabricator.kde.org/D27587

AFFECTED FILES
  templates/ktexteditor-plugin/LICENSES/GPL-2.0-or-later.txt
  templates/ktexteditor-plugin/src/%{APPNAMELC}plugin.cpp
  templates/ktexteditor-plugin/src/%{APPNAMELC}plugin.h
  templates/ktexteditor-plugin/src/%{APPNAMELC}view.cpp
  templates/ktexteditor-plugin/src/%{APPNAMELC}view.h

To: kossebau, #kate, cordlandwehr
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27605: Also auto-generate 24@2x compatibility symlinks

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  create-2x-compatibility-dirs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27605

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham added a revision: D27605: Also auto-generate 24@2x compatibility 
symlinks.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

D27605: Also auto-generate 24@2x compatibility symlinks

[Nathaniel Graham]

ngraham added a task: T11950: Reduce the pain of working on monochrome Breeze 
icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27605

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27605: Also auto-generate 24@2x compatibility symlinks

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Missed this in  D27557 , sorry.

TEST PLAN
  Delete `~/kde/usr/share/icons/{breeze,breeze-dark}` (or wherever your icons 
live)
  Apply patch and build
  Look in 
`~/kde/usr/share/icons/{breeze,breeze-dark}/{devices,actions,places,status}`
  Notice that @2x symlinks are still there

REPOSITORY
  R266 Breeze Icons

BRANCH
  create-2x-compatibility-dirs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27605

AFFECTED FILES
  generate-24px-versions.sh
  icons-dark/actions/24@2x
  icons/actions/24@2x

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 250 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/250/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Feb 2020 16:45:24 +
 Build duration:
1 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 224 lines...][2020-02-23T16:46:10.337Z] [2020-02-23T16:46:10.592Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for BreezeIcons.[2020-02-23T16:46:10.592Z] -- Looking for __GLIBC__[2020-02-23T16:46:10.592Z] -- Looking for __GLIBC__ - found[2020-02-23T16:46:10.592Z] -- Performing Test _OFFT_IS_64BIT[2020-02-23T16:46:10.849Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-23T16:46:10.849Z] -- Performing Test HAVE_DATE_TIME[2020-02-23T16:46:10.849Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-23T16:46:11.409Z] -- The following REQUIRED packages have been found:[2020-02-23T16:46:11.409Z] [2020-02-23T16:46:11.409Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-23T16:46:11.409Z]  * Qt5Core[2020-02-23T16:46:11.409Z]  * Qt5Test[2020-02-23T16:46:11.409Z]  * Qt5 (required version >= 5.12.0)[2020-02-23T16:46:11.409Z] [2020-02-23T16:46:11.409Z] -- Configuring done[2020-02-23T16:46:12.337Z] -- Generating done[2020-02-23T16:46:12.337Z] CMake Warning:[2020-02-23T16:46:12.337Z]   Manually-specified variables were not used by the project:[2020-02-23T16:46:12.337Z] [2020-02-23T16:46:12.337Z] BUILD_QCH[2020-02-23T16:46:12.337Z] [2020-02-23T16:46:12.337Z] [2020-02-23T16:46:12.337Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-23T16:46:13.463Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-02-23T16:46:13.463Z] Scanning dependencies of target breeze-validate-svg[2020-02-23T16:46:13.463Z] Scanning dependencies of target scalable_autogen[2020-02-23T16:46:13.463Z] Scanning dependencies of target qrcAlias_autogen[2020-02-23T16:46:13.463Z] Scanning dependencies of target symlink_autogen[2020-02-23T16:46:13.463Z] Scanning dependencies of target dupe_autogen[2020-02-23T16:46:13.463Z] Scanning dependencies of target newline_autogen[2020-02-23T16:46:13.463Z] [  8%] Automatic MOC for target symlink[2020-02-23T16:46:13.463Z] [  8%] Automatic MOC for target scalable[2020-02-23T16:46:13.463Z] [ 12%] Automatic MOC for target qrcAlias[2020-02-23T16:46:13.463Z] [ 16%] Automatic MOC for target dupe[2020-02-23T16:46:13.463Z] [ 20%] Automatic MOC for target newline[2020-02-23T16:46:13.463Z] [ 20%] Built target qrcAlias_autogen[2020-02-23T16:46:13.463Z] Scanning dependencies of target breeze-icons-mkdir[2020-02-23T16:46:13.463Z] [ 20%] Built target breeze-icons-mkdir[2020-02-23T16:46:13.463Z] Scanning dependencies of target breeze-generate-24px-versions-dark[2020-02-23T16:46:14.389Z] [ 20%] Built target breeze-validate-svg[2020-02-23T16:46:14.389Z] Scanning dependencies of target breeze-icons-dark-mkdir[2020-02-23T16:46:14.389Z] [ 20%] Built target breeze-icons-dark-mkdir[2020-02-23T16:46:14.389Z] Scanning dependencies of target breeze-generate-24px-versions[2020-02-23T16:46:14.645Z] [ 20%] Built target dupe_autogen[2020-02-23T16:46:14.645Z] [ 20%] Built target scalable_autogen[2020-02-23T16:46:14.645Z] [ 20%] Built target newline_autogen[2020-02-23T16:46:14.645Z] [ 20%] Built target symlink_autogen[2020-02-23T16:46:14.645Z] Scanning dependencies of target qrcAlias[2020-02-23T16:46:14.645Z] [ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:14.645Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2020-02-23T16:46:14.900Z] Scanning dependencies of target scalable[2020-02-23T16:46:14.900Z] Scanning dependencies of target dupe[2020-02-23T16:46:14.900Z] Scanning dependencies of target symlink[2020-02-23T16:46:14.900Z] [ 33%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:14.900Z] [ 37%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:14.900Z] [ 41%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:14.900Z] [ 45%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2020-02-23T16:46:14.900Z] [ 50%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2020-02-23T16:46:14.900Z] [ 54%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2020-02-23T16:46:16.267Z] [ 58%] Linking CXX executable bin/qrcAlias[2020-02-23T16:46:16.522Z] [ 62%] Linking CXX executable ../bin/symlink[2020-02-23T16:46:16.522Z] [ 66%] Linking CXX 

T11950: Reduce the pain of working on monochrome Breeze icons

[Nathaniel Graham]

ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham
Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, michaelh, crozbo, 
firef, bruns, skadinna, aaronhoneycutt, mbohlender

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 142 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/142/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 23 Feb 2020 16:45:24 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 222 lines...][2020-02-23T16:46:00.587Z] [2020-02-23T16:46:00.587Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-23T16:46:00.587Z] -- Looking for __GLIBC__[2020-02-23T16:46:00.842Z] -- Looking for __GLIBC__ - found[2020-02-23T16:46:00.842Z] -- Performing Test _OFFT_IS_64BIT[2020-02-23T16:46:00.842Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-23T16:46:00.842Z] -- Performing Test HAVE_DATE_TIME[2020-02-23T16:46:00.842Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-23T16:46:01.098Z] -- The following REQUIRED packages have been found:[2020-02-23T16:46:01.098Z] [2020-02-23T16:46:01.098Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-23T16:46:01.098Z]  * Qt5Core[2020-02-23T16:46:01.098Z]  * Qt5Test[2020-02-23T16:46:01.098Z]  * Qt5 (required version >= 5.12.0)[2020-02-23T16:46:01.098Z] [2020-02-23T16:46:01.352Z] -- Configuring done[2020-02-23T16:46:01.608Z] -- Generating done[2020-02-23T16:46:01.608Z] CMake Warning:[2020-02-23T16:46:01.608Z]   Manually-specified variables were not used by the project:[2020-02-23T16:46:01.608Z] [2020-02-23T16:46:01.608Z] BUILD_QCH[2020-02-23T16:46:01.608Z] [2020-02-23T16:46:01.608Z] [2020-02-23T16:46:01.608Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-23T16:46:02.782Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2020-02-23T16:46:02.782Z] Scanning dependencies of target breeze-validate-svg[2020-02-23T16:46:02.782Z] Scanning dependencies of target qrcAlias_autogen[2020-02-23T16:46:02.782Z] Scanning dependencies of target dupe_autogen[2020-02-23T16:46:02.782Z] Scanning dependencies of target breeze-icons-dark-mkdir[2020-02-23T16:46:02.782Z] Scanning dependencies of target symlink_autogen[2020-02-23T16:46:02.782Z] Scanning dependencies of target breeze-generate-24px-versions[2020-02-23T16:46:02.782Z] Scanning dependencies of target scalable_autogen[2020-02-23T16:46:02.782Z] Scanning dependencies of target newline_autogen[2020-02-23T16:46:02.782Z] Scanning dependencies of target breeze-icons-mkdir[2020-02-23T16:46:02.782Z] Scanning dependencies of target breeze-generate-24px-versions-dark[2020-02-23T16:46:02.782Z] [  4%] Automatic MOC for target qrcAlias[2020-02-23T16:46:02.782Z] [  8%] Automatic MOC for target dupe[2020-02-23T16:46:02.782Z] [ 12%] Automatic MOC for target symlink[2020-02-23T16:46:02.782Z] [ 16%] Automatic MOC for target newline[2020-02-23T16:46:02.782Z] [ 20%] Automatic MOC for target scalable[2020-02-23T16:46:02.782Z] [ 20%] Built target breeze-icons-mkdir[2020-02-23T16:46:02.782Z] [ 20%] Built target breeze-icons-dark-mkdir[2020-02-23T16:46:02.782Z] [ 20%] Built target qrcAlias_autogen[2020-02-23T16:46:02.782Z] Scanning dependencies of target qrcAlias[2020-02-23T16:46:02.782Z] [ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:02.782Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2020-02-23T16:46:03.038Z] [ 29%] Built target scalable_autogen[2020-02-23T16:46:03.038Z] [ 29%] Built target symlink_autogen[2020-02-23T16:46:03.038Z] [ 29%] Built target dupe_autogen[2020-02-23T16:46:03.038Z] [ 29%] Built target newline_autogen[2020-02-23T16:46:03.038Z] Scanning dependencies of target scalable[2020-02-23T16:46:03.038Z] Scanning dependencies of target symlink[2020-02-23T16:46:03.038Z] Scanning dependencies of target dupe[2020-02-23T16:46:03.038Z] Scanning dependencies of target newline[2020-02-23T16:46:03.038Z] [ 37%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:03.038Z] [ 37%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:03.038Z] [ 41%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:03.038Z] [ 45%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[2020-02-23T16:46:03.038Z] [ 50%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2020-02-23T16:46:03.038Z] [ 54%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2020-02-23T16:46:03.038Z] [ 58%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2020-02-23T16:46:03.038Z] [ 62%] Building CXX object 

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 135 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/135/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 23 Feb 2020 16:45:24 +
 Build duration:
25 sec and counting
   CONSOLE OUTPUT
  [...truncated 134 lines...][2020-02-23T16:45:43.772Z] SHLVL = '0'[2020-02-23T16:45:43.772Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-23T16:45:43.772Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-23T16:45:43.772Z] PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-23T16:45:43.772Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2020-02-23T16:45:43.772Z] XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'[2020-02-23T16:45:43.772Z] QT_SELECT = 'qt5'[2020-02-23T16:45:43.772Z] LANG  = 'en_US.UTF-8'[2020-02-23T16:45:43.772Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-23T16:45:43.772Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-23T16:45:43.772Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-23T16:45:43.772Z] [2020-02-23T16:45:43.772Z] [2020-02-23T16:45:43.772Z] == Commencing Configuration:[2020-02-23T16:45:43.772Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13"[2020-02-23T16:45:43.772Z] -- The C compiler identification is Clang 8.0.1[2020-02-23T16:45:44.033Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-23T16:45:44.033Z] -- Check for working C compiler: /usr/bin/cc[2020-02-23T16:45:44.033Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-23T16:45:44.033Z] -- Detecting C compiler ABI info[2020-02-23T16:45:44.033Z] -- Detecting C compiler ABI info - done[2020-02-23T16:45:44.033Z] -- Detecting C compile features[2020-02-23T16:45:44.033Z] -- Detecting C compile features - done[2020-02-23T16:45:44.033Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-23T16:45:44.033Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-23T16:45:44.033Z] -- Detecting CXX compiler ABI info[2020-02-23T16:45:44.288Z] -- Detecting CXX compiler ABI info - done[2020-02-23T16:45:44.288Z] -- Detecting CXX compile features[2020-02-23T16:45:44.288Z] -- Detecting CXX compile features - done[2020-02-23T16:45:44.288Z] -- [2020-02-23T16:45:44.288Z] [2020-02-23T16:45:44.288Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-23T16:45:44.288Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-23T16:45:44.288Z] -- Looking for __GLIBC__[2020-02-23T16:45:44.288Z] -- Looking for __GLIBC__ - not found[2020-02-23T16:45:44.288Z] -- Performing Test _OFFT_IS_64BIT[2020-02-23T16:45:44.288Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-23T16:45:44.288Z] -- Performing Test HAVE_DATE_TIME[2020-02-23T16:45:44.543Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-23T16:45:45.103Z] -- The following REQUIRED packages have been found:[2020-02-23T16:45:45.103Z] [2020-02-23T16:45:45.103Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-23T16:45:45.103Z]  * Qt5Core[2020-02-23T16:45:45.103Z]  * Qt5Test[2020-02-23T16:45:45.103Z]  * Qt5 (required version >= 5.12.0)[2020-02-23T16:45:45.103Z] [2020-02-23T16:45:45.103Z] -- Configuring done[2020-02-23T16:45:46.029Z] -- Generating done[2020-02-23T16:45:46.029Z] CMake Warning:[2020-02-23T16:45:46.029Z]   Manually-specified variables were not used by the project:[2020-02-23T16:45:46.029Z] [2020-02-23T16:45:46.029Z] BUILD_QCH[2020-02-23T16:45:46.029Z] [2020-02-23T16:45:46.029Z] [2020-02-23T16:45:46.029Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-23T16:45:47.017Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-02-23T16:45:47.017Z] Scanning dependencies of target qrcAlias_autogen[2020-02-23T16:45:47.017Z] Scanning dependencies of target symlink_autogen[2020-02-23T16:45:47.017Z] Scanning dependencies of target scalable_autogen[2020-02-23T16:45:47.017Z] Scanning dependencies of target newline_autogen[2020-02-23T16:45:47.017Z] Scanning dependencies of target breeze-validate-svg[2020-02-23T16:45:47.017Z] Scanning dependencies of target breeze-icons-mkdir[2020-02-23T16:45:47.017Z] Scanning 

D27557: Auto-generate 24px monochrome icons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:d0582a4f16bd: Auto-generate 24px monochrome icons 
(authored by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27557?vs=76228=76229

REVISION DETAIL
  https://phabricator.kde.org/D27557

AFFECTED FILES
  generate-24px-versions.sh
  icons-dark/CMakeLists.txt
  icons-dark/actions/24/acrobat.svg
  icons-dark/actions/24/activities.svg
  icons-dark/actions/24/address-book-new.svg
  icons-dark/actions/24/align-horizontal-baseline.svg
  icons-dark/actions/24/align-horizontal-bottom-out.svg
  icons-dark/actions/24/align-horizontal-center.svg
  icons-dark/actions/24/align-horizontal-left-out.svg
  icons-dark/actions/24/align-horizontal-left-to-anchor.svg
  icons-dark/actions/24/align-horizontal-left.svg
  icons-dark/actions/24/align-horizontal-node.svg
  icons-dark/actions/24/align-horizontal-right-out.svg
  icons-dark/actions/24/align-horizontal-right-to-anchor.svg
  icons-dark/actions/24/align-horizontal-right.svg
  icons-dark/actions/24/align-horizontal-top-out.svg
  icons-dark/actions/24/align-vertical-baseline.svg
  icons-dark/actions/24/align-vertical-bottom-out.svg
  icons-dark/actions/24/align-vertical-bottom-to-anchor.svg
  icons-dark/actions/24/align-vertical-bottom.svg
  icons-dark/actions/24/align-vertical-center.svg
  icons-dark/actions/24/align-vertical-node.svg
  icons-dark/actions/24/align-vertical-top-out.svg
  icons-dark/actions/24/align-vertical-top-to-anchor.svg
  icons-dark/actions/24/align-vertical-top.svg
  icons-dark/actions/24/amarok_cart_view.svg
  icons-dark/actions/24/application-exit.svg
  icons-dark/actions/24/application-menu.svg
  icons-dark/actions/24/appointment-new.svg
  icons-dark/actions/24/archive-extract.svg
  icons-dark/actions/24/archive-insert-directory.svg
  icons-dark/actions/24/archive-insert.svg
  icons-dark/actions/24/archive-remove.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-down.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-left.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-right.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/24/arrow-up.svg
  icons-dark/actions/24/audio-volume-high.svg
  icons-dark/actions/24/audio-volume-low.svg
  icons-dark/actions/24/audio-volume-medium.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons-dark/actions/24/auto-scale-all.svg
  icons-dark/actions/24/auto-scale-x.svg
  icons-dark/actions/24/auto-scale-y.svg
  icons-dark/actions/24/autocorrection.svg
  icons-dark/actions/24/bookmark-new-list.svg
  icons-dark/actions/24/bookmark-new.svg
  icons-dark/actions/24/bookmark-toolbar.svg
  icons-dark/actions/24/bookmarks-organize.svg
  icons-dark/actions/24/bookmarks.svg
  icons-dark/actions/24/bordertool.svg
  icons-dark/actions/24/call-start.svg
  icons-dark/actions/24/call-stop.svg
  icons-dark/actions/24/character-set.svg
  icons-dark/actions/24/checkbox.svg
  icons-dark/actions/24/chronometer-lap.svg
  icons-dark/actions/24/chronometer-pause.svg
  icons-dark/actions/24/chronometer-reset.svg
  icons-dark/actions/24/chronometer-start.svg
  icons-dark/actions/24/chronometer.svg
  icons-dark/actions/24/class-or-package.svg
  icons-dark/actions/24/code-block.svg
  icons-dark/actions/24/code-class.svg
  icons-dark/actions/24/code-context.svg
  icons-dark/actions/24/code-function.svg
  icons-dark/actions/24/code-typedef.svg
  icons-dark/actions/24/code-variable.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/color-fill.svg
  icons-dark/actions/24/color-gradient.svg
  icons-dark/actions/24/color-management.svg
  icons-dark/actions/24/color-picker-black.svg
  icons-dark/actions/24/color-picker-grey.svg
  icons-dark/actions/24/color-picker-white.svg
  icons-dark/actions/24/color-picker.svg
  icons-dark/actions/24/colormanagement.svg
  icons-dark/actions/24/configure-shortcuts.svg
  icons-dark/actions/24/configure-toolbars.svg
  icons-dark/actions/24/configure.svg
  icons-dark/actions/24/contact-new.svg
  icons-dark/actions/24/contrast.svg
  icons-dark/actions/24/cursor-arrow.svg
  icons-dark/actions/24/dashboard-show.svg
  icons-dark/actions/24/database-change-key.svg
  icons-dark/actions/24/database-index.svg
  icons-dark/actions/24/debug-execute-from-cursor.svg
  icons-dark/actions/24/debug-execute-to-cursor.svg
  icons-dark/actions/24/debug-run-cursor.svg
  icons-dark/actions/24/debug-run.svg
  icons-dark/actions/24/debug-step-instruction.svg
  icons-dark/actions/24/debug-step-into-instruction.svg
  icons-dark/actions/24/debug-step-into.svg
  icons-dark/actions/24/debug-step-out.svg
  icons-dark/actions/24/debug-step-over.svg
  icons-dark/actions/24/dialog-cancel.svg
  icons-dark/actions/24/dialog-close.svg
  icons-dark/actions/24/dialog-messages.svg
  icons-dark/actions/24/dialog-ok-apply.svg
  icons-dark/actions/24/dialog-ok.svg
  

D27557: Auto-generate 24px monochrome icons

[Nathaniel Graham]

ngraham updated this revision to Diff 76228.
ngraham added a comment.


  Rebase (thanks for the icon fixes, @ndavis)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27557?vs=76129=76228

BRANCH
  autogenerate-24px-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27557

AFFECTED FILES
  generate-24px-versions.sh
  icons-dark/CMakeLists.txt
  icons-dark/actions/24/acrobat.svg
  icons-dark/actions/24/activities.svg
  icons-dark/actions/24/address-book-new.svg
  icons-dark/actions/24/align-horizontal-baseline.svg
  icons-dark/actions/24/align-horizontal-bottom-out.svg
  icons-dark/actions/24/align-horizontal-center.svg
  icons-dark/actions/24/align-horizontal-left-out.svg
  icons-dark/actions/24/align-horizontal-left-to-anchor.svg
  icons-dark/actions/24/align-horizontal-left.svg
  icons-dark/actions/24/align-horizontal-node.svg
  icons-dark/actions/24/align-horizontal-right-out.svg
  icons-dark/actions/24/align-horizontal-right-to-anchor.svg
  icons-dark/actions/24/align-horizontal-right.svg
  icons-dark/actions/24/align-horizontal-top-out.svg
  icons-dark/actions/24/align-vertical-baseline.svg
  icons-dark/actions/24/align-vertical-bottom-out.svg
  icons-dark/actions/24/align-vertical-bottom-to-anchor.svg
  icons-dark/actions/24/align-vertical-bottom.svg
  icons-dark/actions/24/align-vertical-center.svg
  icons-dark/actions/24/align-vertical-node.svg
  icons-dark/actions/24/align-vertical-top-out.svg
  icons-dark/actions/24/align-vertical-top-to-anchor.svg
  icons-dark/actions/24/align-vertical-top.svg
  icons-dark/actions/24/amarok_cart_view.svg
  icons-dark/actions/24/application-exit.svg
  icons-dark/actions/24/application-menu.svg
  icons-dark/actions/24/appointment-new.svg
  icons-dark/actions/24/archive-extract.svg
  icons-dark/actions/24/archive-insert-directory.svg
  icons-dark/actions/24/archive-insert.svg
  icons-dark/actions/24/archive-remove.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-down.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-left.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-right.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/24/arrow-up.svg
  icons-dark/actions/24/audio-volume-high.svg
  icons-dark/actions/24/audio-volume-low.svg
  icons-dark/actions/24/audio-volume-medium.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons-dark/actions/24/auto-scale-all.svg
  icons-dark/actions/24/auto-scale-x.svg
  icons-dark/actions/24/auto-scale-y.svg
  icons-dark/actions/24/autocorrection.svg
  icons-dark/actions/24/bookmark-new-list.svg
  icons-dark/actions/24/bookmark-new.svg
  icons-dark/actions/24/bookmark-toolbar.svg
  icons-dark/actions/24/bookmarks-organize.svg
  icons-dark/actions/24/bookmarks.svg
  icons-dark/actions/24/bordertool.svg
  icons-dark/actions/24/call-start.svg
  icons-dark/actions/24/call-stop.svg
  icons-dark/actions/24/character-set.svg
  icons-dark/actions/24/checkbox.svg
  icons-dark/actions/24/chronometer-lap.svg
  icons-dark/actions/24/chronometer-pause.svg
  icons-dark/actions/24/chronometer-reset.svg
  icons-dark/actions/24/chronometer-start.svg
  icons-dark/actions/24/chronometer.svg
  icons-dark/actions/24/class-or-package.svg
  icons-dark/actions/24/code-block.svg
  icons-dark/actions/24/code-class.svg
  icons-dark/actions/24/code-context.svg
  icons-dark/actions/24/code-function.svg
  icons-dark/actions/24/code-typedef.svg
  icons-dark/actions/24/code-variable.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/color-fill.svg
  icons-dark/actions/24/color-gradient.svg
  icons-dark/actions/24/color-management.svg
  icons-dark/actions/24/color-picker-black.svg
  icons-dark/actions/24/color-picker-grey.svg
  icons-dark/actions/24/color-picker-white.svg
  icons-dark/actions/24/color-picker.svg
  icons-dark/actions/24/colormanagement.svg
  icons-dark/actions/24/configure-shortcuts.svg
  icons-dark/actions/24/configure-toolbars.svg
  icons-dark/actions/24/configure.svg
  icons-dark/actions/24/contact-new.svg
  icons-dark/actions/24/contrast.svg
  icons-dark/actions/24/cursor-arrow.svg
  icons-dark/actions/24/dashboard-show.svg
  icons-dark/actions/24/database-change-key.svg
  icons-dark/actions/24/database-index.svg
  icons-dark/actions/24/debug-execute-from-cursor.svg
  icons-dark/actions/24/debug-execute-to-cursor.svg
  icons-dark/actions/24/debug-run-cursor.svg
  icons-dark/actions/24/debug-run.svg
  icons-dark/actions/24/debug-step-instruction.svg
  icons-dark/actions/24/debug-step-into-instruction.svg
  icons-dark/actions/24/debug-step-into.svg
  icons-dark/actions/24/debug-step-out.svg
  icons-dark/actions/24/debug-step-over.svg
  icons-dark/actions/24/dialog-cancel.svg
  icons-dark/actions/24/dialog-close.svg
  icons-dark/actions/24/dialog-messages.svg
  icons-dark/actions/24/dialog-ok-apply.svg
  icons-dark/actions/24/dialog-ok.svg
  

D27589: Try to apply the colorscheme of the current theme to QIcons

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack, ngraham
Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27596: Load QM files from assets: URLs on Android

[Volker Krause]

vkrause added a task: T12520: Qt 5.14.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27596

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

[Wolfgang Bauer]

wbauer added a comment.


  Confirmed. I tried out the patch now, and that problem is gone.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack
Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27603: KDNSSD: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX statements and add license files
  as required by SPDX specification

REPOSITORY
  R272 KDNSSD

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27603

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-or-later.txt
  cmake/FindAvahi.cmake
  cmake/FindDNSSD.cmake
  src/avahi-domainbrowser.cpp
  src/avahi-domainbrowser_p.h
  src/avahi-publicservice.cpp
  src/avahi-publicservice_p.h
  src/avahi-remoteservice.cpp
  src/avahi-remoteservice_p.h
  src/avahi-servicebrowser.cpp
  src/avahi-servicebrowser_p.h
  src/avahi-servicetypebrowser.cpp
  src/avahi-servicetypebrowser_p.h
  src/avahi_listener.cpp
  src/avahi_listener_p.h
  src/domainbrowser.h
  src/domainmodel.cpp
  src/domainmodel.h
  src/dummy-domainbrowser.cpp
  src/dummy-publicservice.cpp
  src/dummy-remoteservice.cpp
  src/dummy-servicebrowser.cpp
  src/dummy-servicetypebrowser.cpp
  src/mdnsd-domainbrowser.cpp
  src/mdnsd-domainbrowser_p.h
  src/mdnsd-publicservice.cpp
  src/mdnsd-remoteservice.cpp
  src/mdnsd-responder.cpp
  src/mdnsd-responder.h
  src/mdnsd-sdevent.h
  src/mdnsd-servicebrowser.cpp
  src/mdnsd-servicebrowser_p.h
  src/mdnsd-servicetypebrowser.cpp
  src/mdnsd-servicetypebrowser_p.h
  src/org.freedesktop.Avahi.DomainBrowser.xml
  src/org.freedesktop.Avahi.ServiceBrowser.xml
  src/org.freedesktop.Avahi.ServiceTypeBrowser.xml
  src/publicservice.h
  src/remoteservice.h
  src/servicebase.cpp
  src/servicebase.h
  src/servicebase_p.h
  src/servicebrowser.h
  src/servicemodel.cpp
  src/servicemodel.h
  src/servicetypebrowser.h

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27603: KDNSSD: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D27603

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27602: KDbusAddons: Convert license statement to SPDX

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX and add license
  files as required by REUSE.

REPOSITORY
  R271 KDBusAddons

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27602

AFFECTED FILES
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/deadservicetest.cpp
  autotests/kdbusinterprocesslocktest.cpp
  autotests/kdbusservicetest.cpp
  autotests/kdbussimpleservice.cpp
  src/kdbusconnectionpool.cpp
  src/kdbusconnectionpool.h
  src/kdbusinterprocesslock.cpp
  src/kdbusinterprocesslock.h
  src/kdbusservice.cpp
  src/kdbusservice.h
  src/kdedmodule.cpp
  src/kdedmodule.h
  src/kdeinitinterface.cpp
  src/kdeinitinterface.h
  src/tools/kquitapp/kquitapp.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27602: KDbusAddons: Convert license statement to SPDX

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D27602

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27601

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX statements and add
  license files as required by REUSE specification.

REPOSITORY
  R237 KConfig

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27601

AFFECTED FILES
  KF5ConfigMacros.cmake
  LICENSES/BSD-2-Clause.txt
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/MIT.txt
  autotests/fallbackconfigresourcestest.cpp
  autotests/helper.h
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/kconfigcompiler_test.h
  autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp
  autotests/kconfig_compiler/klocalizedstring.h
  autotests/kconfig_compiler/test10main.cpp
  autotests/kconfig_compiler/test11_types.h
  autotests/kconfig_compiler/test11main.cpp
  autotests/kconfig_compiler/test12main.cpp
  autotests/kconfig_compiler/test13main.cpp
  autotests/kconfig_compiler/test1main.cpp
  autotests/kconfig_compiler/test2main.cpp
  autotests/kconfig_compiler/test3amain.cpp
  autotests/kconfig_compiler/test3main.cpp
  autotests/kconfig_compiler/test4main.cpp
  autotests/kconfig_compiler/test5main.cpp
  autotests/kconfig_compiler/test6main.cpp
  autotests/kconfig_compiler/test7main.cpp
  autotests/kconfig_compiler/test8main.cpp
  autotests/kconfig_compiler/test9main.cpp
  autotests/kconfig_compiler/test_dpointer_main.cpp
  autotests/kconfig_compiler/test_emptyentries_main.cpp
  autotests/kconfig_compiler/test_fileextensions_main.cxx
  autotests/kconfig_compiler/test_notifiers_main.cpp
  autotests/kconfig_compiler/test_qdebugcategorymain.cpp
  autotests/kconfig_compiler/test_signal_main.cpp
  autotests/kconfig_compiler/test_translation_kde_domain_main.cpp
  autotests/kconfig_compiler/test_translation_kde_main.cpp
  autotests/kconfig_compiler/test_translation_qt_main.cpp
  autotests/kconfigguitest.cpp
  autotests/kconfigguitest.h
  autotests/kconfigloadertest.cpp
  autotests/kconfigloadertest.h
  autotests/kconfignokdehometest.cpp
  autotests/kconfigskeletontest.cpp
  autotests/kconfigskeletontest.h
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  autotests/kdesktopfiletest.cpp
  autotests/kdesktopfiletest.h
  autotests/kentrymaptest.cpp
  autotests/kentrymaptest.h
  autotests/ksharedconfig_in_global_object.cpp
  autotests/ksharedconfigtest.cpp
  autotests/kstandardshortcuttest.cpp
  autotests/kstandardshortcuttest.h
  autotests/test_kconf_update.cpp
  autotests/test_kconf_update.h
  autotests/test_kconfigutils.cpp
  autotests/test_kconfigutils.h
  cmake/rules_PyKF5.py
  src/core/bufferfragment_p.h
  src/core/conversioncheck.h
  src/core/kauthorized.cpp
  src/core/kauthorized.h
  src/core/kconfig.cpp
  src/core/kconfig.h
  src/core/kconfig_p.h
  src/core/kconfigbackend.cpp
  src/core/kconfigbackend_p.h
  src/core/kconfigbase.cpp
  src/core/kconfigbase.h
  src/core/kconfigbase_p.h
  src/core/kconfigdata.cpp
  src/core/kconfigdata.h
  src/core/kconfiggroup.cpp
  src/core/kconfiggroup.h
  src/core/kconfiggroup_p.h
  src/core/kconfigini.cpp
  src/core/kconfigini_p.h
  src/core/kconfigwatcher.cpp
  src/core/kconfigwatcher.h
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h
  src/core/kemailsettings.cpp
  src/core/kemailsettings.h
  src/core/ksharedconfig.cpp
  src/core/ksharedconfig.h
  src/gui/kconfiggroupgui.cpp
  src/gui/kconfiggui.cpp
  src/gui/kconfiggui.h
  src/gui/kconfigloader.cpp
  src/gui/kconfigloader.h
  src/gui/kconfigloader_p.h
  src/gui/kconfigloaderhandler_p.h
  src/gui/kconfigskeleton.cpp
  src/gui/kconfigskeleton.h
  src/gui/kstandardshortcut.cpp
  src/gui/kstandardshortcut.h
  src/gui/kwindowconfig.cpp
  src/gui/kwindowconfig.h
  src/kconf_update/kconf_update.cpp
  src/kconf_update/kconfigutils.cpp
  src/kconf_update/kconfigutils.h
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigParameters.cpp
  src/kconfig_compiler/KConfigParameters.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd
  src/kconfig_compiler/kconfig_compiler.cpp
  src/kreadconfig/kreadconfig.cpp
  src/kreadconfig/kwriteconfig.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27586: templates: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr requested changes to this revision.
cordlandwehr added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:31
>  KAboutLicense::GPL,
> -i18n("Copyright %{CURRENT_YEAR} %{AUTHOR}"));
> +i18n("SPDX-FileCopyrightText: %{CURRENT_YEAR} %{AUTHOR} "));
>  aboutData.addAuthor(i18n("%{AUTHOR}"), i18n("Author"), 
> QStringLiteral("%{EMAIL}"));

I do not think that we should change this

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27586

To: kossebau, cordlandwehr, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27597: KRunner: Refactor deprecated toSet() method

[Alexander Lohnau]

alex added a reviewer: Plasma.
alex added a comment.


  Thanks :-)

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D27597

To: alex, mlaurent, apol, #plasma
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27587: templates: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr accepted this revision.
cordlandwehr added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R39 KTextEditor

BRANCH
  spdxlicensefortemplate

REVISION DETAIL
  https://phabricator.kde.org/D27587

To: kossebau, #kate, cordlandwehr
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27597: KRunner: Refactor deprecated toSet() method

[Alexander Lohnau]

alex updated this revision to Diff 76219.
alex added a comment.


  Keep compatibility with Qt < 5.14

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27597?vs=76213=76219

BRANCH
  deprecation_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27597

AFFECTED FILES
  src/declarative/runnermodel.cpp

To: alex, mlaurent, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27597: KRunner: Refactor deprecated toSet() method

[Ahmad Samir]

ahmadsamir added a comment.


  Hi there. Since KF5 min. supported Qt version is 5.12, you have to make the 
code conditional so that it still build on Qt < 5.14.
  
  (Qt 5.14 is where range-iterators-based constructors were introduced to Qt 
containers including QList https://doc.qt.io/qt-5/qlist.html#QList-4).
  
  For an example see: 
https://phabricator.kde.org/R91:202af7d3f3275c998f06fbb8f414f23215e867ef

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D27597

To: alex, mlaurent, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27597: KRunner: Refactor deprecated toSet() method

[Alexander Lohnau]

alex created this revision.
alex added reviewers: mlaurent, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.

REVISION SUMMARY
  The deprecated toSet method of the QList class has been refactored as in the 
deprecation message suggested.

TEST PLAN
  Should compile without this deprecation warning.

REPOSITORY
  R308 KRunner

BRANCH
  deprecation_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27597

AFFECTED FILES
  src/declarative/runnermodel.cpp

To: alex, mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This works with both the old and the new way of Qt's asset deployment, ie.
  with Qt 5.13 and Qt 5.14.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27596

AFFECTED FILES
  modules/ECMQmLoader.cpp.in

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kateviewhelpers.cpp:1963
> You should keep devicePixelRatioF calls

This is true. But in this case a non-answer: Maybe QIcon::paint does it correct 
as well. In other words, the code can very likely be improved, but also ok as 
is.

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann
Cc: anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, 
sars

D27594: Remove unused KDBusConnectionPool include

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  KDBusConnectionPool is about to be deprecated.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27594

AFFECTED FILES
  src/core/kdirnotify.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27588: templates: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R308 KRunner

BRANCH
  spdxlicensefortemplate

REVISION DETAIL
  https://phabricator.kde.org/D27588

To: kossebau, cordlandwehr, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

[Alexander Lohnau]

alex added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27591

To: alex, elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

[Alexander Lohnau]

alex created this revision.
alex added a reviewer: elvisangelaccio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.

REVISION SUMMARY
  The quotes around the json file name were added. Without these the moc 
process would throw a parse error.

TEST PLAN
  /

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27591

AFFECTED FILES
  src/widgets/kabstractfileitemactionplugin.h

To: alex, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

[David Redondo]

davidre edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack
Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

[David Redondo]

davidre added a comment.


  In D27589#616106 , @wbauer wrote:
  
  > Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ?
  
  
  Yes seems like the exact bug

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack
Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27038: [KMessageWidget] Allow the style to change our palette

[David Redondo]

davidre added a comment.


  In D27038#616095 , @apol wrote:
  
  > But then now we are not refreshing the palette when it changes outside, no?
  >
  > How about adding a boolean value when it's already happening to prevent the 
infinite recursion?
  
  
  I refresing the palette when the application palette changes. But yes could 
also do it this way

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns