D27355: POC: Make kstatusnotifieritem available without dbus

[Johnny Jazeix]

jjazeix added a comment.


  Can we push it as this to fix the Windows builds? It also breaks a few ones 
in https://binary-factory.kde.org/view/Windows%2064-bit/

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27355

To: vonreth, bcooksley, jjazeix, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27769: modemmanager-qt: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R281:8ad494d957ca: modemmanager-qt: Convert license headers to 
SPDX expressions (authored by cordlandwehr).

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27769?vs=76737&id=77061

REVISION DETAIL
  https://phabricator.kde.org/D27769

AFFECTED FILES
  .Doxyfile.cmake
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/bearerpropertiestest.cpp
  autotests/bearerpropertiestest.h
  autotests/modem3gpppropertiestest.cpp
  autotests/modem3gpppropertiestest.h
  autotests/modem3gppussdpropertiestest.cpp
  autotests/modem3gppussdpropertiestest.h
  autotests/modemcdmapropertiestest.cpp
  autotests/modemcdmapropertiestest.h
  autotests/modemlocationpropertiestest.cpp
  autotests/modemlocationpropertiestest.h
  autotests/modemmessagingpropertiestest.cpp
  autotests/modemmessagingpropertiestest.h
  autotests/modemomapropertiestest.cpp
  autotests/modemomapropertiestest.h
  autotests/modempropertiestest.cpp
  autotests/modempropertiestest.h
  autotests/modemtest.cpp
  autotests/modemtest.h
  autotests/modemtimepropertiestest.cpp
  autotests/modemtimepropertiestest.h
  cmake/FindModemManager.cmake
  examples/main.cpp
  src/bearer.cpp
  src/bearer.h
  src/bearer_p.h
  src/call.cpp
  src/call.h
  src/call_p.h
  src/dbus/dbus.h
  src/dbus/fakedbus.h
  src/fakemodem/bearer.cpp
  src/fakemodem/bearer.h
  src/fakemodem/fakemodem.cpp
  src/fakemodem/fakemodem.h
  src/fakemodem/modem.cpp
  src/fakemodem/modem.h
  src/fakemodem/modem3gpp.cpp
  src/fakemodem/modem3gpp.h
  src/fakemodem/modem3gppussd.cpp
  src/fakemodem/modem3gppussd.h
  src/fakemodem/modemcdma.cpp
  src/fakemodem/modemcdma.h
  src/fakemodem/modemlocation.cpp
  src/fakemodem/modemlocation.h
  src/fakemodem/modemmessaging.cpp
  src/fakemodem/modemmessaging.h
  src/fakemodem/modemoma.cpp
  src/fakemodem/modemoma.h
  src/fakemodem/modemsimple.cpp
  src/fakemodem/modemsimple.h
  src/fakemodem/modemtime.cpp
  src/fakemodem/modemtime.h
  src/fakemodem/objectmanager.cpp
  src/fakemodem/objectmanager.h
  src/fakemodem/sms.cpp
  src/fakemodem/sms.h
  src/generictypes.cpp
  src/generictypes.h
  src/generictypes_p.h
  src/interface.cpp
  src/interface.h
  src/interface_p.h
  src/macros_p.h
  src/manager.cpp
  src/manager.h
  src/manager_p.h
  src/mmdebug_p.h
  src/modem.cpp
  src/modem.h
  src/modem3gpp.cpp
  src/modem3gpp.h
  src/modem3gpp_p.h
  src/modem3gppussd.cpp
  src/modem3gppussd.h
  src/modem3gppussd_p.h
  src/modem_p.h
  src/modemcdma.cpp
  src/modemcdma.h
  src/modemcdma_p.h
  src/modemdevice.cpp
  src/modemdevice.h
  src/modemdevice_p.h
  src/modemfirmware.cpp
  src/modemfirmware.h
  src/modemfirmware_p.h
  src/modemlocation.cpp
  src/modemlocation.h
  src/modemlocation_p.h
  src/modemmessaging.cpp
  src/modemmessaging.h
  src/modemmessaging_p.h
  src/modemoma.cpp
  src/modemoma.h
  src/modemoma_p.h
  src/modemsignal.cpp
  src/modemsignal.h
  src/modemsignal_p.h
  src/modemsimple.cpp
  src/modemsimple.h
  src/modemsimple_p.h
  src/modemtime.cpp
  src/modemtime.h
  src/modemtime_p.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/modemvoice_p.h
  src/sim.cpp
  src/sim.h
  src/sim_p.h
  src/sms.cpp
  src/sms.h
  src/sms_p.h

To: cordlandwehr, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27872: sftp: fix partial transfer resuming when copying to local

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Erroneous submit?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27872

To: sitter, ngraham, feverfew, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov

D27873: sftp: do not show creation time when we do not know it

[Stefan Brüns]

bruns added a comment.


  At least the openssh implementation apparently only supports atime/mtime:
  
https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sftp-common.c?rev=1.31&content-type=text/x-cvsweb-markup

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27873

To: sitter, ngraham, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov

D27873: sftp: do not show creation time when we do not know it

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Btrfs definitely does support birthtime

INLINE COMMENTS

> kio_sftp.cpp:496
>  entry.fastInsert(KIO::UDSEntry::UDS_MODIFICATION_TIME, sb->mtime);
> -entry.fastInsert(KIO::UDSEntry::UDS_CREATION_TIME, sb->createtime);
> +if (sb->createtime != 0) {
> +// Birth time may be unknown if the underlying file system 
> doesn't

You should check for `SSH_FILEXFER_ATTR_CREATETIME` in the flags field:
https://api.libssh.org/master/group__libssh__sftp.html#gabbfacf308d2116ae09b1ca4f901afe2d

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27873

To: sitter, ngraham, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi marked 5 inline comments as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi updated this revision to Diff 77049.
crossi added a comment.


  rename attribute to parentGroupName

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27133?vs=76833&id=77049

REVISION DETAIL
  https://phabricator.kde.org/D27133

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_subgroups.cpp.ref
  autotests/kconfig_compiler/test_subgroups.h.ref
  autotests/kconfig_compiler/test_subgroups.kcfg
  autotests/kconfig_compiler/test_subgroups.kcfgc
  autotests/kconfig_compiler/test_subgroups_main.cpp
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kcfg.xsd

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi planned changes to this revision.
crossi added inline comments.

INLINE COMMENTS

> ervin wrote in test_subgroups.kcfg:10
> Now that I see it, I think I'd go for "parentGroupName" since this is not 
> referential and really about the name (like the name parameter)

`parentGroupName` sounds more explicit, I will replace with it.

> ervin wrote in KConfigSourceGenerator.cpp:354
> Unrelated right, this is not due to your patch, or am I confused?

It was there before my patch, just pointing it for later.

Fortunately, some of the concerns have been addressed in D27497 


REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 57 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/57/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Mar 2020 17:39:57 +
 Build duration:
3 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.68.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 492 test(s), Skipped: 0 test(s), Total: 492 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9147/13176)49%
(4228/8640)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2757/2879)52%
(782/1512)src94%
(44/47)94%
(44/47)62%
(6390/10297)48%
(3446/7128)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 58 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/58/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Mar 2020 17:39:57 +
 Build duration:
2 min 52 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.68.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 492 test(s), Skipped: 0 test(s), Total: 492 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9147/13176)49%
(4228/8640)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2757/2879)52%
(782/1512)src94%
(44/47)94%
(44/47)62%
(6390/10297)48%
(3446/7128)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/56/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Mar 2020 17:39:57 +
 Build duration:
1 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[Nathaniel Graham]

ngraham closed this revision.
ngraham added a comment.


  Please file a bug report with your concerns. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9734

To: broulik, #frameworks, dfaure, michaelh, mlaurent
Cc: ngraham, kde-frameworks-devel, juansimon, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

[David Faure]

dfaure closed this revision.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D27876

To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

[David Faure]

dfaure added a comment.


  It did indeed... Thanks, fixing.

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27876

To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Kevin Ottens]

ervin added a comment.


  In D27840#622937 , @ngraham wrote:
  
  > This patch doesn't apply on top of KDeclarative for me:
  >
  >   This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, 
but
  >   the commit is nowhere in the working copy. Try to apply it against the
  >   current working copy state? (a1282da765c1b909d03d6c94eb77fd99e4374d74)
  >   [Y/n] y
  >  
  >   Checking patch src/qmlcontrols/kcmcontrols/settingstateproxy.h...
  >   Checking patch src/qmlcontrols/kcmcontrols/settingstateproxy.cpp...
  >   Checking patch src/qmlcontrols/kcmcontrols/qml/qmldir...
  >   Checking patch 
src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml...
  >   Checking patch src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml...
  >   Checking patch src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp...
  >   Checking patch src/qmlcontrols/kcmcontrols/CMakeLists.txt...
  >   error: while searching for:
  >  
  >   set(kcmcontrols_SRCS
  >   kcmcontrolsplugin.cpp
  >   )
  >  
  >   add_library(kcmcontrolsplugin SHARED ${kcmcontrols_SRCS})
  >  
  >   error: patch failed: src/qmlcontrols/kcmcontrols/CMakeLists.txt:2
  >   Hunk #2 succeeded at 12 (offset -1 lines).
  >   Applied patch src/qmlcontrols/kcmcontrols/settingstateproxy.h cleanly.
  >   Applied patch src/qmlcontrols/kcmcontrols/settingstateproxy.cpp cleanly.
  >   Applied patch src/qmlcontrols/kcmcontrols/qml/qmldir cleanly.
  >   Applied patch src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml 
cleanly.
  >   Applied patch src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml 
cleanly.
  >   Applied patch src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp cleanly.
  >   Applying patch src/qmlcontrols/kcmcontrols/CMakeLists.txt with 1 reject...
  >   Rejected hunk #1.
  >   Hunk #2 applied cleanly.
  >  
  >Patch Failed! 
  >
  
  
  Ah right, sorry it depends on D27839 .

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 57 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/57/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Mar 2020 16:49:42 +
 Build duration:
1 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 240 lines...][2020-03-05T16:50:27.412Z] -- Found QHelpGenerator executable: /usr/lib64/qt5/bin/qhelpgenerator[2020-03-05T16:50:27.412Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2020-03-05T16:50:27.412Z] -- The following features have been enabled:[2020-03-05T16:50:27.412Z] [2020-03-05T16:50:27.412Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-03-05T16:50:27.412Z] [2020-03-05T16:50:27.412Z] -- The following REQUIRED packages have been found:[2020-03-05T16:50:27.412Z] [2020-03-05T16:50:27.412Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-03-05T16:50:27.412Z]  * Qt5Gui[2020-03-05T16:50:27.412Z]  * LibIcal (required version >= 2.0), Implementation of iCalendar protocols and data formats, [2020-03-05T16:50:27.412Z]  * Doxygen (required version >= 1.8.13)[2020-03-05T16:50:27.412Z]Needed for API dox QCH file generation[2020-03-05T16:50:27.412Z]  * QHelpGenerator, Part of Qt5 tools[2020-03-05T16:50:27.412Z]Needed for API dox QCH file generation[2020-03-05T16:50:27.412Z]  * Qt5Core[2020-03-05T16:50:27.412Z]  * Qt5[2020-03-05T16:50:27.412Z]  * Qt5Test[2020-03-05T16:50:27.412Z] [2020-03-05T16:50:27.412Z] -- Configuring done[2020-03-05T16:50:27.670Z] -- Generating done[2020-03-05T16:50:27.670Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-05T16:50:28.557Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcalendarcore --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2020-03-05T16:50:28.557Z] Scanning dependencies of target KF5CalendarCore_QCH[2020-03-05T16:50:28.557Z] [  0%] Generating src/KF5CalendarCore.qch, src/KF5CalendarCore.tags[2020-03-05T16:50:29.526Z] Building up file structure...[2020-03-05T16:50:29.526Z] Insert custom filters...[2020-03-05T16:50:29.526Z] Insert help data for filter section (1 of 1)...[2020-03-05T16:50:29.526Z] Insert files...[2020-03-05T16:50:29.526Z] Insert contents...[2020-03-05T16:50:29.526Z] Insert indices...[2020-03-05T16:50:29.526Z] Documentation successfully generated.[2020-03-05T16:50:29.526Z] [  0%] Built target KF5CalendarCore_QCH[2020-03-05T16:50:29.789Z] Scanning dependencies of target testicaltimezones_autogen[2020-03-05T16:50:29.789Z] [  0%] Automatic MOC for target testicaltimezones[2020-03-05T16:50:30.054Z] [  0%] Built target testicaltimezones_autogen[2020-03-05T16:50:30.054Z] Scanning dependencies of target KF5CalendarCore_autogen[2020-03-05T16:50:30.054Z] [  1%] Automatic MOC for target KF5CalendarCore[2020-03-05T16:50:30.637Z] [  1%] Built target KF5CalendarCore_autogen[2020-03-05T16:50:30.637Z] Scanning dependencies of target KF5CalendarCore[2020-03-05T16:50:30.637Z] [  1%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/KF5CalendarCore_autogen/mocs_compilation.cpp.o[2020-03-05T16:50:32.038Z] [  2%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/event.cpp.o[2020-03-05T16:50:32.980Z] [  2%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/exceptions.cpp.o[2020-03-05T16:50:33.926Z] [  3%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/filestorage.cpp.o[2020-03-05T16:50:34.874Z] [  3%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/freebusy.cpp.o[2020-03-05T16:50:36.279Z] [  4%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/freebusycache.cpp.o[2020-03-05T16:50:37.240Z] [  4%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/freebusyperiod.cpp.o[2020-03-05T16:50:37.826Z] [  5%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/icalformat.cpp.o[2020-03-05T16:50:39.755Z] [  5%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/icalformat_p.cpp.o[2020-03-05T16:50:42.295Z] [  6%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/icaltimezones.cpp.o[2020-03-05T16:50:43.799Z] [  6%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/incidence.cpp.o[2020-03-05T16:50:45.182Z] [  7%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/incidencebase.cpp.o[2020-03-05T16:50:47.094Z] [  7%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/journal.cpp.o[2020-03-05T16:50:47.662Z] [  8%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/memorycalendar.cpp.o[2020-03-05T16:50:49.579Z] [  8%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/occurrenceiterator.cpp.o[2020-03-05T16:50:50.521Z] [  9%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/period.cpp.o[2020-03-05T16:50:51.086Z] [  9%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/person.cpp.o[2020-03-

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 56 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/56/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Mar 2020 16:49:42 +
 Build duration:
1 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 219 lines...][2020-03-05T16:50:28.838Z] -- Detecting CXX compiler ABI info[2020-03-05T16:50:29.102Z] -- Detecting CXX compiler ABI info - done[2020-03-05T16:50:29.102Z] -- Detecting CXX compile features[2020-03-05T16:50:29.102Z] -- Detecting CXX compile features - done[2020-03-05T16:50:29.102Z] -- [2020-03-05T16:50:29.102Z] [2020-03-05T16:50:29.103Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for KCalendarCore.[2020-03-05T16:50:29.103Z] -- Looking for __GLIBC__[2020-03-05T16:50:29.103Z] -- Looking for __GLIBC__ - found[2020-03-05T16:50:29.103Z] -- Performing Test _OFFT_IS_64BIT[2020-03-05T16:50:29.375Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-03-05T16:50:29.375Z] -- Performing Test HAVE_DATE_TIME[2020-03-05T16:50:29.636Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-05T16:50:29.636Z] -- Found LibIcal: /usr/lib64/libical.so;/usr/lib64/libicalss.so;/usr/lib64/libicalvcal.so (found suitable version "3.0.7", minimum required is "2.0") [2020-03-05T16:50:29.636Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2020-03-05T16:50:29.902Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-03-05T16:50:29.902Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-03-05T16:50:29.902Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-03-05T16:50:29.902Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-03-05T16:50:30.164Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-03-05T16:50:30.428Z] -- Found Doxygen: /usr/bin/doxygen (found suitable version "1.8.16", minimum required is "1.8.13") found components: doxygen dot [2020-03-05T16:50:30.428Z] -- Found QHelpGenerator executable: /usr/lib64/qt5/bin/qhelpgenerator[2020-03-05T16:50:30.428Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2020-03-05T16:50:30.428Z] -- The following features have been enabled:[2020-03-05T16:50:30.428Z] [2020-03-05T16:50:30.428Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-03-05T16:50:30.428Z] [2020-03-05T16:50:30.428Z] -- The following REQUIRED packages have been found:[2020-03-05T16:50:30.428Z] [2020-03-05T16:50:30.428Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-03-05T16:50:30.428Z]  * Qt5Gui[2020-03-05T16:50:30.428Z]  * LibIcal (required version >= 2.0), Implementation of iCalendar protocols and data formats, [2020-03-05T16:50:30.428Z]  * Doxygen (required version >= 1.8.13)[2020-03-05T16:50:30.428Z]Needed for API dox QCH file generation[2020-03-05T16:50:30.428Z]  * QHelpGenerator, Part of Qt5 tools[2020-03-05T16:50:30.428Z]Needed for API dox QCH file generation[2020-03-05T16:50:30.428Z]  * Qt5Core[2020-03-05T16:50:30.428Z]  * Qt5[2020-03-05T16:50:30.428Z]  * Qt5Test[2020-03-05T16:50:30.428Z] [2020-03-05T16:50:30.428Z] -- Configuring done[2020-03-05T16:50:30.997Z] -- Generating done[2020-03-05T16:50:30.997Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-05T16:50:31.823Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcalendarcore --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-03-05T16:50:31.823Z] Scanning dependencies of target KF5CalendarCore_QCH[2020-03-05T16:50:31.823Z] [  0%] Generating src/KF5CalendarCore.qch, src/KF5CalendarCore.tags[2020-03-05T16:50:33.734Z] Building up file structure...[2020-03-05T16:50:33.734Z] Insert custom filters...[2020-03-05T16:50:33.734Z] Insert help data for filter section (1 of 1)...[2020-03-05T16:50:33.734Z] Insert files...[2020-03-05T16:50:33.734Z] Insert contents...[2020-03-05T16:50:33.734Z] Insert indices...[2020-03-05T16:50:33.734Z] Documentation successfully generated.[2020-03-05T16:50:33.734Z] [  0%] Built target KF5CalendarCore_QCH[2020-03-05T16:50:33.734Z] Scanning dependencies of target testicaltimezones_autogen[2020-03-05T16:50:33.734Z] [  0%] Automatic MOC for target testicaltimezones[2020-03-05T16:50:33.734Z] [  0%] Built target testicaltimezones_autogen[2020-03-05T16:50:33.734Z] Scanning dependencies of target KF5CalendarCore_autogen[2020-03-05T16:50:33.734Z] [  1%] Automatic MOC for target KF5CalendarCore[2020-03-05T16:50:34.325Z] [  1%] Built target KF5CalendarCore_autogen[2020-03-05T16:50:34.592Z] Scanning dependencies of target KF5CalendarCore[2020-03-05T16:50:34.592Z] [  1%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/KF5CalendarCore_autogen/mocs_com

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/55/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Mar 2020 16:49:42 +
 Build duration:
32 sec and counting
   CONSOLE OUTPUT
  [...truncated 169 lines...][2020-03-05T16:50:07.000Z] -- Performing Test _OFFT_IS_64BIT[2020-03-05T16:50:07.000Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-03-05T16:50:07.000Z] -- Performing Test HAVE_DATE_TIME[2020-03-05T16:50:07.258Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-05T16:50:07.258Z] -- Found LibIcal: /usr/local/lib/libical.so;/usr/local/lib/libicalss.so;/usr/local/lib/libicalvcal.so (found suitable version "3.0.4", minimum required is "2.0") [2020-03-05T16:50:07.258Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2020-03-05T16:50:07.258Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-03-05T16:50:07.258Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-03-05T16:50:07.516Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-03-05T16:50:07.516Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-03-05T16:50:07.516Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-03-05T16:50:07.516Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components: doxygen dot [2020-03-05T16:50:07.516Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2020-03-05T16:50:07.774Z] -- The following features have been enabled:[2020-03-05T16:50:07.774Z] [2020-03-05T16:50:07.774Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-03-05T16:50:07.774Z] [2020-03-05T16:50:07.774Z] -- The following REQUIRED packages have been found:[2020-03-05T16:50:07.774Z] [2020-03-05T16:50:07.774Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-03-05T16:50:07.774Z]  * Qt5Gui[2020-03-05T16:50:07.774Z]  * LibIcal (required version >= 2.0), Implementation of iCalendar protocols and data formats, [2020-03-05T16:50:07.774Z]  * Doxygen (required version >= 1.8.13)[2020-03-05T16:50:07.774Z]Needed for API dox QCH file generation[2020-03-05T16:50:07.774Z]  * QHelpGenerator, Part of Qt5 tools[2020-03-05T16:50:07.774Z]Needed for API dox QCH file generation[2020-03-05T16:50:07.774Z]  * Qt5Core[2020-03-05T16:50:07.774Z]  * Qt5[2020-03-05T16:50:07.774Z]  * Qt5Test[2020-03-05T16:50:07.774Z] [2020-03-05T16:50:07.774Z] -- Configuring done[2020-03-05T16:50:08.039Z] -- Generating done[2020-03-05T16:50:08.039Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-05T16:50:08.708Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcalendarcore --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-03-05T16:50:08.708Z] Scanning dependencies of target Qt5Core_QCH[2020-03-05T16:50:08.708Z] Scanning dependencies of target testicaltimezones_autogen[2020-03-05T16:50:08.708Z] Scanning dependencies of target KF5CalendarCore_autogen[2020-03-05T16:50:08.708Z] [  1%] Automatic MOC for target KF5CalendarCore[2020-03-05T16:50:08.708Z] [  1%] Built target Qt5Core_QCH[2020-03-05T16:50:08.708Z] [  1%] Automatic MOC for target testicaltimezones[2020-03-05T16:50:08.708Z] Scanning dependencies of target KF5CalendarCore_QCH[2020-03-05T16:50:08.708Z] [  1%] Generating src/KF5CalendarCore.qch, src/KF5CalendarCore.tags[2020-03-05T16:50:09.276Z] [  1%] Built target testicaltimezones_autogen[2020-03-05T16:50:09.545Z] [  1%] Built target KF5CalendarCore_autogen[2020-03-05T16:50:09.545Z] Scanning dependencies of target KF5CalendarCore[2020-03-05T16:50:09.545Z] [  2%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/calstorage.cpp.o[2020-03-05T16:50:09.545Z] [  3%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/attachment.cpp.o[2020-03-05T16:50:09.545Z] [  3%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/alarm.cpp.o[2020-03-05T16:50:09.545Z] [  4%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/KF5CalendarCore_autogen/mocs_compilation.cpp.o[2020-03-05T16:50:09.545Z] [  4%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/attendee.cpp.o[2020-03-05T16:50:09.545Z] [  4%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/calendar.cpp.o[2020-03-05T16:50:09.545Z] [  5%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/calfilter.cpp.o[2020-03-05T16:50:09.545Z] [  5%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/duration.cpp.o[2020-03-05T16:50:09.545Z] [  5%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/compat.cpp.o[2020-03-05T16:50:09.545Z] [  6%] Building CXX object src/CMakeFiles/KF5CalendarCore.dir/customproperties.cpp.o[2020-03-05T16:50:09.545Z] [  6%] Building CXX object src/

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> rearrangecolumns.cpp:37
> +QTimer::singleShot(500, &pm, [&]() {
> +pm.setSourceColumns(QVector() << 2 << 1 << 0 << 3);
> +});

Thanks :) This one slipped?

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27876

To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

[David Faure]

dfaure updated this revision to Diff 77047.
dfaure added a comment.


  Use initializer lists

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27876?vs=77044&id=77047

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27876

AFFECTED FILES
  src/core/krearrangecolumnsproxymodel.cpp
  tests/CMakeLists.txt
  tests/rearrangecolumns.cpp

To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

[Nathaniel Graham]

ngraham added a comment.


  This patch doesn't apply on top of KDeclarative for me:
  
This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, 
but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (a1282da765c1b909d03d6c94eb77fd99e4374d74)
[Y/n] y

Checking patch src/qmlcontrols/kcmcontrols/settingstateproxy.h...
Checking patch src/qmlcontrols/kcmcontrols/settingstateproxy.cpp...
Checking patch src/qmlcontrols/kcmcontrols/qml/qmldir...
Checking patch src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml...
Checking patch src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml...
Checking patch src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp...
Checking patch src/qmlcontrols/kcmcontrols/CMakeLists.txt...
error: while searching for:

set(kcmcontrols_SRCS
kcmcontrolsplugin.cpp
)

add_library(kcmcontrolsplugin SHARED ${kcmcontrols_SRCS})

error: patch failed: src/qmlcontrols/kcmcontrols/CMakeLists.txt:2
Hunk #2 succeeded at 12 (offset -1 lines).
Applied patch src/qmlcontrols/kcmcontrols/settingstateproxy.h cleanly.
Applied patch src/qmlcontrols/kcmcontrols/settingstateproxy.cpp cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/qmldir cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml 
cleanly.
Applied patch src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml 
cleanly.
Applied patch src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp cleanly.
Applying patch src/qmlcontrols/kcmcontrols/CMakeLists.txt with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.

 Patch Failed!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27841

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27871: sftp: fix seekPos + file resuming when part file is of size 11

[Stefan Brüns]

bruns added a comment.


  Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN 
could only happen iff the file where opened with O_NONBLOCK. All other seek 
errors are fatal.").

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27871

To: sitter, ngraham, feverfew
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov

D27811: [KConfigGui] Check font weight when clearing styleName property

[Kevin Ottens]

ervin added a comment.


  In D27811#622916 , @ahmadsamir 
wrote:
  
  > In D27811#622885 , @ervin wrote:
  >
  > > This styleName thing is an endless amount of fun... The patch LGTM, I'll 
let others weight in though since it can have ramifications I might miss.
  >
  >
  > Well this one is the tip of the ice berg, the berg itself was 
a2774ff5b41987c3919a9e 
 :)
  
  
  Yeah I know but we still need to account for this Qt "addition" at other 
places. It wasn't exactly transparent.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27811

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27811: [KConfigGui] Check font weight when clearing styleName property

[Ahmad Samir]

ahmadsamir added a comment.


  In D27811#622885 , @ervin wrote:
  
  > This styleName thing is an endless amount of fun... The patch LGTM, I'll 
let others weight in though since it can have ramifications I might miss.
  
  
  Well this one is the tip of the ice berg, the berg itself was 
a2774ff5b41987c3919a9e 
 :)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27811

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  In D27833#622353 , @apol wrote:
  
  > What's the use-case?
  
  
  Having an idea of the patch you want to build on top of this would indeed 
help.

INLINE COMMENTS

> kcoreconfigskeleton.cpp:210
> +Q_D(KConfigSkeletonItem);
> +d->mLoadedValueImpl= impl;
> +}

Missing space before =

> kcoreconfigskeleton.cpp:226
> +Q_D(const KPropertySkeletonItem);
> +return QVariant::fromValue(d->mLoadedValue);
> +});

This is already a QVariant

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27833

To: meven, ervin, bport, crossi, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27871: sftp: fix seekPos + file resuming when part file is of size 11

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kio_sftp.cpp:1687
>  if (pos != sbPart->size) {
> -qCDebug(KIO_SFTP_LOG) << "Failed to seek to" << 
> sbPart->size << "bytes in source file. Reason given" << strerror(errno);
> +qCDebug(KIO_SFTP_LOG) << "Failed to seek to" << 
> sbPart->size << "bytes in source file. Reason given:" << strerror(errno);
>  sftp_attributes_free(sb);

You should save errno immediately after QT_LSEEK, otherwise any function may 
overwrite it. See `man 3 errno`:

> A common mistake is to do
> 
>   if (somecall() == -1) {
>   printf("somecall() failed\n");
>   if (errno == ...) { ... }
>   }
>
> 
> where errno no longer needs to have the value it had upon return from 
> somecall() (i.e., it may have been changed by the printf(3)).  If the value 
> of errno should be preserved across a library call, it must be saved:
> 
>   if (somecall() == -1) {
>   int errsv = errno;
>   printf("somecall() failed\n");
>   if (errsv == ...) { ... }
>   }
>

> kio_sftp.cpp:1955
>  fd = QT_OPEN( QFile::encodeName(sPart), O_RDWR );  // append if 
> resuming
> -offset = seekPos(fd, 0, SEEK_END);
> -if(offset < 0) {
> +offset = QT_LSEEK(fd, partFile.size(), SEEK_SET);
> +if (offset != partFile.size()) {

dito

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27871

To: sitter, ngraham, feverfew
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Small nitpick: can we have initializer lists for the stringlist and columns 
in the tests, to promote (IMHO) good C++ code? :)

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27876

To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27876

To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27876: KRearrangeColumnsProxyModel: reset in setSourceColumns()

[David Faure]

dfaure created this revision.
dfaure added reviewers: kossebau, vkrause, davidedmundson, ahiemstra.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Otherwise the view won't update, when doing this dynamically.
  With a test program.

TEST PLAN
  See test program

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27876

AFFECTED FILES
  src/core/krearrangecolumnsproxymodel.cpp
  tests/CMakeLists.txt
  tests/rearrangecolumns.cpp

To: dfaure, kossebau, vkrause, davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27811: [KConfigGui] Check font weight when clearing styleName property

[Kevin Ottens]

ervin added a comment.


  This styleName thing is an endless amount of fun... The patch LGTM, I'll let 
others weight in though since it can have ramifications I might miss.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27811

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcoreconfigskeleton.cpp:581
> +// HACK for BC concerns
> +// TODO KF6: remove KCoreConfigSkeletonPrivate::mValues and add a value 
> field to KCoreConfigSkeleton::ItemEnum::Choice
> +const auto inHash = d_ptr->mValues.value(name);

You mean KConfigSkeletonItemPrivate aren't you? (instead of 
KCoreConfigSkeletonPrivate)

> meven wrote in kcoreconfigskeleton.h:788
> I expect those to be found through grep, and I had comments in the past to 
> put it somewhere where it could not get in documentation, in cpp guarantees 
> this.

Well, regular comments don't go in the docs ;-)
(you need the triple slash or the double start at start of comment for it to be 
picked up by doxygen)

But cpp, why not.

> KConfigCommonStructs.h:60
> +
> +QString value() const {
> +return !val.isEmpty() ? val : name;

New line before opening curly brace please

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27811: [KConfigGui] Check font weight when clearing styleName property

[Kevin Ottens]

ervin added a reviewer: bport.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27811

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Harald Sitter]

sitter added a comment.


  It's doable in cmake but it'd be awkward and needlessly complex I think, you 
are much better served putting the actual processing into a script.
  
  ki18n's cmake/ macros have function with very similar tech. In fact, 
KI18N_INSTALL probably is super close in the functionality. It generates .mos 
out of the .pos at build time, while you want to generate 24px out of 22px.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: usta, davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D27873: sftp: do not show creation time when we do not know it

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-ctime

REVISION DETAIL
  https://phabricator.kde.org/D27873

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D23465: Add new non standard mime type for ROOT cern files

[Alex Debus]

alexde abandoned this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23465

To: alexde, #vdg
Cc: yurchor, ltoscano, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

[Ahmad Samir]

ahmadsamir added a comment.


  FTR, gwenview should be fixed by D27875 .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "[Add MarkInterfaceV2, to 
s/QPixmap/QIcon/g for symbols of marks" to "Add MarkInterfaceV2, to 
s/QPixmap/QIcon/g for symbols of marks".
kossebau edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann, cullmann
Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, 
rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, 
sars

D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Having thought some more about the KDevelop cases, their pixmap preprocessing 
really should be replaced by proper custom icons, so the currently proposed 
MarkInterfaceV2 should be fine also for KDevelop.
  Thus going to land this post 5.68 tagging then as is. Thanks everyone for 
review :)

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann, cullmann
Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, 
rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, 
sars

D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 77041.
kossebau added a comment.


  Do proper static_cast into QMetaType enum

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27533?vs=76127&id=77041

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/include/ktexteditor/markinterface.h
  src/search/katesearchbar.cpp
  src/view/kateviewhelpers.cpp

To: kossebau, #kate, #kdevelop, dhaumann, cullmann
Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, 
rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, 
sars

D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "[WIP] Add MarkInterfaceV2, to 
s/QPixmap/QIcon/g for symbols of marks" to "[Add MarkInterfaceV2, to 
s/QPixmap/QIcon/g for symbols of marks".

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann, cullmann
Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, 
rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, 
sars

D27802: smb: fix ipv6 support

[Harald Sitter]

sitter added a comment.


  Ah sorry for the unnecessary wait. I wasn't planning on 19.12. Thanks for 
asking though :)

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: cfeck, thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27873: sftp: do not show creation time when we do not know it

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  creation time (aka birth time) is file system dependent, if the fs doesn't
  support it we seem to get createtime==0. skip over it when that is the
  case.
  
  BUG: 375305
  FIXED-IN: 20.04

TEST PLAN
  browsing a directory on btrfs over sftp doesn't show creation time as 1970

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-ctime

REVISION DETAIL
  https://phabricator.kde.org/D27873

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kconfigcompiler_test.cpp:80
>  "test_signal",
> +"test_notifiers",
>  "test_translation_kde",

This seems unrelated... So we had this test case available but it was in fact 
never run?

> test_subgroups.kcfg:10
> +
> +
> +

Now that I see it, I think I'd go for "parentGroupName" since this is not 
referential and really about the name (like the name parameter)

> test_subgroups.kcfg:20
> +
> +

Probably worth also having cases with:

- the group name being parameterized but not the parentGroup
- both name and parentGroup not be parameterized

Just to have all the possible combinations.

> KConfigSourceGenerator.cpp:354
>  
> +// TODO : Some compiler option won't work or generate bogus settings file.
> +// * Does not manage properly Notifiers=true kcfgc option for parameterized 
> entries :

Unrelated right, this is not due to your patch, or am I confused?

> KConfigXmlParser.cpp:502
>  
> +QString parentGroup = e.attribute(QStringLiteral("parentGroup"));
> +

I'd const auto it, or at least const.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27872: sftp: fix partial transfer resuming when copying to local

[Harald Sitter]

sitter created this revision.
sitter added reviewers: ngraham, feverfew.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the previous condition checked if the final target path size was >0,
  which it would only be when the file already exists (i.e. overwrite) in
  all other scenarios it would always be false and as such resuming wouldn't
  work. what we actually want to check is whether the part file is >0 (i.e.
  there's actual pending bytes to resume from).
  
  this makes resuming work when copying remote->local
  
  CCBUG: 417645

TEST PLAN
  - create file of suitably large size (1g)
  - `split -b somesize` the file into two segments
  - copy first segment to /tmp/file.part
  - connect to /tmp over sftp and copy the file there
  - progress starts at 50% and resulting file is same as input file

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-resume-to-local

REVISION DETAIL
  https://phabricator.kde.org/D27872

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, ngraham, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27871: sftp: fix seekPos + file resuming when part file is of size 11

[Harald Sitter]

sitter created this revision.
sitter added reviewers: ngraham, feverfew.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously seekPos would loop over offset==EAGAIN. the returned off_t of
  seek is not an error, but the offset or -1. this incorrect handling
  of the return value resulted in attempting to seek a file of the size 11
  to get stuck in an infinite loop as EAGAIN==11 and so the loop would
  always be true. any other file size would have been fine, so the impact
  of this is actually super small.
  
  also sync up the expectation and handling a bit more between copy and put
  scenarios.
  specifically we always seek to the size we (think) the part file has,
  instead of letting the libc determine the end. this is in part so
  we can simply do an offset==size comparison to check if the seek worked
  to the end we expected it to.
  
  the seekPos() helper was removed as it now serves no purpose over calling
  lseek directly.
  
  BUG: 417645
  FIXED-IN: 20.04

TEST PLAN
  - create file
  - `split -b 11` file to get a segment exactly EAGAIN size
  - copy first segment to some other dir as file.part
  - open sftp to other dir and copy file there
  - copy doesn't get stuck, the file.part is removed, and the resulting file is 
same as input
  - vice versa copy from sftp to local

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-seekpos

REVISION DETAIL
  https://phabricator.kde.org/D27871

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, ngraham, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77032.
ahmadsamir added a comment.


  Remove redundant #include

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77031&id=77032

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77031.
ahmadsamir added a comment.


  Fix _debug.h file name

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77029&id=77031

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:57
> +ecm_qt_declare_logging_category(kiofilewidgets_SRCS
> +HEADER kiofilewidgets_debug.h
> +IDENTIFIER KIO_KFILEWIDGETS_KFILEFILTERCOMBO

Perhaps name the header matching kfilefiltercombo, to make clear this one is 
not providing the general library category.

> kfilefiltercombo.cpp:29
>  #include 
> +#include 
>  

Should not be needed, served by generated header already.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add invalid QMimeType to mimes filter

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77029.
ahmadsamir retitled this revision from "[KFileFilterCombo] Don't add inavlid 
QMimeType to mime filter" to "[KFileFilterCombo] Don't add invalid QMimeType to 
mimes filter".
ahmadsamir removed a reviewer: kossebau.
ahmadsamir removed a subscriber: kossebau.
ahmadsamir added a comment.


  Fix typo; fix qt logging bits

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77015&id=77029

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns, 
kossebau

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[Friedrich W. H. Kossebau]

kossebau added a comment.


  BTW, typo in title of commit ("inadlid").

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in kfilefiltercombo.cpp:31
> Err why don't you include kiofilewidgets_debug.h instead?
> 
> You're redefining what the generated file contains, here.

No, the generated one contains only `kf5.kio.filewidgets`, not 
`kf5.kio.filewidgets.kfilefiltercombo`.
That's why I proposed to invert things and use 
`ecm_qt_declare_logging_category()` for the latter, so we have a generated 
header to include indeed for the caegory we use here, and use 
`ecm_qt_export_logging_category()` for the virtual base category 
`kf5.kio.filewidgets` instead (done only to have this one available & 
"documented" in KDebugSettings).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R268:8e14750977c6: Fix "Make it compile against last 
qt5.15 without deprecated method. QProcess… (authored by fvogt).

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27863?vs=77022&id=77026

REVISION DETAIL
  https://phabricator.kde.org/D27863

AFFECTED FILES
  src/runtime/kserviceactioncomponent.cpp

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfilefiltercombo.cpp:31
> +Q_DECLARE_LOGGING_CATEGORY(KIO_KFILEWIDGETS_KFILEFILTERCOMBO)
> +Q_LOGGING_CATEGORY(KIO_KFILEWIDGETS_KFILEFILTERCOMBO, 
> "kf5.kio.filewidgets.kfilefiltercombo", QtWarningMsg)
>  

Err why don't you include kiofilewidgets_debug.h instead?

You're redefining what the generated file contains, here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R268 KGlobalAccel

BRANCH
  somefix

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

fvogt marked an inline comment as done.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

fvogt edited the test plan for this revision.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

fvogt updated this revision to Diff 77022.
fvogt added a comment.


  Do it differently, just like it's done below

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27863?vs=77009&id=77022

BRANCH
  somefix

REVISION DETAIL
  https://phabricator.kde.org/D27863

AFFECTED FILES
  src/runtime/kserviceactioncomponent.cpp

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

fvogt retitled this revision from "Revert "Make it compile against last qt5.15 
without deprecated method. QProcess::execute(QString) is deprecated"" to "Fix 
"Make it compile against last qt5.15 without deprecated method. 
QProcess::execute(QString) is deprecated"".

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

fvogt added a comment.


  In D27863#622655 , @mlaurent wrote:
  
  > if splitting is already done why this code re-call 
"m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString())" ? 
  >  => QProcess::startDetached(commands, parts) no ?
  
  
  I would assume that works, yes.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Laurent Montel]

mlaurent added a comment.


  if splitting is already done why this code re-call 
"m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString())" ?
  
  > QProcess::startDetached(commands, parts) no ?
  ===

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Looks good from a quick scan. If the content of the generated kio.categories 
files also matches what you expect, things are fine. Perhaps I would invert 
things and generate the header for kf5.kio.filewidgets.kfilefiltercombo and 
include that, instead of the manual definition in the C++ code. And do the 
ecm_qt_export_logging_category for kf5.kio.filewidgets instead, given this is 
not yet used.
  
  Meh, I really need to get to finish my prototype for T12741 
, which also brings the ability to define 
multiple categories per generated header, instead of just one. That should get 
more sanity into things.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[Ahmad Samir]

ahmadsamir added a reviewer: kossebau.
ahmadsamir added a subscriber: kossebau.
ahmadsamir added a comment.


  @kossebau: did I get the Qt logging bits correctly? (I copied from your other 
related commits :)).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77015.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Give a warning about invalid mimeTypes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27865?vs=77012&id=77015

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Problems in KWayland causes by API and ABI compatibility promises

[Vlad Zahorodnii]

Hi,

KWayland is a library that provides convenience wrappers for Wayland 
protocols. Usually, when we want to implement some Wayland protocol, 
first, we add corresponding wrappers in KWayland and after that we 
actually implement the protocol in KWin.


Unfortunately, we made a bad design choice in KWayland. It is common in 
KWayland to see abstractions over unstable protocols. We do it in the 
name of "don't repeat yourself" principle. This reduces the amount of 
duplicated code in KWin, but it also makes much more difficult to extend 
KWayland. Abstracting unstable protocols turns out to be really bad when 
the next version of an unstable protocol contains big changes, e.g. 
xdg-shell-unstable-v5 -> xdg-shell-unstable-v6. Due to the API and ABI 
compatibility promises, we can't fix the broken design of those 
wrappers. We should not try to abstract over Wayland protocols in the 
first place!


We need to fix those wrappers in order to implement the corresponding 
protocols properly in KWin (and fix a few bugs).


One option is to make KWayland unstable so we are free to do necessary 
changes to fix the wrappers, but it doesn't really go along with the 
Frameworks' policies. Another option is to move KWayland somewhere else, 
e.g. KWin or Plasma.


Alternatively, we could provide new wrappers and append a suffix to 
class names, e.g. "2" or "V2". But I don't like this approach for a 
couple of reasons. First, we are going to mix two types of versions in a 
single class name, e.g. XdgToplevelV6InterfaceV2, etc. Second, some 
protocols are not completely implemented in KWin, so we may still need 
to change wrappers in a way that may break API or ABI compatibility. 
Arguably, we just don't have to push semi-finished changes, but 
implementing everything all at once is a bit difficult and tackling one 
problem at a time is much easier.


I'm writing this email to bring problems that we currently have in 
KWayland up to discussion and find the way in which we can address them.


For what it's worth the question of moving KWayland out of Frameworks to 
somewhere else had been raised before, but the discussion got stalled... 
sort of. [1]


Cheers,
Vlad

[1] https://phabricator.kde.org/T11903

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

fvogt added a comment.


  The split arguments are already available as `parts` above, as used in the 
klauncher call AFAICT.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

[Juan Simon]

juansimon reopened this revision.
juansimon added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: kde-frameworks-devel.


Operating System: Arch Linux 
KDE Plasma Version: 5.18.2
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
  
  Besides the lack of documentation regarding this and other relevant options 
for the creation of, for example, services for Dolphin.
  The `X-KDE-RequiredNumberOfUrls` option allows me to set an exact number of 
occurrences but not a minimum and a maximum or just a minimum, as pointed out 
by @michaelh.
  For example, I want to create an option to move n files to a new sub-folder, 
but I only want this option to appear if the minimum number of files selected 
is 2.
  Another example, I want to create an option to compress several image files 
and create a comic book. I want at least 4 images selected for this option to 
appear.
  These 2 examples I have given are real cases that I have recently encountered 
when switching to KDE.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9734

To: broulik, #frameworks, dfaure, michaelh, mlaurent
Cc: kde-frameworks-devel, juansimon, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 324 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/324/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 05 Mar 2020 12:00:21 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34833/62066)40%
(17666/43804)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9729/10192)47%
(4538/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8731/14618)51%
(4506/8825)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8328)43%
(2076/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Ahmad Samir]

ahmadsamir added a comment.


  Looking at upstream code, it looks like they introduced a static 
splitCommad() method since 5.15, so I think we'll have to use a
  #if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
  
  kludge to handle this case. Their rationale is more precise argument 
handling, which sort of makes sense:
  
https://code.qt.io/cgit/qt/qtbase.git/commit/?id=92eea633491ce8138c5caceb904ad26c1eb91044
  
https://code.qt.io/cgit/qt/qtbase.git/commit/?id=2090b770daa87039f27c15aad6bdbc42e5fe702c

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 315 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/315/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 05 Mar 2020 12:00:21 +
 Build duration:
9 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 449 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/449/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 05 Mar 2020 12:00:21 +
 Build duration:
5 min 44 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34820/62065)40%
(17666/43808)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9729/10192)47%
(4540/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8718/14617)51%
(4506/8825)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8328)43%
(2078/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
 

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[Ahmad Samir]

ahmadsamir added a comment.


  In D27865#622605 , @dfaure wrote:
  
  > Maybe add a warning about the invalid type? After all it's a programmer 
error to send us invalid mimetypes here, right? Are you also fixing the source 
of the issue in gwenview?
  
  
  A warning makes sense, yes.
  
  About gwenview, it's on my todo list to track down the issue there next.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> kserviceactioncomponent.cpp:72
>  } else {
> -
> QProcess::startDetached(m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"),
>  QString()), QStringList());
> +
> QProcess::startDetached(m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"),
>  QString()));
>  }

Hum... interesting:

#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
QProcess::startDetached(m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"),
 QString()));
#else
const QString commandLine = 
m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString());
if (!commandLine.isEmpty()) {

  QStringList arguments = QProcess::splitCommand(commandLine);
  const QString prog = arguments.takeFirst();
  QProcess::startDetached(prog, arguments);

}   
#endif

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:082e01b19a8e: KIO::iconNameForUrl(): handle the case of a 
file/folder under trash:/ (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27864?vs=77010&id=77014

REVISION DETAIL
  https://phabricator.kde.org/D27864

AFFECTED FILES
  autotests/kfileitemtest.cpp
  src/core/global.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27838: Port to new QML Connections syntax

[David Edmundson]

davidedmundson added a comment.


  Relevant temporary "fix": 
https://codereview.qt-project.org/c/qt/qtdeclarative/+/293011

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27838

To: jbbgameich, #frameworks, apol
Cc: davidedmundson, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

[Méven Car]

meven accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  l-trash-stuff (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27864

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[David Faure]

dfaure added a comment.


  Maybe add a warning about the invalid type? After all it's a programmer error 
to send us invalid mimetypes here, right? Are you also fixing the source of the 
issue in gwenview?
  
  Thanks!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Yay for unittests :-)

REPOSITORY
  R241 KIO

BRANCH
  l-trash-stuff (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27864

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter, broulik.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  When setting the mime filter, check that the QMimeType we get from
  QMimeDatabase::mimeTypeForName() is valid before adding it to the mime
  filter list. This fixes a bug where if the QMimeType is invalid its name
  (and comment) property is empty, leading to empty entries in the filter
  widget drop-down menu.
  
  BUG: 417355
  
  FIXED-IN: 5.68

TEST PLAN
  - Open gwenview -> file -> open and check the filter drown-down menu there 
are a couple (two?) empty entries
  - Apply diff and try again, no empty entries

REPOSITORY
  R241 KIO

BRANCH
  l-kfilefiltercombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27865

AFFECTED FILES
  src/filewidgets/kfilefiltercombo.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter, broulik.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  For trash:/ we have two individual cases:
  
  - trash:/ itself, show empty/full trash icon
  - trash:/file and trash:/folder/, show icon for the file mimetype or 
inode/directory respectively
  
  Less if nesting by using a ternary.
  
  This fixes the testtrash unit test.
  
  Extend kfileitemtest to test all cases.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-trash-stuff (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27864

AFFECTED FILES
  autotests/kfileitemtest.cpp
  src/core/global.cpp

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27544: Fix update scenarios with no explicit downloadlink selected

[Alex Debus]

alexde added a comment.


  In D27544#622272 , @ngraham wrote:
  
  > (...) there has to be a way to (...) label everything properly etc.
  
  
  
  
  In D27544#622501 , @leinir wrote:
  
  > We are at least two people not too happy with that situation... The label 
we're using for that now is technically a free-text field. (...) However, each 
downloaditem does have a tags section, and while that would need some thought 
put into it, i think we could do something clever with that. A bit outside the 
scope of this patch, of course, but something to spent some braining time on :)
  
  
  Sounds similar to bug #415483.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27544

To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, 
#discover_software_store
Cc: alexde, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

fvogt added a reviewer: mlaurent.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D27863

To: fvogt, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  This port is broken AFAICT - it tries to run the full Exec= line as binary, 
without
  splitting arguments first.
  
  This reverts commit 59cbea835502428f30c1495abe4a1b3d133103e3 
.

TEST PLAN
  Not tested at all.

REPOSITORY
  R268 KGlobalAccel

BRANCH
  somefix

REVISION DETAIL
  https://phabricator.kde.org/D27863

AFFECTED FILES
  src/runtime/kserviceactioncomponent.cpp

To: fvogt, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven marked 4 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ervin wrote in kcoreconfigskeleton.cpp:580
> No I meant the comment needs to be adjusted due to the changes (fields 
> changing place and such) sorry if I was unclear.

I updated the comment since your first comment, I think it is ok now.

> ervin wrote in kcoreconfigskeleton.h:788
> Yeah, noticed only later... I wonder if it's more obvious in the header or 
> the cpp...

I expect those to be found through grep, and I had comments in the past to put 
it somewhere where it could not get in documentation, in cpp guarantees this.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven updated this revision to Diff 77006.
meven added a comment.


  Fix typo

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=76999&id=77006

BRANCH
  arcpatch-D27463_2

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  autotests/kconfig_compiler/test5.cpp.ref
  autotests/kconfig_compiler/test5.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> meven wrote in kcoreconfigskeleton.cpp:580
> You mean I should prepare this and put it in KF6 waiting for merge queue ?

No I meant the comment needs to be adjusted due to the changes (fields changing 
place and such) sorry if I was unclear.

> meven wrote in kcoreconfigskeleton.h:788
> I have one in `QString KCoreConfigSkeleton::ItemEnum::valueForChoice(QString 
> name) const`

Yeah, noticed only later... I wonder if it's more obvious in the header or the 
cpp...

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27802: smb: fix ipv6 support

[Christoph Feck]

cfeck added a comment.


  Well, cannot delay the release any longer.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: cfeck, thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ervin wrote in kcoreconfigskeleton.cpp:580
> Will need an update

You mean I should prepare this and put it in KF6 waiting for merge queue ?

> ervin wrote in kcoreconfigskeleton.h:788
> const QString &name
> 
> Probably worth adding a KF6 comment somewhere as well, because your first 
> attempt felt more natural, we're going for this weird construct only for BC 
> concerns.

I have one in `QString KCoreConfigSkeleton::ItemEnum::valueForChoice(QString 
name) const`

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Méven Car]

meven updated this revision to Diff 76999.
meven marked 9 inline comments as done.
meven added a comment.


  Remove enumValues, const ref args, move mValues to 
KCoreConfigSkeletonItemPrivate, improve comments

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=76866&id=76999

BRANCH
  arcpatch-D27463_2

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  autotests/kconfig_compiler/test5.cpp.ref
  autotests/kconfig_compiler/test5.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27544: Fix update scenarios with no explicit downloadlink selected

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D27544#622272 , @ngraham wrote:
  
  > As an aside, I'm somewhat dissatisfied with the current UX when there are 
multiple files. :( I converted a friend of mine to Plasma the other day and he 
was very confused by the multiple items available when he was downloading new 
stuff using the new GHNS window. I know that some of this is the fault of 
content uploaders, but if so, there has to be a way to guide them to upload 
only one file, or to mark a specific file as the real/primary one, and to label 
everything properly etc.
  
  
  We are at least two people not too happy with that situation... The label 
we're using for that now is technically a free-text field, so it certainly 
should be possible to fix in a backwards-compatible sort of way (as it's a 
question of what the server provides us with)... but as for "the real one", 
that's not a thing that makes sense except in very specific cases (for example, 
it makes no sense conceptually when you have e.g. icon sets or mouse cursor 
sets with multiple variants...). However, each downloaditem does have a tags 
section, and while that would need some thought put into it, i think we could 
do something clever with that. A bit outside the scope of this patch, of 
course, but something to spent some braining time on :)
  
  In the meantime, the situation needs some work anyway, as what currently 
happens when there's crazy long downloaditem names is that it gets elided on 
the right... which would be sort of fine, if you could get to that information 
some other way, which you can't, so... yup, wants fixing ;) (also outside the 
scope of this patch, mind, but still)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27544

To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, 
#discover_software_store
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcoreconfigskeleton.cpp:580
> +{
> +// TODO KF6 move value to ItemEnum::Choice and remove 
> KCoreConfigSkeleton::ItemEnum::mValues
> +const auto inHash = mValues.value(name);

Will need an update

> kcoreconfigskeleton.cpp:586
> +/**
> + * Stores a choice value for name
> + */

This comment should go away

> kcoreconfigskeleton.h:788
> + */
> +QString valueForChoice(QString name) const;
> +

const QString &name

Probably worth adding a KF6 comment somewhere as well, because your first 
attempt felt more natural, we're going for this weird construct only for BC 
concerns.

> kcoreconfigskeleton.h:793
> + */
> +void setValueForChoice(QString name, QString valueForChoice);
> +

const ref for the parameters

> kcoreconfigskeleton.h:797
>  QList mChoices;
> +QHash mValues;
>  };

Nope, can't be here, this still breaks binary compatibility. As I mentioned in 
my last comment it should be buried all the way into the d-pointer inherited 
from KConfigSkeletonItem... This is inefficient in term of memory load but it's 
the only option to keep BC.

> KConfigCommonStructs.h:108
>  Choices choices;
> +QHash enumValues;
>  QList signalList;

Well, on that side you should have kept the more natural value() method IMO.

> KConfigXmlParser.cpp:193
>  QList chlist;
> +const QRegularExpression choiceNameRegex = 
> QRegularExpression(QStringLiteral("\\w+"));
> +

nitpick: I'd const auto that one, but it's your call

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27859: [server] Expose SurfaceRole class

[Vlad Zahorodnii]

zzag added a dependent revision: D27860: [server] Add some sub-surface life 
cycle signals.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27859

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

[Vlad Zahorodnii]

zzag added a dependent revision: D27859: [server] Expose SurfaceRole class.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27828

To: zzag, #kwin, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27860: [server] Add some sub-surface life cycle signals

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  These signals can be very useful when one wants to monitor changes in a
  sub-surface tree.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27860

AFFECTED FILES
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

[Vlad Zahorodnii]

zzag added a dependency: D27859: [server] Expose SurfaceRole class.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27860

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27859: [server] Expose SurfaceRole class

[Vlad Zahorodnii]

zzag added a dependency: D27828: [server] Introduce 
SurfaceInterface::boundingRect().

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27859

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27777: Fix clicking thumb-only delegate

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:b9a1dd14800b: Fix clicking thumb-only delegate (authored 
by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2?vs=76754&id=76997

REVISION DETAIL
  https://phabricator.kde.org/D2

AFFECTED FILES
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml

To: leinir, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27859: [server] Expose SurfaceRole class

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  This can be useful for implementing out-of-tree shell surface protocols.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27859

AFFECTED FILES
  src/server/CMakeLists.txt
  src/server/generic_shell_surface_p.h
  src/server/surface_interface.cpp
  src/server/surfacerole.cpp
  src/server/surfacerole.h
  src/server/surfacerole_p.h

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

[Simon Depiets]

sdepiets updated this revision to Diff 76992.
sdepiets added a comment.


  Disable autodetect on language change

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26342?vs=74851&id=76992

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26342

AFFECTED FILES
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h
  src/core/backgroundchecker_p.h
  src/ui/highlighter.cpp
  src/ui/highlighter.h

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns