D28229: [FileIndexScheduler] Emit change to LowPowerIdle state

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice catch.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28229

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27724: Synchronise setNeedsSave between KCModule and ConfigModule in both directions

[David Edmundson]

davidedmundson retitled this revision from "Syncronise setNeedsSave between 
KCModule and ConfigModule in both directions" to "Synchronise setNeedsSave 
between KCModule and ConfigModule in both directions".

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson, ervin
Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

[David Edmundson]

davidedmundson added a comment.


  > Unfortunately, if the user clicks on reset button at first, the apply 
button is disabled an stays disabled.
  
  I'm not sure I understand why that would happen.
  
  That means there's something else going on, and we shouldn't ship this till 
we understand it.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson, ervin
Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

[David Edmundson]

davidedmundson updated this revision to Diff 78329.
davidedmundson added a comment.


  typo fix

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27724?vs=76644=78329

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27724

AFFECTED FILES
  src/kcmoduleqml.cpp

To: davidedmundson, ervin
Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

[David Edmundson]

davidedmundson marked an inline comment as done.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson, ervin
Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

[Albert Astals Cid]

aacid added a comment.


  In D26342#632842 , @sdepiets wrote:
  
  > In D26342#623729 , @aacid wrote:
  >
  > > Would it make sense to enshrine this behaviour with an autotest?
  >
  >
  > Sorry what do you mean by that? Similar to tests/BackgroundTest.cpp ?
  
  
  No, something like the stuff autotests/
  
  one example would be something like, use a text written in french that the 
autodetect algorithm properly detects as french, but then you go and force say 
German on it and then you go and ask for which language is and it should say 
German when autodetetaLanguageDisabled = true but then if you go and say 
setAutoDetectLanguageDisabled(false) again it should say again French
  
  Am i making sense?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 78324.
ngraham added a comment.


  Rebase better (one of these days I'll remember to do it right the first time 
around...)

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=78323=78324

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 78323.
ngraham added a comment.


  Rebase

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=78177=78323

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir
  src/desktoptheme/breeze/icons/window.svg

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f363a06ae697: Update window-pin, Add more sizes, Remove 
redundant edit-delete (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28228?vs=78314=78321

REVISION DETAIL
  https://phabricator.kde.org/D28228

AFFECTED FILES
  src/desktoptheme/breeze/icons/window.svg

To: ndavis, #vdg, #plasma, cblack, ngraham
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28229: [FileIndexScheduler] Emit change to LowPowerIdle state

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The state update is emitted from scheduleIndexing. Trigger it also
  on changes to battery powered.
  
  The change is mostly cosmetic, as the power state is evaluated correctly
  before starting the content indexer.

TEST PLAN
  1. `balooctl monitor`
  2. plug/unplug power
  
  State changes between Idle/LowPowerIdle

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28229

AFFECTED FILES
  src/file/fileindexscheduler.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

[Nathaniel Graham]

ngraham added a dependent revision: D28211: Make Pin buttons consistently sized 
in System Tray and Clock pop-ups.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  pin-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28228

To: ndavis, #vdg, #plasma, cblack, ngraham
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  pin-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28228

To: ndavis, #vdg, #plasma, cblack, ngraham
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> commandlauncherjobtest.cpp:3
> +This file is part of the KDE libraries
> +Copyright (c) 2014, 2020 David Faure 
> +

same.

> commandlauncherjobtest.h:3
> +This file is part of the KDE libraries
> +Copyright (c) 2014, 2020 David Faure 
> +

Should just be 2020, right?

> commandlauncherjob.cpp:50
> +// Do *NOT* delete the KProcessRunner instances here.
> +// We need it to keep running so it can do terminate startup 
> notification on process exit.
> +}

s/do terminate/terminate/

REPOSITORY
  R241 KIO

BRANCH
  2020_03_commandlauncherjob

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

[Noah Davis]

ndavis added a comment.


  In D28228#633141 , @cblack wrote:
  
  > Pin icon looks good, but I fail to see how removing edit-delete is a 
related change in this patch.
  
  
  eh, it's not. I guess I could do it in a separate patch. It's just a pain to 
untangle multiple changes when the icons are all in the same SVG.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  pin-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28228

To: ndavis, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

[Carson Black]

cblack accepted this revision as: VDG, cblack.
cblack added a comment.
This revision is now accepted and ready to land.


  Pin icon looks good, but I fail to see how removing edit-delete is a related 
change in this patch.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  pin-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28228

To: ndavis, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28228

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  16 and 22px sizes added for window-pin and unpin. Style was also updated for 
window-unpin.
  
  edit-delete is redundant because it's already defined in edit.svg. I don't 
think it's used anywhere at all. It was actually window-close, but renamed to 
edit-delete for whatever reason.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  pin-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28228

AFFECTED FILES
  src/desktoptheme/breeze/icons/window.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28200: Enable wrapping of error messages which use KMessageWidget

[Nathaniel Graham]

ngraham added a comment.


  Anyway, @develoot, could you provide your email address so we can land this 
patch with proper authorship information?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28200

To: develoot, #vdg, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Nathaniel Graham]

ngraham added a comment.


  Just to add a different perspective on this, while I agree that "many users 
want it" isn't an automatic justification, I don't think it should carry no 
weight, either. We are making this software for users, and we ought to pay 
attention to their desires. Yes, it's our job to give then what they really 
//need//, not necessarily what they //ask for//. However when users 
consistently complain about the same thing over an extended period of time, I 
think we'd be remiss to ignore that and say the users don't know what they're 
talking about and we know better. Maybe sometimes we do, but that should be 
something we continuously challenge and verify rather than assuming it.
  
  I see this as a "powerful when needed" feature. The determinism of always 
showing a menu is indeed highly usable for novice or normal users, but 
eventually I think it starts to feel annoying for power users. I think it's 
pretty likely for the most common drag-and-drop operation to be a regular move 
from one location on the same partition to another one, and if you realize 
this, I think it's nice to have that be a default rather than getting asked 
every time.
  
  Speaking personally, every time I drag-and-drop from one local location to 
another on the same partition after forgetting to hold down the shift key, a 
little voice in my head says, "darn it, why can it just copy by default?"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

[Benjamin Port]

bport planned changes to this revision.
bport added inline comments.

INLINE COMMENTS

> dfaure wrote in kconfigtest.cpp:1965
> This would pass no matter in which file the write happened, no, due to 
> caching?
> Doesn't this need a generalLocal.reparseConfiguration() to be meaningful?

yes indeed

> dfaure wrote in kconfigtest.cpp:1970
> Hmm, so this is what this is all about?
> 
> This contradicts the documentation for revertToDefault().
> 
> - Reverts the entry with key @p key in the current group in the
> - application specific config file to either the system wide (default)
> - value or the value specified in the global KDE config file.
> 
> The value in the global config file is 10, that's what this is supposed to 
> revert to.

This is a global local file, not system wide and so not considered as default
cf. https://lxr.kde.org/source/frameworks/kconfig/src/core/kconfig.cpp#0702
if the entry is set system wide 
/etc/kde5rc
/etc/xdg/system.kdeglobals
/etc/xdg/kdeglobals
/etc/xdg/yourcustomfile
~/.config/system.kdeglobals

It will be reverted to the default value specified in the file

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sounds like you need another feature, not breaking an existing one.

INLINE COMMENTS

> kconfigtest.cpp:1965
> +QVERIFY(local.sync());
> +QCOMPARE(generalLocal.readEntry("testRestore", 1), 20);
> +

This would pass no matter in which file the write happened, no, due to caching?
Doesn't this need a generalLocal.reparseConfiguration() to be meaningful?

> kconfigtest.cpp:1970
> +local.reparseConfiguration();
> +QCOMPARE(generalLocal.readEntry("testRestore", 1), 1);
> +}

Hmm, so this is what this is all about?

This contradicts the documentation for revertToDefault().

- Reverts the entry with key @p key in the current group in the
- application specific config file to either the system wide (default)
- value or the value specified in the global KDE config file.

The value in the global config file is 10, that's what this is supposed to 
revert to.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

[David Hurka]

davidhurka added a comment.


  There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 
16px. There are 1561 icons in 22px but not in 32px, and 9 icons in 32px but not 
in 22px. What are 12px and 32px good for?
  
  I fixed the 6 32px icons which had the old style. 2 additional 32px icons 
already had the corner fold in the top: document-edit-sign, document-preview. I 
linked document-preview and document-preview-archive.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

[David Hurka]

davidhurka updated this revision to Diff 78305.
davidhurka added a comment.


  - link 32px document-preview-archive and document-preview
  - Move corner fold to top for 6 32px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28203?vs=78230=78305

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28203

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  icons/actions/22/filename-group-length.svg
  

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

[David Hurka]

davidhurka abandoned this revision.
davidhurka added a comment.


  garg.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28204

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

[David Hurka]

davidhurka updated this revision to Diff 78304.
davidhurka added a comment.


  - link 32px document-preview-archive and document-preview
  - Move corner fold to top for 6 32px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28204?vs=78231=78304

BRANCH
  move-corner-fold-to-top

REVISION DETAIL
  https://phabricator.kde.org/D28204

AFFECTED FILES
  icons-dark/actions/16/acrobat.svg
  icons-dark/actions/16/distribute-horizontal-page.svg
  icons-dark/actions/16/distribute-vertical-page.svg
  icons-dark/actions/16/document-edit-decrypt.svg
  icons-dark/actions/16/document-edit-encrypt.svg
  icons-dark/actions/16/document-edit-sign-encrypt.svg
  icons-dark/actions/16/document-edit-sign.svg
  icons-dark/actions/16/document-export.svg
  icons-dark/actions/16/document-import.svg
  icons-dark/actions/16/document-preview-archive.svg
  icons-dark/actions/16/edit-clone-unlink.svg
  icons-dark/actions/16/edit-clone.svg
  icons-dark/actions/16/edit-copy.svg
  icons-dark/actions/16/edit-guides.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-group-length.svg
  icons-dark/actions/16/filename-group-tracks.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/fork.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/password-copy.svg
  icons-dark/actions/16/restoration.svg
  icons-dark/actions/22/acrobat.svg
  icons-dark/actions/22/distribute-horizontal-page.svg
  icons-dark/actions/22/distribute-vertical-page.svg
  icons-dark/actions/22/document-edit-decrypt.svg
  icons-dark/actions/22/document-edit-encrypt.svg
  icons-dark/actions/22/document-edit-sign-encrypt.svg
  icons-dark/actions/22/document-edit-sign.svg
  icons-dark/actions/22/document-export-ocal.svg
  icons-dark/actions/22/document-export.svg
  icons-dark/actions/22/document-import-ocal.svg
  icons-dark/actions/22/document-import.svg
  icons-dark/actions/22/document-preview-archive.svg
  icons-dark/actions/22/edit-clone-unlink.svg
  icons-dark/actions/22/edit-clone.svg
  icons-dark/actions/22/edit-copy.svg
  icons-dark/actions/22/edit-guides.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/entry-clone.svg
  icons-dark/actions/22/filename-group-length.svg
  icons-dark/actions/22/filename-group-tracks.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/fork.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-page.svg
  icons-dark/actions/22/gnumeric-pagesetup-hf-pages.svg
  icons-dark/actions/22/insert-page-break.svg
  icons-dark/actions/22/password-copy.svg
  icons-dark/actions/22/restoration.svg
  icons-dark/actions/32/acrobat.svg
  icons-dark/actions/32/document-edit-decrypt.svg
  icons-dark/actions/32/document-edit-encrypt.svg
  icons-dark/actions/32/document-edit-sign-encrypt.svg
  icons-dark/actions/32/document-export.svg
  icons-dark/actions/32/document-import.svg
  icons-dark/actions/32/document-preview-archive.svg
  icons-dark/actions/32/document-preview.svg
  icons/actions/16/acrobat.svg
  icons/actions/16/distribute-horizontal-page.svg
  icons/actions/16/distribute-vertical-page.svg
  icons/actions/16/document-edit-decrypt.svg
  icons/actions/16/document-edit-encrypt.svg
  icons/actions/16/document-edit-sign-encrypt.svg
  icons/actions/16/document-edit-sign.svg
  icons/actions/16/document-export.svg
  icons/actions/16/document-import.svg
  icons/actions/16/document-preview-archive.svg
  icons/actions/16/edit-clone-unlink.svg
  icons/actions/16/edit-clone.svg
  icons/actions/16/edit-copy.svg
  icons/actions/16/edit-guides.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-group-length.svg
  icons/actions/16/filename-group-tracks.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/fork.svg
  icons/actions/16/gnumeric-pagesetup-hf-page.svg
  icons/actions/16/gnumeric-pagesetup-hf-pages.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/16/password-copy.svg
  icons/actions/16/restoration.svg
  icons/actions/22/acrobat.svg
  icons/actions/22/distribute-horizontal-page.svg
  icons/actions/22/distribute-vertical-page.svg
  icons/actions/22/document-edit-decrypt.svg
  icons/actions/22/document-edit-encrypt.svg
  icons/actions/22/document-edit-sign-encrypt.svg
  icons/actions/22/document-edit-sign.svg
  icons/actions/22/document-export-ocal.svg
  icons/actions/22/document-export.svg
  icons/actions/22/document-import-ocal.svg
  icons/actions/22/document-import.svg
  icons/actions/22/document-preview-archive.svg
  icons/actions/22/edit-clone-unlink.svg
  icons/actions/22/edit-clone.svg
  icons/actions/22/edit-copy.svg
  icons/actions/22/edit-guides.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/entry-clone.svg
  icons/actions/22/filename-group-length.svg
  

D28223: Add "Stat" prefix to StatDetails Enum entries

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, kossebau, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Relates to D25010 

TEST PLAN
  Builds

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28223

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobtest.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp

To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven added a comment.


  In D25010#632977 , @kossebau wrote:
  
  > In D25010#632835 , @dfaure wrote:
  >
  > > Yes, either prefixes or the C++11 way with enum class.
  >
  >
  > I propose to go with prefixes again, for consistency with currrent enum 
usages in KF/KIO APIs.
  
  
  I have a patch D28223 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28191: [KFontChooser] General code cleanup

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78299.
ahmadsamir added a comment.


  Also enable size spinbox when enabling the size list box

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78295=78299

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D25010#632835 , @dfaure wrote:
  
  > Yes, either prefixes or the C++11 way with enum class.
  
  
  I propose to go with prefixes again, for consistency with currrent enum 
usages in KF/KIO APIs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:12d1e200f081: Create ConfigView an unmanaged ConfigWidget 
(authored by bport).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27502?vs=77269=78296

REVISION DETAIL
  https://phabricator.kde.org/D27502

AFFECTED FILES
  autotests/test_settings.cpp
  src/core/CMakeLists.txt
  src/core/languagefilter.cpp
  src/core/loader.cpp
  src/core/loader_p.h
  src/core/settings.cpp
  src/core/settings.h
  src/core/settings_p.h
  src/core/settingsimpl.cpp
  src/core/settingsimpl_p.h
  src/core/speller.cpp
  src/ui/CMakeLists.txt
  src/ui/configui.ui
  src/ui/configview.cpp
  src/ui/configview.h
  src/ui/configwidget.cpp
  src/ui/dialog.cpp
  src/ui/highlighter.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28191: [KFontChooser] General code cleanup

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78295.
ahmadsamir added a comment.


  Make connect() actually work for the QCheckBoxes

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28191?vs=78265=78295

BRANCH
  l-kfontchooser (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28191

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h

To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

[David Hurka]

davidhurka added a comment.


  I understand the concerns. It looks unbalanced. But these icons also look 
unbalanced now: acrobat, filename-title-amarok.
  
  By the way I changed the arrow of document-export to point //outwards// the 
document, not inwards. That often confused me in inkscape, where both icons are 
used next to each other.
  
  document-edit-encrypt and -decrypt are swapped now. Maybe that could confuse 
users who are used to look at the corner fold.
  
  And insert-page-break looses the metaphor of “a break in the page”, but I 
think that’s ok.
  
  I wasn’t aware that there are still 32px monochrome icons. I will fix that. 
Didn’t we want to drop them?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

[Nathaniel Graham]

ngraham added a comment.


  Looks fine to me in practice: F8195133: Screenshot_20200323_105905.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

[Noah Davis]

ndavis added a comment.


  In D28203#632917 , @ngraham wrote:
  
  > Why do you think we shouldn't change the copy icon? Then it would be the 
only one not using the new style.
  
  
  Admittedly, my justification isn't rock solid. I just think it looks worse. 
It makes the top right awfully empty/unbalanced and I think changing it is more 
likely to bother people.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

[Benjamin Port]

bport created this revision.
bport added reviewers: ervin, dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bport requested review of this revision.

REVISION SUMMARY
  This will allow administrator to change default value and be reflected at 
user level
  
  Depends on D28128 .

TEST PLAN
  added an unit test

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28221

AFFECTED FILES
  autotests/kconfigskeletontest.cpp
  autotests/kconfigskeletontest.h
  src/core/kconfigdata.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/gui/kwindowconfig.cpp

To: bport, ervin, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

[Benjamin Port]

bport added a dependent revision: D28221: Don't write default value to 
configuration file when default value came from /etc/* file.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27902: smb: figure out the best host to use for the UDS_URL

[Méven Car]

meven added a comment.


  Seems fine to me

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27902

To: sitter, ngraham, dfaure
Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D28203: Move corner fold to top right in 24 icons

[Nathaniel Graham]

ngraham added a comment.


  Why do you think we shouldn't change the copy icon? Then it would be the only 
one not using the new style.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Maybe the first one should be renamed to ApplicationLauncherJob, now that I 
found out it wouldn't be a good place for running commands (the setters are too 
different).
  
  Probably.

INLINE COMMENTS

> commandlauncherjob.cpp:63
> +
> +void KIO::CommandLauncherJob::setIcon(const QString )
> +{

Can we have a setDesktopName() as an additional shortcut for icon + executable

It will also help the heuristic KProcessRunner is doing:

  KService::Ptr service = KService::serviceByDesktopName(bin);

which won't work now kompare is probably with the ID org.kde.kompare

> commandlauncherjob.h:39
> + * The job finishes when the application is successfully started. At that 
> point you can
> + * query the PID(s).
> + *

PID without (s)

> commandlauncherjob.h:98
> + * @return the PID of the application that was started.
> + * Convenience method for pids().at(0). You should only use this when 
> specifying zero or one URL,
> + * or when you are sure that the application supports opening multiple 
> files. Otherwise use pids().

this is copy pasted

REPOSITORY
  R241 KIO

BRANCH
  2020_03_commandlauncherjob

REVISION DETAIL
  https://phabricator.kde.org/D28201

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

[Noah Davis]

ndavis added a comment.


  I don't think we should change the copy icon. Other than that, this patch 
looks great.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

[Dan Leinir Turthra Jensen]

leinir added reviewers: ahiemstra, broulik, mart.
leinir added a comment.


  tagging in a couple of people who definitely know things about the new thing 
:)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28220

To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

[Dan Leinir Turthra Jensen]

leinir added reviewers: KNewStuff, Frameworks, Plasma.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28220

To: leinir, #knewstuff, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This switches from using the QML DropShadow to using the
  new, high efficiency ShadowedRectangle in Kirigami.
  
  - Modify (and equalise logic) in GridTileDelegate
  - Clean up EntryScreenshots, and use ShadowedRectangle
  - Also use ShadowedRectangle in the bigpreview and tile delegates

TEST PLAN
  No visible changes (as expected) from the switch
  Minor visible change from the EntryScreenshots modifications (now correctly 
shows the shadows all the way around)

REPOSITORY
  R304 KNewStuff

BRANCH
  switch-to-kirigami-shadowedrectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28220

AFFECTED FILES
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: Problems in KWayland causes by API and ABI compatibility promises

[David Edmundson]

>
> That's a good question! On one hand, it's nice to have Qt-friendly
> wrappers for Wayland protocols. On the other hand, it would be even
> better to have a library to write Wayland compositors. So, one just
> needs to plug a few classes in order to get started with drm and
> xdg-shell stuff.

>On the other hand, it would be even better to have a library to write Wayland 
>compositors.

Yeah, I feel that's what kwayland was originally going for. Seat, for
example, does a lot of dispatching and logic internally.
Then it drifted into being just wrappers.

We do need to answer that question definitively otherwise we'll be
forever stuck coding against each other.

>
> > 
> >
> > To bootstrap this I've started an initial list of discrete yes/no
> > questions to help serve as a starting point of what kwayland's
> > direction specifically should be.
> >

I agree with you on all your responses to my question set.
Which means landing your implementation of wmbase somewhere makes
sense as it removes that one awkward abstraction.



This thread hasn't fully addressed your initial comments on ABI and API.

It's worth me mentioning that I have made another compositor based on
kwayland, my Qt out of process plasmoids.

>Another option is to move KWayland somewhere else, e.g. KWin or Plasma.

Moving is far far from trivial. We have plasma-framework depend on
kwayland client API. And moving just the server API would break the
client tests. We also have a released spectacle using kwayland.
It'll be really messy, plus there's any damage this could do to
distro's opinion on frameworks as a whole.

Realistically within KF5 we have two options:
  - We can start to introduce more versioned classes and see if that
helps address the problem before we make more drastic policy changes

  - We can put new protocols somewhere else and elevate them in
frameworks when they actually have users

My fear with the latter is that we'll end up over time, we'll start
forking existing protocols in wayland to fix things and ultimately end
up in an even messier fragmented state.

For KF6 we have more options.

David

D27504: smb faster copy to local

[Nathaniel Graham]

ngraham added a comment.


  Yeah due to the quantity of new code, it feels more like 20.08 material, TBH.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, 
kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, 
alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D27504: smb faster copy to local

[Harald Sitter]

sitter added a comment.


  Any opinions on landing this for 20.04 still? It is technically a bugfix. It 
is also practically a whole lot of risky code, making me rather uneasy about 
putting it in past beta.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, 
kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, 
alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D28128: Add force save behavior to KEntryMap

[Benjamin Port]

bport marked 2 inline comments as done.
bport added a comment.


  Added a unittest

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

[Benjamin Port]

bport updated this revision to Diff 78289.
bport added a comment.


  Add unit test

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28128?vs=77925=78289

REVISION DETAIL
  https://phabricator.kde.org/D28128

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  autotests/kentrymaptest.cpp
  autotests/kentrymaptest.h
  src/core/kconfigdata.cpp
  src/core/kconfigdata.h
  src/core/kconfigini.cpp

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28129: Read the new message string after rather than before

[Harald Sitter]

sitter added a comment.


  Mh. Not quite what I had in mind but I suppose it makes sense this way. 
  I think we need a test case for the highlighter though :| It totally blows up 
in my face when I trace a running dolphin because toskip isn't quite right.

INLINE COMMENTS

> backtracegenerator.cpp:95
>  
> +auto preamble = new QTemporaryFile;
> +preamble->open();

This is leaking the file, is it not? It never deletes this object.

> gdbhighlighter.cpp:59
>  int lineNr = currentBlock().firstLineNumber();
> +int toskip = 1 + m_infoLinesCount; // 1st line contains 'Application: 
> ...'
>  while ( cur < text.length() ) {

lineNr is initialized to currentBlock().firstLineNumber() that is not 
necessarily 0, so toskip needs to be 
`lineNr + 1 + infocount` otherwise the skipping doesn't work as expected.

Should also be camel toSkip.

> gdbhighlighter.cpp:65
>  }
> -if (lineNr == 0) {
> -// line that contains 'Application: ...'
> +if (lineNr <= toskip) {
>  ++lineNr;

Isn't this off-by-one versus the original code?
Say we have no infolines we'd then skip
[0] and [1] when previously we'd only skip [0].

> gdbhighlighter.cpp:76
> +// toskip since we skip the first line and the info lines
> +QMap< int, BacktraceLine >::iterator it = lines.lowerBound(lineNr - 
> toskip);
>  Q_ASSERT(it != lines.end());

The assert below fails when I trace a running dolphin, I am not super sure why 
but I am guessing it's because the toskip init being bugged vis a vis the 
lineNr being an offset.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28129

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20986: Don't call click on the delegate, when we just want it to become current item

[Dan Leinir Turthra Jensen]

leinir abandoned this revision.
leinir added a comment.


  No longer needed

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20986

To: leinir, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27883: Register spawned applications as an independent cgroups

[David Edmundson]

davidedmundson marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27883: Register spawned applications as an independent cgroups

[David Edmundson]

davidedmundson updated this revision to Diff 78288.
davidedmundson added a comment.


  review comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27883?vs=78002=78288

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27883

AFFECTED FILES
  src/gui/kprocessrunner.cpp
  src/gui/kprocessrunner_p.h

To: davidedmundson, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D26342: Allow overriding to disable auto language detection

[Simon Depiets]

sdepiets added a comment.


  In D26342#623729 , @aacid wrote:
  
  > Would it make sense to enshrine this behaviour with an autotest?
  
  
  Sorry what do you mean by that? Similar to tests/BackgroundTest.cpp ?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[David Faure]

dfaure added a comment.


  Yes, either prefixes or the C++11 way with enum class.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R275:37754045e2b8: [KSortFilterProxyModel QML] Make 
invalidateFilter public (authored by broulik).

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28197?vs=78227=78279

REVISION DETAIL
  https://phabricator.kde.org/D28197

AFFECTED FILES
  autotests/ksortfilterproxymodel_qml.cpp
  src/qml/ksortfilterproxymodel.cpp
  src/qml/ksortfilterproxymodel.h

To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: KCodecs: Convert license statements to SPDX expressions

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R270 KCodecs

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27741

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> kossebau wrote in global.h:320
> This injects generic terms like `Basic`, `User`, `Time`, `Acl`, etc. into the 
> KIO namespace, with no futher hint that these belong to this very enum, 
> resulting in potential wrong usages (due to completion-based coding when 
> being convertable to int) or in potential conflicts with other future 
> additions.
> 
> Sadly no time to follow the review. Had this been discussed before? Ideally 
> those flags would get more explicit names, like `BasicDetail` (hm, what is 
> basic actually), `UserDetail`, etc.
> 
> Could not find naming recommendations for current Qt, but here some old one, 
> scroll to the section "Naming Enum Types and Values": 
> https://doc.qt.io/archives/qq/qq13-apis.html#theartofnaming

Yes it had been discussed and what you suggest was in a previous iteration : 
https://phabricator.kde.org/D25010?vs=69181=69385=ignore-most#change-FL2qoDJhfEB5

Somehow I removed it :
https://phabricator.kde.org/D25010?vs=70051=70088=ignore-most#change-FL2qoDJhfEB5

But I can't find why I did this, I guess it was a merging/synchronizing issue 
and lost those changes.
Have I already mentioned how much I dislike arcanist as I work on two machines, 
it is quite annoying.

Unless @dfaure you find a reason why I shouldn't do it, I will add those prefix 
back, since KF 5.69 is not yet out of the door, it is possible.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns