D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R275 KItemModels

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28494

To: ahmadsamir, #frameworks, dfaure, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, broulik.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Use QSortFilterProxyModel::setFilterRegularExpression() instead of
  setFitlerRegExp().

TEST PLAN
  make && ctest

REPOSITORY
  R275 KItemModels

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28494

AFFECTED FILES
  autotests/klinkitemselectionmodeltest.cpp

To: ahmadsamir, #frameworks, dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27504: smb faster copy to local

[Nathaniel Graham]

ngraham added a comment.


  @sitter Well, master is now 20.08. Shall we land this if nobody has any 
objections?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, 
kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D27504: smb faster copy to local

[Marijo Mustac]

mmustac added a comment.


  Those look very lovely.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, 
kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D28220: Switch to using Kirigami's ShadowedRectangle

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  switch-to-kirigami-shadowedrectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28220

To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

[Arjen Hiemstra]

ahiemstra added a comment.


  It's fine with me but I'm going to leave the final call to @broulik since he 
did a more in-depth review.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28220

To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Stefan Brüns]

bruns added a comment.


  In D27951#639352 , @meven wrote:
  
  > In D27951#639350 , @meven wrote:
  >
  > > > Another question, will UDSEntry::UDS_DEVICE_ID be available on Windows?
  > >
  > > I am not a Windows specialist but I imagine we could hack together an 
equivalent solution (I am saying this should be possible not that we will 
implement, feel free to give it a try in file_win.cpp ;) ).
  >
  >
  > dwVolumeSerialNumber of 
https://docs.microsoft.com/fr-fr/windows/win32/api/fileapi/ns-fileapi-by_handle_file_information
 seems promising
  >  
https://docs.microsoft.com/fr-fr/windows/win32/api/fileapi/nf-fileapi-getfileinformationbyhandle?redirectedfrom=MSDN
  
  
  Or 
https://docs.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_id_info.
 May be a little bit cheapers, as it retrieves less information.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: bruns, elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, ngraham

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir marked 3 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in file_unix.cpp:304
> This buf.st_dev is the decimal part in:
> $ stat /usr/bin/file | grep Device
> Device: 804h/2052d Inode: 9168 Links: 1
> that would be "2052"
> 
> whereas with statx it returns buf.stx_dev_major which is an uint32_t.

With makedev() now I get the same numbers.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir updated this revision to Diff 79071.
ahmadsamir retitled this revision from "[FileProtocol] change statx stat_dev() 
to use device major + minor" to "[FileProtocol] change statx stat_dev() to 
return makedev(major, minor)".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a subscriber: bruns.
ahmadsamir added a comment.


  Use makedev()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28478?vs=79044=79071

BRANCH
  l-statx (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28478

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Commit a99c6136da2d 
 
("Samba: Ensure to differenciate mounts sharing the
  same source") only fixed the multiple mount problem for SMB share. This
  can also happen for all other mounts (remounted local file systems,
  NFS, ...).
  
  Also clarify the comment.

REPOSITORY
  R245 Solid

BRANCH
  fix_comment

REVISION DETAIL
  https://phabricator.kde.org/D28488

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Stefan Brüns]

bruns added a comment.


  The comment and commit message are lacking required information. One should 
not have to go to the bug report to actually see why this is needed.
  
  While the summary has the BR reference, the code comment is totally unclear.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28476

To: meven, #frameworks, sitter
Cc: bruns, ahmadsamir, anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

[Stefan Brüns]

bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> file_unix.cpp:286
>  inline static uint16_t stat_mode(struct statx ) { return buf.stx_mode; }
> -inline static uint32_t stat_dev(struct statx ) { return 
> buf.stx_dev_major; }
> +inline static uint32_t stat_dev(struct statx ) { return 
> (buf.stx_dev_major * 100) + buf.stx_dev_minor; }
>  inline static uint64_t stat_ino(struct statx ) { return buf.stx_ino; }

` * 100` is definitely wrong - maybe `* 0x100`, but ...

TLDR: use `makedev`, and change the return type to dev_t.

dev_t is defined as a 64bit type atleast on Linux, which matches the 32bit 
major/minor parts of buf.stx_dev_*.  Traditionally, major/minor are used as 
low/high bytes of a 16 bit type, but these can easily exhausted on a larger 
system. So this is was makedev does:

  #define __SYSMACROS_DEFINE_MAKEDEV(DECL_TEMPL)  \
__SYSMACROS_DECLARE_MAKEDEV (DECL_TEMPL)  \
{ \
  __dev_t __dev;  \
  __dev  = (((__dev_t) (__major & 0x0fffu)) <<  8);   \
  __dev |= (((__dev_t) (__major & 0xf000u)) << 32);   \
  __dev |= (((__dev_t) (__minor & 0x00ffu)) <<  0);   \
  __dev |= (((__dev_t) (__minor & 0xff00u)) << 12);   \
  return __dev;   \
}

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> file_unix.cpp:149
> +if (listlen == -1) {
> +qCWarning(KIO_FILE) << "libc failed to extract list of xattr from 
> file";
> +return false;

Now try this when the source is e.g. FAT formatted ...

Make this dependent on errno.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns added a comment.


  In D17816#639272 , @usta wrote:
  
  > is there a KDE policy about usage of qCWarning( , qCDebug( ?
  >  Because afaik debug one can be ignored by system and some of those might 
be important to show to user to see
  >  So for example  this one looks like a warning instead of a debug info for 
me ( but not sure what your opinions are) :
  >  qCDebug(KIO_FILE) << "libc failed to extract list of xattr from file";
  >
  >   or this one :
  >   qCDebug(KIO_FILE) << "cant copy Extended attributes";
  >
  > other than those for me it looks ok
  
  
  These ones are fine, as it depends on the XAttr support of the file system - 
we don't want a warning when someone
  copies from a FAT USB-Stick.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns added a comment.


  There are still several comments which have not yet been addressed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Nathaniel Graham]

ngraham added a comment.


  @bruns?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 79054.
cochise added a comment.


  qCDebug -> qCWarning

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=78777=79054

BRANCH
  arcpatch-D17816_2

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 177 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/177/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 01 Apr 2020 14:36:03 +
 Build duration:
3 min 12 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.69.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6934/9121)43%
(10807/24857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2902/2996)49%
(6201/12736)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1309)35%
(991/2822)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(681/801)42%
(957/2273)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/5/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 01 Apr 2020 14:36:03 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D28457: kdirwatch: fix a recently introduced crash

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:0ee65124c0f6: kdirwatch: fix a recently introduced crash 
(authored by meven).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28457?vs=79002=79048

REVISION DETAIL
  https://phabricator.kde.org/D28457

AFFECTED FILES
  src/lib/io/kdirwatch.cpp

To: meven, bruns, #frameworks, iasensio
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#639350 , @meven wrote:
  
  > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect 
ioslave, including the stat call made in `KIO::StatJob`.
  >  It is in the kdeconnect code base, the issue you point to is there.
  
  
  Thanks, got it. Then could we simply use KMountPoint instead of UDS_Device_ID 
? KMountPoint seems more reliable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> meven wrote in jobtest.cpp:1382
> Please add a separate test dedicated for Inode like `statWithInode()` like 
> `statSymlink` does for instance.
> Here you change the purpose of this test : default stat behavior with stat(), 
> to default + inode with statDetails.

Righto. Done.

> meven wrote in jobtest.cpp:1398
> UDS_CREATION_TIME is statx specific only on Linux
> Just make it clear in the comment.

In the new unit test, I think using HAVE_STATX is self-explanatory (I'll leave 
JobTest::stat() alone in this diff to keep the commit atomic).

> meven wrote in file_unix.cpp:286
> We should probably use `makedev` 
> http://man7.org/linux/man-pages/man3/makedev.3.html in fact to ensure to 
> match original stat behavior.

I am not an expert on stat low-level system calls; but if the goal is to have a 
unique UDS_DEVICE_ID, we could leave it as uint32 which is what statx returns 
by default, it's system specific anyway, and a system will have statx or not...

> meven wrote in file_unix.cpp:304
> Did you compare with the no-statx case ?
> We should try to have the same output.

This buf.st_dev is the decimal part in:
$ stat /usr/bin/file | grep Device
Device: 804h/2052d Inode: 9168 Links: 1
that would be "2052"

whereas with statx it returns buf.stx_dev_major which is an uint32_t.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Nathaniel Graham]

ngraham added a comment.


  In D17816#639272 , @usta wrote:
  
  > is there a KDE policy about usage of qCWarning( , qCDebug( ?
  >  Because afaik debug one can be ignored by system and some of those might 
be important to show to user to see
  >  So for example  this one looks like a warning instead of a debug info for 
me ( but not sure what your opinions are) :
  >  qCDebug(KIO_FILE) << "libc failed to extract list of xattr from file";
  >
  >   or this one :
  >   qCDebug(KIO_FILE) << "cant copy Extended attributes";
  >
  > other than those for me it looks ok
  
  
  You should change your status to "Accepted" once you're happy with it

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

[Ahmad Samir]

ahmadsamir updated this revision to Diff 79044.
ahmadsamir marked 2 inline comments as done.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28478?vs=79031=79044

BRANCH
  l-statx (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28478

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Méven Car]

meven added a comment.


  In D27951#639350 , @meven wrote:
  
  > > Another question, will UDSEntry::UDS_DEVICE_ID be available on Windows?
  >
  > I am not a Windows specialist but I imagine we could hack together an 
equivalent solution (I am saying this should be possible not that we will 
implement, feel free to give it a try in file_win.cpp ;) ).
  
  
  dwVolumeSerialNumber of 
https://docs.microsoft.com/fr-fr/windows/win32/api/fileapi/ns-fileapi-by_handle_file_information
 seems promising
  
https://docs.microsoft.com/fr-fr/windows/win32/api/fileapi/nf-fileapi-getfileinformationbyhandle?redirectedfrom=MSDN

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Méven Car]

meven added a comment.


  In D27951#637792 , @trmdi wrote:
  
  > In D27951#637690 , @meven wrote:
  >
  > > Look into kde connect kioslave.
  > >  That does not concern this diff much though.
  >
  >
  > I don't understand this. I'm using KMountPoint to check if source and dest 
are on the same partion, it's working as expected.
  >  But if I switch to use `KIO::StatJob`, it will fail, because for the file 
inside a KDE Connect directory, `KIO::UDSEntry::UDS_DEVICE_ID` return the same 
value with the root partion.
  
  
  Maybe you don't much about KIO.
  
  Anything that uses `KIO::` calls is treated by ioslave which are programs to 
handle protocols.
  For instance file:/ (that handles /) or kdeconnect:/
  Anything that concerns a kdeconnet:/ url is handled by the kdeconnect 
ioslave, including the stat call made in `KIO::StatJob`.
  It is in the kdeconnect code base, the issue you point to is there.
  
  > Another question, will UDSEntry::UDS_DEVICE_ID be available on Windows?
  
  I am not a Windows specialist but I imagine we could hack together an 
equivalent solution (I am saying this should be possible not that we will 
implement, feel free to give it a try in file_win.cpp ;) ).

INLINE COMMENTS

> dropjob.cpp:309
> +const QString  = 
> mountPoints.findByPath(url.path())->mountedFrom();
> +if (sourceDevice != destDevice && !KFileItem(url).isLink()) {
> +allItemsAreSameDevice = false;

You can create a `KFileItem(url)` before, so that you can reuse it line 314, 
instead of building one again.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

Re: Problems in KWayland causes by API and ABI compatibility promises

[Aleix Pol]

FWIW I ported KDE Connect away from it here:
https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/199

Leaving the rest as plasma-specific components.

Aleix

On Wed, Apr 1, 2020 at 2:04 PM David Edmundson
 wrote:
>
> Here is a list of active uses of the KWayland::Client API.
>
> frameworks
> plasma-framework (for window positioning)
>
> apps:
> spectacle (for window positioning)
> kdeconnect-kde  (for fake input)
> yakuake (for window positioning)
>
> extragear
> latte-dock (for window positioning, custom shadow (which could be
> ported already) and windowmanagement)
>
> workspace:
> kwin unit tests
> libkscreen
> breeze (till Qt5.15)
> oxyen (till Qt5.15)
> xdg-desktop-portal
> kinfocenter
> plasma-workspace
> plasma-nano
> kscreenlocker
> powerdevil
> kwayland-integration (the backend for kwindowsystem)
> plasma-phone-components
> plasma-integration
>
> David

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

[Méven Car]

meven added a comment.


  In D28478#639294 , @ahmadsamir 
wrote:
  
  > I'll address the comments, but one point which I couldn't figure out is 
that HAVE_STATX isn't available for the unit tests, any examples on how to make 
it work there too?
  
  
  I tried to do it as well, but it seems quite complicated to share it with the 
main code base and I couldn't find a way.
  The variable is added by `src/ioslaves/file/ConfigureChecks.cmake` and 
`src/ioslaves/file/config-kioslave-file.h.cmake` in the first place.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27455: FileWidgets: Ignore Return events from KDirOperator

[Méven Car]

meven updated this revision to Diff 79039.
meven added a comment.


  Use a single if statement, handle for Qt::Key_Enter as well

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27455?vs=78142=79039

BRANCH
  arcpatch-D27455

REVISION DETAIL
  https://phabricator.kde.org/D27455

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: meven, dfaure, ngraham, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Re: Problems in KWayland causes by API and ABI compatibility promises

[David Edmundson]

Here is a list of active uses of the KWayland::Client API.

frameworks
plasma-framework (for window positioning)

apps:
spectacle (for window positioning)
kdeconnect-kde  (for fake input)
yakuake (for window positioning)

extragear
latte-dock (for window positioning, custom shadow (which could be
ported already) and windowmanagement)

workspace:
kwin unit tests
libkscreen
breeze (till Qt5.15)
oxyen (till Qt5.15)
xdg-desktop-portal
kinfocenter
plasma-workspace
plasma-nano
kscreenlocker
powerdevil
kwayland-integration (the backend for kwindowsystem)
plasma-phone-components
plasma-integration

David

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

[Ahmad Samir]

ahmadsamir added a comment.


  I'll address the comments, but one point which I couldn't figure out is that 
HAVE_STATX isn't available for the unit tests, any examples on how to make it 
work there too?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/2/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 01 Apr 2020 10:28:58 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:a99c6136da2d: Samba: Ensure to differenciate mounts 
sharing the same source (authored by meven).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28476?vs=79035=79036

REVISION DETAIL
  https://phabricator.kde.org/D28476

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, #frameworks, sitter
Cc: ahmadsamir, anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> jobtest.cpp:1382
>  const QUrl url(QUrl::fromLocalFile(filePath));
> -KIO::StatJob *job = KIO::stat(url, KIO::HideProgressInfo);
> +KIO::StatJob *job = KIO::statDetails(url, KIO::StatJob::SourceSide, 
> KIO::StatDefaultDetails | KIO::StatInode);
>  QVERIFY(job);

Please add a separate test dedicated for Inode like `statWithInode()` like 
`statSymlink` does for instance.
Here you change the purpose of this test : default stat behavior with stat(), 
to default + inode with statDetails.

> jobtest.cpp:1398
> +#if 1 // should be HAVE_STATX
> +QVERIFY(entry.contains(KIO::UDSEntry::UDS_CREATION_TIME));
> +QVERIFY(entry.contains(KIO::UDSEntry::UDS_DEVICE_ID));

UDS_CREATION_TIME is statx specific only on Linux
Just make it clear in the comment.

> jobtest.cpp:1400
> +QVERIFY(entry.contains(KIO::UDSEntry::UDS_DEVICE_ID));
> +QVERIFY(entry.contains(KIO::UDSEntry::UDS_INODE));
> +QCOMPARE(entry.count(), 11);

KIO::UDSEntry::UDS_DEVICE_ID and KIO::UDSEntry::UDS_INODE are not statx 
specific (it is supported for all UNIX systems)

> file_unix.cpp:286
>  inline static uint16_t stat_mode(struct statx ) { return buf.stx_mode; }
> -inline static uint32_t stat_dev(struct statx ) { return 
> buf.stx_dev_major; }
> +inline static uint32_t stat_dev(struct statx ) { return 
> (buf.stx_dev_major * 100) + buf.stx_dev_minor; }
>  inline static uint64_t stat_ino(struct statx ) { return buf.stx_ino; }

We should probably use `makedev` 
http://man7.org/linux/man-pages/man3/makedev.3.html in fact to ensure to match 
original stat behavior.

> file_unix.cpp:304
>  inline static mode_t stat_mode(QT_STATBUF ) { return buf.st_mode; }
>  inline static dev_t stat_dev(QT_STATBUF ) { return buf.st_dev; }
>  inline static ino_t stat_ino(QT_STATBUF ) { return buf.st_ino; }

Did you compare with the no-statx case ?
We should try to have the same output.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  You know, I may have noticed this when working on kinfocenter and then 
quickly forgotten about it again  
  Good stuff!

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28476

To: meven, #frameworks, sitter
Cc: ahmadsamir, anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta added a comment.


  is there a KDE policy about usage of qCWarning( , qCDebug( ?
  Because afaik debug one can be ignored by system and some of those might be 
important to show to user to see
  So for example  this one looks like a warning instead of a debug info for me 
( but not sure what your opinions are) :
  qCDebug(KIO_FILE) << "libc failed to extract list of xattr from file";
   or this one :
   qCDebug(KIO_FILE) << "cant copy Extended attributes";
  other than those for me it looks ok

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Méven Car]

meven updated this revision to Diff 79035.
meven added a comment.


  Correct typo in comment

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28476?vs=79032=79035

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28476

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, #frameworks
Cc: ahmadsamir, anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Méven Car]

meven updated this revision to Diff 79032.
meven marked an inline comment as done.
meven added a comment.


  Use QLatin1Char

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28476?vs=79030=79032

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28476

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, #frameworks
Cc: ahmadsamir, anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise marked an inline comment as done.
cochise added a comment.


  Hi, @usta and @bruns 
  We still have some change pending? 
  Thanks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:131
> +return source + ':' + mountpoint;
>  }
>  return source;

Nitpick: QLatin1Char.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28476

To: meven, #frameworks
Cc: ahmadsamir, anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  On Linux systems that have statx available, stat_dev() returned
  stx_dev_major, which could be the same value for different partitions.
  Change it to combine stx_dev_major and stx_dev_minor to get a unique
  number (meaning a unique UDSEntry::UDS_DEVICE_ID).
  
  Extend JobTest::stat() unit test to check that UDS_DEVICE_ID is unique
  for each individual partition.
  
  Also in JobTest::stat(), use a smaller #if/#endif to keep the HTTP stat
  bits disabled (it's been disabled since kdelibs4 split so...).

TEST PLAN
  $ stat /usr/bin/file | grep Device
  Device: 804h/2052d  Inode: 9168Links: 1
  $ stat ~/.bashrc | grep Device
  Device: 803h/2051d  Inode: 97  Links: 1
  
  Apply small patch from http://www.davidfaure.fr/2020/uds_device_test.diff,
  then:
  $ kioclient5 openProperties /usr/bin/file
  "DEVICE" 804
  $ kioclient5 openProperties ~/.bashrc
  "DEVICE" 803
  
  without this change DEVICE would be "8" for both of these files.

REPOSITORY
  R241 KIO

BRANCH
  l-statx (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28478

AFFECTED FILES
  autotests/jobtest.cpp
  src/ioslaves/file/file_unix.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Méven Car]

meven updated this revision to Diff 79030.
meven marked an inline comment as done.
meven added a comment.


  Use QLatin1String

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28476?vs=79025=79030

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28476

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, #frameworks
Cc: anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:127
>  return fstype + mountpoint;
> +} else if (fstype == "cifs") {
> +// append mountpoints to samba device name as they don't contain it 
> in getmntent

use `QLatin1String`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28476

To: meven, #frameworks
Cc: anthonyfieroni, sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/26/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Wed, 01 Apr 2020 08:53:33 +
 Build duration:
8 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Méven Car]

meven updated this revision to Diff 79025.
meven added a comment.


  Use a char instead of char*

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28476?vs=79023=79025

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28476

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, #frameworks
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Ahmad Samir]

ahmadsamir added a subscriber: sitter.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28476

To: meven, #frameworks
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e247985be433: [DirectorySizeJob] Fix sub-dirs count when 
resolving symlinks to dirs (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28472?vs=79014=79024

REVISION DETAIL
  https://phabricator.kde.org/D28472

AFFECTED FILES
  src/core/directorysizejob.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Yay for unittests (and my bad for not running them when making that change). 
Thanks for the fix!

REPOSITORY
  R241 KIO

BRANCH
  l-dirsizejob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28472

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Méven Car]

meven updated this revision to Diff 79023.
meven added a comment.


  Fix comment

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28476?vs=79022=79023

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28476

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28476: Samba: Ensure to differenciate mounts sharing the same source

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  `getmntent` for samba returns fsname of the form "//server/folder" (same as 
`mount`) 
  It is not sufficient to use in udi as device name as it does not 
differenciate mounts sharing the same source but having different mount points.
  
  BUG: 418906
  FIXED-IN: 5.69

TEST PLAN
  With a local cifs mount point:
  
  Before
  $ solid-hardware5 list | grep ourfiles
  udi = '/org/kde/fstab///meven-synapse/ourfiles'
  
  After
  $ solid-hardware5 list | grep ourfiles
  udi = '/org/kde/fstab///meven-synapse/ourfiles:/media/samba'

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28476

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  After 730a6ddd828fb1fbdf0f3 
, 
the behaviour changed and the code sets
  KIO::UDSEntry::UDS_DEVICE_ID after symlinks are resovled (if
  KIO::StatResolveSymlink is set); this meant that if we have dir A and
  a symlink to it B, the loop that detects hard-links will skip A if B
  was processed before, as both will have the same inode.
  
  This fixes the directorySize() unit test from kiocore-jobtest; the
  totalSubdirs() count didn't match the expected value.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-dirsizejob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28472

AFFECTED FILES
  src/core/directorysizejob.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns