KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/23/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 03 Apr 2020 03:26:22 +
 Build duration:
2 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 623 lines...][2020-04-03T03:28:23.527Z] [ 47%] Linking CXX executable ../../../bin/andpostingiteratortest[2020-04-03T03:28:23.792Z] [ 47%] Built target andpostingiteratortest[2020-04-03T03:28:23.792Z] [ 47%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexerprovider.cpp.o[2020-04-03T03:28:24.839Z] [ 48%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/mtimedbtest.cpp.o[2020-04-03T03:28:25.463Z] [ 48%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/singledbtest.cpp.o[2020-04-03T03:28:25.463Z] [ 48%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/propertydata.cpp.o[2020-04-03T03:28:26.096Z] Scanning dependencies of target documentiddbtest[2020-04-03T03:28:26.096Z] [ 48%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest_autogen/mocs_compilation.cpp.o[2020-04-03T03:28:26.385Z] [ 48%] Linking CXX executable ../../../bin/transactiontest[2020-04-03T03:28:27.016Z] [ 48%] Built target transactiontest[2020-04-03T03:28:27.016Z] [ 49%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/extractorprocess.cpp.o[2020-04-03T03:28:27.016Z] [ 50%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest.cpp.o[2020-04-03T03:28:28.590Z] [ 50%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[2020-04-03T03:28:28.590Z] [ 51%] Linking CXX executable ../../../bin/queryparsertest[2020-04-03T03:28:28.590Z] [ 51%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/singledbtest.cpp.o[2020-04-03T03:28:28.590Z] [ 51%] Built target queryparsertest[2020-04-03T03:28:28.590Z] [ 51%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/timeestimator.cpp.o[2020-04-03T03:28:29.660Z] [ 52%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[2020-04-03T03:28:29.660Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/file/extractorprocess.cpp:37:21: warning: unused parameter 'exitCode' [-Wunused-parameter][2020-04-03T03:28:29.660Z] [=](int exitCode, QProcess::ExitStatus exitStatus)[2020-04-03T03:28:29.660Z] ^[2020-04-03T03:28:30.355Z] 1 warning generated.[2020-04-03T03:28:30.355Z] [ 52%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/singledbtest.cpp.o[2020-04-03T03:28:30.935Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/lib/searchstore.cpp:245:21: error: use of undeclared identifier 'BALOO'[2020-04-03T03:28:30.935Z] qCDebug(BALOO) << "Folder" << value.toString() << "does not exist";[2020-04-03T03:28:30.935Z] ^[2020-04-03T03:28:30.935Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/lib/searchstore.cpp:345:17: error: use of undeclared identifier 'BALOO'[2020-04-03T03:28:30.935Z] qCDebug(BALOO) << "Comparison must be with an integer";[2020-04-03T03:28:30.935Z] ^[2020-04-03T03:28:30.935Z] Scanning dependencies of target documenttimedbtest[2020-04-03T03:28:30.935Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.14/src/lib/searchstore.cpp:391:17: error: use of undeclared identifier 'BALOO'[2020-04-03T03:28:30.935Z] qCDebug(BALOO) << "Type" << value << "does not exist";[2020-04-03T03:28:30.935Z] ^[2020-04-03T03:28:30.935Z] [ 53%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest_autogen/mocs_compilation.cpp.o[2020-04-03T03:28:30.935Z] [ 53%] Linking CXX executable ../../../bin/mtimedbtest[2020-04-03T03:28:31.200Z] 3 errors generated.[2020-04-03T03:28:31.200Z] gmake[2]: *** [src/lib/CMakeFiles/KF5Baloo.dir/build.make:271: src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o] Error 1[2020-04-03T03:28:31.200Z] gmake[2]: *** Waiting for unfinished jobs[2020-04-03T03:28:31.200Z] [ 53%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/indexcleaner.cpp.o[2020-04-03T03:28:31.200Z] [ 53%] Built target mtimedbtest[2020-04-03T03:28:31.200Z] Scanning dependencies of target documentdatadbtest[2020-04-03T03:28:31.200Z] [ 53%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/documentdatadbtest_autogen/mocs_compilation.cpp.o[2020-04-03T03:28:31.465Z] Scanning dependencies of target documenturldbtest[2020-04-03T03:28:31.466Z] [ 53%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/documenturldbtest_autogen/mocs_compilation.cpp.o[2020-04-03T03:28:32.926Z] [ 53%] Linking CXX executable ../../../bin/documentiddbtest[2020-04-03T03:28:33.207Z] [ 53%] Built target 

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/50/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 03 Apr 2020 03:26:22 +
 Build duration:
1 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 380 lines...][2020-04-03T03:27:15.769Z] [14/81] Building CXX object src\codecs\CMakeFiles\KF5BalooCodecs.dir\doctermscodec.cpp.obj[2020-04-03T03:27:15.769Z] [15/81] Building CXX object src\codecs\CMakeFiles\KF5BalooCodecs.dir\postingcodec.cpp.obj[2020-04-03T03:27:16.052Z] [16/81] Building CXX object src\codecs\CMakeFiles\KF5BalooCodecs.dir\positioncodec.cpp.obj[2020-04-03T03:27:16.320Z] [17/81] Linking CXX static library lib\KF5BalooCodecs.lib[2020-04-03T03:27:16.320Z] [18/81] Automatic MOC for target KF5BalooEngine[2020-04-03T03:27:19.103Z] [19/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\postingiterator.cpp.obj[2020-04-03T03:27:19.414Z] [20/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\andpostingiterator.cpp.obj[2020-04-03T03:27:19.704Z] [21/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\queryparser.cpp.obj[2020-04-03T03:27:19.704Z] [22/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\positiondb.cpp.obj[2020-04-03T03:27:19.704Z] ..\src\engine\positiondb.cpp(105): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.704Z] ..\src\engine\positiondb.cpp(145): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.704Z] ..\src\engine\positiondb.cpp(168): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.704Z] ..\src\engine\positiondb.cpp(169): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.704Z] [23/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\documenturldb.cpp.obj[2020-04-03T03:27:19.987Z] [24/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\document.cpp.obj[2020-04-03T03:27:19.987Z] [25/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\documentdatadb.cpp.obj[2020-04-03T03:27:19.987Z] ..\src\engine\documentdatadb.cpp(97): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.987Z] ..\src\engine\documentdatadb.cpp(151): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.987Z] [26/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\phraseanditerator.cpp.obj[2020-04-03T03:27:19.987Z] [27/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\documentdb.cpp.obj[2020-04-03T03:27:19.987Z] ..\src\engine\documentdb.cpp(100): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.987Z] ..\src\engine\documentdb.cpp(153): warning C4267: 'return': conversion from 'size_t' to 'uint', possible loss of data[2020-04-03T03:27:19.987Z] ..\src\engine\documentdb.cpp(176): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.988Z] [28/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\idfilenamedb.cpp.obj[2020-04-03T03:27:19.988Z] ..\src\engine\idfilenamedb.cpp(105): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:19.988Z] ..\src\engine\idfilenamedb.cpp(164): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:20.257Z] [29/81] Building CXX object src\engine\CMakeFiles\KF5BalooEngine.dir\postingdb.cpp.obj[2020-04-03T03:27:20.258Z] ..\src\engine\postingdb.cpp(103): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:20.258Z] ..\src\engine\postingdb.cpp(139): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:20.258Z] ..\src\engine\postingdb.cpp(178): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data[2020-04-03T03:27:20.258Z] ..\src\engine\postingdb.cpp(303): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:20.258Z] ..\src\engine\postingdb.cpp(304): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:20.258Z] ..\src\engine\postingdb.cpp(232): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-04-03T03:27:20.258Z] ..\src\engine\postingdb.cpp(259): note: see reference to function template instantiation 'Baloo::PostingIterator *Baloo::PostingDB::iter>(const QByteArray &,Validator)' being compiled[2020-04-03T03:27:20.258Z] with[2020-04-03T03:27:20.258Z] [[2020-04-03T03:27:20.258Z] Validator=Baloo::PostingDB::prefixIter::[2020-04-03T03:27:20.258Z] 

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.14 - Build # 15 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.14/15/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 03 Apr 2020 03:26:26 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 657 lines...][2020-04-03T03:27:17.259Z] [ 47%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/propertydata.cpp.o[2020-04-03T03:27:17.260Z] [ 47%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o[2020-04-03T03:27:17.517Z] [ 47%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/documentdbtest.cpp.o[2020-04-03T03:27:17.517Z] [ 47%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/singledbtest.cpp.o[2020-04-03T03:27:17.517Z] [ 47%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[2020-04-03T03:27:17.775Z] [ 48%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[2020-04-03T03:27:17.775Z] [ 48%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[2020-04-03T03:27:17.775Z] [ 49%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[2020-04-03T03:27:17.775Z] Scanning dependencies of target documenttimedbtest[2020-04-03T03:27:17.775Z] [ 49%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest_autogen/mocs_compilation.cpp.o[2020-04-03T03:27:17.775Z] Scanning dependencies of target transactiontest[2020-04-03T03:27:18.034Z] [ 49%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/transactiontest_autogen/mocs_compilation.cpp.o[2020-04-03T03:27:18.034Z] [ 50%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/transactiontest.cpp.o[2020-04-03T03:27:18.034Z] [ 50%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/singledbtest.cpp.o[2020-04-03T03:27:18.034Z] [ 50%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/baloodebug.cpp.o[2020-04-03T03:27:18.293Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.14/src/lib/searchstore.cpp: In member function ���Baloo::PostingIterator* Baloo::SearchStore::constructQuery(Baloo::Transaction*, const Baloo::Term&)���:[2020-04-03T03:27:18.293Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.14/src/lib/searchstore.cpp:245:21: error: ���BALOO��� was not declared in this scope[2020-04-03T03:27:18.293Z]   245 | qCDebug(BALOO) << "Folder" << value.toString() << "does not exist";[2020-04-03T03:27:18.293Z]   | ^[2020-04-03T03:27:18.293Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.14/src/lib/searchstore.cpp:245:13: error: ���qCDebug��� was not declared in this scope; did you mean ���qDebug���?[2020-04-03T03:27:18.293Z]   245 | qCDebug(BALOO) << "Folder" << value.toString() << "does not exist";[2020-04-03T03:27:18.293Z]   | ^~~[2020-04-03T03:27:18.293Z]   | qDebug[2020-04-03T03:27:18.293Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.14/src/lib/searchstore.cpp:345:17: error: ���BALOO��� was not declared in this scope[2020-04-03T03:27:18.293Z]   345 | qCDebug(BALOO) << "Comparison must be with an integer";[2020-04-03T03:27:18.293Z]   | ^[2020-04-03T03:27:18.293Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.14/src/lib/searchstore.cpp:345:9: error: ���qCDebug��� was not declared in this scope; did you mean ���qDebug���?[2020-04-03T03:27:18.293Z]   345 | qCDebug(BALOO) << "Comparison must be with an integer";[2020-04-03T03:27:18.293Z]   | ^~~[2020-04-03T03:27:18.293Z]   | qDebug[2020-04-03T03:27:18.293Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.14/src/lib/searchstore.cpp: In member function ���Baloo::EngineQuery Baloo::SearchStore::constructTypeQuery(const QString&)���:[2020-04-03T03:27:18.293Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.14/src/lib/searchstore.cpp:391:17: error: ���BALOO��� was not declared in this scope[2020-04-03T03:27:18.293Z]   391 | qCDebug(BALOO) << "Type" << value << "does not exist";[2020-04-03T03:27:18.293Z]   | ^[2020-04-03T03:27:18.293Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.14/src/lib/searchstore.cpp:391:9: error: ���qCDebug��� was not declared in this scope; did you mean ���qDebug���?[2020-04-03T03:27:18.293Z]   391 | qCDebug(BALOO) << "Type" << value << "does not exist";[2020-04-03T03:27:18.293Z]   | ^~~[2020-04-03T03:27:18.293Z]   | qDebug[2020-04-03T03:27:18.293Z] [ 50%] Linking CXX executable ../../../bin/baloo_file_extractor[2020-04-03T03:27:18.552Z] [ 50%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/baloosettings.cpp.o[2020-04-03T03:27:18.552Z] make[2]: *** [src/lib/CMakeFiles/KF5Baloo.dir/build.make:271: 

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 236 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/236/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 Apr 2020 03:26:23 +
 Build duration:
56 sec and counting
   CONSOLE OUTPUT
  [...truncated 619 lines...][2020-04-03T03:27:15.768Z] [ 38%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/filemonitor.cpp.o[2020-04-03T03:27:15.768Z] [ 39%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/regexpcache.cpp.o[2020-04-03T03:27:15.768Z] Scanning dependencies of target documentdbtest[2020-04-03T03:27:15.768Z] [ 40%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/documentdbtest_autogen/mocs_compilation.cpp.o[2020-04-03T03:27:16.028Z] [ 41%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/taglistjob.cpp.o[2020-04-03T03:27:16.028Z] [ 41%] Linking CXX executable ../../../bin/positiondbtest[2020-04-03T03:27:16.028Z] [ 41%] Linking CXX executable ../../../bin/phraseanditeratortest[2020-04-03T03:27:16.301Z] [ 41%] Linking CXX executable ../../../bin/orpostingiteratortest[2020-04-03T03:27:16.301Z] [ 41%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/indexerconfig.cpp.o[2020-04-03T03:27:16.301Z] [ 41%] Built target positiondbtest[2020-04-03T03:27:16.301Z] [ 41%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileindexerconfig.cpp.o[2020-04-03T03:27:16.301Z] [ 41%] Built target phraseanditeratortest[2020-04-03T03:27:16.301Z] [ 41%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.o[2020-04-03T03:27:16.564Z] [ 42%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o[2020-04-03T03:27:16.564Z] [ 42%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileexcludefilters.cpp.o[2020-04-03T03:27:16.564Z] [ 42%] Built target orpostingiteratortest[2020-04-03T03:27:16.564Z] [ 42%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileexcludefilters.cpp.o[2020-04-03T03:27:16.564Z] Scanning dependencies of target documenttimedbtest[2020-04-03T03:27:16.564Z] [ 42%] Building CXX object autotests/unit/engine/CMakeFiles/postingdbtest.dir/singledbtest.cpp.o[2020-04-03T03:27:16.564Z] [ 42%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest_autogen/mocs_compilation.cpp.o[2020-04-03T03:27:16.826Z] [ 42%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/propertydata.cpp.o[2020-04-03T03:27:16.826Z] [ 42%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/propertydata.cpp.o[2020-04-03T03:27:16.826Z] [ 42%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/documentdbtest.cpp.o[2020-04-03T03:27:17.095Z] [ 42%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[2020-04-03T03:27:17.095Z] [ 43%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloodebug.cpp.o[2020-04-03T03:27:17.095Z] [ 44%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[2020-04-03T03:27:17.678Z] [ 44%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/baloodebug.cpp.o[2020-04-03T03:27:17.678Z] [ 45%] Linking CXX executable ../../../bin/postingdbtest[2020-04-03T03:27:17.678Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/lib/searchstore.cpp: In member function ���Baloo::PostingIterator* Baloo::SearchStore::constructQuery(Baloo::Transaction*, const Baloo::Term&)���:[2020-04-03T03:27:17.678Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/lib/searchstore.cpp:245:21: error: ���BALOO��� was not declared in this scope[2020-04-03T03:27:17.678Z]   245 | qCDebug(BALOO) << "Folder" << value.toString() << "does not exist";[2020-04-03T03:27:17.678Z]   | ^[2020-04-03T03:27:17.678Z] [ 45%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest.cpp.o[2020-04-03T03:27:17.678Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/lib/searchstore.cpp:245:13: error: ���qCDebug��� was not declared in this scope; did you mean ���qDebug���?[2020-04-03T03:27:17.678Z]   245 | qCDebug(BALOO) << "Folder" << value.toString() << "does not exist";[2020-04-03T03:27:17.678Z]   | ^~~[2020-04-03T03:27:17.678Z]   | qDebug[2020-04-03T03:27:17.678Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/lib/searchstore.cpp:345:17: error: ���BALOO��� was not declared in this scope[2020-04-03T03:27:17.678Z]   345 | qCDebug(BALOO) << "Comparison must be with an integer";[2020-04-03T03:27:17.678Z]   | ^[2020-04-03T03:27:17.678Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/lib/searchstore.cpp:345:9: error: ���qCDebug��� was not declared in this scope; did you mean ���qDebug���?[2020-04-03T03:27:17.678Z]   345 | qCDebug(BALOO) << 

D28501: [SearchStore] Use categorized logging

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:6a0be3910727: [SearchStore] Use categorized logging 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28501?vs=79172=79186

REVISION DETAIL
  https://phabricator.kde.org/D28501

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28397: Replace Vokoscreen with VokoscreenNG

[Gaston Haro]

harogaston updated this revision to Diff 79185.
harogaston added a comment.


  Removed unnesessary changes to .desktop as indicated

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28397?vs=78778=79185

BRANCH
  update-vokoscreen-url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28397

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/vokoscreen.desktop
  data/kmoretools-desktopfiles/vokoscreen.png
  data/kmoretools-desktopfiles/vokoscreenNG.desktop
  data/kmoretools-desktopfiles/vokoscreenNG.png
  src/kmoretools/kmoretoolspresets.cpp

To: harogaston, #knewstuff, ngraham, leinir
Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28528: UDSEntry: add constructor variant with std::initializer_list

[Aleix Pol Gonzalez]

apol added a comment.


  +1 Makes sense, the code looks a bit fiddly but should allow cleaner code.

INLINE COMMENTS

> kossebau wrote in udsentry.h:127
> Do you mean deep-copy by memcopy? There should be no such, the 
> `UDSEntryInitListEntry(uint field, const QString )` constructor does a 
> normal shared copy:
> 
>   new(m_u.s) QString(value);
> 
> At least by what I understand and the test/experiments told me.
> 
> Still chances I missed something, being the first time I do such code, so 
> tear apart where needed :)

Yeah you're right.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28528

To: kossebau, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28528: UDSEntry: add constructor variant with std::initializer_list

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> apol wrote in udsentry.h:127
> I'm not sure, it skips the constructor/destructor, but then when it's a 
> string we need to do a memcopy. Are you sure this is faster than the 
> refcounting?

Do you mean deep-copy by memcopy? There should be no such, the 
`UDSEntryInitListEntry(uint field, const QString )` constructor does a 
normal shared copy:

  new(m_u.s) QString(value);

At least by what I understand and the test/experiments told me.

Still chances I missed something, being the first time I do such code, so tear 
apart where needed :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28528

To: kossebau, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28528: UDSEntry: add constructor variant with std::initializer_list

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> udsentry.h:127
> +// holds either the numeric or the string value
> +// done to avoid unneeded QString constructor & destructor in case of 
> numeric value
> +union U {

I'm not sure, it skips the constructor/destructor, but then when it's a string 
we need to do a memcopy. Are you sure this is faster than the refcounting?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28528

To: kossebau, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Friedrich W. H. Kossebau]

kossebau added a comment.


  D28528  now up additionally, for those 
cases where a init list could be used instead.
  
  Having challenged myself, I even found some pattern for doing a union with 
non-trivial constructors, which is a bit ugly, but makes one feel C++ expertish 
;) Also learned during that that unions can have constructors (needed/used for 
init of the const long long)... that language keeps on an eternal student :P

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28521

To: kossebau, #frameworks, dfaure
Cc: apol, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28528: UDSEntry: add constructor variant with std::initializer_list

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  For entries with fixed set of fields having an initializer list option comes
  as nice syntactix sugar and spares the need of the explicit reserve() call,
  and making sure to use the right size value there.
  
  Due to fields having either a numeric value or a string one, this needs some
  bit of C++ vodoo to avoid extra costs of having both a QString & a longlong
  field per every entry, which would also mean a QString constructor &
  destructor call also for each numeric field of the init list.
  The UDSEntryBenchmark showed that those constructors & destructors add
  notable cossts over explicit code to reserve & fill a UDSEntry, while using
  a union with a QString mapped onto a char array gets numbers close.

TEST PLAN
  New & old unit tests work, KIO usage e.g. in Dolphin with local filesystem
  or FTP server works as before.

REPOSITORY
  R241 KIO

BRANCH
  udsentryinitlistconstructor

REVISION DETAIL
  https://phabricator.kde.org/D28528

AFFECTED FILES
  autotests/udsentrytest.cpp
  autotests/udsentrytest.h
  src/core/slavebase.cpp
  src/core/udsentry.cpp
  src/core/udsentry.h
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/widgets/renamedialog.cpp
  tests/udsentrybenchmark.cpp

To: kossebau, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28470: WIP: IconItem: Refactor source handling for different types

[Carson Black]

cblack added a comment.


  Splitting into multiple classes seems like a good idea, but "strategy"? Seems 
like an odd choice of name to me.

INLINE COMMENTS

> iconitem.cpp:58
> +
> +class NullStategy : public IconItemStrategy
> +{

Is this class necessary? I feel like this class's behaviour should be what its 
parent does without a child implementation.

> iconitem.cpp:58
> +
> +class NullStategy : public IconItemStrategy
> +{

Also, "Stategy" instead of "Strategy"

> iconitem.cpp:80
> +private:
> +QIcon m_icon;
> +};

Seems unused.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D28501: [SearchStore] Use categorized logging

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28501

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Re: Problems in KWayland causes by API and ABI compatibility promises

[David Edmundson]

Kevin, thanks for your input.

I think there's a general feeling towards forking the server completely.

But we need to decide something concrete, and this ML is dying down. I
propose we have a voice/video chat with the objective of agreeing on a
concrete plan both short term and for KF6 and then just going ahead
and making the changes.

Given Doodle's take forever and everyone's probably quarantined
anyway, I propose we do it just after the Monday Plasma meeting. If
someone is eager to share an opinion and can't make that, message here
and we'll choose something more formally.

David

D28355: Introduce function ecm_install_configured_file

[David Edmundson]

davidedmundson updated this revision to Diff 79176.
davidedmundson added a comment.


  extra escape
  
  Not needed for the tests, yet weirdly threw an error in plasma...

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28355?vs=79115=79176

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28355

AFFECTED FILES
  docs/module/ECMConfiguredInstall.rst
  modules/ECMConfiguredInstall.cmake
  tests/CMakeLists.txt
  tests/ECMConfiguredInstallTest/CMakeLists.txt
  tests/ECMConfiguredInstallTest/check_tree.cmake.in
  tests/ECMConfiguredInstallTest/configured.txt
  tests/ECMConfiguredInstallTest/configured_atOnly.txt.in
  tests/ECMConfiguredInstallTest/expected/configured.txt
  tests/ECMConfiguredInstallTest/expected/configured_atOnly.txt
  tests/ECMConfiguredInstallTest/expected/multi1.txt
  tests/ECMConfiguredInstallTest/expected/multi2.txt
  tests/ECMConfiguredInstallTest/multi1.txt.in
  tests/ECMConfiguredInstallTest/multi2.txt.in

To: davidedmundson
Cc: kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D28501: [SearchStore] Use categorized logging

[Stefan Brüns]

bruns updated this revision to Diff 79172.
bruns added a comment.


  .

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28501?vs=79108=79172

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28501

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28506: [QueryParser] Fix broken detection of end quote

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:6be616f64b13: [QueryParser] Fix broken detection of end 
quote (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28506?vs=79114=79171

REVISION DETAIL
  https://phabricator.kde.org/D28506

AFFECTED FILES
  autotests/unit/engine/queryparsertest.cpp
  src/engine/queryparser.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28505: [EngineQuery] Provide toString(Term) overload for QTest

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:1f9ed1db7e27: [EngineQuery] Provide toString(Term) 
overload for QTest (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28505?vs=79113=79170

REVISION DETAIL
  https://phabricator.kde.org/D28505

AFFECTED FILES
  src/engine/enginequery.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28504: [EngineQuery] Remove unused position member, extend tests

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a6112063b9fa: [EngineQuery] Remove unused position 
member, extend tests (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28504?vs=79112=79169

REVISION DETAIL
  https://phabricator.kde.org/D28504

AFFECTED FILES
  autotests/unit/engine/queryparsertest.cpp
  src/engine/enginequery.cpp
  src/engine/enginequery.h
  src/engine/queryparser.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28503: [Term] Make debug output more compact and nicer to read

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:36803b7199f9: [Term] Make debug output more compact and 
nicer to read (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28503?vs=79111=79168

REVISION DETAIL
  https://phabricator.kde.org/D28503

AFFECTED FILES
  src/lib/term.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Looking at kio-extras, seems there are quite some more cases where the number 
of values inserted is fixed.
  
  Okay, I will revive my std::initializer_list code again, in a separate patch, 
there are enough use-cases available, so at least the sugar code is nice to 
have, even without measurable performance changes. Perhaps one of the reviewers 
then will be able to help how to do efficient code which avoids the unneeded 
QString constructor/destructor calls.
  
  Until then, the current patch should at least do some µ-improvement for 
people browsing lots of files via ftp & http :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28521

To: kossebau, #frameworks, dfaure
Cc: apol, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28522: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:d63e8bf49ce5: [QtQuick dialog] Port to UrlBUtton and hide 
when theres no URL (authored by ngraham).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28522?vs=79158=79161

REVISION DETAIL
  https://phabricator.kde.org/D28522

AFFECTED FILES
  src/qtquick/qml/EntryDetails.qml

To: ngraham, leinir, #knewstuff, #vdg, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Yes, I had also looked into adding a constructor with std::initializer_list 
for more code sugar, but found no way to deal with both QString & longlong 
where the overhead needed would be worth this. At least by the numbers the 
benchmark gave me
  And there are only a few cases with a fixed set of inserts, most add stuff 
conditionally, so the few cases seemed not worth the effort and I deleted my 
approach.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28521

To: kossebau, #frameworks, dfaure
Cc: apol, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28522: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  port-to-urlbutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28522

To: ngraham, leinir, #knewstuff, #vdg, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Aleix Pol Gonzalez]

apol added a comment.


  +1 Makes sense.
  
  Would it be possible to have a constructor such as this?
  
const UDSEntry destUds = {
{ UDSEntry::UDS_NAME, d->dest.fileName()} ,
{ UDSEntry::UDS_MODIFICATION_TIME, 
mtimeDest.toMSecsSinceEpoch() / 1000} ,
{ UDSEntry::UDS_CREATION_TIME, ctimeDest.toMSecsSinceEpoch() / 
1000} ,
{ UDSEntry::UDS_SIZE, sizeDest}
};
  
  It would allow for a cleaner text and no need to reserve explicitly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28521

To: kossebau, #frameworks, dfaure
Cc: apol, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28520: Fix lifetime of slot in KIO-MTP

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense

REPOSITORY
  R320 KIO Extras

BRANCH
  slotLifetime (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28520

To: feverfew, akrutzler, dfaure, elvisangelaccio, apol
Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D28522: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: leinir, KNewStuff, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Port from `linkButton` to `UrlButton` for links that open webpages, as this 
is what
  `UrlButton` was specifically designed for. Also hide any link that doesn't 
actually go
  anywhere because the URL isn't defined by the data source.

TEST PLAN
  F8211891: Screenshot_20200402_111651.png 

  
  There's no longer a donation button that doesn't do anything when clicked, 
and the
  homepage link shows a tooltip when hovered.

REPOSITORY
  R304 KNewStuff

BRANCH
  port-to-urlbutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28522

AFFECTED FILES
  src/qtquick/qml/EntryDetails.qml

To: ngraham, leinir, #knewstuff, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Use more UDSEntry::reserve() calls to 
avoid reallocson multiple inserts" to "Use more UDSEntry::reserve() calls to 
avoid reallocs on multiple inserts".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28521

To: kossebau, #frameworks, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28521: Use more UDSEntry::reserve() calls to avoid reallocson multiple inserts

[Ahmad Samir]

ahmadsamir added a comment.


  Typo in commit message "reallocson".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28521

To: kossebau, #frameworks, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28521: Use more UDSEntry::reserve() calls to avoid reallocson multiple inserts

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  moreudsentryreserve

REVISION DETAIL
  https://phabricator.kde.org/D28521

AFFECTED FILES
  src/core/slavebase.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/remote/remoteimpl.cpp
  src/ioslaves/trash/kio_trash.cpp
  src/widgets/renamedialog.cpp

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28504: [EngineQuery] Remove unused position member, extend tests

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28504

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28505: [EngineQuery] Provide toString(Term) overload for QTest

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28505

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28506: [QueryParser] Fix broken detection of end quote

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops!

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28506

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28503: [Term] Make debug output more compact and nicer to read

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28503

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28501: [SearchStore] Use categorized logging

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> bruns wrote in searchstore.cpp:239
> Its hardly more than reformatting.

But the commit message is about categorized logging, not reformatting. Just do 
the reformatting in a separate commit, no need for review I'd say

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28501

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28520: Fix lifetime of slot in KIO-MTP

[Alexander Saoutkin]

feverfew created this revision.
feverfew added reviewers: akrutzler, dfaure, elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  This slot was incorrectly made to last the lifetime of the slave. In fact, 
this
  slot should only be live for the lifetime of the event loop (one I/O 
operation).
  
  This can cause issues with the data being emitted for data from other IO 
  operations. By making it live in the lifetime of the local event loop this 
  scenario cannot occur as LIBMTP only allows one operation at a time.

TEST PLAN
  Via the use of KIOFuse (as this is where the bug was noticed). 
  Before: Opening a file for the first time worked. Subsequent opens would fail 
  due to garbage output After: Opening any number of files at any time works.

REPOSITORY
  R320 KIO Extras

BRANCH
  slotLifetime (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28520

AFFECTED FILES
  mtp/kio_mtp.cpp

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[David Faure]

dfaure added a comment.


  Good question. I haven't seen that done in most callers, but indeed, what if 
it's in a path with a space, like often happens on Windows?
  It sounds like the answer is yes, it should be quoted.
  The real answer is to write a CommandLauncherJob unittest for such a case, of 
course :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R275:8696ae59a274: [KItemModels/KLinkItemSelectionModelTest] 
Port QRegExp to QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28494?vs=79087=79143

REVISION DETAIL
  https://phabricator.kde.org/D28494

AFFECTED FILES
  autotests/klinkitemselectionmodeltest.cpp

To: ahmadsamir, #frameworks, dfaure, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28498: [xdgoutput] Explicitly set version of server interface

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in display.h:296
> I can't make it explicit. It's not a constructor

Passing an enum as const& is wrong although it doesn't make much of a 
difference in practice.

`You can't introduce another createXdgOutputManager() because it's not 
overloaded`. He's adding an overload, I don't understand.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28513: smb: use prettyname.local for hostname of wsdiscoveries

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I like this much better too!
  
  Stable branch?

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28510: [kprocessrunner] Escape hyphen characters in scope names

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28510

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[Kai Uwe Broulik]

broulik added a comment.


  Ok, makes sense. Just realized: do I need to `quoteArgs` the `executable`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28498: [xdgoutput] Explicitly set version of server interface

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> display.h:297
> + */
> +XdgOutputManagerInterface *createXdgOutputManager(const 
> XdgOutputInterfaceVersion , QObject *parent = nullptr);
> +

You can't introduce another createXdgOutputManager() because it's not 
overloaded. You probably need to rename this method, e.g. 
createXdgOutputManager2.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  KProcessRunner::KProcessRunner(QString cmd) calls 
KProcess::setShellCommand(cmd) which ... has two modes. Either 
KShell::splitArgs()[0] finds an executable that exists (checking that there is 
no "&&" or "||" or ";" in the command) in which case it uses the splitted args, 
and no /bin/sh is involved, *or* it passes the whole command as is to "sh -c", 
as a single argument. That first optimization aside, it is logical for 
setShellCommand to take a single string. So It's logical to me that 
KProcessRunner takes a single string, and that you join the stringlist in 
CommandLauncherJob.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  More convenient than having to construct a proper escaped commandline.

TEST PLAN
  - Ported the runners in D28512  to use 
it, had something with a space properly escaped
  
  Somehow this looks a bit wrong to me, i.e. shouldnt we have some args in 
kprocessrunner, too, or does it also just pass that command along verbatim?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

AFFECTED FILES
  src/gui/commandlauncherjob.cpp
  src/gui/commandlauncherjob.h

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir marked 4 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> meven wrote in jobtest.cpp:1530
> If you want to avoid doing this you can remove fields asked from statDetails 
> `KIO::StatBasic | KIO::StatUser | KIO::StatInode` for instance.
> And have a more focused test.

Good point, I slimmed it down to just KIO::StatInode. (Maybe that's too thin?).

> meven wrote in jobtest.cpp:1568
> You can have an else with just ` QCOMPARE(device, otherDevice);` and move 
> most of the  code inside of `if (!otherTmpDirIsOnSamePartition())` outside of 
> the if branch.

I moved the condition to the top, if we can't find two partitions on the 
system, bail out early.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir updated this revision to Diff 79133.
ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  - Less stat details, in that unit test we're interested in Inode stuff
  - In the test, return early if we can't find two separate partitions

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28478?vs=79071=79133

BRANCH
  l-statx (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28478

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28513: smb: use prettyname.local for hostname of wsdiscoveries

[Harald Sitter]

sitter added a comment.


  Competes with D27902 
  While this diff runs the risk of not being able to resolve 100% of the time 
(sans ip address fallback in listDir) it has the huge advantage that discovery 
isn't getting super slow when multiple wsd hosts are found and consequently 
need costly host resolution performed. So, I like this diff mch better.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28513: smb: use prettyname.local for hostname of wsdiscoveries

[Harald Sitter]

sitter created this revision.
sitter added reviewers: ngraham, meven.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  previously we simply used the ip address. this is fairly awkward though.
  instead try to deduce a resolvable host name from the pretty name.
  
  at discovery time we simply assume prettyName.local is the hostname.
  
  at listDir time we then attempt to resolve the name and if that fails
  strip the .local to get the presumed LLMNR/netbios name. this means
  the (first) listDir may be slower while we try to find a working hostname
  but discovery is still as fast as possible.

TEST PLAN
  wsdd on linux server resolves as expected, wsd on win10 also resolves as 
expected

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

AFFECTED FILES
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp

To: sitter, ngraham, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Méven Car]

meven added a comment.


  Just a few nitpicks in test and this is good IMHO

INLINE COMMENTS

> jobtest.cpp:1516
> +QVERIFY2(job->exec(), qPrintable(job->errorString()));
> +// TODO set setSide
> +const KIO::UDSEntry  = job->statResult();

Can remove

> jobtest.cpp:1530
> +#if 1 // should be #ifdef HAVE_STATX
> +QVERIFY(entry.contains(KIO::UDSEntry::UDS_CREATION_TIME));
> +QCOMPARE(entry.count(), 11);

If you want to avoid doing this you can remove fields asked from statDetails 
`KIO::StatBasic | KIO::StatUser | KIO::StatInode` for instance.
And have a more focused test.

> jobtest.cpp:1566
> +const int otherDevice = 
> otherEntry.numberValue(KIO::UDSEntry::UDS_DEVICE_ID);
> +qDebug() << "device ID:" << device << "; otherDevice ID:" << 
> otherDevice;
> +QVERIFY(device != otherDevice);

You can remove this now ;)

> jobtest.cpp:1568
> +QVERIFY(device != otherDevice);
> +}
> +}

You can have an else with just ` QCOMPARE(device, otherDevice);` and move most 
of the  code inside of `if (!otherTmpDirIsOnSamePartition())` outside of the if 
branch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:131
> I got the impression you liked being lax. Guess only when the shoe is on the 
> other foot.

I do like being lax! I literally gave you a ship it despite your comment being 
literally wrong.
Picking on useless crap such as whether a comment is technically entirely 
correct or not doesn't give anything of value to anyone except the person 
picking, who is really just getting an air of superiority I'm sure. The rest of 
the world meanwhile gets their time wasted. You seem to not appreciate that, 
and I'll clearly not make you see it either. One of many great failures of 
mine, right next to wanting things get done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28498: [xdgoutput] Explicitly set version of server interface

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in display.h:296
> I agree it's weird to take a const&, but it's what the others do

I can't make it explicit. It's not a constructor

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28498: [xdgoutput] Explicitly set version of server interface

[David Edmundson]

davidedmundson updated this revision to Diff 79127.
davidedmundson added a comment.


  update

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28498?vs=79102=79127

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28498

AFFECTED FILES
  autotests/client/test_xdg_output.cpp
  src/client/xdgoutput.h
  src/server/display.cpp
  src/server/display.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h

To: davidedmundson, #kwin
Cc: anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28498: [xdgoutput] Explicitly set version of server interface

[David Edmundson]

davidedmundson marked an inline comment as done.
davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in display.h:287
> Should we deprecate the one without version?

I'll add a doc. 
I don't want to waste time with the macro stuff given we know there's only one 
user.

> anthonyfieroni wrote in display.h:296
> explicit, also take enum class by value.

I agree it's weird to take a const&, but it's what the others do

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/3/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 02 Apr 2020 10:22:23 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:e468daf0d100: [Fstab] Ensure uniqueness for all 
filesystem types (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28488?vs=79067=79126

REVISION DETAIL
  https://phabricator.kde.org/D28488

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> sitter wrote in fstabhandling.cpp:131
> The previous comment was factually correct, it never claimed the same source 
> on the same mount would be differentiated. Your comment on the other hand 
> does and it's wrong. It's doesn't say it's unique for the purposes of 
> presentation or anything. It says mountpoints are unique. But they are not.
> I got the impression you liked nitpicking. Guess only when the shoe is on the 
> other foot.

I got the impression you liked being lax. Guess only when the shoe is on the 
other foot.

REPOSITORY
  R245 Solid

BRANCH
  fix_comment

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:131
> You let the old comment pass without any further remarks, but now you start 
> nitpicking?
> 
> From the acessibility viewpoint of the mount, it is unique.

The previous comment was factually correct, it never claimed the same source on 
the same mount would be differentiated. Your comment on the other hand does and 
it's wrong. It's doesn't say it's unique for the purposes of presentation or 
anything. It says mountpoints are unique. But they are not.
I got the impression you liked nitpicking. Guess only when the shoe is on the 
other foot.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Harald Sitter]

sitter accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  fix_comment

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28510: [kprocessrunner] Escape hyphen characters in scope names

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Desktop names can be from the set "ASCII letters, digits, dash (U+002D
  HYPHEN-MINUS) and underscore (U+005F LOW LINE). "
  
  Hyphen is a special character in systemd units indicating a logical tree
  level. We would process drop-ins incorrectly, Specification says they should 
be escaped.

TEST PLAN
  Ran elf-dissector
  systemdcg-ls showed
  org.kde.elf\x2ddissector-0dc652e69f5d4557873db10d03517b41.scope

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28510

AFFECTED FILES
  src/gui/kprocessrunner.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28501: [SearchStore] Use categorized logging

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28501

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28501: [SearchStore] Use categorized logging

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> apol wrote in searchstore.cpp:239
> This change is not related to what the commit message describes.

Its hardly more than reformatting.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28501

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28498: [xdgoutput] Explicitly set version of server interface

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> display.h:296
> + */
> +XdgOutputManagerInterface *createXdgOutputManager(const 
> XdgOutputInterfaceVersion , QObject *parent = nullptr);
> +

explicit, also take enum class by value.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28502: [baloosearch] Bail out early if specified folder is not valid

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:04a0b6348c10: [baloosearch] Bail out early if specified 
folder is not valid (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28502?vs=79110=79123

REVISION DETAIL
  https://phabricator.kde.org/D28502

AFFECTED FILES
  src/tools/baloosearch/main.cpp

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28324: [Inotify] Remove dead/duplicate code

[Stefan Brüns]

bruns marked 5 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28324

To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> sitter wrote in fstabhandling.cpp:131
> The comment is still wrong.

You let the old comment pass without any further remarks, but now you start 
nitpicking?

From the acessibility viewpoint of the mount, it is unique.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28502: [baloosearch] Bail out early if specified folder is not valid

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28502

To: bruns, #baloo, ngraham, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28501: [SearchStore] Use categorized logging

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> searchstore.cpp:239
>  else if (property == "includefolder") {
> -const QByteArray folder = 
> QFile::encodeName(QFileInfo(value.toString()).canonicalFilePath());
> +const QFileInfo fi = QFileInfo(value.toString());
> +const QByteArray folder = QFile::encodeName(fi.canonicalFilePath());

This change is not related to what the commit message describes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28501

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28498: [xdgoutput] Explicitly set version of server interface

[Aleix Pol Gonzalez]

apol added a comment.


  Some concerns at the documentation level. Looks good overall.

INLINE COMMENTS

> display.h:287
>   */
>  XdgOutputManagerInterface *createXdgOutputManager(QObject *parent = 
> nullptr);
>  

Should we deprecate the one without version?

> xdgoutput_interface.h:105
>   * It should be set once before the first done call
> - * @since 5.XDGOUTPUT
> + * Version 2 only
> + * @since 5.69

I'd write something like `Only effective since version UnstableV2`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28498

To: davidedmundson, #kwin
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:131
> The first mount is no longer visible, it is shadowed by the first one. You 
> can not read any files from it or write to it. You can not  unmount it.

The comment is still wrong.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added a comment.


  In D28488#639942 , @broulik wrote:
  
  > Wat. So maybe we need to add a hash of mount options to it? (Though I 
personally would call that pebkac)
  
  
  +1

INLINE COMMENTS

> sitter wrote in fstabhandling.cpp:131
> 
> 
>   λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me  
>   λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me
>   λ ajax ~ → sudo mount --bind /tmp /mnt 
>   λ ajax ~ → sudo mount --bind /tmp /mnt
>   λ ajax ~ → mount|grep /mnt
>   //bear.local/foo on /mnt type cifs 
> (rw,relatime,vers=3.1.1,cache=strict,username=me,uid=0,noforceuid,gid=0,noforcegid,addr=fd00::::8c8d:02ff:fec7:d6a4,file_mode=0755,dir_mode=0755,soft,nounix,serverino,mapposix,rsize=4194304,wsize=4194304,bsize=1048576,echo_interval=60,actimeo=1)
>   //bear.local/foo on /mnt type cifs 
> (rw,relatime,vers=3.1.1,cache=strict,username=me,uid=0,noforceuid,gid=0,noforcegid,addr=2a03:c100:f100:4f00:8c8d:02ff:fec7:d6a4,file_mode=0755,dir_mode=0755,soft,nounix,serverino,mapposix,rsize=4194304,wsize=4194304,bsize=1048576,echo_interval=60,actimeo=1,user=me)
>   /dev/nvme1n1p1 on /mnt type btrfs 
> (rw,relatime,ssd,space_cache,subvolid=1082,subvol=/@/tmp)
>   /dev/nvme1n1p1 on /mnt type btrfs 
> (rw,relatime,ssd,space_cache,subvolid=1082,subvol=/@/tmp)

The first mount is no longer visible, it is shadowed by the first one. You can 
not read any files from it or write to it. You can not  unmount it.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Kai Uwe Broulik]

broulik added a comment.


  Wat. So maybe we need to add a hash of mount options to it? (Though I 
personally would call that pebkac)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28355: Introduce function ecm_install_configured_file

[David Edmundson]

davidedmundson updated this revision to Diff 79115.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  update

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28355?vs=78887=79115

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28355

AFFECTED FILES
  docs/module/ECMConfiguredInstall.rst
  modules/ECMConfiguredInstall.cmake
  tests/CMakeLists.txt
  tests/ECMConfiguredInstallTest/CMakeLists.txt
  tests/ECMConfiguredInstallTest/check_tree.cmake.in
  tests/ECMConfiguredInstallTest/configured.txt
  tests/ECMConfiguredInstallTest/configured_atOnly.txt.in
  tests/ECMConfiguredInstallTest/expected/configured.txt
  tests/ECMConfiguredInstallTest/expected/configured_atOnly.txt
  tests/ECMConfiguredInstallTest/expected/multi1.txt
  tests/ECMConfiguredInstallTest/expected/multi2.txt
  tests/ECMConfiguredInstallTest/multi1.txt.in
  tests/ECMConfiguredInstallTest/multi2.txt.in

To: davidedmundson
Cc: kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D28355: Introduce function ecm_install_configured_file

[David Edmundson]

davidedmundson marked 3 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> kossebau wrote in ECMConfiguredInstall.cmake:62
> Actually, _configure_args could be a list  (starting with empty, not "") and 
> one would do list(APPEND). And cmake would then properly resolve that var 
> when used with configure_file I would expect (to be tested).

COPY_ONLY I think is mutually exclusive anyway.

List are nicer than messing with a string anyway. I've done that.

> kossebau wrote in check_tree.cmake.in:4-11
> This could become a macro/function perhaps, instead of repeating the same 
> logic 4 times. Actually one that should get moved to tests/test_helpers.cmake 
> later, as I remember other places which also check generated files against 
> file samples.
> 
> But can also be done as follow-up by someone (tm).

Heh, I'm wary of the trap where you end up needing tests to test the tests.

I've done it anyway. As a function. It's not in test_helpers yet, but would 
serve as a base.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:131
> Of course they are - you can just mount one fs at a path at any time.

λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me  
  λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me
  λ ajax ~ → sudo mount --bind /tmp /mnt 
  λ ajax ~ → sudo mount --bind /tmp /mnt
  λ ajax ~ → mount|grep /mnt
  //bear.local/foo on /mnt type cifs 
(rw,relatime,vers=3.1.1,cache=strict,username=me,uid=0,noforceuid,gid=0,noforcegid,addr=fd00::::8c8d:02ff:fec7:d6a4,file_mode=0755,dir_mode=0755,soft,nounix,serverino,mapposix,rsize=4194304,wsize=4194304,bsize=1048576,echo_interval=60,actimeo=1)
  //bear.local/foo on /mnt type cifs 
(rw,relatime,vers=3.1.1,cache=strict,username=me,uid=0,noforceuid,gid=0,noforcegid,addr=2a03:c100:f100:4f00:8c8d:02ff:fec7:d6a4,file_mode=0755,dir_mode=0755,soft,nounix,serverino,mapposix,rsize=4194304,wsize=4194304,bsize=1048576,echo_interval=60,actimeo=1,user=me)
  /dev/nvme1n1p1 on /mnt type btrfs 
(rw,relatime,ssd,space_cache,subvolid=1082,subvol=/@/tmp)
  /dev/nvme1n1p1 on /mnt type btrfs 
(rw,relatime,ssd,space_cache,subvolid=1082,subvol=/@/tmp)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> sitter wrote in fstabhandling.cpp:131
> mountpoints are not unique

Of course they are - you can just mount one fs at a path at any time.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28506: [QueryParser] Fix broken detection of end quote

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case the a closing quote was not followed by any term, but only
  whitespace, punctuation or other ignored characters (or any mixture
  thereof), the quote would not be detected.

TEST PLAN
  ctest -R queryparser

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28506

AFFECTED FILES
  autotests/unit/engine/queryparsertest.cpp
  src/engine/queryparser.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Harald Sitter]

sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fstabhandling.cpp:131
> +// for different users. Make sure it is unique by appending the
> +// mountpoint (which is unique).
> +return source + QLatin1Char(':') + mountpoint;

mountpoints are not unique

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28505: [EngineQuery] Provide toString(Term) overload for QTest

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Without the overload QTest only provides the generic "Compared values
  are not the same" message, without any details.
  
  Also make the debug output more compact.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28505

AFFECTED FILES
  src/engine/enginequery.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28504: [EngineQuery] Remove unused position member, extend tests

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The "pos" member is unused, remove it from the EngineQuery class.

TEST PLAN
  ctest
  $> baloosearch foo png -> finds foo.png and foo_bar.png
  $> baloosearch foo.png -> still finds foo.png, but not foo_bar.png

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28504

AFFECTED FILES
  autotests/unit/engine/queryparsertest.cpp
  src/engine/enginequery.cpp
  src/engine/enginequery.h
  src/engine/queryparser.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Fine

REPOSITORY
  R245 Solid

BRANCH
  fix_comment

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28503: [Term] Make debug output more compact and nicer to read

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Do not print the property name if it is not specified (i.e. the default).

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28503

AFFECTED FILES
  src/lib/term.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28220: Switch to using Kirigami's ShadowedRectangle

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:aa29f344928e: Switch to using Kirigamis 
ShadowedRectangle (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28220?vs=78430=79109

REVISION DETAIL
  https://phabricator.kde.org/D28220

AFFECTED FILES
  CMakeLists.txt
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28502: [baloosearch] Bail out early if specified folder is not valid

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  $> baloosearch -d /foo "test"
  /foo is not a valid directory

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28502

AFFECTED FILES
  src/tools/baloosearch/main.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28500: [PhraseAndIteratorTest] Cleanup, use better variable names

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Instead of pi1...piN, use something better tractable.
  
  No functional changes.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28500

AFFECTED FILES
  autotests/unit/engine/phraseanditeratortest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28501: [SearchStore] Use categorized logging

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  no functional changes

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28501

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns added a comment.


  In D28488#639815 , @meven wrote:
  
  > Good idea, we should fix this once and for all.
  >  Two points though about udi form :
  >
  > 1/ Nfs udi would no be great.
  >  For instance the source for nfs is usually of the form :
  >  192.168.0.1:/export
  >
  > With this we would have 
  >  192.168.0.1:/export:/mountpount
  >
  > I suggest for the nfs source to remove the first ':' in the first place
  >  To get :
  >  192.168.0.1/export:mountpount for nfs
  
  
  Lots of mangling for IMHO no benefit. The UDI is not really visible for the 
user.
  
  > 2/ For fuse mounts this removes the fstype from the udi, which is present 
currently for this case and handy.
  
  It does not ...

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28499: [LauncherJobs] Emit description

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Provides for better error reporting.

TEST PLAN
  Can't go in before tagging due to string freeze
  F825: Screenshot_20200402_101736.png 

  
  I kinda think `KNotificationJobUiDelegate` should add a "Failed" of sorts to 
the title since it doesn't go through the regular kuiserver job tracking which 
does that in case of an error

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp
  src/gui/commandlauncherjob.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:3dafde9c61b9: Introduce KNotificationJobUiDelegate 
(authored by broulik).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28295?vs=78839=79104

REVISION DETAIL
  https://phabricator.kde.org/D28295

AFFECTED FILES
  src/CMakeLists.txt
  src/knotificationjobuidelegate.cpp
  src/knotificationjobuidelegate.h

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Méven Car]

meven added a reviewer: sitter.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28498: [xdgoutput] Explicitly set version of server interface

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Implication being that when v2 is used name and description will be set
  appropriately. This brings us being spec-compliant if new wayland is
  used against old kwin.
  
  Resource check works by knowing that clients can't register a version
  newer than the client so setName will then no-op internally.

TEST PLAN
  Test failed till I bumped it to V2.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28498

AFFECTED FILES
  autotests/client/test_xdg_output.cpp
  src/client/xdgoutput.h
  src/server/display.cpp
  src/server/display.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Méven Car]

meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  Good idea, we should fix this once and for all.
  Two points though about udi form :
  
  1/ Nfs udi would no be great.
  For instance the source for nfs is usually of the form :
  192.168.0.1:/export
  
  With this we would have 
  192.168.0.1:/export:/mountpount
  
  I suggest for the nfs source to remove the first ':' in the first place
  To get :
  192.168.0.1/export:@mountpount for nfs
  
  2/ For fuse mounts this removes the fstype from the udi, which is present 
currently for this case and handy.
  So perhaps we would want to use the fstype :
  
  nfs/192.168.0.1/export:mountpount for nfs
  cifs//server/export:mountpoint for cifs (perhaps without the double slash)
  fuse.type/source/export:mountpount for fuse
  sftp/username@source/export:mountpoint for sftp
  
  Perhaps event fstype:/ to make the fstype look like a protocol in the udi, 
i.e : `fuse.type:/source/export:mountpount` and 
`sftp:/username@source/export:mountpoint for sftp`
  A complete udi would like like:
  `/orge/kde/fstab/sftp:/username@source/export:mountpoint`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28295: Introduce KNotificationJobUiDelegate

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I'm OK with this landing into 5.69
  
  Feel free to emit a description from the two new jobs.
  
  Thanks,
  David.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  fix_comment

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28295: Introduce KNotificationJobUiDelegate

[Kai Uwe Broulik]

broulik added a comment.


  Is this good now? But I think I'll wait until after tagging, it's not really 
urgent to get it in

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns