Re: Problems in KWayland causes by API and ABI compatibility promises

[Kevin Ottens]

Hello,

On Thursday, 16 April 2020 23:38:23 CEST David Edmundson wrote:
> On Wed, Apr 8, 2020 at 5:10 PM Kevin Ottens  wrote:
> > On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote:
> > > Here is a list of active uses of the KWayland::Client API.
> > > 
> > > frameworks
> > > 
> > > plasma-framework (for window positioning)
> > > 
> > > apps:
> > > spectacle (for window positioning)
> > > kdeconnect-kde  (for fake input)
> > > yakuake (for window positioning)
> > > 
> > > extragear
> > > 
> > > latte-dock (for window positioning, custom shadow (which could be
> > > 
> > > ported already) and windowmanagement)
> > 
> > The part of the list above makes me wonder, shouldn't the window
> > positioning and windowmanager features be on KWindowSystem?
> 
> Yeah, doing that will resolve 90% of the client cases.
> In general for things like blur and everything the slightly higher
> level abstraction is working out better as we can abstract X and
> wayland in one go, which really helps the client code.

Sounds like a plan then.
 
> Also, it's worth really clarifying that in absolutely any proposal
> KWayland as-is can't go away, so clients using that will still
> function.

Of course, it's just that the one in KF would become frozen and deprecated 
until KF6. But then the development would move on with the other copy which 
would be less of a burden for everyone.

> The slight twist on that which we need to be wary of is that client
> code will return shared objects if you request a
> KWaylandClient::PlasmaShellSurface::get(window())
> for the same window from two places you'll get the same PlasmaShell
> instance returned - and therefore the same wl_resource.
> If we hypothetically had a kwayland2::client also have a
> plasmashellsurface::get() method we would have two plasma_shellsurface
> wl_resources's for the same wl_surface which is a protocol error and
> our client will get violently killed.

Honestly you lost me here. :-)

> > > workspace:
> > > kwin unit tests
> > > libkscreen
> > > breeze (till Qt5.15)
> > > oxyen (till Qt5.15)
> > > xdg-desktop-portal
> > > kinfocenter
> > > plasma-workspace
> > > plasma-nano
> > > kscreenlocker
> > > powerdevil
> > > kwayland-integration (the backend for kwindowsystem)
> > > plasma-phone-components
> > > plasma-integration
> > 
> > I think the above is less of an issue, right? Because workspace would have
> > a copy of KWayland which could be shared with whatever stability
> > constraints needed.
> 
> It means it has to stay as an exported workspace lib, but yeah it
> wouldnt' be a problem.

Yes, exactly my position as well.

Regards.
-- 
Kevin Ottens, http://ervin.ipsquad.net

enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en

signature.asc
Description: This is a digitally signed message part.

D28874: Taiwanese holidays

[Ricky Lindén]

shrapnel updated this revision to Diff 80346.
shrapnel added a comment.


  Uploaded .diff instead of .patch

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28874?vs=80303=80346

REVISION DETAIL
  https://phabricator.kde.org/D28874

AFFECTED FILES
  holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch
  holidays/holidays.qrc
  holidays/plan2/holiday_tw_zh

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/27/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 17 Apr 2020 04:47:27 +
 Build duration:
3 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 80344.
mlaurent added a comment.


  Use m_menu->addActions(m_dropActions);

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80182=80344

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure, apol
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:48f60533b922: [plasma-framework] make it compiles without 
foreach (authored by mlaurent).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19913?vs=80344=80345

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/utils.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure, apol
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham added a comment.


  [insert I-have-no-idea-what-I'm-doing dog meme here]
  
  When trying to create items in root-owned locations, I'm getting an errors 
saying "The process for the file protocol died unexpectedly." or else Dolphin 
simply crashes with a totally unhelpful backtrace.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Chinmoy Ranjan Pradhan]

chinmoyr requested changes to this revision.
chinmoyr added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> file_unix.cpp:1331
> +KAuth::Action::DetailsMap details;
> +details.insert(KAuth::Action::AuthDetail::DetailMessage, 
> QStringLiteral("Authentication is required to perform this action."));
> +execAction.setDetailsV2(details);

We need to set a different message for each action.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham updated this revision to Diff 80343.
ngraham added a comment.


  Set the patch base

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=80342=80343

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham updated this revision to Diff 80342.
ngraham added a comment.


  - Fix build failure
  - Add more stuff (thanks @chinmoyr)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=80341=80342

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham commandeered this revision.
ngraham added a reviewer: chinmoyr.
ngraham added a comment.


  Yoink!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham added a comment.


  Thanks @chinmoyr!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: chinmoyr, #frameworks, dfaure
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 80341.
chinmoyr marked an inline comment as done.
chinmoyr added a comment.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.


  Rebased on master.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=18821=80341

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.json

To: chinmoyr, #frameworks, dfaure
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> file_unix.cpp:141
> +// Get the list of keys
> +ssize_t listlen = 512;
> +QByteArray keylist(listlen, Qt::Uninitialized);

The idea is almost right, the implementation is wrong.

  1. set listlen to 0
  
  2. resize keylist to listlen
  3. execute flistxattr with size = keylist.size();
  4a. if (3.) returns listlen > 0 and keylist.size() == 0, go to (2.)
  4b. if (3.) returns listlen > 0 and keylist.size() > 0 -> break
  4c. if (3.) returns listlen == -1 and errno == ERANGE, set listlen to 0 and 
go to (2.)
  4d. if (3.) returns listlen == -1 and errno == ENOTSUP -> return
  4e. if (3.) returns listlen == 0 -> return
  
  5. resize keylist to listlen, the list may shrink between flistxattr calls.

> file_unix.cpp:153
> +if (errno == ERANGE) {
> +keylist.resize(listlen + 512);
> +}

as listlen is -1 here, you always resize to 511 ...

> file_unix.cpp:163
> +}
> +} while (listlen == -1 && errno == ERANGE);
> +

man 2 flistxattr:

> In addition, the errors documented in stat(2) can also occur.

So any error but ERANGE will exit the loop, and you will have bogus keylist 
contents.

Do `return false` on any error but ERANGE in the loop.

After the loop (i.e. when listlen is guaranteed to be > 0), resize keylist to 
listlen, the list may shrink.

> file_unix.cpp:173
> +// For each key
> +keylist.squeeze();
> +while (keyPtr != keylist.cend()) {

Thats bad. Thats really bad.

squeeze may reallocate. This invalidates keyPtr.

> file_unix.cpp:186
> +ssize_t valuelen = 512;
> +QByteArray value(valuelen, Qt::Uninitialized);
> +do {

`QByteArray value` should be created outside the keyPtr loop.

This reduces the calls to malloc for the QByteArray data storage.

Then for each attribute, do a `value.resize(value.capacity)`.

> file_unix.cpp:196
> +if (valuelen == -1 && errno == ERANGE) {
> +value.resize(valuelen + 512);
> +}

-1 + 512 = 511 ...

Should be `value.resize(value.size() + 512)` or something similar.

> file_unix.cpp:198
> +}
> +} while (valuelen == -1 && errno == ERANGE);
> +

Again, valuelen may be -1 here ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/54/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 16 Apr 2020 23:43:51 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34940/62151)40%
(17729/43904)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10282)46%
(4580/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8496/14316)51%
(4462/8698)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8344)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/62/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 16 Apr 2020 23:43:51 +
 Build duration:
7 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 553 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/553/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Apr 2020 23:43:51 +
 Build duration:
5 min 44 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34930/62149)40%
(17731/43908)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10283)46%
(4580/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8493/14316)51%
(4467/8698)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8342)43%
(2081/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D28902: CopyJob: when stat'ing the dest, use StatBasic.

[David Faure]

dfaure created this revision.
dfaure added a reviewer: meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  However the StatDetail enum doesn't specify which enum value will get us
  UDS_LOCAL_PATH (because kio_file doesn't have that). kio_desktop does,
  but doesn't honour StatDetail yet. One approach is to consider it part
  of Basic, the other is to add a new enum value for it.

TEST PLAN
  jobtest and testtrash still pass

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28902

AFFECTED FILES
  src/core/copyjob.cpp

To: dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

[David Faure]

dfaure created this revision.
dfaure added reviewers: meven, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This indirectly fixes the testtrash unittest which noticed that the
  directory size cache was being updated when CopyJob stat's the
  destination trash:/.

TEST PLAN
  bin/testtrash

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28901

AFFECTED FILES
  src/core/global.h
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/kio_trash.h
  src/ioslaves/trash/trashimpl.cpp
  src/ioslaves/trash/trashimpl.h

To: dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure added a comment.


  Yep, that's it. Renaming trash:/A to trash:/B calls KIO::moveAs which stats 
trash:/ [useful to resolve desktop:/ to a local dir for instance], which now 
updates the on-disk cache... with 'A', before it gets renamed to 'B'.
  
  I think I know what the best solution is. Using StatDetails to skip the 
(expensive) size stuff when CopyJob calls stat(). Bugfix and performance 
improvement :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D19913: [plasma-framework] make it compiles without foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.

INLINE COMMENTS

> dropmenu.cpp:80
>  } else if (m_menu) {
> -foreach (QAction *action, m_dropActions) {
> +for (QAction *action : qAsConst(m_dropActions)) {
>  m_menu->addAction(action);

`m_menu->addActions(m_dropActions);`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure, apol
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D28900: Fix wayland scanner warnings

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28900

To: apol, #build_system, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D28900: Fix wayland scanner warnings

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Build System, KWin, Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Tells cmake not to automoc certain files that don't need it, which would 
become a big fuss on the cmake output.

TEST PLAN
  No warnings

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28900

AFFECTED FILES
  find-modules/FindQtWaylandScanner.cmake
  find-modules/FindWaylandScanner.cmake

To: apol, #build_system, #kwin, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D26888: work around to fully support the windows backend

[Albert Vaca Cintora]

albertvaka added a comment.


  @vonreth @broulik Can you folks give this a final review? We have been 
building KDE Connect for Windows off a custom branch with this patch, but I 
would like to use official builds of KNotifications so it would be great if we 
can merge it.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26888

To: brute4s99, vonreth, broulik, #kde_connect
Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 marked 2 inline comments as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26888

To: brute4s99, vonreth, broulik, #kde_connect
Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 80333.
brute4s99 added a comment.


  work around to fully support the windows backend

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26888?vs=74291=80333

BRANCH
  arcpatch-D26888

REVISION DETAIL
  https://phabricator.kde.org/D26888

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, vonreth, broulik, #kde_connect
Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28891: Nicaragua Holidays

[Nathaniel Graham]

ngraham added a comment.


  You're very welcome. Thank you for the patch!

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello added a comment.


  Thank you for your time and support. 

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Nathaniel Graham]

ngraham added a comment.


  Great job! I'll hand it over to @winterz and other reviewers now.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello added a comment.


  Okay, I'm confident it went through this time

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello updated this revision to Diff 80322.
carguello added a comment.


  Adding Nicaragua Holidays file back

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28891?vs=80319=80322

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28891

AFFECTED FILES
  holidays/holidays.qrc
  holidays/plan2/holiday_ni_es

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Nathaniel Graham]

ngraham added a comment.


git add [the path to the new file you want to add]`
arc diff --update D28891

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello added a comment.


  
  
  How can I add it back? Sorry this is my first time using git and Phabricator

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Nathaniel Graham]

ngraham added a comment.


  Now the new file you wanted to add is gone. :)
  
  With Phabricator, you need to include all commits in your patch, not just the 
latest one.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello updated this revision to Diff 80319.
carguello added a comment.


  Previously messed up holidays/holidays.qrc I have fixed it now

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28891?vs=80318=80319

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28891

AFFECTED FILES
  holidays/holidays.qrc

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello added a comment.


  I think I messed up 

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

Re: Problems in KWayland causes by API and ABI compatibility promises

[David Edmundson]

On Wed, Apr 8, 2020 at 5:10 PM Kevin Ottens  wrote:
>
> Hello,
>
> On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote:
> > Here is a list of active uses of the KWayland::Client API.
> >
> > frameworks
> > plasma-framework (for window positioning)
> >
> > apps:
> > spectacle (for window positioning)
> > kdeconnect-kde  (for fake input)
> > yakuake (for window positioning)
> >
> > extragear
> > latte-dock (for window positioning, custom shadow (which could be
> > ported already) and windowmanagement)
>
> The part of the list above makes me wonder, shouldn't the window positioning
> and windowmanager features be on KWindowSystem?

Yeah, doing that will resolve 90% of the client cases.
In general for things like blur and everything the slightly higher
level abstraction is working out better as we can abstract X and
wayland in one go, which really helps the client code.

Also, it's worth really clarifying that in absolutely any proposal
KWayland as-is can't go away, so clients using that will still
function.

The slight twist on that which we need to be wary of is that client
code will return shared objects if you request a
KWaylandClient::PlasmaShellSurface::get(window())
for the same window from two places you'll get the same PlasmaShell
instance returned - and therefore the same wl_resource.
If we hypothetically had a kwayland2::client also have a
plasmashellsurface::get() method we would have two plasma_shellsurface
wl_resources's for the same wl_surface which is a protocol error and
our client will get violently killed.

> > workspace:
> > kwin unit tests
> > libkscreen
> > breeze (till Qt5.15)
> > oxyen (till Qt5.15)
> > xdg-desktop-portal
> > kinfocenter
> > plasma-workspace
> > plasma-nano
> > kscreenlocker
> > powerdevil
> > kwayland-integration (the backend for kwindowsystem)
> > plasma-phone-components
> > plasma-integration
>
> I think the above is less of an issue, right? Because workspace would have a
> copy of KWayland which could be shared with whatever stability constraints
> needed.

It means it has to stay as an exported workspace lib, but yeah it
wouldnt' be a problem.

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello updated this revision to Diff 80318.
carguello added a comment.


  Remove file extension .qrc per instructions

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28891?vs=80309=80318

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28891

AFFECTED FILES
  holidays/holidays.qrc

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

Re: Problems in KWayland causes by API and ABI compatibility promises

[David Edmundson]

> Given Doodle's take forever and everyone's probably quarantined
> anyway, I propose we do it just after the Monday Plasma meeting. If
> someone is eager to share an opinion and can't make that, message here
> and we'll choose something more formally.

That didn't really work out. Doodle it is!

https://doodle.com/poll/k8gzdvwhgibn7hma

Then we'll meet in #kwin on IRC

David

D28891: Nicaragua Holidays

[Nathaniel Graham]

ngraham removed a reviewer: VDG.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Nathaniel Graham]

ngraham added reviewers: winterz, Frameworks.
ngraham added a comment.


  Thanks for the patch! You need to update the `holidays/holidays.qrc` file 
too, to mention this new file that you're adding. Also I don't think you need 
to have the `.qrc` extension on the file you're adding.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, #vdg, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello added a reviewer: VDG.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, ngraham, bruns

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

[David Edmundson]

davidedmundson updated this revision to Diff 80312.
davidedmundson added a comment.


  update

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28892?vs=80311=80312

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28892

AFFECTED FILES
  autotests/client/test_remote_access.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

[David Edmundson]

davidedmundson updated this revision to Diff 80311.
davidedmundson added a comment.


  spelling

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28892?vs=80310=80311

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28892

AFFECTED FILES
  autotests/client/test_remote_access.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In this test we are waiting on 4 events. 2 things via 2 threads. It was
  unstable.
  
  This patch avoids hardcoding a bunch of ifs() handling recieving
  different orders, by waiting for both events.
  
  We can't use QTRY_COMPARE as ConnectionThread does magic things with
  QCoreApplication::eventDispatcher which don't work quite the same.
  
  This is a bit of a shot in the dark. It passes 100% of the time locally,
  lets see what CI manages to do :)

TEST PLAN
  Ran test :)

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28892

AFFECTED FILES
  autotests/client/test_remote_access.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28891: Nicaragua Holidays

[Carlos Arguello]

carguello created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
carguello requested review of this revision.

REVISION SUMMARY
  Added file containing Nicaragua holidays in holidays/plan2/holiday_ni_es

REPOSITORY
  R175 KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28891

AFFECTED FILES
  holidays/plan2/holiday_ni_es.qrc

To: carguello
Cc: kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham added a comment.


  Good question. I'm not sure it's possible here; the list views that use this 
component as a delegate might have to learn how to unset the selection with 
their own `TapHandler`. I'm not 100% sure on that though.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

[Nicolas Fella]

Hi,

this looks like a simple prison build failure to me. However, I cannot 
reprocuce this with
the binary factory container and the current Prison Android CI builds is blue. 
There is a
single red Android build in the Prison CI history 
(https://build.kde.org/job/Frameworks/
job/prison/job/kf5-qt5%20AndroidQt5.14/5/[1]) with what appears to be the same
error message. Not sure how to explain that though.

Nico


On Donnerstag, 16. April 2020 21:10:44 CEST Ben Cooksley wrote:
> On Fri, Apr 17, 2020 at 6:37 AM Johan Ouwerkerk  
> wrote:
> > On Thu, Apr 16, 2020 at 10:51 AM Ben Cooksley  wrote:
> >> Hi all,
> >>
> >> Does anyone know why the below would have suddenly started failing a
> >> little while back?
> >>
> >> Thanks,
> >> Ben
> >
> > Based on the error message I would expect this to be related to the effort
> > to fix Android pkgs not being generated for both 32bit and 64bit ARM.
> I see. Do we have a timeline for this being fixed?
>
> > Regards,
> >
> > - Johan
>
> Cheers,
> Ben




[1] 
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.14/5/

D28808: [ExpandableListItem] make it touch-friendly

[Niccolò Venerandi]

niccolove added a comment.


  This generically works, except for: would it be possible to make it so that 
clicking on an empty point will drop the list and button hover status? 
otherwise, you kind of get stuck to this situation:
  F8242311: Screenshot_20200416_224831.png 

  
  (ps yay, first time I actually manage to try a patch and review it. I'm 
getting better!)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Niccolò Venerandi]

niccolove added a reviewer: niccolove.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28811: Add drawer on mobile and clean code

[Olivier Churlaud]

ochurlaud accepted this revision.
ochurlaud added a comment.


  In D28811#649209 , @ognarb wrote:
  
  > I now generate the CSS from aether-sass. The code can be found 
https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss.
  And all tree wikis are using it.
  >
  > @ochurlaud should I create a sysadmin request for you to get access to the 
repo in invent so that you can edit it if you need?
  
  
  No need, I don't work much anymore on apidox.
  
  Does it work locally? If I use your patch and try locally on my computer? If 
it works, then you can ship it.

REPOSITORY
  R264 KApiDox

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

[Ben Cooksley]

On Fri, Apr 17, 2020 at 6:37 AM Johan Ouwerkerk  wrote:
>
>
> On Thu, Apr 16, 2020 at 10:51 AM Ben Cooksley  wrote:
>>
>> Hi all,
>>
>> Does anyone know why the below would have suddenly started failing a little 
>> while back?
>>
>> Thanks,
>> Ben
>
>
> Based on the error message I would expect this to be related to the effort to 
> fix Android pkgs not being generated for both 32bit and 64bit ARM.

I see. Do we have a timeline for this being fixed?

>
> Regards,
>
> - Johan

Cheers,
Ben

D19913: [plasma-framework] make it compiles without foreach

[Laurent Montel]

mlaurent added a comment.


  Ping ?:)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

[Johan Ouwerkerk]

On Thu, Apr 16, 2020 at 10:51 AM Ben Cooksley  wrote:

> Hi all,
>
> Does anyone know why the below would have suddenly started failing a
> little while back?
>
> Thanks,
> Ben
>

Based on the error message I would expect this to be related to the effort
to fix Android pkgs not being generated for both 32bit and 64bit ARM.

Regards,

- Johan

D27840: Introduce SettingState* elements to ease KCM writing

[Kevin Ottens]

ervin updated this revision to Diff 80305.
ervin added a comment.


  Fix issues found with Cyril's patches on various KCMs.

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27840?vs=78698=80305

REVISION DETAIL
  https://phabricator.kde.org/D27840

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/CMakeLists.txt
  src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp
  src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml
  src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir
  src/qmlcontrols/kcmcontrols/settingstatebindingprivate.cpp
  src/qmlcontrols/kcmcontrols/settingstatebindingprivate.h
  src/qmlcontrols/kcmcontrols/settingstateproxy.cpp
  src/qmlcontrols/kcmcontrols/settingstateproxy.h

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Chris Holland]

Zren added a comment.


  Phab only understands `.diff`. Phab does not recognize `.patch`.
  
git diff --staged > D28874.diff
  
  Or:
  
git diff origin/master > D28874.diff

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

[Igor Poboiko]

poboiko added a comment.


  @dfaure There seem to be a regression caused by this patch: if I reach the 
end of current view, and then press Enter so it has to scroll down, it scrolls 
to the very beginning of the document instead.
  
  This is the same issue as in ancient bug 195828 
, and it seems like it is Qt issue.
  
  Here's the simplest MWE:
  
#include 
#include 
#include 
#include 
#include 

int main(int argc, char *argv[])
{
QApplication a(argc, argv);
auto w = new QWidget();
auto edit = new QTextEdit();
auto button = new QPushButton(QStringLiteral("Insert new line"));
button->connect(button, ::clicked, [edit](){
auto cursor = edit->textCursor();
cursor.beginEditBlock();
cursor.insertBlock();
edit->setTextCursor(cursor);
cursor.endEditBlock();
});
auto layout = new QVBoxLayout(w);
layout->addWidget(edit);
layout->addWidget(button);
w->show();
return a.exec();
}
  
  Seems like the following code in `QTextCursorPrivate::setX` causes the 
trouble:
  
if (priv->isInEditBlock() || priv->inContentsChange) {
x = -1; // mark dirty
return;
}
  
  and seems like this "dirty" value is treated literally afterwards.
  
  For this example, switching `endEditBlock` and `setTextCursor` lines fixes 
the issue (and same with `Insert Rule`).
  I've also found a (dirty) workaround for the original patch: if I call 
`setTextCursor(textCursor())` right after `endEditBlock()`, it works like a 
charm. It seems like this line (although semantically is a NOOP) triggers the 
update of this "dirty" value.
  
  How should I proceed?

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28819

To: poboiko, #frameworks, mlaurent, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28874: Taiwanese holidays

[Ricky Lindén]

shrapnel updated this revision to Diff 80303.
shrapnel added a comment.


  Fixed the typos

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28874?vs=80288=80303

REVISION DETAIL
  https://phabricator.kde.org/D28874

AFFECTED FILES
  holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch
  holidays/plan2/holiday_tw_zh

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28865: [PhraseAndIterator] Remove temporary arrays when checking matches

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a27a2282da3f: [PhraseAndIterator] Remove temporary arrays 
when checking matches (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28865?vs=80239=80301

REVISION DETAIL
  https://phabricator.kde.org/D28865

AFFECTED FILES
  src/engine/phraseanditerator.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28864: [Extractor] Better balance idle and busy mode

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:ef3535630914: [Extractor] Better balance idle and busy 
mode (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28864?vs=80297=80300

REVISION DETAIL
  https://phabricator.kde.org/D28864

AFFECTED FILES
  src/file/extractor/app.cpp
  src/file/extractor/app.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28883: Add wrapper for wl_global_remove

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28883

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28864: [Extractor] Better balance idle and busy mode

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, makes sense to me!

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28864

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28863: [Extractor] Fix idle monitoring

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:0d56f65f03c3: [Extractor] Fix idle monitoring (authored 
by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28863?vs=80237=80299

REVISION DETAIL
  https://phabricator.kde.org/D28863

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:bd502bf0af46: [Extractor] Remove IdleStateMonitor wrapper 
class (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28862?vs=80295=80298

REVISION DETAIL
  https://phabricator.kde.org/D28862

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/idlestatemonitor.cpp
  src/file/extractor/idlestatemonitor.h

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28865: [PhraseAndIterator] Remove temporary arrays when checking matches

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28865

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28864: [Extractor] Better balance idle and busy mode

[Stefan Brüns]

bruns updated this revision to Diff 80297.
bruns edited the summary of this revision.
bruns added a comment.


  extend summary

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28864?vs=80296=80297

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28864

AFFECTED FILES
  src/file/extractor/app.cpp
  src/file/extractor/app.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28864: [Extractor] Better balance idle and busy mode

[Nathaniel Graham]

ngraham added a comment.


  Can you explain the conceptual reasoning behind this change?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28864

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28863: [Extractor] Fix idle monitoring

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28863

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28864: [Extractor] Better balance idle and busy mode

[Stefan Brüns]

bruns updated this revision to Diff 80296.
bruns added a comment.


  Extend commit message, reduce idle timeout

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28864?vs=80238=80296

REVISION DETAIL
  https://phabricator.kde.org/D28864

AFFECTED FILES
  src/file/extractor/app.cpp
  src/file/extractor/app.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

[Stefan Brüns]

bruns updated this revision to Diff 80295.
bruns added a comment.


  add line break before closing brace in lambda, use 2 minutes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28862?vs=80236=80295

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28862

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/idlestatemonitor.cpp
  src/file/extractor/idlestatemonitor.h

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> broulik wrote in app.cpp:63
> Coding style

Side note - both the Frameworks and the reference Qt coding style say nothing 
about lambdas.

If you read the `connect(...);` as a single statement, it should stay as is.

If you read the lambda as a function, the closing brace should go on a separate 
line.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28874: Taiwanese holidays

[Chris Holland]

Zren added a comment.


  There's a few extra spaces at the end of `"植樹節 "` and `"中秋節 補假 "` too.
  
  Not sure how well you know `git`, but make sure to run `git add 
holidays/plan2/holiday_tw_zh` again after making your changes, before running 
`git diff --staged` to upload the modified diff.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Allen Winter]

winterz added a comment.


  problems:
  
  - "religous" should be "religious"
  - missing ':' at the start of Constitution Day
- missing ':' at the start of Christmas Day

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Allen Winter]

winterz requested changes to this revision.
winterz added a comment.
This revision now requires changes to proceed.


  testing fails.  don't know why yet.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28701: Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: Add KPackage support to KNewStuffCore

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 80289.
leinir added a comment.


  Address @ngraham's (and my own) worry about the synchronous behaviour 
exhibited by KPackage... Something a bit like this probably wants to go into 
KPackage itself, perhaps we can consider this after we've done a bit of testing 
of its solidity here...
  
  - Add a simple async job wrapper for KPackage operations
  - Add the KPackage job to the build
  - Switch KNSCore::Installation to using the new async KPackageJob

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28701?vs=80195=80289

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/cache.cpp
  src/core/cache.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/installation.cpp
  src/core/installation.h
  src/core/jobs/kpackagejob.cpp
  src/core/jobs/kpackagejob.h
  src/downloaddialog.h

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28874: Taiwanese holidays

[Ricky Lindén]

shrapnel updated this revision to Diff 80288.
shrapnel added a comment.


  Hopefully the changes to both files are there now

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28874?vs=80277=80288

REVISION DETAIL
  https://phabricator.kde.org/D28874

AFFECTED FILES
  holidays/holidays.qrc
  holidays/plan2/holiday_tw_zh

To: shrapnel, #vdg, Zren
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80284.
apol added a subscriber: zzag.
apol added a comment.


  renamed protocol as per @zzag's suggestion

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80278=80284

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/videostreaming.cpp
  src/client/videostreaming.h

To: apol, #kwin, jgrulich
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Chris Holland]

Zren added a comment.


  Now you're missing `holidays/plan2/holiday_tw_zh` which can still be seen 
here: https://phabricator.kde.org/D28874?id=80260
  
git add holidays/holidays.qrc
git add holidays/plan2/holiday_tw_zh
git diff --staged > D28874.diff

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu added a comment.


  Ok, Thanks! I'll check it this weekend.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
rdieter, mikesomov

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 20 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/20/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 16 Apr 2020 14:48:35 +
 Build duration:
2 min 47 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerouter.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1665/3634)31%
(748/2413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1193/2666)31%
(529/1698)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 24 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/24/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 16 Apr 2020 14:48:36 +
 Build duration:
1 min 16 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_pagerouter.qml

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 417 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/417/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Apr 2020 14:48:35 +
 Build duration:
1 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerouter.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1665/3634)31%
(748/2413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1193/2666)31%
(529/1698)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol added a dependent revision: D28884: screencasting: Adoption of the 
org_kde_plasma_video_streaming protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28883: Add wrapper for wl_global_remove

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Removes the Global from the registry, but does not delete the underlying
  wl_global
  
  Removal of a global is racey in wayland. 
  A client could be trying to bind at that moment.
  
  Typically globals are static for the lifespan of the compositor, however
  there are exceptions
  
  For those cases this call will can remove the global from the registry,
  but still keep the wl_global instance alive
  and handling bind requests.
  
  The compositor can then remove the Global wrapper (this object) deleting
  the wl_global after an arbitrary delay or
  keep it around for re-use for the duration of the compositor.

TEST PLAN
  Unit test
  Made blur global outlive BlurEffect - no longer disconnects plasma on config 
changes

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28883

AFFECTED FILES
  autotests/client/test_wayland_blur.cpp
  src/server/global.cpp
  src/server/global.h

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: KWin, jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Creates a protocol based on Pipewire that allows us to request feeds to
  be set up by KWin rather than having to do it from a separate process.
  
  This will offer tighter control to KWin to do serve not only outputs but
  also windows as well.

TEST PLAN
  Treat this as a proof of concept to discuss if it's the protocol
  we need right now.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/protocols/video-streaming.xml
  src/client/videostreaming.cpp
  src/client/videostreaming.h

To: apol, #kwin, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Ricky Lindén]

shrapnel updated this revision to Diff 80277.
shrapnel edited the summary of this revision.
shrapnel added a comment.


  Added holiday_tw_zh to holidays.qrc-file (I'm new to git/phabricator so 
hopefully it makes sense)

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28874?vs=80260=80277

REVISION DETAIL
  https://phabricator.kde.org/D28874

AFFECTED FILES
  holidays/holidays.qrc

To: shrapnel, #vdg, Zren
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Allen Winter]

winterz added a comment.


  you need to add the change to holidays.qrc to this patch

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

[Igor Poboiko]

poboiko marked 3 inline comments as done.
poboiko added a comment.


  In D28854#649189 , 
@abstractdevelop wrote:
  
  > Hey, thanks for this @poboiko  I used to have to implement this myself, so 
this will be very useful in my app, O20.Word. ;)
  
  
  Sure, you're welcome! I like doing useful stuff :)

INLINE COMMENTS

> dfaure wrote in krichtextedit.cpp:346
> If boundedLevel is 6, the size adjustement will be -1?
> Does this mean a heading that's smaller than normal text?

Yes, that's true. I agree it's a bit confusing, but that's the case with HTML 
too, which I had in mind (see screenshot, it's Chrome)
F8241667: scr1.png 

For markdown, it seems like there are only 5 levels, 5th having the same size 
as normal text (6th level gets ignored, that's Okular)
F8241670: scr2.png 

I guess we probably can follow the Markdown way and bound it with 5, just to 
avoid confusion.

> dfaure wrote in krichtextedit.cpp:375
> This seems to duplicate what happened with selectCursor already. Why are two 
> cursors necessary to change the style of one paragraph?

I used `selectCursor` to select a line (block) under cursor and then change the 
style of the selection with `mergeCharFormat` .

`cursor` is for actual users cursor, which also has to change the style, so 
newly typed text will have the same style and heading level too (I use 
`mergeBlockCharFormat` for that reason - if I use `mergeCharFormat` here, the 
cursor will remain big after I press `Enter` after a title. However, it will 
change its size to the smaller one immediately after I start typing). But I 
don't want to mess with users selection, that's why I'm keeping both.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28854

To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure
Cc: abstractdevelop, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> thumbnail.cpp:726
>  
> +const auto mountsList = KMountPoint::currentMountPoints();
> +const auto mount =  mountsList.findByPath(filePath);

Calling currentMountPoints() for every created file is definitely a bad idea ...

https://github.com/KDE/kio/blob/master/src/core/kmountpoint.cpp#L272

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> thumbnail.cpp:729
> +const auto thumbRootMount = 
> mountsList.findByPath(m_thumbBasePath);
> +//If file is on the same filesystem as thumbnail directory, we 
> can cache it.
> +const bool isEncrypted = mount != thumbRootMount && 
> (mount->mountType() == QLatin1String("fuse.cryfs") || mount->mountType() == 
> QLatin1String("fuse.encfs"));

This can be checked much faster by comparing the device ids from a stat call. 
Then the code would also better match the comment.

Though, being on the same FS is a sufficient condition to create the thumbnail, 
it is not required. So the condition should probably read:

  dev_t fileDevId = ...
  if (m_thumbnailDirDeviceId != fileDevId) {
 bool isEncrypted = ...
 if (isEncrypted) {
  continue; // or return or whatever ...
 }
  }

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
rdieter, mikesomov

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, blaze.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  QRegularExpression::wildcardToRegularExpression() mainly handles file
  pattern globbing (e.g. "*.txt") which means it doesn't allow "/" in
  the file name (which is technically correct); but we have to subvert
  it because the keys in kwallet are in the form "foobar.com/"
  which does have a "/" in it. It's a hack, but it works here because
  in reality, there're no actual files/folders in kwallet, it's just
  data structures and "/" is an acceptable separator.

TEST PLAN
  - make && ctest
  - The password dialog in Falkon still wors

REPOSITORY
  R311 KWallet

BRANCH
  l-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28880

AFFECTED FILES
  src/api/KWallet/kwallet.cpp
  src/runtime/kwalletd/backend/kwalletbackend.cc

To: ahmadsamir, #frameworks, dfaure, blaze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28745: Skip caching thumbnails on encrypted filesystems

[Méven Car]

meven accepted this revision.
meven added a comment.


  In D28745#649011 , @marcingu wrote:
  
  > In D28745#648036 , @meven wrote:
  >
  > > This is gonna have an hefty toll on perf as it will add a `getmntent` 
syscall to every thumbnail generation.
  > >  Using `Solid::Device::listFromType` would leverage Solid always 
up-to-date (using events rather thane sysalls) device cache.
  > >  I am not sure in the end this is preferable though.
  >
  >
  > Unfortunately I'm new to the project and have no idea what would be the 
best way of checking if path is on encrypted filesystem.
  
  
  AFAICT this is not clear at the moment. This is too bad it stumbles upon a 
new contributor to deal with it.
  I recently learned about QStorageInfo that covers the same use case as 
KMountPoint.
  
  > One thing I could do is to move check into thumbForDirectory and transfer 
it through drawSubThumbnail and createSubThumbnail. Which will run the check 
once per directory, instead of running it up to four times.
  >  The big downside however is that we no longer will be able to skip the 
check if thumbnail already exist, so that likely would be slower in most cases.
  
  We should avoid absolutely avoid that, this is far worse than saving 1 
syscall per thumbnail.
  
  And after a second though a sysall is not much given we are generating a 
thumbnail that will be far longer to compute, so the price of the syscall 
should be unnoticeable.

INLINE COMMENTS

> thumbnail.cpp:729
> +const auto thumbRootMount = 
> mountsList.findByPath(m_thumbBasePath);
> +//If file is on the same filesystem as thumbnail directory, we 
> can cache it.
> +const bool isEncrypted = mount != thumbRootMount && 
> (mount->mountType() == QLatin1String("fuse.cryfs") || mount->mountType() == 
> QLatin1String("fuse.encfs"));

Add a space after //

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven
Cc: meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
rdieter, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/61/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 16 Apr 2020 10:25:10 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/53/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 16 Apr 2020 10:25:09 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34940/62151)40%
(17723/43906)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9815/10282)46%
(4574/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8492/14316)51%
(4461/8700)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8344)43%
(2077/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 552 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/552/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 16 Apr 2020 10:25:09 +
 Build duration:
9 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34929/62150)40%
(17721/43910)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10283)46%
(4568/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8492/14316)51%
(4463/8700)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8342)43%
(2081/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1791/4287)36%
(1311/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

[Jonathan Marten]

marten added a comment.


  I'm happy to work on the refactoring if you think it's the right thing to do.
  
  Do you mean splitting SchedulerPrivate::slotReparseSlaveConfiguration() up 
into two halves, the first part (KProtocolManager::reparseConfiguration through 
to NetRC::self()->reload - reparsing the configuration in the current process) 
being called directly and by the DBus signal, while the second half (check that 
'proto' is applicable then iterate through the allSlaves() list) being called 
only from emitReparseSlaveConfiguration?  Something like:
  
void Scheduler::emitReparseSlaveConfiguration()
{
  schedulerPrivate()->slotReparseSlaveConfiguration(...);
  schedulerPrivate()->reparseOtherSlaves();
}

void SchedulerPrivate::slotReparseSlaveConfiguration(...)
{
  KProtocolManager::reparseConfiguration();
  ,,,
  NetRC::self()->reload();
}

void SchedulerPrivate::reparseOtherSlaves()
{
  check protocol, return if not applicable
  iterate over allSlaves()
  {
slave->send(CMD_REPARSECONFIGURATION); slave->resetHost();
  }
}

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28647

To: marten, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28862: [Extractor] Remove IdleStateMonitor wrapper class

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

[Stefan Brüns]

bruns added a comment.


  In D28862#649411 , @broulik wrote:
  
  > It used to be 2 minutes, now it's 1?
  
  
  It used to be infinity ... 1 minute is completely sufficient.

INLINE COMMENTS

> broulik wrote in app.cpp:59
> Why the member variable? It's a singleton after all

Because its used recurrently in a slot in a later patch

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams