Re: RFC: Switching to min Qt version 5.14 for KF on December 14th
Hi, Am Samstag, 12. Dezember 2020, 22:25:32 CET schrieb David Faure: > Just a data point on this discussion. Every time we raise the min Qt > version, we make life easier for KDE developers, and harder for others who > might be thinking of integrating a framework into their project. > > Just today I tried using a KF5 library to extend a single plugin in an > existing webserver (which I don't control, and which is mostly written in > python) [1]. That server is entirely set up with a docker environment on top > of... debian buster, which has Qt 5.11.3. > Fail. > I'm going to have to apply a patch to the KF5 library as part of the > Dockerfile, to port it back to Qt 5.11. No way I can convince them to change > the base distribution, all I'll get as a reply is to port away from QtCore. > > Obviously the 5.11 ship has sailed by now, and I know we can't support old > versions forever, but this kind of experience makes me very wary of raising > requirements too fast. I am reading an objection to the proposed bump in these words, am I correct in doing that? Given you being KF release worker/manager and all your merits with KF, and also given no-one else so far has commented on this. I would accept that then and drop my request to adapt the current Qt compatibility road map. I tested the waters at least. Though please those who want to support Qt 5.13 for some more time, consider adding support for KDE CI then. It leaves a bad feeling in my stomach that KF 5.77+ seems effectively for Qt 5.13 with a sticker "Good Luck!" right now. I fear that lowers the image with (potential) KF consumers, it does at least with me for other projects. I (and possibly many other KF contributors) have no way to test against Qt 5.13, so might introduce regressions/break things in the future, which feels bad :/ Cheers Friedrich
KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 272 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/272/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Wed, 16 Dec 2020 18:26:28 + Build duration: 44 sec and counting JUnit Tests Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515 Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)
Re: KACL from KIO isn't really POSIX-compliant
El dimecres, 2 de desembre de 2020, a les 10:36:30 CET, Gleb Popov va escriure: > Hello everyone. > > I tried compiling kio/src/core/kacl.cpp on FreeBSD, which does support > POSIX ACLs, and failed. This is because KACL's code uses non-standard > Linux-specific acl_* functions. I tried implementing them using standard > ones and it turned out to be impossible, mainly because types like acl_t > are opaque to the user of the library. > > For instance, there is no standard acl_get_perm() function and it is > impossible to implement it without getting into acl_permset_t. > > Now I'm a bit unsure how to solve this. I can implement non-standard > functions in FreeBSD's libc without touching KACL code, or I can rewrite > the KACL class to be truly POSIX-compliant. The latter seems to be a better > idea on the first look, but it'd require keeping track of all the > permission flags set (again, because there is no acl_get_perm()) inside. > This will turn KACL class from being a tiny acl_* wrapper into a beefy > chunk of code, but at least we won't lie that it is POSIX-compliant. > > Any thoughts? This is exactly why we need CI at the Merge Request stage and not later, we would have caught this and whoever was proposing the change would have to fix it or find someone to help fix it. Anyhow, that's off topic :D About how to fix it, well fixing it in FreeBSD is probably "harder" that in kio (amount of people needed to be convinced), so I'd vote for the second so we can get unblocked as soon as possible. On how to fix it in KIO, the optimal way in my opinion is "abstract-like-its-kde", i.e. create a wrapper API on top of acl_* that has a #if LINUX and just calls the existing code and and #else POSIX and has the "beefy chunk of code" (but that's me not having a clue whatsoever about this ACL code). Cheers, Albert > > P.S. Please CC me, as I'm not subscribed. >
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 398 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/398/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Wed, 16 Dec 2020 17:41:34 + Build duration: 9 min 30 sec and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 397 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/397/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Wed, 16 Dec 2020 17:35:06 + Build duration: 6 min 22 sec and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.15 - Build # 392 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.15/392/ Project: kf5-qt5 SUSEQt5.15 Date of build: Wed, 16 Dec 2020 10:50:39 + Build duration: 6 min 49 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.78.0.xmllogs/KF5KIO/5.78.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 59 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report68% (25/37)67% (295/438)67% (295/438)58% (37556/65204)41% (19258/46623)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (59/59)100% (59/59)96% (10975/11484)46% (5340/11560)autotests.http100% (5/5)100% (5/5)99% (581/582)65% (88/136)autotests.kcookiejar100% (1/1)100% (1/1)93% (165/177)70% (49/70)src100% (1/1)100% (1/1)89% (8/9)71% (10/14)src.core88% (105/119)88% (105/119)61% (8852/14588)53% (4617/8784)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets77% (33/43)77% (33/43)59% (5166/8683)46% (2328/5054)src.gui100% (8/8)100% (8/8)80% (735/917)61% (380/622)src.gui.systemd50% (2/4)50% (2/4)4% (7/187)1% (1/116)src.ioslaves.file100% (7/7)100% (7/7)54% (721/1347)40% (440/1112)src.ioslaves.file.kauth0% (0/2)0% (0/2)0% (0/168)0% (0/89)src.ioslaves.ftp100% (2/2)100% (2/2)47% (653/1376)37% (531/1420)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/148)src.ioslaves.http88% (7/8)88% (7/8)41% (1778/4311)35% (1287/3644)src.ioslaves.http.kcookiejar40% (2/5)40% (2/5)47% (630/1331)56% (578/1037)src.ioslaves.remote100% (2/2)100% (2/2)27%
KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 52 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/52/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 16 Dec 2020 10:50:38 + Build duration: 6 min 25 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.78.0.xmllogs/KF5KIO/5.78.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 59 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report68% (25/37)67% (295/438)67% (295/438)58% (37552/65203)41% (19260/46623)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (59/59)100% (59/59)96% (10976/11484)46% (5340/11560)autotests.http100% (5/5)100% (5/5)99% (581/582)65% (88/136)autotests.kcookiejar100% (1/1)100% (1/1)93% (165/177)70% (49/70)src100% (1/1)100% (1/1)89% (8/9)71% (10/14)src.core88% (105/119)88% (105/119)61% (8852/14588)53% (4624/8784)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets77% (33/43)77% (33/43)59% (5166/8683)46% (2328/5054)src.gui100% (8/8)100% (8/8)80% (735/917)61% (380/622)src.gui.systemd50% (2/4)50% (2/4)4% (7/187)1% (1/116)src.ioslaves.file100% (7/7)100% (7/7)54% (721/1347)40% (440/1112)src.ioslaves.file.kauth0% (0/2)0% (0/2)0% (0/168)0% (0/89)src.ioslaves.ftp100% (2/2)100% (2/2)47% (653/1376)37% (531/1420)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/148)src.ioslaves.http88% (7/8)88% (7/8)41% (1778/4311)35% (1287/3644)src.ioslaves.http.kcookiejar40% (2/5)40% (2/5)47% (630/1331)56% (578/1037)src.ioslaves.remote100% (2/2)100% (2/2)27%
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 396 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/396/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Wed, 16 Dec 2020 10:50:39 + Build duration: 4 min 31 sec and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 271 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/271/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Wed, 16 Dec 2020 10:11:14 + Build duration: 55 sec and counting JUnit Tests Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515 Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_keynavigation.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_listskeynavigation.qml
