D25409: rst: Add support for standalone hyperlinks
adrianchavesfernandez added a reviewer: mosra. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25409 To: adrianchavesfernandez, mosra Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D25409: rst: Add support for standalone hyperlinks
adrianchavesfernandez created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. adrianchavesfernandez requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH rst-standalone-hyperlinks REVISION DETAIL https://phabricator.kde.org/D25409 AFFECTED FILES autotests/folding/highlight.rst.fold autotests/html/highlight.rst.html autotests/input/highlight.rst autotests/reference/highlight.rst.ref data/syntax/markdown.xml data/syntax/rest.xml To: adrianchavesfernandez Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D25276: reStructuredText: Fix inline literals highlighting preceding characters
adrianchavesfernandez added a reviewer: mosra. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25276 To: adrianchavesfernandez, mosra Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D25276: reStructuredText: Fix inline literals highlighting preceding characters
adrianchavesfernandez created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. adrianchavesfernandez requested review of this revision. TEST PLAN Covered by automated tests, and tested locally (new sytanx file with stable Kate) REPOSITORY R216 Syntax Highlighting BRANCH rst-inline-literal-prefix REVISION DETAIL https://phabricator.kde.org/D25276 AFFECTED FILES autotests/folding/highlight.rst.fold autotests/html/highlight.cmake.html autotests/html/highlight.rst.html autotests/input/highlight.rst autotests/reference/highlight.cmake.ref autotests/reference/highlight.rst.ref data/syntax/rest.xml To: adrianchavesfernandez Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
Re: Review Request 115907: Link tests with extra libraries as well
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115907/ --- (Updated March 4, 2014, 8:17 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kxmlgui Description --- Uses the optional extra libraries in the tests as well. Diffs - CMakeLists.txt 4db9ac5 autotests/CMakeLists.txt 01725da src/CMakeLists.txt a0dd642 tests/CMakeLists.txt 413fa92 tests/krichtexteditor/CMakeLists.txt 45c1abe Diff: https://git.reviewboard.kde.org/r/115907/diff/ Testing --- Tests build with and without KF5Attica. Thanks, Adrián Chaves Fernández ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Undefined references to Attica
O Xoves, 20 de Febreiro de 2014 10:50:21 Alex Merry escribiu: On 20/02/14 06:56, Adrián Chaves Fernández wrote: I was trying to build frameworks 4.96.0, and I run into trouble compiling the tests for KXmlGui, due to undefined references to Attica. I did this to solve it: https://git.reviewboard.kde.org/r/115907/diff/ Now, on the next package, KBookmarks, I again get undefined references to Attica (from the KXmlGui shared library) when building the tests. Am I missing something here? I'm starting to think the issue is with my personal configuration and not with the packages themselves. Odd; that shouldn't be happening. Does that statement include https://git.reviewboard.kde.org/r/115907/diff/ ? Should I need those changes to build kxmlgui or shouldn’t I? What system are you building on? Also, `make VERBOSE=1` can be a helpful debugging tool; I could imagine maybe getting errors like this if you are doing static builds. I’m building on Chakra, which should be not too different from Arch Linux. I’m using this lines for the actual build of kbookmarks (after building kxmlgui with the linked patch): mkdir -p build cd build cmake ../kbookmarks-4.96.0 \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_INSTALL_PREFIX=/usr/bin \ -DLIB_INSTALL_DIR=lib make With VERBOSE=1 in make, I get this towards the end: Linking CXX executable kbookmarkdialogtest cd /home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kbookmarks/src/build/tests /usr/bin/cmake -E cmake_link_script CMakeFiles/kbookmarkdialogtest.dir/link.txt --verbose=1 /usr/bin/c++ -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -g -fvar-tracking-assignments -g -fvar-tracking-assignments -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -O2 -g -DNDEBUG -Wl,--enable-new-dtags -Wl,-O1,--sort-common,--as-needed,-z,relro CMakeFiles/kbookmarkdialogtest.dir/kbookmarkdialogtest.cpp.o CMakeFiles/kbookmarkdialogtest.dir/kbookmarkdialogtest_automoc.cpp.o -o kbookmarkdialogtest -rdynamic ../src/libKF5Bookmarks.so.4.96.0 /usr/lib/libQt5Xml.so.5.2.1 /usr/lib/libQt5Widgets.so.5.2.1 /usr/lib/libQt5Gui.so.5.2.1 /usr/lib/libQt5Core.so.5.2.1 -Wl,-rpath,/home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kbookmarks/src/build/src /usr/bin/ld: warning: libKF5Attica.so.4, needed by /usr/lib/libKF5XmlGui.so.4, not found (try using -rpath or -rpath-link) /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Person::~Person()' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Provider::~Provider()' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Person::city() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Person::extendedAttribute(QString const) const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::ItemJobAttica::Person::result() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Metadata::~Metadata()' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Person::country() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::ProviderManager::ProviderManager(QFlagsAttica::ProviderManager::ProviderFlag const)' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::ProviderManager::providers() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Provider::name() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Provider::Provider()' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Person::avatarUrl() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::ProviderManager::loadDefaultProviders()' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Metadata::error() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::ProviderManager::~ProviderManager()' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::BaseJob::staticMetaObject' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::BaseJob::start()' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::ProviderManager::providerByUrl(QUrl const) const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Provider::isValid() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Provider::requestPerson(QString const)' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Person::homepage() const' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::Provider::operator=(Attica::Provider const)' /usr/lib/libKF5XmlGui.so.4: undefined reference to `Attica::BaseJob::metadata() const' collect2: error: ld returned 1 exit status make[2]: *** [tests/kbookmarkdialogtest] Error 1 make[2]: Leaving directory `/home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kbookmarks/src/build' make[1]: *** [tests/CMakeFiles/kbookmarkdialogtest.dir
Re: Review Request 115907: Link tests with extra libraries as well
On Feb. 20, 2014, 10:46 a.m., Alex Merry wrote: Can you describe the problem this fixes? Are the tests directly using these libraries somehow? If I build with these steps: mkdir -p build cd build cmake ../kxmlgui-4.96.0 \ -DCMAKE_INSTALL_PREFIX=/usr/bin \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DLIB_INSTALL_DIR=lib \ -DSYSCONF_INSTALL_DIR=/etc make In Chakra, I cannot get it to build. Without these changes, I get something like this when building the tests: Linking CXX executable kbugreporttest cd /home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kxmlgui/src/build/tests /usr/bin/cmake -E cmake_link_script CMakeFiles/kbugreporttest.dir/link.txt --verbose=1 /usr/bin/c++ -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -g -fvar-tracking-assignments -g -fvar-tracking-assignments -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -O2 -g -DNDEBUG -Wl,--enable-new-dtags -Wl,-O1,--sort-common,--as-needed,-z,relro CMakeFiles/kbugreporttest.dir/kbugreporttest.cpp.o CMakeFiles/kbugreporttest.dir/kbugreporttest_automoc.cpp.o -o kbugreporttest -rdynamic /usr/lib/libQt5Test.so.5.2.1 /usr/lib/libKF5WidgetsAddons.so.4.96.0 /usr/lib/libKF5I18n.so.4.96.0 ../src/libKF5XmlGui.so.4.96.0 /usr/lib/libKF5ConfigWidgets.so.4.96.0 /usr/lib/libKF5Codecs.so.4.96.0 /usr/lib/libKF5Auth.so.4.96.0 /usr/lib/libKF5I18n.so.4.96.0 /usr/lib/libKF5CoreAddons.so.4.96.0 /usr/lib/libKF5WidgetsAddons.so.4.96.0 /usr/lib/libKF5ConfigGui.so.4.96.0 /usr/lib/libQt5Xml.so.5.2.1 /usr/lib/libKF5ConfigC ore.so.4.96.0 /usr/lib/libQt5Widgets.so.5.2.1 /usr/lib/libQt5Gui.so.5.2.1 /usr/lib/libQt5DBus.so.5.2.1 /usr/lib/libQt5Core.so.5.2.1 -Wl,-rpath,/home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kxmlgui/src/build/src /usr/bin/ld: warning: libKF5Attica.so.4, needed by ../src/libKF5XmlGui.so.4.96.0, not found (try using -rpath or -rpath-link) ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::~Person()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::~Provider()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::city() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::extendedAttribute(QString const) const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ItemJobAttica::Person::result() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Metadata::~Metadata()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::country() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::ProviderManager(QFlagsAttica::ProviderManager::ProviderFlag const)' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::providers() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::name() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::Provider()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::avatarUrl() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::loadDefaultProviders()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Metadata::error() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::~ProviderManager()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::BaseJob::staticMetaObject' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::BaseJob::start()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::providerByUrl(QUrl const) const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::isValid() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::requestPerson(QString const)' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::homepage() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::operator=(Attica::Provider const)' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::BaseJob::metadata() const' collect2: error: ld returned 1 exit status make[2]: *** [tests/kbugreporttest] Error 1 make[2]: Leaving directory `/home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kxmlgui/src/build' make[1]: *** [tests/CMakeFiles/kbugreporttest.dir/all] Error 2 make[1]: Leaving directory `/home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kxmlgui/src/build' make: *** [all] Error 2 - Adrián --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115907/#review50328 --- On Feb. 20, 2014, 5:53 a.m., Adrián Chaves Fernández wrote
Re: Review Request 115907: Link tests with extra libraries as well
On Feb. 20, 2014, 10:46 a.m., Alex Merry wrote: Can you describe the problem this fixes? Are the tests directly using these libraries somehow? Adrián Chaves Fernández wrote: If I build with these steps: mkdir -p build cd build cmake ../kxmlgui-4.96.0 \ -DCMAKE_INSTALL_PREFIX=/usr/bin \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DLIB_INSTALL_DIR=lib \ -DSYSCONF_INSTALL_DIR=/etc make In Chakra, I cannot get it to build. Without these changes, I get something like this when building the tests: Linking CXX executable kbugreporttest cd /home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kxmlgui/src/build/tests /usr/bin/cmake -E cmake_link_script CMakeFiles/kbugreporttest.dir/link.txt --verbose=1 /usr/bin/c++ -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -g -fvar-tracking-assignments -g -fvar-tracking-assignments -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -O2 -g -DNDEBUG -Wl,--enable-new-dtags -Wl,-O1,--sort-common,--as-needed,-z,relro CMakeFiles/kbugreporttest.dir/kbugreporttest.cpp.o CMakeFiles/kbugreporttest.dir/kbugreporttest_automoc.cpp.o -o kbugreporttest -rdynamic /usr/lib/libQt5Test.so.5.2.1 /usr/lib/libKF5WidgetsAddons.so.4.96.0 /usr/lib/libKF5I18n.so.4.96.0 ../src/libKF5XmlGui.so.4.96.0 /usr/lib/libKF5ConfigWidgets.so.4.96.0 /usr/lib/libKF5Codecs.so.4.96.0 /usr/lib/libKF5Auth.so.4.96.0 /usr/lib/libKF5I18n.so.4.96.0 /usr/lib/libKF5CoreAddons.so.4.96.0 /usr/lib/libKF5WidgetsAddons.so.4.96.0 /usr/lib/libKF5ConfigGui.so.4.96.0 /usr/lib/libQt5Xml.so.5.2.1 /usr/lib/libKF5C onfigCore.so.4.96.0 /usr/lib/libQt5Widgets.so.5.2.1 /usr/lib/libQt5Gui.so.5.2.1 /usr/lib/libQt5DBus.so.5.2.1 /usr/lib/libQt5Core.so.5.2.1 -Wl,-rpath,/home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kxmlgui/src/build/src /usr/bin/ld: warning: libKF5Attica.so.4, needed by ../src/libKF5XmlGui.so.4.96.0, not found (try using -rpath or -rpath-link) ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::~Person()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::~Provider()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::city() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::extendedAttribute(QString const) const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ItemJobAttica::Person::result() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Metadata::~Metadata()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::country() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::ProviderManager(QFlagsAttica::ProviderManager::ProviderFlag const)' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::providers() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::name() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::Provider()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::avatarUrl() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::loadDefaultProviders()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Metadata::error() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::~ProviderManager()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::BaseJob::staticMetaObject' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::BaseJob::start()' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::ProviderManager::providerByUrl(QUrl const) const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::isValid() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::requestPerson(QString const)' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Person::homepage() const' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::Provider::operator=(Attica::Provider const)' ../src/libKF5XmlGui.so.4.96.0: undefined reference to `Attica::BaseJob::metadata() const' collect2: error: ld returned 1 exit status make[2]: *** [tests/kbugreporttest] Error 1 make[2]: Leaving directory `/home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kxmlgui/src/build' make[1]: *** [tests/CMakeFiles/kbugreporttest.dir/all] Error 2 make[1]: Leaving directory `/home/gallaecio/proxectos/empaquetamento/repositorios/desktop/kxmlgui/src/build' make: *** [all] Error 2 Hmm
