D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado 
aleksanderm updated this revision to Diff 61582.
aleksanderm added a comment.


  Renamed methods and made the getter const.

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22395?vs=61580=61582

BRANCH
  aleksander/dbus-timeout

REVISION DETAIL
  https://phabricator.kde.org/D22395

AFFECTED FILES
  src/bearer.cpp
  src/bearer.h
  src/call.cpp
  src/call.h
  src/modem.cpp
  src/modem.h
  src/modem3gpp.cpp
  src/modem3gpp.h
  src/modem3gppussd.cpp
  src/modem3gppussd.h
  src/modemcdma.cpp
  src/modemcdma.h
  src/modemlocation.cpp
  src/modemlocation.h
  src/modemmessaging.cpp
  src/modemmessaging.h
  src/modemoma.cpp
  src/modemoma.h
  src/modemsignal.cpp
  src/modemsignal.h
  src/modemsimple.cpp
  src/modemsimple.h
  src/modemtime.cpp
  src/modemtime.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/sim.cpp
  src/sim.h
  src/sms.cpp
  src/sms.h

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado 
aleksanderm added a comment.


  F7006291: test.cpp  attaching a tester 
program to exercise the new API in one of the interfaces.

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D22395

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added 1 blocking reviewer(s): jgrulich.
aleksanderm requested review of this revision.

REVISION SUMMARY
  Some methods in the ModemManager API (e.g. network scan) may take
  longer to complete than the default DBus timeout configured for the
  QDBusAbstractInterface, which is 25s usually.
  
  Allow clients to update this default timeout on every interface.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  aleksander/dbus-timeout

REVISION DETAIL
  https://phabricator.kde.org/D22395

AFFECTED FILES
  src/bearer.cpp
  src/bearer.h
  src/call.cpp
  src/call.h
  src/modem.cpp
  src/modem.h
  src/modem3gpp.cpp
  src/modem3gpp.h
  src/modem3gppussd.cpp
  src/modem3gppussd.h
  src/modemcdma.cpp
  src/modemcdma.h
  src/modemlocation.cpp
  src/modemlocation.h
  src/modemmessaging.cpp
  src/modemmessaging.h
  src/modemoma.cpp
  src/modemoma.h
  src/modemsignal.cpp
  src/modemsignal.h
  src/modemsimple.cpp
  src/modemsimple.h
  src/modemtime.cpp
  src/modemtime.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/sim.cpp
  src/sim.h
  src/sms.cpp
  src/sms.h

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

2019-04-04 Thread Aleksander Morgado 
aleksanderm marked an inline comment as done.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

2019-04-04 Thread Aleksander Morgado 
aleksanderm updated this revision to Diff 55395.
aleksanderm retitled this revision from "device: include Reapply() in the 
interface" to "device: include reapplyConnection() in the interface".

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20238?vs=55379=55395

REVISION DETAIL
  https://phabricator.kde.org/D20238

AFFECTED FILES
  src/device.cpp
  src/device.h

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include Reapply() in the interface

2019-04-03 Thread Aleksander Morgado 
aleksanderm updated this revision to Diff 55379.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20238?vs=55377=55379

REVISION DETAIL
  https://phabricator.kde.org/D20238

AFFECTED FILES
  src/device.cpp
  src/device.h

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include Reapply() in the interface

2019-04-03 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: jgrulich, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added 1 blocking reviewer(s): jgrulich.
aleksanderm requested review of this revision.

REVISION SUMMARY
  The NetworkManager::Device interface was lacking the support for reapplying 
settings during runtime.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

AFFECTED FILES
  src/device.cpp
  src/device.h

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-06-11 Thread Aleksander Morgado 
aleksanderm added a comment.


  Any ETA to land this change?

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-logging

REVISION DETAIL
  https://phabricator.kde.org/D13117

To: aleksanderm, jgrulich, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13482: Implement support for the Voice and Call interfaces

2018-06-11 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich.
aleksanderm added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
aleksanderm requested review of this revision.

REVISION SUMMARY
  The Voice and Call interfaces were introduced in ModemManager 1.6, and
  they provide access to voice-related operations (e.g. start a call,
  hangup a call, get notified of incoming calls..).
  
  This commit adds bindings for those 2 interfaces in ModemManagerQt.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  master-fixes

REVISION DETAIL
  https://phabricator.kde.org/D13482

AFFECTED FILES
  src/CMakeLists.txt
  src/call.cpp
  src/call.h
  src/call_p.h
  src/dbus/CMakeLists.txt
  src/dbus/callinterface.cpp
  src/dbus/callinterface.h
  src/dbus/dbus.h
  src/dbus/fakedbus.h
  src/dbus/introspection/org.freedesktop.ModemManager1.Call.xml
  src/dbus/introspection/org.freedesktop.ModemManager1.Modem.Voice.xml
  src/dbus/voiceinterface.cpp
  src/dbus/voiceinterface.h
  src/generictypes.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/modemvoice_p.h

To: aleksanderm, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-05-25 Thread Aleksander Morgado 
aleksanderm added a reviewer: Frameworks.

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D13117

To: aleksanderm, jgrulich, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13117: Don't set custom domain filter rules

2018-05-25 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: jgrulich, broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
aleksanderm requested review of this revision.

REVISION SUMMARY
  The library shouldn't set custom filter rules, it's a task of the app
  using the library to enable or disable them.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-logging

REVISION DETAIL
  https://phabricator.kde.org/D13117

AFFECTED FILES
  src/manager.cpp

To: aleksanderm, jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11320: Fix QVariantMapList operator >> implementation

2018-03-15 Thread Aleksander Morgado 
aleksanderm added a comment.


  In D11320#225486 , @broulik wrote:
  
  > Is that custom marshaller even neccessary? I thought Qt could resolve QList 
and QVariantMap (even nested) automatically? Can you try just removing that 
entire thing?
  
  
  Unless I'm missing something, it seems that it really is needed, this is what 
I got when removing the custom marshallers for QVariantMapList:
  
CMakeFiles/KF5ModemManagerQt.dir/bearer.cpp.o: In function 
`QList > qdbus_cast > 
>(QDBusArgument const&, QList >*)':

bearer.cpp:(.text._Z10qdbus_castI5QListI4QMapI7QString8QVariantEEET_RK13QDBusArgumentPS6_[_Z10qdbus_castI5QListI4QMapI7QString8QVariantEEET_RK13QDBusArgumentPS6_]+0x3e):
 undefined reference to `operator>>(QDBusArgument const&, QList >&)'
CMakeFiles/KF5ModemManagerQt.dir/generictypes.cpp.o: In function `void 
qDBusMarshallHelper > >(QDBusArgument&, 
QList > const*)':

generictypes.cpp:(.text._Z19qDBusMarshallHelperI5QListI4QMapI7QString8QVariantEEEvR13QDBusArgumentPKT_[_Z19qDBusMarshallHelperI5QListI4QMapI7QString8QVariantEEEvR13QDBusArgumentPKT_]+0x1f):
 undefined reference to `operator<<(QDBusArgument&, QList > const&)'
CMakeFiles/KF5ModemManagerQt.dir/generictypes.cpp.o: In function `void 
qDBusDemarshallHelper > >(QDBusArgument const&, 
QList >*)':

generictypes.cpp:(.text._Z21qDBusDemarshallHelperI5QListI4QMapI7QString8QVariantEEEvRK13QDBusArgumentPT_[_Z21qDBusDemarshallHelperI5QListI4QMapI7QString8QVariantEEEvRK13QDBusArgumentPT_]+0x1f):
 undefined reference to `operator>>(QDBusArgument const&, QList >&)'
collect2: error: ld returned 1 exit status

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D11320

To: aleksanderm, #frameworks, jgrulich
Cc: broulik, michaelh, ngraham

D11353: manager: add support to R/W the GlobalDnsConfiguration property

2018-03-15 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich.
aleksanderm added a project: Frameworks.
aleksanderm requested review of this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  globaldnsconfiguration

REVISION DETAIL
  https://phabricator.kde.org/D11353

AFFECTED FILES
  src/CMakeLists.txt
  src/dnsconfiguration.cpp
  src/dnsconfiguration.h
  src/dnsdomain.cpp
  src/dnsdomain.h
  src/manager.cpp
  src/manager.h
  src/manager_p.h

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham

D11320: Fix QVariantMapList operator >> implementation

2018-03-14 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich.
Restricted Application added a project: Frameworks.
aleksanderm requested review of this revision.

REVISION SUMMARY
Thread 1 "united-airlion" received signal SIGSEGV, Segmentation fault.
0x7255776f in _dbus_type_reader_recurse () from 
/usr/lib/libdbus-1.so.3
(gdb) bt
#0  0x7255776f in _dbus_type_reader_recurse () at 
/usr/lib/libdbus-1.so.3
#1  0x76a821d0 in  () at /usr/lib/libQt5DBus.so.5
#2  0x76a825b8 in QDBusArgument::beginArray() const () at 
/usr/lib/libQt5DBus.so.5
#3  0x76443ec9 in operator>>(QDBusArgument const&, 
QList >&) () at /usr/lib/libKF5ModemManagerQt.so.6
#4  0x76443f2d in operator>>(QDBusArgument const&, 
QList >&) () at /usr/lib/libKF5ModemManagerQt.so.6
#5  0x76443f2d in operator>>(QDBusArgument const&, 
QList >&) () at /usr/lib/libKF5ModemManagerQt.so.6
#6  0x76443f2d in operator>>(QDBusArgument const&, 
QList >&) () at /usr/lib/libKF5ModemManagerQt.so.6
#7  0x76a87d30 in QDBusMetaType::demarshall(QDBusArgument const&, 
int, void*) () at /usr/lib/libQt5DBus.so.5

REPOSITORY
  R281 ModemManagerQt

BRANCH
  fix-qvariantmaplist-demarshalling

REVISION DETAIL
  https://phabricator.kde.org/D11320

AFFECTED FILES
  src/generictypes.cpp

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham

D10366: cmake: don't flag libnm-util as found when ModemManager is found

2018-02-07 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich.
Restricted Application added a project: Frameworks.
aleksanderm requested review of this revision.

REVISION SUMMARY
  Looks like a leftover from when this file was imported from NM.
  libnm-util has nothing to do with MM.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  upstream-fixes

REVISION DETAIL
  https://phabricator.kde.org/D10366

AFFECTED FILES
  cmake/FindModemManager.cmake

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham

D10309: device: define StateChangeReason and MeteredStatus as Q_ENUMs

2018-02-04 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich.
Restricted Application added a project: Frameworks.
aleksanderm requested review of this revision.

REVISION SUMMARY
  So that e.g. users of the library can easily print them as strings.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  fixes

REVISION DETAIL
  https://phabricator.kde.org/D10309

AFFECTED FILES
  src/device.h

To: aleksanderm, #frameworks, jgrulich
Cc: michaelh, ngraham