D16674: MTP: fix runtime warning when showing a warning to the user.
akrutzler accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D16674 To: dfaure, akrutzler, elvisangelaccio, apol Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D15277: [mtp] Move MTP device handling from kioslave to kiod-module
This revision was automatically updated to reflect the committed changes. Closed by commit R320:aaa1edbb74c4: [mtp] Move MTP device handling from kioslave to kiod-module (authored by akrutzler). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15277?vs=43074=43145 REVISION DETAIL https://phabricator.kde.org/D15277 AFFECTED FILES mtp/CMakeLists.txt mtp/devicecache.cpp mtp/devicecache.h mtp/filecache.cpp mtp/filecache.h mtp/kio_mtp.cpp mtp/kio_mtp.h mtp/kio_mtp_helpers.cpp mtp/kio_mtp_helpers.h mtp/kiod_module/CMakeLists.txt mtp/kiod_module/kmtpd.cpp mtp/kiod_module/kmtpd.h mtp/kiod_module/kmtpd.json mtp/kiod_module/mtpdevice.cpp mtp/kiod_module/mtpdevice.h mtp/kiod_module/mtpstorage.cpp mtp/kiod_module/mtpstorage.h mtp/shared/CMakeLists.txt mtp/shared/kmtpdeviceinterface.cpp mtp/shared/kmtpdeviceinterface.h mtp/shared/kmtpdinterface.cpp mtp/shared/kmtpdinterface.h mtp/shared/kmtpfile.cpp mtp/shared/kmtpfile.h mtp/shared/kmtpstorageinterface.cpp mtp/shared/kmtpstorageinterface.h mtp/shared/org.kde.kmtp.daemon.xml mtp/shared/org.kde.kmtp.device.xml mtp/shared/org.kde.kmtp.storage.xml To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D15277: [mtp] Move MTP device handling from kioslave to kiod-module
akrutzler added a comment. Great! Is there anything else left to do @elvisangelaccio and @mlaurent before I land this? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D15277: [mtp] Move MTP device handling from kioslave to kiod-module
akrutzler retitled this revision from "[RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module" to "[mtp] Move MTP device handling from kioslave to kiod-module". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module
akrutzler updated this revision to Diff 43074. akrutzler marked 4 inline comments as done. akrutzler added a comment. - Rebase - Reserve memory for lists/vectors in advance. - Prepend "static" to all class-level functions - Fix typos REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15277?vs=42685=43074 BRANCH mtp_next (branched from master) REVISION DETAIL https://phabricator.kde.org/D15277 AFFECTED FILES mtp/CMakeLists.txt mtp/devicecache.cpp mtp/devicecache.h mtp/filecache.cpp mtp/filecache.h mtp/kio_mtp.cpp mtp/kio_mtp.h mtp/kio_mtp_helpers.cpp mtp/kio_mtp_helpers.h mtp/kiod_module/CMakeLists.txt mtp/kiod_module/kmtpd.cpp mtp/kiod_module/kmtpd.h mtp/kiod_module/kmtpd.json mtp/kiod_module/mtpdevice.cpp mtp/kiod_module/mtpdevice.h mtp/kiod_module/mtpstorage.cpp mtp/kiod_module/mtpstorage.h mtp/shared/CMakeLists.txt mtp/shared/kmtpdeviceinterface.cpp mtp/shared/kmtpdeviceinterface.h mtp/shared/kmtpdinterface.cpp mtp/shared/kmtpdinterface.h mtp/shared/kmtpfile.cpp mtp/shared/kmtpfile.h mtp/shared/kmtpstorageinterface.cpp mtp/shared/kmtpstorageinterface.h mtp/shared/org.kde.kmtp.daemon.xml mtp/shared/org.kde.kmtp.device.xml mtp/shared/org.kde.kmtp.storage.xml To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module
akrutzler added inline comments. INLINE COMMENTS > mlaurent wrote in mtpstorage.cpp:176 > QString() directly no ? Of course, thanks! :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module
akrutzler updated this revision to Diff 42685.
akrutzler marked 5 inline comments as done.
akrutzler added a comment.
- Use QString() directly instead of QStringLiteral("")
- Use explicit specifier
- Call either finished or error in slave methods
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15277?vs=42450=42685
BRANCH
mtp_next
REVISION DETAIL
https://phabricator.kde.org/D15277
AFFECTED FILES
mtp/CMakeLists.txt
mtp/devicecache.cpp
mtp/devicecache.h
mtp/filecache.cpp
mtp/filecache.h
mtp/kio_mtp.cpp
mtp/kio_mtp.h
mtp/kio_mtp_helpers.cpp
mtp/kio_mtp_helpers.h
mtp/kiod_module/CMakeLists.txt
mtp/kiod_module/kmtpd.cpp
mtp/kiod_module/kmtpd.h
mtp/kiod_module/kmtpd.json
mtp/kiod_module/mtpdevice.cpp
mtp/kiod_module/mtpdevice.h
mtp/kiod_module/mtpstorage.cpp
mtp/kiod_module/mtpstorage.h
mtp/shared/CMakeLists.txt
mtp/shared/kmtpdeviceinterface.cpp
mtp/shared/kmtpdeviceinterface.h
mtp/shared/kmtpdinterface.cpp
mtp/shared/kmtpdinterface.h
mtp/shared/kmtpfile.cpp
mtp/shared/kmtpfile.h
mtp/shared/kmtpstorageinterface.cpp
mtp/shared/kmtpstorageinterface.h
mtp/shared/org.kde.kmtp.daemon.xml
mtp/shared/org.kde.kmtp.device.xml
mtp/shared/org.kde.kmtp.storage.xml
To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module
akrutzler added inline comments. INLINE COMMENTS > dfaure wrote in mtpstorage.cpp:499 > DBus timeouts are actually configurable, if you need to block until the copy > is done, btw. In my previous approach I increased the timeout to 10 minutes. This worked fine until I downloaded a file of about 10GB or so from my phone -> timeout. It's hard to find a proper timeout which is why I chose the async way. :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module
akrutzler updated this revision to Diff 42450. akrutzler marked 13 inline comments as done. akrutzler added a comment. - Rebase - Remove unrelated changes - Remove Q_FUNC_INFO - Remove private static methods from header file - Use currentDateTimeUtc instead of currentDateTime - Generate D-Bus interface with qdbusxml2cpp REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15277?vs=41002=42450 BRANCH mtp_next REVISION DETAIL https://phabricator.kde.org/D15277 AFFECTED FILES mtp/CMakeLists.txt mtp/devicecache.cpp mtp/devicecache.h mtp/filecache.cpp mtp/filecache.h mtp/kio_mtp.cpp mtp/kio_mtp.h mtp/kio_mtp_helpers.cpp mtp/kio_mtp_helpers.h mtp/kiod_module/CMakeLists.txt mtp/kiod_module/kmtpd.cpp mtp/kiod_module/kmtpd.h mtp/kiod_module/kmtpd.json mtp/kiod_module/mtpdevice.cpp mtp/kiod_module/mtpdevice.h mtp/kiod_module/mtpstorage.cpp mtp/kiod_module/mtpstorage.h mtp/shared/CMakeLists.txt mtp/shared/kmtpdeviceinterface.cpp mtp/shared/kmtpdeviceinterface.h mtp/shared/kmtpdinterface.cpp mtp/shared/kmtpdinterface.h mtp/shared/kmtpfile.cpp mtp/shared/kmtpfile.h mtp/shared/kmtpstorageinterface.cpp mtp/shared/kmtpstorageinterface.h mtp/shared/org.kde.kmtp.daemon.xml mtp/shared/org.kde.kmtp.device.xml mtp/shared/org.kde.kmtp.storage.xml To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module
akrutzler added a comment. Thanks for the review. I will address your comments and hopefully have a patch ready in the next days. :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D9802: Avoid Dolphin crash
akrutzler added inline comments. INLINE COMMENTS > michaelh wrote in kcoredirlister.cpp:1233 > I'd like to ask for some help here. > Debugging in KDevelop, trying to step through the code: > it's not possible for me. Sometimes the debugger even crashed. > > - I checked for debugging symbols with file libKF5*: OK > - I checked loading with lsof $(pgrep dolphin): OK > > What do I miss? Sorry i don't use KDevelop, i am using QtCreator and debugging works pretty good there. Maybe give QtCreator a try :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, alexeymin, genaxxx, emmanuelp
D9802: Avoid Dolphin crash
akrutzler added inline comments. INLINE COMMENTS > michaelh wrote in kcoredirlister.cpp:1233 > I'm working with kio right now. Is better to just comment it out for the time > being? Yes, i would just comment this out :) Once you are done, undo the comment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, alexeymin, genaxxx, emmanuelp
D9802: Avoid Dolphin crash
akrutzler added inline comments.
INLINE COMMENTS
> kcoredirlister.cpp:1233
>
> -Q_ASSERT(!name.isEmpty());
> if (name.isEmpty()) {
Q_ASSERT is just executed in debug builds. It wont crash in release builds.
Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9802
To: michaelh, #dolphin, #frameworks
Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef,
andrebarros, alexeymin, genaxxx, emmanuelp
