Re: CI system maintainability

[Andrius Štikonas]

+1 for this. I think running tests before merging is more acceptable than 
having mandatory reviews.

On 29 March 2019 11:10:52 GMT+00:00, Ovidiu-Florin Bogdan 
 wrote:
>Hello,
>
>A Merge Request in GitLab does not necessarily imply the need for a
>review by e person. It can just run a pipeline to validate that the
>code isn't broken. If the pipeline fails, the merge button is not
>available.
>
>We use GitLab at work and we have it set up like this:
>
>* Main branches (develop/master/release/etc) are proteted and cannot be
>directly commited/pushed to, and only updated through MR
>* Each project defines what it's build/validate pipeline is
>(Jenkinsfile in project repo)
>* The pipeline is executed uppon creating the MR
>* if the Pipeline passes, the MR can be merged to the mainline branch
>
>This way we ensure that no code gets in that fails the build or with
>tests failing.
>
>P.S. We also store the build artifacts in a binary repository from
>where other pipelines can fetch them to be used in compiling other
>projects.
>
>P.P.S. This is the "DevOps" process used in most companies. The tools
>might differ, but the process is the same. It's the same for most FOSS
>projects as well.
>
>Regards,
>Ovidiu
>
>În ziua de joi, 28 martie 2019, la 10:29:22 EET, Kevin Ottens a scris:
>> Hello,
>> 
>> On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
>> > Please note that the commits in this instance were pushed without
>> > review, so restrictions on merge requests wouldn't make a
>difference
>> > in this case unfortunately.
>> 
>> Maybe it's about time to make reviews mandatory... I know it's
>unpopular in 
>> KDE, and I advocated for "don't force a tool if you can get someone
>to look at 
>> your screen or pair with you" in the past. Clearly this compromise
>gets 
>> somewhat exploited and that's especially bad in the case of a fragile
>and 
>> central component like KDE PIM.
>> 
>> Regards.
>> 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

D16344: Do not try to fallback to "less secure" protocols

[Andrius Štikonas]

stikonas added a comment.


  Line 89 in 
https://api.kde.org/frameworks/kio/html/ktcpsocket_8cpp_source.html suggests 
that it is the same as QSsl:SecureProtocols.
  
  Can you confirm that it works with TLSv1.2 only sites? (e.g. 
https://stikonas.eu:5281/admin/). Ideally we should  test with TLSv1.3 too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16344

To: aacid
Cc: jtamate, carewolf, dfaure, stikonas, kde-frameworks-devel, michaelh, 
ngraham, bruns

D13377: Fixup @since for skip switcher API

[Andrius Štikonas]

stikonas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13377

To: fvogt, #plasma, stikonas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#252165 , @bruns wrote:
  
  > Resizing: 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize
  
  
  Does not work well yet, just a few errors where KPM succeeds:
  
  - Cannot resize btrfs filesystem on /dev/sdb1: (null) filesystem 'btrfs' is 
not supported.
  - LUKS encrypted ext4: looks like I can resize internal file system but no 
way to resize outer LUKS container (i.e. what cryptsetup resize does)
  - Does not recognize LVM PVs, no way to resize them.
  
  On the other hand, it might be useful in certain cases. E.g. to resize FAT 
and maybe HPFS (not all distros ship fatresize).
  
  In any case, resizing is not the only thing. No way to copy/move file systems.
  
  I'm not opposed to UDisks in principle, I am just saying it's not there yet.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250688 , @bruns wrote:
  
  > Gnome-disks does, and so do other programs.
  
  
  Gnome-disks uses UDisks to do everything and can't do anything on its own. So 
available features are very limited (not even resizing partitions).
  I suspect it is significantly less portable (e.g. to FreeBSD).
  That's why gnome-disks was written from scratch (with fewer features than 
gparted that it was supposedly replacing).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250660 , @bruns wrote:
  
  > No, thats completely off, as thats the action you are authorizing.
  >
  > > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  >
  > I want it to show what it is asking permission for, and to be specific - 
does it want to format the USB stick I just inserted, or my home partition.
  
  
  Partition Manager wouldn't be able to show such specific text anyway (what is 
being formatted). It just starts a helper that can execute any command it asks. 
You can't make it work otherwise.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10518: Use QWidget to see if the window is visible

[Andrius Štikonas]

stikonas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

To: apol, #frameworks, stikonas
Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

[Andrius Štikonas]

stikonas accepted this revision.
stikonas added a comment.
This revision is now accepted and ready to land.


  Works for me.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

To: apol, #frameworks, stikonas
Cc: stikonas, michaelh

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas reclaimed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas abandoned this revision.
stikonas added a comment.


  Le's close it in favour of https://phabricator.kde.org/D10518

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas updated this revision to Diff 27181.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10495?vs=27106=27181

REVISION DETAIL
  https://phabricator.kde.org/D10495

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas added a comment.


  Well, basically when you click on any KF5 application (e.g. Konversation, 
KGpg, Akregator, etc...) in the system tray, nothing happens.
  This does no happen with Qt5-only programs. Clicking on system tray there 
always brings the window up.
  
  From what I can see in the code, on X11 
KWindowSystem::activateWindow(associatedWidget->winId()); raises the window
  but if I understand correctly KWindowSystem::activateWindow can never work on 
Wayland. This is clearly not what end user
  would expect.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas added a comment.


  This is more to start some discussion on system tray under Wayland. I'm not 
sure myself if this should be committed. I just use this workaround locally 
until winId() works on Wayland.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas created this revision.
stikonas added reviewers: wbauer, Plasma, davidedmundson, volkov.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
stikonas requested review of this revision.

REVISION SUMMARY
  Currently restoring system tray does not work on Wayland.
  
  Even with this commit, the functionality is still worse than on X11 because 
clicking on system tray does not hide application window.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4799: Delay notifications until desktop session has loaded

[Andrius Štikonas]

stikonas added a comment.


  This introduces a regression https://bugs.kde.org/show_bug.cgi?id=380974

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4799

To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, 
dfaure, graesslin
Cc: stikonas, plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Andrius Štikonas]

stikonas accepted this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  improveKAboutDataAPIDox

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, aacid, mpyne, ltoscano, stikonas
Cc: dfaure

D5405: Create desktop file name based on organization domain unless set explicitely

[Andrius Štikonas]

stikonas added a comment.


  > ! In https://phabricator.kde.org/D5405#101683, @graesslin wrote:
  >  My comment was not meant as a stop-this-effort comment. If we can improve 
here to do more sane things I'm all for it.
  
  No, it's not your comment. We were discussing this on #kde-devel and it looks 
like any improvements would require changes to the documented behaviour of 
KAboutData. And it could be that some apps are relying on it (although I think 
it's unlikely), so we didn't reach the consensus on what can be done in KF5, 
although everybody agreed things could be made saner for KF6...
  
  In any quite a few apps in 17.04 or 17.08 and extragear are now fixed and I 
also asked some 3rd party Qt apps to fix things, i.e. qbittorrent, qtox already 
merged fixes in git. I think people are just not aware enough about the various 
issues (its not unwillingness to fix them), even those mentioned in your 
blog... Actually even plasmashell hasn't fixed it's icon in wayland

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5405

To: stikonas, mpyne, kossebau, aacid, ltoscano
Cc: nalvarez, graesslin, mak, plasma-devel, kde-frameworks-devel, #frameworks, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol

D5405: Create desktop file name based on organization domain unless set explicitely

[Andrius Štikonas]

stikonas abandoned this revision.
stikonas added a comment.


  Ok, so let us not change kcoreaddons now although it's still something that 
could have better default behaviour in KF6.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5405

To: stikonas, mpyne, kossebau, aacid, ltoscano
Cc: nalvarez, graesslin, mak, plasma-devel, kde-frameworks-devel, #frameworks, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol

D5405: Create desktop file name based on organization domain unless set explicitely

[Andrius Štikonas]

stikonas added a comment.


  In fact API documentation says explicitely that
  
  > IMPORTANT: if the organization domain is set, the .desktop file that 
describes your application should have an entry like 
X-DBUS-ServiceName=reversed_domain.kmyapp For instance kwrite passes 
"http://www.kate-editor.org; as the homePageAddress so it needs 
X-DBUS-ServiceName=org.kate-editor.kwrite in its kwrite.desktop file.
  
  So if I understand correctly current documentation is not consistent, one 
thing contradicts another. I'm not sure if it is good to keep inconsistent 
behaviour till KF6... Well, it would be nice to hear if anybody else have any 
ideas?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5405

To: stikonas, mpyne, kossebau, aacid, ltoscano
Cc: mak, plasma-devel, kde-frameworks-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol

D5405: Create desktop file name based on organization domain unless set explicitely

[Andrius Štikonas]

stikonas added a comment.


  In https://phabricator.kde.org/D5405#101575, @mak wrote:
  
  > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote:
  >
  > > I'm still confused. Documentation or not, bad usage or not, is it correct 
that desktop file name is constructed from both the organization domain AND the 
homepage?
  >
  >
  > Yes. See 
https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s02.html
  
  
  The specs only mention reverse DNS, it says nothing about homepage. But all 
projects that I saw use reverse DNS of organization name, e.g. org.kde, never 
reverse of homepage in desktop files.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5405

To: stikonas, mpyne, kossebau, aacid, ltoscano
Cc: mak, plasma-devel, kde-frameworks-devel, #frameworks, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol

D5405: Create desktop file name based on organization domain unless set explicitely

[Andrius Štikonas]

stikonas created this revision.
stikonas added a project: Plasma on Wayland.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  On Wayland icons are obtained from desktop files that are named  
reverseOrganizationDomain.componentName.desktop. Unfortunately the current code 
sets desktop file name to reverseHomepage.comeponentName.desktop so kwin is not 
able to find an icon.

TEST PLAN
  Many applications still need to correctly set organization domain, but those 
that do now show proper icon.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5405

AFFECTED FILES
  src/lib/kaboutdata.cpp

To: stikonas, mpyne, ltoscano, kossebau, aacid
Cc: plasma-devel, kde-frameworks-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol

Re: Finding kdesu binary

[Andrius Štikonas]

> On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas  
> wrote:
> > Hi,
> >
> > I would like to ask how do I find kdesu binary from the code (of 
> > partitionmanager).
> >
> > PartitionManager tries to restart itself with root privileges and tries to 
> > rerun itself with kdesu, kdesudo or gksu...
> > However, KF5 based kdesu is now in libexec, something like
> > /usr/lib64/libexec/kf5/kdesu
> > but it varies from distribution to distribution and not in $PATH.
> >
> > Is there a way to find the location in the cross-platform way? There is 
> > kf5-config --path libexec but it is from kdelibs4support
> > and it's better not to depend on kdelibs4support.
> 
> If I understand correctly, you should use the KSu framework for that.
> kdesu is not public API, that's why it's in libexec.
> 
> Aleix

Hmm, but KSu framework does not have any GUI. And it is only used by
kdesu binary itself and krunner_shell library.

I would basically have to reimplement kdesu password dialog. Isn't this a bit 
inefficient?
Especially, when kdesu dialog is already shown automatically if partitionmanager
is launched from menu.

Andrius
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Finding kdesu binary

[Andrius Štikonas]

Hi,

I would like to ask how do I find kdesu binary from the code (of 
partitionmanager).

PartitionManager tries to restart itself with root privileges and tries to 
rerun itself with kdesu, kdesudo or gksu...
However, KF5 based kdesu is now in libexec, something like
/usr/lib64/libexec/kf5/kdesu
but it varies from distribution to distribution and not in $PATH.

Is there a way to find the location in the cross-platform way? There is 
kf5-config --path libexec but it is from kdelibs4support
and it's better not to depend on kdelibs4support.

Kind regards,
Andrius
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Finding kdesu binary

[Andrius Štikonas]

2016 m. sausio 29 d., penktadienis 17:30:32 GMT Aleix Pol rašė:
> On Fri, Jan 29, 2016 at 5:03 PM, Andrius Štikonas <andr...@stikonas.eu> wrote:
> >> On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas  
> >> wrote:
> >> > Hi,
> >> >
> >> > I would like to ask how do I find kdesu binary from the code (of 
> >> > partitionmanager).
> >> >
> >> > PartitionManager tries to restart itself with root privileges and tries 
> >> > to rerun itself with kdesu, kdesudo or gksu...
> >> > However, KF5 based kdesu is now in libexec, something like
> >> > /usr/lib64/libexec/kf5/kdesu
> >> > but it varies from distribution to distribution and not in $PATH.
> >> >
> >> > Is there a way to find the location in the cross-platform way? There is 
> >> > kf5-config --path libexec but it is from kdelibs4support
> >> > and it's better not to depend on kdelibs4support.
> >>
> >> If I understand correctly, you should use the KSu framework for that.
> >> kdesu is not public API, that's why it's in libexec.
> >>
> >> Aleix
> >
> > Hmm, but KSu framework does not have any GUI. And it is only used by
> > kdesu binary itself and krunner_shell library.
> >
> > I would basically have to reimplement kdesu password dialog. Isn't this a 
> > bit inefficient?
> > Especially, when kdesu dialog is already shown automatically if 
> > partitionmanager
> > is launched from menu.
> 
> Ah yes, you are right, kdesu is in kde-cli-tools. My apologies.
> 
> You can access the libexec install dir like done in discover and
> desktopexecparser [1].
> 
> Basically you need to pass the libexec directory from cmake:
> target_compile_definitions(YourTarget PRIVATE
> -DCMAKE_INSTALL_FULL_LIBEXECDIR_KF5=\"${CMAKE_INSTALL_FULL_LIBEXECDIR_KF5}\")
> 
> And then summon it as a full path: CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 "/kdesu".
> 
> HTH,
> Aleix
> 
> [1] https://lxr.kde.org/ident?_i=kdesu&_remember=1
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 

Thanks a lot! Works perfectly.

Andrius

-- 
I encourage the use of end to end email encryption

GPG key:   https://stikonas.eu/andrius.asc
Fingerprint:  1EE5 A320 5904 BAA2 B88C 0A9D 24FD 3194 0095 C0E1

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KConfigXT for QGroupBox?

[Andrius Štikonas]

Dear all,

Kdelibs4 had a widget called KButtonGroup. It is now deprecated in KDE 
Frameworks. The closest available replacement is QGroupBox. Unfortunately, I 
noticed that KConfigXT framework does not support it. It would be nice to have 
this feature...

Kind regards,
Andrius Štikonas

P.S. Thanks to Albert Astals Cid for answering a few questions I had when I 
ported KDE Partition Manager to KF5.

-- 
I encourage the use of end to end email encryption

GPG key:   https://stikonas.eu/stikonas.asc
Fingerprint:  1EE5 A320 5904 BAA2 B88C 0A9D 24FD 3194 0095 C0E1


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel