D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arvidhansson requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  num-lock-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19952

AFFECTED FILES
  icons/status/16/input-num-on.svg
  icons/status/22/input-num-on.svg

To: arvidhansson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#435940 , @ndavis wrote:
  
  > That "1" is too blurry. Did you use the font tool or did you draw it with 
the pen or rectangle tools?
  
  
  I used the font tool in Inkscape and pasted the 1 in the input-caps-on.svg I 
found in my local directory. Then I used the "export to PNG" option and 
attached the PNG to the summary. The SVG isn't blurry if you open it in 
Inkscape.
  
  > Since this is "numlock" Wouldn't it make more sense to put a "1" inside of 
a lock or next to a lock?
  
  That's true! I will see what I can do tomorrow.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#436427 , @ndavis wrote:
  
  > In D19952#436425 , @taskf wrote:
  >
  > > Hi, I created some icons a week ago, just didn't post them as 
@arvidhansson was already on the task.
  > >
  > > They are not polished as you can see from the screenshot. The left 
version symbolizes a lock, while the right one, which I like more, symbolizes a 
keyboard key.
  > >
  > > F6711403: Screenshot_20190322_211216.png 

  >
  
  
  Nice! This icons are really good!
  
  > I like the one on the right more. Our locks don't look like the once on the 
left.
  > 
  > Normally, our strikethroughs (the red diagonal line) go from the top left 
to the bottom right, similar to the No symbol 
.
  
  Well, I think you (Taskf) know what to do, just tell us if you need a hand.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: taskf, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#436834 , @taskf wrote:
  
  > There is one issue I'm not sure about. The user might feel pressured to 
check something if the symbol is stroked as it fells like "something is wrong". 
In that case I would suggest just using the ON version and make it 50% 
transparent in OFF mode.
  
  
  I agree, it isn't  even an caps-lock-off key.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: taskf, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#436919 , @taskf wrote:
  
  > Hmm, still I somehow like the stroked version, while I wouldn't recommend 
using it this particular case. Even the transparent version can easily be 
controlled the `disabled` state of this icon object. Currently, I think it 
would be good to add both icons to Breeze iconset, just in case there is 
another use case for it some day. I added all the other mockups I did just to 
let you know.
  >  F6716206: image.png 
  
  
  Yes, both icon may be the best alternative, is it just me or is the 
transparent icon more like grey?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#437419 , @ndavis wrote:
  
  > In D19952#436853 , @arvidhansson 
wrote:
  >
  > > In D19952#436834 , @taskf 
wrote:
  > >
  > > > There is one issue I'm not sure about. The user might feel pressured to 
check something if the symbol is stroked as it fells like "something is wrong". 
In that case I would suggest just using the ON version and make it 50% 
transparent in OFF mode.
  > >
  > >
  > > I agree, it isn't  even an caps-lock-off key. A 50% tranparent icon would 
fit better
  >
  >
  > This can be done in the system tray widget instead of making a separate 
icon for off. Ever notice how the notifications icon is grey when it's not 
active?
  
  
  Sorry, I don't understand, never had noticed anything special with the 
notifications.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#437726 , @ndavis wrote:
  
  > In D19952#437670 , @arvidhansson 
wrote:
  >
  > > In D19952#437419 , @ndavis 
wrote:
  > >
  > > > This can be done in the system tray widget instead of making a separate 
icon for off. Ever notice how the notifications icon is grey when it's not 
active?
  > >
  > >
  > > Sorry, I don't understand, never had noticed anything special with the 
notifications.
  >
  >
  > Top icon is for notifications (partly transparent), bottom icon is for 
Redshift (100% opacity)
  >  F6718240: Screenshot_20190324_184101.png 

  >
  > In D19952#437664 , @arvidhansson 
wrote:
  >
  > > [...] is it just me or is the transparent icon more like grey?
  >
  >
  > It's not just you, but that's how partly transparent black on a white 
background is supposed to look.
  
  
  Okay, I get it, what should we do now?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#438310 , @ndavis wrote:
  
  > In D19952#438130 , @arvidhansson 
wrote:
  >
  > > In D19952#437726 , @ndavis 
wrote:
  > >
  > > > In D19952#437670 , 
@arvidhansson wrote:
  > > >
  > > > > In D19952#437419 , @ndavis 
wrote:
  > > > >
  > > > > > This can be done in the system tray widget instead of making a 
separate icon for off. Ever notice how the notifications icon is grey when it's 
not active?
  > > > >
  > > > >
  > > > > Sorry, I don't understand, never had noticed anything special with 
the notifications.
  > > >
  > > >
  > > > Top icon is for notifications (partly transparent), bottom icon is for 
Redshift (100% opacity)
  > > >  F6718240: Screenshot_20190324_184101.png 

  > > >
  > > > In D19952#437664 , 
@arvidhansson wrote:
  > > >
  > > > > [...] is it just me or is the transparent icon more like grey?
  > > >
  > > >
  > > > It's not just you, but that's how partly transparent black on a white 
background is supposed to look.
  > >
  > >
  > > Okay, I get it, what should we do now?
  >
  >
  > We only make `input-numlock-on`, no off version
  
  
  Yeah, but which icon should we use? T-ask's icon maybe?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#438965 , @ndavis wrote:
  
  > The rounded corners and bold 1 are not very breeze like, so I don't think 
so, unless he changes his design. Unless you still plan to do the icon 
yourself, you should probably hand off responsibility for the patch to someone 
else.
  
  
  Sorry for the confusion, as I'm new to this I really need help and aren't 
able to do this alone, just just wanted to bring some attention to this and 
learn how to work with KDE. Thanks for all help, should we now use t-ask's 
first icon(the right one) or something else?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#439120 , @ndavis wrote:
  
  > In D19952#439031 , @arvidhansson 
wrote:
  >
  > > In D19952#438965 , @ndavis 
wrote:
  > >
  > > > The rounded corners and bold 1 are not very breeze like, so I don't 
think so, unless he changes his design. Unless you still plan to do the icon 
yourself, you should probably hand off responsibility for the patch to someone 
else.
  > >
  > >
  > > Sorry for the confusion, as I'm new to this I really need help and aren't 
able to do this alone, just just wanted to bring some attention to this and 
learn how to work with KDE. Thanks for all help, should we now use t-ask's 
first icon(the right one) or something else?
  >
  >
  > No problem, it's just unfortunate that you picked an issue where other 
people already had their own ideas planned. If there weren't more than 1 design 
to look at, it would be easier for me to work with you 1-on-1. Why don't you 
try making an icon for an app you like that doesn't already have an icon in 
Breeze Icons? Not Firefox, Thunderbird or proprietary software (although there 
might be some exceptions). If you have questions, bring them up in the VDG chat.
  
  
  Okay, I don't think I should work with this anymore, just wantet to fix this 
bug: https://bugs.kde.org/show_bug.cgi?id=391134. Please complete this yourself.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns