D18673: Add symlinks for flatpak
GeeXT created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GeeXT requested review of this revision. REVISION SUMMARY This patch creates symlinks (for every application I've found on Flathub and for which Breeze icon theme has an icon) to let flatpak-provided .desktop files point to breeze-provided icons. Flatpak-exported .desktop files use different icon names (e. g. org.kde.okular instead of just okular) and because of that flatpak-provided .desktop files show in menus and panels with their default icons instead of breeze-provided icons even when Breeze icon theme is used. TEST PLAN This can be tested by applying the patch and installing the icon theme into ~/.local/share/icons. Reboot/relogin may be necessary. Then to see the changes you can install org.gimp.GIMP from flathub. Without the patch GIMP uses its default icon in application menus/panels/docks/etc. With the patch it will use the breeze-provided icon. REPOSITORY R266 Breeze Icons BRANCH flatpak-symlinks (branched from master) REVISION DETAIL https://phabricator.kde.org/D18673 AFFECTED FILES icons-dark/apps/16/com.github.bajoja.indicator-kdeconnect.svg icons-dark/apps/22/com.github.bajoja.indicator-kdeconnect.svg icons-dark/apps/22/org.kde.elisa.svg icons-dark/apps/22/org.videolan.VLC.svg icons-dark/apps/32/org.videolan.VLC.svg icons-dark/apps/48/com.elsevier.MendeleyDesktop.svg icons-dark/apps/48/com.google.AndroidStudio.svg icons-dark/apps/48/com.sublimetext.three.svg icons-dark/apps/48/com.syntevo.SmartGit.svg icons-dark/apps/48/com.valvesoftware.Steam.svg icons-dark/apps/48/com.viber.Viber.svg icons-dark/apps/48/cx.ring.Ring.svg icons-dark/apps/48/fr.free.Homebank.svg icons-dark/apps/48/fr.handbrake.ghb.svg icons-dark/apps/48/io.atom.Atom.svg icons-dark/apps/48/io.brackets.Brackets.svg icons-dark/apps/48/io.github.Fontforge.svg icons-dark/apps/48/net.scribus.Scribus.svg icons-dark/apps/48/nl.openoffice.bluefish.svg icons-dark/apps/48/org.audacityteam.Audacity.svg icons-dark/apps/48/org.blender.Blender.svg icons-dark/apps/48/org.clementine_player.Clementine.svg icons-dark/apps/48/org.codeblocks.codeblocks.svg icons-dark/apps/48/org.darktable.Darktable.svg icons-dark/apps/48/org.filezillaproject.Filezilla.svg icons-dark/apps/48/org.gimp.GIMP.svg icons-dark/apps/48/org.gnu.emacs.svg icons-dark/apps/48/org.inkscape.Inkscape.svg icons-dark/apps/48/org.kde.elisa.svg icons-dark/apps/48/org.kde.kapman.svg icons-dark/apps/48/org.kde.katomic.svg icons-dark/apps/48/org.kde.kblocks.svg icons-dark/apps/48/org.kde.kdenlive.svg icons-dark/apps/48/org.kde.kdiamond.svg icons-dark/apps/48/org.kde.kjumpingcube.svg icons-dark/apps/48/org.kde.klines.svg icons-dark/apps/48/org.kde.kolourpaint.svg icons-dark/apps/48/org.kde.kontact.svg icons-dark/apps/48/org.kde.okular.svg icons-dark/apps/48/org.kde.skrooge.svg icons-dark/apps/48/org.libreoffice.LibreOffice-base.svg icons-dark/apps/48/org.libreoffice.LibreOffice-calc.svg icons-dark/apps/48/org.libreoffice.LibreOffice-draw.svg icons-dark/apps/48/org.libreoffice.LibreOffice-impress.svg icons-dark/apps/48/org.libreoffice.LibreOffice-main.svg icons-dark/apps/48/org.libreoffice.LibreOffice-math.svg icons-dark/apps/48/org.libreoffice.LibreOffice-startcenter.svg icons-dark/apps/48/org.libreoffice.LibreOffice-writer.svg icons-dark/apps/48/org.octave.Octave.svg icons-dark/apps/48/org.qbittorrent.qBittorrent.svg icons-dark/apps/48/org.qownnotes.QOwnNotes.svg icons-dark/apps/48/org.quassel_irc.QuasselClient.svg icons-dark/apps/48/org.synfig.SynfigStudio.svg icons-dark/apps/48/org.telegram.desktop.svg icons-dark/apps/48/org.tordini.flavio.Minitube.svg icons-dark/apps/48/org.videolan.VLC.svg icons/apps/16/com.github.bajoja.indicator-kdeconnect.svg icons/apps/22/com.github.bajoja.indicator-kdeconnect.svg icons/apps/22/org.kde.elisa.svg icons/apps/22/org.videolan.VLC.svg icons/apps/32/org.videolan.VLC.svg icons/apps/48/com.elsevier.MendeleyDesktop.svg icons/apps/48/com.google.AndroidStudio.svg icons/apps/48/com.sublimetext.three.svg icons/apps/48/com.syntevo.SmartGit.svg icons/apps/48/com.valvesoftware.Steam.svg icons/apps/48/com.viber.Viber.svg icons/apps/48/cx.ring.Ring.svg icons/apps/48/fr.free.Homebank.svg icons/apps/48/fr.handbrake.ghb.svg icons/apps/48/io.atom.Atom.svg icons/apps/48/io.brackets.Brackets.svg icons/apps/48/io.github.Fontforge.svg icons/apps/48/net.scribus.Scribus.svg icons/apps/48/nl.openoffice.bluefish.svg icons/apps/48/org.audacityteam.Audacity.svg icons/apps/48/org.blender.Blender.svg icons/apps/48/org.clementine_player.Clementine.svg icons/apps/48/org.codeblocks.codeblocks.svg icons/apps/48/org.darktable.Darktable.svg icons/apps/48/org.filezillaproject.Filezilla.svg icons/apps/48/org.gimp.GIMP.svg icons/apps/48/org.gnu.emacs.svg icons/apps/48/
D18762: Add support for portals in KRun
GeeXT created this revision. GeeXT added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GeeXT requested review of this revision. REVISION SUMMARY Currently KRun in Flatpak/Snap doesn't support portals so it can't launch an application for a given url (because it can't break through sandbox). This patch allows KRun to use portals to pass the url through sandbox. QDesktopServices::openUrl handles that case and sends appropriate DBus calls to portals, so URIs will be proccessed accordingly by host system. FEATURE: 399380 TEST PLAN I couldn't build KIO from master in current flatpak KDE runtime (even without the patch), so here are commands to test the patch on top of KIO 5.54.1: 1. Install org.kde.Sdk 5.12 from flathub 2. Install org.kde.konversation from KDE Nightly flatpak repo (https://community.kde.org/Guidelines_and_HOWTOs/Flatpak) 3. Apply the patch to KIO 5.54.1 4. run 'flatpak run --filesystem=host --command=sh --devel org.kde.Sdk//5.12' to enter SDK 5. build KIO 6. exit SDK (exit or Ctrl+D) 7. run flatpak shell with Konversation 'flatpak run --filesystem=host --command=sh org.kde.konversation' 8. run LD_PRELOAD="path/to/libKF5KIOCore.so path/top/libKF5KIOWidgets.so path/to/libKF5KIOFileWidgets.so" /app/bin/konversation to run it with just compiled KIO (the compiled libraries are located in bin directory inside your build directory) Now link clicks should pass sandbox and do the appropriate actions (open browser for http links, email application for mailto links, file manager for file://...) REPOSITORY R241 KIO BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 AFFECTED FILES src/widgets/krun.cpp To: GeeXT, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18762: Add support for portals in KRun
GeeXT updated this revision to Diff 50972. GeeXT added a comment. Restored the accidentally deleted empty line... REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=50968&id=50972 BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 AFFECTED FILES src/widgets/krun.cpp To: GeeXT, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18762: Add support for portals in KRun
GeeXT updated this revision to Diff 51017. GeeXT added a comment. The result should be negated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=50972&id=51017 BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 AFFECTED FILES src/widgets/krun.cpp To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18762: Add support for portals in KRun
GeeXT updated this revision to Diff 51047. GeeXT added a comment. Add check for external browser enablement status REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=51017&id=51047 BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 AFFECTED FILES src/widgets/krun.cpp src/widgets/krun_p.h To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18762: Add support for portals in KRun
GeeXT added a comment. Ping? Btw, I couldn't find any usages of setEnableExternalBrowser in BrowserRun or KonqRun but there is an usage after instantiating an object of KonqRun (in KonqMainWindow::openUrl). It's strange that a caller must call the function itself or it will crash... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18673: Add symlinks for flatpak
GeeXT added a reviewer: Frameworks. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18673 To: GeeXT, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18762: Add support for portals in KRun
GeeXT marked an inline comment as done. REPOSITORY R241 KIO BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18762: Add support for portals in KRun
GeeXT updated this revision to Diff 52163. GeeXT added a comment. Swap the conditions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=51047&id=52163 BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 AFFECTED FILES src/widgets/krun.cpp src/widgets/krun_p.h To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18762: Add support for portals in KRun
GeeXT added a comment. @apol I didn't applied for KDE Developer Account yet (I'm new here) so I can't, sorry. REPOSITORY R241 KIO BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
