D27195: Change "Redisplay" to "Refresh"

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27195#606954 , @ngraham wrote:
  
  > "Reload" could also work, as that's also a very common and recognizable 
term.
  
  
  That is a good point but if you call it "Reload" you might as well proceed to 
also replace every instance of "Refresh" in Plasma and KApps with "Reload" for 
consistency.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  redisplay-to-refresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27195

To: ngraham, #vdg, The-Feren-OS-Dev, ndavis
Cc: kde-frameworks-devel, The-Feren-OS-Dev, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27195: Change "Redisplay" to "Refresh"

[Dominic Hayes]

The-Feren-OS-Dev accepted this revision.
The-Feren-OS-Dev added a comment.
This revision is now accepted and ready to land.


  This is something I've recently suggested myself, so having this happen would 
be a small change but still a good change.
  
  Furthermore this'll make it consistent with Plasma's Folder View's 
terminology for "Refresh Desktop".

REPOSITORY
  R265 KConfigWidgets

BRANCH
  redisplay-to-refresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27195

To: ngraham, #vdg, The-Feren-OS-Dev
Cc: kde-frameworks-devel, The-Feren-OS-Dev, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25015: Update breeze theme shadows

[Dominic Hayes]

The-Feren-OS-Dev accepted this revision.
The-Feren-OS-Dev added a comment.


  I feel like the shadows might be slightly overcompensating in shadow strength 
for the small shadow span (it looks kinda weird on first glance), but apart 
from that minor nitpick, I'd say this is good to go.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham, The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin, ngraham, 
filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D26555#591657 , @ngraham wrote:
  
  > Looks like this needs a bit of CMake work to stop installing the old icons:
  >
  >   # from directory: /home/nate/kde/build/plasma-framework
  >   gmake[2]: *** No rule to make target 
'/home/nate/kde/src/plasma-framework/src/desktoptheme/air/icons/nepomuk.svg', 
needed by 'src/desktoptheme/oxygen/oxygen.gzipped/icons/nepomuk.svgz'.  Stop.
  >   gmake[1]: *** [CMakeFiles/Makefile2:880: 
src/desktoptheme/oxygen/CMakeFiles/oxygen_desktoptheme_graphics_icons.dir/all] 
Error 2
  >
  >
  > Probably need to add the new ones too.
  
  
  Hmm, can't seem to find any mentions of 'nepomuk' anywhere...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  @bruns @ngraham What do you two think about using the find icon as the search 
icon, given IIRC we used the find icon for search in Dolphin in the 
Oxygen-era/KDE4-era?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  There we go. Noticed there was a slight imperfection with the icon alignment 
in the previous edit so fixed that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 73235.
The-Feren-OS-Dev added a comment.


  Rename 'nepomuk' Plasma Theme icons to 'search' and redesign Oxygen/Air 
'search' icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26555?vs=73233=73235

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

AFFECTED FILES
  src/desktoptheme/air/icons/nepomuk.svg
  src/desktoptheme/air/icons/search.svg
  src/desktoptheme/breeze/icons/nepomuk.svg
  src/desktoptheme/breeze/icons/search.svg

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 73233.
The-Feren-OS-Dev added a comment.


  Rename 'nepomuk' Plasma Theme icons to 'search'

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26555?vs=73230=73233

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

AFFECTED FILES
  src/desktoptheme/air/icons/nepomuk.svg
  src/desktoptheme/air/icons/search.svg
  src/desktoptheme/breeze/icons/nepomuk.svg
  src/desktoptheme/breeze/icons/search.svg

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  *sigh* It seems scour-icon decided to nuke the layer names that made the 
icons identifiable, working on fixing that now.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  ^ that was just me scour-icon'ing the SVG file as I forgot to initially.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 73230.
The-Feren-OS-Dev added a comment.


  Rename 'nepomuk' Plasma Theme icons to 'search' and restyle Oxygen/Air Search 
Icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26555?vs=73229=73230

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

AFFECTED FILES
  src/desktoptheme/air/icons/nepomuk.svg
  src/desktoptheme/air/icons/search.svg
  src/desktoptheme/breeze/icons/nepomuk.svg
  src/desktoptheme/breeze/icons/search.svg

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 73229.
The-Feren-OS-Dev added a comment.


  Rename 'nepomuk' Plasma Theme icons to 'search' and restyle Oxygen/Air's icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26555?vs=73225=73229

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

AFFECTED FILES
  src/desktoptheme/air/icons/nepomuk.svg
  src/desktoptheme/air/icons/search.svg
  src/desktoptheme/breeze/icons/nepomuk.svg
  src/desktoptheme/breeze/icons/search.svg

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Hmph... Oxygen has a low-quality 'search' icon. I'll update the diff again in 
a bit to add a higher quality version of the icon in SVG form if I can find a 
higher quality SVG of the icon from Oxygen.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 73225.
The-Feren-OS-Dev added a comment.


  Rename 'nepomuk' Plasma Theme icons to 'search'

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26555?vs=73161=73225

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

AFFECTED FILES
  src/desktoptheme/air/icons/nepomuk.svg
  src/desktoptheme/breeze/icons/nepomuk.svg
  src/desktoptheme/breeze/icons/search.svg

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Alright, I'll look into having a replacement icon for Oxygen/Air.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham
Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  If anyone has any issues with removing the 'nepomuk' icon theming, please be 
sure to let me know so I can add them back in again on this patch to be 
alongside the 'search' theming to sort that issue out.
  
  It appears that no 1st-party Plasmoids I can see in Plasma have the nepomuk 
icon now, so the only potential issue I can currently see is the loss of 
theming for 3rd-party Search Plasmoids.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg, ndavis
Cc: ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma, #vdg
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev, #plasma
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D26555#591132 , @davidre wrote:
  
  > In D26555#591131 , 
@The-Feren-OS-Dev wrote:
  >
  > > In D26555#591126 , @davidre 
wrote:
  > >
  > > > I still think the proper fix was to investigate why the widget explorer 
didn't show an icon instead of randomly changing the icon it uses which can 
have potential impact on other themes
  > >
  > >
  > > This is a fix to it happening in real-time in Plasmashell me making this 
patch is not related to a potential issue with Widget Explorer. However, I 
could easily edit this patch to retain the nepomuk icons alongside the renamed 
ones if needed.
  >
  >
  > But if I understood it right this patch is a reaction to an issue caused by 
changing the icon which was caused by the widget explorer issue?
  
  
  I honestly haven't heard about the potential Widget Factory issue side of it, 
but this patch was definitely made because the Milou Plasmoid changed its icon 
from 'nepomuk' to 'search'.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D26555#591126 , @davidre wrote:
  
  > I still think the proper fix was to investigate why the widget explorer 
didn't show an icon instead of randomly changing the icon it uses which can 
have potential impact on other themes
  
  
  This is a fix to it happening in real-time in Plasmashell me making this 
patch is not related to a potential issue with Widget Explorer. However, I 
could easily edit this patch to retain the nepomuk icons alongside the renamed 
ones if needed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev
Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev retitled this revision from "Rename nepomuk Plasma Theme icons 
to 'search'" to "Rename 'nepomuk' Plasma Theme icons to 'search'".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26555

To: The-Feren-OS-Dev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename nepomuk Plasma Theme icons to 'search'

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
The-Feren-OS-Dev requested review of this revision.

REVISION SUMMARY
  BUG: 416072
  
  Since the Milou/Search applet changed its icon from 'nepomuk' to 'search', 
the Breeze and Air/Oxygen Plasma Themes no longer theme that Plasmoid icon. 
This patch fixes that by renaming the themed icons to theme the Milou Plasmoid 
once more.

TEST PLAN
  1. Apply one of the Plasma Theme affected by this patch once patched
  
  2. Use a non-Breeze icon set that would make the 'search' icon pop-out 
style-wise
  
  3. Add the Milou/Search Plasmoid to a panel if not already added
  
  4. It should now use the Plasma Themed icon instead of the icon set's icon 
for 'search' on that Plasmoid

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26555

AFFECTED FILES
  src/desktoptheme/air/icons/nepomuk.svg
  src/desktoptheme/air/icons/search.svg
  src/desktoptheme/breeze/icons/nepomuk.svg
  src/desktoptheme/breeze/icons/search.svg

To: The-Feren-OS-Dev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns