D25443: [chmodjob] Port away from QLinkedList

[Fabian Kosmale]

fabiank added a comment.


  While the change should be fine as is, that sounds like a job for std::deque, 
as we don't need insertions/removals at random positions. Or even for a 
std::queue, because we only operate on the front.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks
Cc: fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

[Fabian Kosmale]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:49f871844632: Check if group < LastGroup, as 
KIconEffect doesn't handle UserGroup anyway (authored by fabiank).
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12002?vs=31533&id=34305

REVISION DETAIL
  https://phabricator.kde.org/D12002

AFFECTED FILES
  src/kiconloader.cpp

To: fabiank, mart, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D11998: Ensure that the model is set when resetResizing is called

[Fabian Kosmale]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bff960d67162: Ensure that the model is set when 
resetResizing is called (authored by fabiank).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11998?vs=31525&id=31578

REVISION DETAIL
  https://phabricator.kde.org/D11998

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: fabiank, dfaure, ngraham, apol
Cc: apol, ngraham, #frameworks, michaelh, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

[Fabian Kosmale]

fabiank added a comment.


  I'm to tired to test this myself, but could you please test this with the 
edge case where some file names are so long that they don't fit in the view? 
Also, Stretch disables manual resizing, right?' If that is also deemed useful, 
we could adapt the solution from 
https://centaurialpha.github.io/resize-qheaderview-to-contents-and-interactive. 
That's pyqt, but the same idea applies to C++. The resize event handling code 
is even already there, just needs to be adjusted.

REPOSITORY
  R241 KIO

BRANCH
  column-widths (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11993

To: sharvey, ngraham, dfaure
Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

[Fabian Kosmale]

fabiank added reviewers: mart, dfaure, mlaurent.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D12002

To: fabiank, mart, dfaure, mlaurent
Cc: #frameworks, michaelh, ngraham, bruns

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

[Fabian Kosmale]

fabiank created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
fabiank requested review of this revision.

TEST PLAN
  Run the steps described in the testplan of D12001 
. Without the patch, the
  warning "Illegal icon group: 7" gets displayed, as Okular uses User icons.
  Applying the patch fixes this; unit tests still run without failure.

REPOSITORY
  R302 KIconThemes

BRANCH
  fixWarning

REVISION DETAIL
  https://phabricator.kde.org/D12002

AFFECTED FILES
  src/kiconloader.cpp

To: fabiank
Cc: #frameworks, michaelh, ngraham, bruns

D11998: Ensure that the model is set when resetResizing is called

[Fabian Kosmale]

fabiank added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11998

To: fabiank, dfaure
Cc: #frameworks, michaelh, ngraham, bruns

D11998: Ensure that the model is set when resetResizing is called

[Fabian Kosmale]

fabiank created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
fabiank requested review of this revision.

REVISION SUMMARY
  Previously, KDirOperatorDetailView::setModel called resetResizing before
  QTreeView::setModel was called. Thus, when resetResizing called model()
  to obtain the model, it was still nullptr, leading to the following
  warning: "QObject::connect: invalid null parameter"
  
  As nothing we do in KDirOperatorDetailView::setModel depends on the
  model not being set yet, we simply move the call to
  KDirOperatorDetailView::setModel to the beginning of the method, to
  ensure that model() returns the new model

TEST PLAN
  Run any application which uses the KDE file dialog. Start opening a file, then
  switch the file dialog to the detailed or detailed tree mode. Without the 
patch,
  the warning should appear. Applying the patch removes the warning.

REPOSITORY
  R241 KIO

BRANCH
  fixConnectWarning

REVISION DETAIL
  https://phabricator.kde.org/D11998

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: fabiank
Cc: #frameworks, michaelh, ngraham, bruns

D11768: Add Desktop and Downloads to the default list of Places

[Fabian Kosmale]

fabiank added a comment.


  In D11768#236349 , @ngraham wrote:
  
  > In Neon and Kubuntu, ~/Desktop exists for a new user by default. Is this 
not the case in other distros?
  
  
  I'm not sure what is currently done, but I'm pretty sure in Chakra we used to 
create localized versions (and I think even Ubuntu did that), so instead of 
~/Desktop,  a German user would have ~/Schreibtisch. There's actually an xdg 
standard for this, https://www.freedesktop.org/wiki/Software/xdg-user-dirs. 
Afaik, Qt supports this with QStandardPaths, e.g. 
QStandardPaths::DesktopLocation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: fabiank, progwolff, broulik, michaelh, ngraham

D10927: Apply fixes to simple clazy warnings

[Fabian Kosmale]

This revision was automatically updated to reflect the committed changes.
Closed by commit R284:29e7a1d89278: Apply fixes to simple clazy warnings 
(authored by fabiank).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10927?vs=28288&id=28597

REVISION DETAIL
  https://phabricator.kde.org/D10927

AFFECTED FILES
  src/kcompletion_p.h
  src/khistorycombobox.cpp

To: fabiank, dfaure
Cc: #frameworks, michaelh

D10927: Apply fixes to simple clazy warnings

[Fabian Kosmale]

fabiank added a reviewer: dfaure.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D10927

To: fabiank, dfaure
Cc: #frameworks, michaelh

D10927: Apply fixes to simple clazy warnings

[Fabian Kosmale]

fabiank retitled this revision from "Use const methods to prevent container 
from detaching

KHistoryComboBox: reserve list before populating it" to "Apply fixes to simple 
clazy warnings".
fabiank edited the summary of this revision.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D10927

To: fabiank
Cc: #frameworks, michaelh

D10927: Use const methods to prevent container from detachingKHistoryComboBox: reserve list before populating it

[Fabian Kosmale]

fabiank created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
fabiank requested review of this revision.

REVISION SUMMARY
  Apply fixes to simple clazy warnings

REPOSITORY
  R284 KCompletion

BRANCH
  clazyfixes

REVISION DETAIL
  https://phabricator.kde.org/D10927

AFFECTED FILES
  src/kcompletion_p.h
  src/khistorycombobox.cpp

To: fabiank
Cc: #frameworks, michaelh