D22609: Add expanding spacers as a customization option for toolbars

[Felix Ernst]

felixernst added a comment.


  I kept the names lowercase because I like the visible difference between 
lowercase separator/spacer and title case actions. I don't mind changing the 
names to title case though. Judge for yourself:
  F7109858: Screenshot_20190728_185837.png 

  
  F7109860: Screenshot_20190728_191058.png 


REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add expanding spacers as a customization option for toolbars

[Felix Ernst]

felixernst updated this revision to Diff 62687.
felixernst marked an inline comment as done.
felixernst added a comment.


  Rename to "expanding spacer", Cast to QToolBar instead
  
  Remove unrelated comments and documentation

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22609?vs=62188&id=62687

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

AFFECTED FILES
  src/kedittoolbar.cpp
  src/kxmlgui.xsd
  src/kxmlguibuilder.cpp

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add expanding spacers as a customization option for toolbars

[Felix Ernst]

felixernst retitled this revision from "Add spacers as a customization option 
for toolbars" to "Add expanding spacers as a customization option for toolbars".

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst added a comment.


  You all are too kind!
  
  > Code looks fine.
  
  First try \o/
  
  I'll put the comments that aren't directly related into another revision.
  I'll rename it to "--- expanding spacer ---" then. So I'll keep it lowercase 
and in the same style as "--- seperator ---" if nobody has a better idea.
  
  > fixed-width spacer
  
  I don't really understand their benefit yet because I can't imagine a 
scenario where I would want one that wouldn't better be solved with an 
expanding one. So to me it seems like it is a widget we don't want to have so 
users don't pick the spacer that is worse in 95 % of cases out of lack of 
knowledge.
  I can be convinced to add a fixed-width one though if I see an example where 
we would want them. We would have to decide what size a fixed-width spacer has.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst edited the summary of this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst updated this revision to Diff 62188.
felixernst added a comment.


  Use insertWidget(before, spacer) instead of addWidget(spacer)

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22609?vs=62185&id=62188

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

AFFECTED FILES
  src/kedittoolbar.cpp
  src/kedittoolbar.h
  src/kxmlgui.xsd
  src/kxmlguibuilder.cpp

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst planned changes to this revision.
felixernst added a comment.


  Need to fix wrong return type in KXMLGUIBuilder::createCustomElement

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst edited the summary of this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
felixernst requested review of this revision.

REVISION SUMMARY
  This commit adds spacers to the kxmlgui framework so all applications
  using it will be able to use any amount of spacers in their toolbar(s).
  
  KEditToolbar gets the --- spacer --- entry by default. This entry is
  modified to allow any amount of spacers to be put into the toolbars
  (just like separators).
  The xml scheme is changed to allow "" nodes
  (just like separators).
  KXmlGuiBuilder then builds the simple spacer by itself.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

AFFECTED FILES
  src/kedittoolbar.cpp
  src/kedittoolbar.h
  src/kxmlgui.xsd
  src/kxmlguibuilder.cpp

To: felixernst
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns