D24003: kwaylandScanner produce version enum per class
gladhorn marked an inline comment as done. gladhorn added inline comments. INLINE COMMENTS > zzag wrote in generator.cpp:431 > Is it correct thogugh? Can you provide some test input so it's easier to see > the problem? run kwaylandScanner on /usr/share/wayland-protocols/unstable/primary-selection/primary-selection-unstable-v1.xml and see that it produces something that doesn't compile. With this change it compiles. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24003 To: gladhorn, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24004: Teach kwaylandscanner about PrimarySelection
gladhorn added subscribers: zzag, romangg, davidedmundson. gladhorn added a comment. @romangg and @davidedmundson any comments? I think @zzag prefers the class names without the V1. I'd like to progress on this step by step and the generator at least gives a good starting point. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24004 To: gladhorn, #kwin Cc: davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24002: Sort files alphabetically in cmake list
This revision was automatically updated to reflect the committed changes. Closed by commit R127:6c8f110f3a22: Sort files alphabetically in cmake list (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24002?vs=66278=66279 REVISION DETAIL https://phabricator.kde.org/D24002 AFFECTED FILES src/server/CMakeLists.txt To: gladhorn, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24003: kwaylandScanner produce version enum per class
gladhorn added a comment. The unstable primary selection v1 protocol produces code that doesn't compile, after this change it does compile - since it expects the version enums for three classes, but only the first one is actually written into the file. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24003 To: gladhorn, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24002: Sort files alphabetically in cmake list
gladhorn updated this revision to Diff 66278. gladhorn added a comment. Actually sort all files REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24002?vs=66254=66278 BRANCH arcpatch-D24002 REVISION DETAIL https://phabricator.kde.org/D24002 AFFECTED FILES src/server/CMakeLists.txt To: gladhorn, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24004: Teach kwaylandscanner about PrimarySelection
gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY This allows generating the skeleton classes for the primary selection protocol. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D24004 AFFECTED FILES src/tools/mapping.txt To: gladhorn, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24003: kwaylandScanner produce version enum per class
gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Otherwise it only creates the enum for the first class encountered. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D24003 AFFECTED FILES src/tools/generator.cpp To: gladhorn, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24002: Sort files alphabetically in cmake list
gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Adding further files is confusing, since the list is almost alphabetical. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D24002 AFFECTED FILES src/server/CMakeLists.txt To: gladhorn, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23915: Improve documentation
This revision was automatically updated to reflect the committed changes. Closed by commit R127:6388d550e3a2: Improve documentation (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23915?vs=66078=66150 REVISION DETAIL https://phabricator.kde.org/D23915 AFFECTED FILES src/client/datadevice.h src/client/dpms.h src/server/datadevice_interface.h src/server/dpms_interface.h To: gladhorn, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23586: Improve code that detects useful elements in an Svg file
gladhorn added inline comments.
INLINE COMMENTS
> svg.cpp:103
> while (!reader.atEnd()) {
> -if (reader.readNext() == QXmlStreamReader::StartElement &&
> +const auto t = reader.readNext();
> +if (t == QXmlStreamReader::StartElement) {
Maybe use "element" instead of "t" as variable name?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D23586
To: apol, #plasma, #frameworks
Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23915: Improve documentation
gladhorn updated this revision to Diff 66078. gladhorn retitled this revision from "Improve documentation Some of the documentation did not say what the purpose of the respective class was, but rather gave a tautology. For people new to the code base it helps to mention that DPMS is power management. That DataDevice is for copy..." to "Improve documentation". gladhorn edited the summary of this revision. gladhorn added a comment. Thank you arc for messing up my commit message XD REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23915?vs=66026=66078 BRANCH arcpatch-D23915_1 REVISION DETAIL https://phabricator.kde.org/D23915 AFFECTED FILES src/client/datadevice.h src/client/dpms.h src/server/datadevice_interface.h src/server/dpms_interface.h To: gladhorn, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23917: Use const_iterator
This revision was automatically updated to reflect the committed changes. Closed by commit R127:28841048d555: Use const_iterator (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=66021=66027 REVISION DETAIL https://phabricator.kde.org/D23917 AFFECTED FILES src/client/plasmawindowmanagement.cpp src/client/registry.cpp src/server/keyboard_interface.cpp src/server/output_interface.cpp src/server/outputdevice_interface.cpp src/server/seat_interface.cpp tests/pasteclient.cpp To: gladhorn, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS
gladhorn added inline comments. INLINE COMMENTS > romangg wrote in dpms.h:44 > Yea, maybe just write that this class is meant to create the DPMS object > below only. You already have the information you provided here there then. I agree. The first two lines are actually repetitions and they don't say what the class is good for at all. I'll update this. REPOSITORY R127 KWayland BRANCH arcpatch-D23915 REVISION DETAIL https://phabricator.kde.org/D23915 To: gladhorn, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS
gladhorn updated this revision to Diff 66026. gladhorn retitled this revision from "Add some docstrings" to "Improve documentation Some of the documentation did not say what the purpose of the respective class was, but rather gave a tautology. For people new to the code base it helps to mention that DPMS is power management. That DataDevice is for copy...". gladhorn edited the summary of this revision. gladhorn added a comment. Updating D23915: Improve documentation == Some of the documentation did not say what the purpose of the respective class was, but rather gave a tautology. For people new to the code base it helps to mention that DPMS is power management. That DataDevice is for copy... REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23915?vs=65941=66026 BRANCH arcpatch-D23915 REVISION DETAIL https://phabricator.kde.org/D23915 AFFECTED FILES src/client/datadevice.h src/client/dpms.h src/server/datadevice_interface.h src/server/dpms_interface.h To: gladhorn, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23917: Use const_iterator
gladhorn updated this revision to Diff 66021. gladhorn edited the summary of this revision. gladhorn removed subscribers: broulik, zzag. gladhorn added a comment. Fixed two missing spots REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65946=66021 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 AFFECTED FILES src/client/plasmawindowmanagement.cpp src/client/registry.cpp src/server/keyboard_interface.cpp src/server/output_interface.cpp src/server/outputdevice_interface.cpp src/server/seat_interface.cpp tests/pasteclient.cpp To: gladhorn, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, broulik, zzag
D23917: Use const_iterator
gladhorn added a comment. Yes, for me always using constBegin/constEnd makes reading the code slightly easier. INLINE COMMENTS > zzag wrote in registry.cpp:879 > constEnd Thanks! > zzag wrote in output_interface.cpp:119 > constEnd Thanks! REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23917 To: gladhorn, #kwin Cc: broulik, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23917: Use const_iterator
gladhorn updated this revision to Diff 65946. gladhorn added a comment. fixup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65945=65946 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 AFFECTED FILES src/client/plasmawindowmanagement.cpp src/client/registry.cpp src/server/keyboard_interface.cpp src/server/output_interface.cpp src/server/outputdevice_interface.cpp src/server/seat_interface.cpp tests/pasteclient.cpp To: gladhorn, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23917: Use const_iterator
gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When trivial, replace iterators with the const versrion. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 AFFECTED FILES src/client/plasmawindowmanagement.cpp src/client/registry.cpp src/server/keyboard_interface.cpp src/server/output_interface.cpp src/server/outputdevice_interface.cpp src/server/seat_interface.cpp tests/pasteclient.cpp To: gladhorn, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23916: Remove capture of this in lambda
This revision was automatically updated to reflect the committed changes. Closed by commit R127:858d9255f722: Remove capture of this in lambda (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23916?vs=65943=65944 REVISION DETAIL https://phabricator.kde.org/D23916 AFFECTED FILES src/server/outputdevice_interface.cpp src/server/seat_interface.cpp To: gladhorn, #kwin, zzag, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23916: Remove capture of this in lambda
gladhorn updated this revision to Diff 65943. gladhorn added a comment. Remove more lambda this captures REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23916?vs=65942=65943 BRANCH arcpatch-D23916 REVISION DETAIL https://phabricator.kde.org/D23916 AFFECTED FILES src/server/outputdevice_interface.cpp src/server/seat_interface.cpp To: gladhorn, #kwin, zzag, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23916: Remove capture of this in lambda
gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When this is not used, there is no point in capturing it. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23916 AFFECTED FILES src/server/seat_interface.cpp To: gladhorn, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23915: Add some docstrings
gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When first reading the KWayland code, some explanations help getting around. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23915 AFFECTED FILES src/client/datadevice.h src/client/dpms.h src/server/dpms_interface.h To: gladhorn, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D14240: Improve API docs a bit
This revision was automatically updated to reflect the committed changes. Closed by commit R296:9dd578b12d40: Improve API docs a bit (authored by gladhorn). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14240?vs=38116=38145 REVISION DETAIL https://phabricator.kde.org/D14240 AFFECTED FILES src/kdeclarative/qmlobject.h To: gladhorn, #plasma, dhaumann, apol Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14240: Improve API docs a bit
gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Some typos and make some sentences easier to read REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D14240 AFFECTED FILES src/kdeclarative/qmlobject.h To: gladhorn, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14118: Improve "Remove this [widget]" text
gladhorn accepted this revision.
gladhorn added a comment.
This revision is now accepted and ready to land.
I'd say make the casing consistent, otherwise it's a clear improvement in my
opinion.
INLINE COMMENTS
> containment.cpp:127
> if (closeApplet) {
> -closeApplet->setText(i18nc("%1 is the name of the applet", "Remove
> this %1", title()));
> +closeApplet->setText(i18nc("%1 is the name of the applet", "Remove
> this %1 widget", title()));
> }
The translation help says applet, is widget or applet the better word? But
actually the "add new" dialog in plasma says widget, so I'm for that for
consistency reasons.
> applet_p.cpp:124
> if (closeApplet) {
> -closeApplet->setText(i18nc("%1 is the name of the applet", "Remove
> this %1", q->title()));
> +closeApplet->setText(i18nc("%1 is the name of the applet", "Remove
> this %1 Widget", q->title()));
> }
This (Widget) is upper case (above it's lower case, which I prefer a tiny bit).
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
remove-this-widget (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D14118
To: ngraham, #plasma, #vdg, gladhorn
Cc: gladhorn, kde-frameworks-devel, michaelh, ngraham, bruns
D6877: Add Conan files
This revision was automatically updated to reflect the committed changes. Closed by commit R243:802d106c8e81: Add Conan files (authored by gladhorn). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17127=17153 REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py test_package/CMakeLists.txt test_package/conanfile.py test_package/example.cpp To: gladhorn, dfaure Cc: dfaure, apol, cfeck, #frameworks
D6877: Add Conan files
gladhorn updated this revision to Diff 17127. gladhorn marked an inline comment as done. gladhorn added a comment. fix url REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17126=17127 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py test_package/CMakeLists.txt test_package/conanfile.py test_package/example.cpp To: gladhorn Cc: apol, cfeck, #frameworks
D6877: Add Conan files
gladhorn marked 3 inline comments as done. gladhorn added inline comments. INLINE COMMENTS > apol wrote in conanfile.py:5 > Can we re-use the version from the `CMakeLists.txt`? The goal is to generate it. > apol wrote in conanfile.py:7 > Re-use from metainfo.yml? For now we consider this as a proof of concept. > apol wrote in conanfile.py:9 > I don't understand what this means :( building shared libs or static ones. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D6877 To: gladhorn Cc: apol, cfeck, #frameworks
D6877: Add Conan files
gladhorn updated this revision to Diff 17126. gladhorn added a comment. Updated according to comments REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17124=17126 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py test_package/CMakeLists.txt test_package/conanfile.py test_package/example.cpp To: gladhorn Cc: apol, cfeck, #frameworks
D6877: Add Conan files
gladhorn updated this revision to Diff 17124. gladhorn added a comment. remove -git from the version REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17118=17124 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py test_package/CMakeLists.txt test_package/conanfile.py test_package/example.cpp To: gladhorn Cc: apol, cfeck, #frameworks
D6877: Add Conan files
gladhorn updated this revision to Diff 17118. gladhorn added a comment. Fix license REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17116=17118 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py test_package/CMakeLists.txt test_package/conanfile.py test_package/example.cpp To: gladhorn Cc: apol, cfeck, #frameworks
D6877: Add Conan files
gladhorn updated this revision to Diff 17116. gladhorn added a comment. Remove private test stuff REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17115=17116 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py test_package/CMakeLists.txt test_package/conanfile.py test_package/example.cpp To: gladhorn Cc: apol, cfeck, #frameworks
D6877: Add Conan files
gladhorn created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Conan is a C++ package manager. This is an experiment to make KF5 frameworks available on Conan to make building KDE applications easier. See also https://conan.io/ . TODO: - detect version number automatically REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py test_package/CMakeLists.txt test_package/conanfile.py test_package/example.cpp To: gladhorn Cc: #frameworks
D6624: do not crash qaccessible by causing a resize in a resize event
gladhorn added a comment. Considering that the Qt bug will not be fixed in the next few days (I hope to get around to it, but it's involved), this makes sense. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To: sitter, gladhorn Cc: cfeck, anthonyfieroni, #frameworks
Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/#review77498 --- Without testing anything, I think that this will break QWidget's file dialog when set to modal. Iirc this breaks for example the open dialogs in qt creator. - Frederik Gladhorn On March 12, 2015, 1:19 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/ --- (Updated March 12, 2015, 1:19 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Bugs: 345002 https://bugs.kde.org/show_bug.cgi?id=345002 Repository: frameworkintegration Description --- Not sure it's the right approach, but right now, the FileDialog QtQuickControls will be broken in the kde interqation if set as modal, see https://bugs.kde.org/show_bug.cgi?id=345002 the commit 2ee76f0 makes show() not do anything in that case, and the FileDialog QML bindings seems to assume to call only show() Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 9ffb1d9 Diff: https://git.reviewboard.kde.org/r/122918/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/#review76006 --- src/notifybyktts.h https://git.reviewboard.kde.org/r/122555/#comment52450 I have no idea how this is used, should it be i18n'ed? And Text to Speech - Frederik Gladhorn On Feb. 13, 2015, 3:11 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/ --- (Updated Feb. 13, 2015, 3:11 a.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifications Description --- Add optional dependency on Qt5TextToSpeech for speech notifications. Diffs - CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 src/knotification.h c85621699793436442090b7f94ea82ef10c45b89 src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 src/kstatusnotifieritem.h 113dad513c320ef97f59b221b3541ca2f388693e src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 src/notifybyspeech.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122555/diff/ Testing --- As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
On Feb. 13, 2015, 11:49 a.m., Aleix Pol Gonzalez wrote: +1 What's the status of QtSpeech? Jeremy Whiting wrote: I'll blog about it shortly. I think QtSpeech is Qt 5.6 material realistically. It's usable on most platforms but needs cleanup and API review and a couple of features are not done on all platforms. - Frederik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 --- On Feb. 13, 2015, 7:42 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 13, 2015, 7:42 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
On Feb. 13, 2015, 12:17 p.m., Martin Klapetek wrote: src/knotifyconfigactionswidgetbase.ui, line 141 https://git.reviewboard.kde.org/r/122554/diff/1/?file=348626#file348626line141 Is Jovie still used in QtSpeech? If not, it should be removed from here I tend to agree to TTS or even better Text to Speech/Text-To-Speech. - Frederik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75987 --- On Feb. 13, 2015, 7:42 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 13, 2015, 7:42 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Fwd: [Development] Qt Contributors' Summit 2014 in Berlin 10-11th June
Hello, we will have a Qt Contributors' Summit again. The event is invite only, but I think many people on these lists qualify for the event. Especially if you have lately been submitting patches through gerrit or otherwise been involved with Qt developement consider joining. This is a great chance to influence many things in Qt directly with great discussions. Also a great start to getting deeper involved of course ;) See the forwarded mail for details. -- Best regards, Frederik Gladhorn Senior Software Engineer - Digia, Qt Visit us on: http://qt.digia.com ---BeginMessage--- Hello, Qt Contributors' Summit is coming! This year the summit will be organized in the Estrel Convention center in Berlin on 10-11th June. Please see the event wiki for details: http://qt-project.org/groups/qt-contributors-summit-2014/wiki Participation to the event is limited and based on merit in the Qt project. Priority is given to Maintainers and Approvers, but everyone who has contributed to the success of the project in any way can apply for an invitation. To request an invitation to the event, please use the following form: https://www.webropolsurveys.com/S/7CB14527039843C9.par Be sure to fill in why you should be invited. The request page will be open through April and after closing the form, we will send out invitations as soon as possible. Best regards, Tero Kojo Qt Online Community Manager, Digia QtCS 2014 event coordinator P.S. If your company would like to help make the event even better by sponsoring, see the wiki sponsoring page http://qt-project.org/groups/qt-contributors-summit-2014/wiki/Sponsorship and contact me (Tero Kojo) for details. ___ Development mailing list developm...@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ---End Message--- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KSpeech
Torsdag 6. mars 2014 20.34.05 skrev Christoph Feck: On Thursday 06 March 2014 17:13:19 Jeremy Whiting wrote: On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn gladh...@kde.org wrote: Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: 3. user configurability (As a user I can't set up which voice I would like all speech-using applications to use) As with other Qt libs, this is more for the platform to set up. Currently qtspeech uses whatever voice is selected system wide (aka the default). I think that is the right approach - follow what we get from the platform. For KDE I'd thus suggest creating a configuration module which lets the user choose the platform defaults. Yeah, each platform could have its own configuration of the defaults sure, the only part missing is a real-time configuration change. For example if Jovie is reduced to a kcm to configure speech-dispatcher's default voice and I start listening to a pdf from okular or something and decide I need the pitch to be lower, changing the default voice wont change the voice that speech-dispatcher is already using to read the pdf. Maybe that could be fixed with a patch to speech-dispatcher to accept immediate default changes though, I'll have to think about that. Let me refer to http://www.w3.org/TR/2011/WD-css3-speech-20110419/ which defines attributes a web page can use to influence speech. Would be nice if we had API supporting web speech. This is interesting in that different synths have already some sort of support for this. Regarding voice selection, it would be very useful to allow the application to specify female/male/child voice via API (in addition to the ability to let the user reconfigure actual voices). Similar to letting the application request Sans, Sans Serif, and Monospaced font. For example, when generating different voices while reading out e-book stories. Makes sense. I'd like to get an overview over the native APIs first. Let's collect their capabilities and then try to come up with a sensible compromise. Feel free to gather data here: http://qt-project.org/wiki/QtSpeech Cheers, Frederik Christoph Feck (kdepepo) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KSpeech
Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: Took a quick read through that just now and it looks pretty promising from what I saw. I guess I don't know my way around gerrit very well because I couldn't see a place to comment on the code like reviewboard. Really the only difference between jovie and that class are the following: 1. jovie has some old code and ui to control jobs at a fine grain that spd doesn't expose really well, so I left it out when I ported ktts to spd. I would like to expose voices and languages in a sensible fashion. This is tricky to get right cross-platform. I started with something on Linux but decided to implement other backends first before attempting to implement voice selection. For language/locale I think qtspeech should default to the system locale and let the user select a different one. 2. user defined filters with some sane/useful defaults (if we were to use QtSpeech for kde notifications, set konvi to speak all messages, there's not a way to let the user say change jpwhiting fregl: you rock into jpwhiting says fregl you rock) Maybe. I'd rather keep qtspeech very simple. My goals where to make it a tiny library that is lean, fast and async by using signals and slots. I want it to be good enough to be used in apps that use voice navigation, but also when writing a screen reader. Some level of configuration is required in any case. Let's come up with a good api that makes sense across platforms, then I'm in. 3. user configurability (As a user I can't set up which voice I would like all speech-using applications to use) As with other Qt libs, this is more for the platform to set up. Currently qtspeech uses whatever voice is selected system wide (aka the default). I think that is the right approach - follow what we get from the platform. For KDE I'd thus suggest creating a configuration module which lets the user choose the platform defaults. 4. dbus, though this isn't as important if each application that uses speech links to the library and speech-dispatcher or the system apis do the async for us already anyway as you said. I don't see a point in adding dbus into the mix indeed. One thing that is interesting though is what kind of effect you get when opening the speech backend from two apps at the same time. Items 1 and 4 will be irrelevant in a KF5 world but I'm wondering how 2 and 3 could be added either to qtspeech itself or as a kspeech library that wraps qtspeech for kde applications to use. Any thoughts on that? I would be pretty interested in helping with qtspeech if it greatly simplifies or even deprecates jovie as it looks like it could do possibly. I'd be more than happy to get contributions of course. I cannot promise much from my side, of course I'd like to continue working on this project as time permits (so far it really is a spare time thing). Greetings, Frederik Jeremy On Wed, Mar 5, 2014 at 12:29 PM, Frederik Gladhorn gladh...@kde.org wrote: On Tuesday 4. March 2014 16.43.10 Jeremy Whiting wrote: Hello all, I've realized a bit ago that kspeech was not included in the kdelibs split (probably because it was in staging at the time and didn't conform to the other framework policies yet). I've cleaned it up a bit and put it in my scratch space, but have some architectural questions about it before I make it a proper framework. 1. The KSpeech dbus interface is old and showing its age. Many of the methods are no longer implemented in the application itself since it was ported to speech-dispatcher. One thing I would definitely like to do is clean up/remove methods that aren't implemented currently (and possibly re add some later on if speech-dispatcher gets better/more support for job control, etc.) So the question about this is is KF5 time a good time to drop/clean up the dbus interface? 2. The KSpeech interface that was in kdelibs/interfaces is just that a dbus interface only. I would like to make it a proper library/framework with a QObject based class for talking to Jovie (the application that implements the KSpeech dbus interface) and wonder if other things such as what's currently in jovie/libkttsd should be in the kspeech library also. If I move code from jovie into libkspeech (or merge kspeech interface into libkttsd and make libkttsd a framework likely renamed to libkspeech since libkttsd isn't a public library anyway and has the old ktts name) what's the best way to preserve the history of both the kspeech interface and libkttsd sources. Didn't the plasma or kde-workspaces split do something fancy with git where old history pointed to the old git repo somehow? Along with this, if libkspeech is defining the kspeech dbus interface and has a class to talk to that interface, does the interface still need to be in servicetypes like
Re: kf5 alpha 1 : attica?
On Thursday 6. February 2014 00.29.45 David Faure wrote: Frederik wrote: From my point of view, please just go ahead and change it as you think is sensible. OK, thanks for the green lights, I went ahead: * Qt4 support for attica is now in the qt4 branch * Attica master is now qt5 only, and requires ECM. * It gained all the bells and whistles of being a proper framework: camelcase forwarding headers, version upgrade to 4.96.0, .pri file, etc. And, being released together with the other frameworks. The only thing that makes attica an odd duck compared to the other frameworks is that we can't yet move it under the frameworks/ hierarchy because that would break the Qt4 build scripts. So, all KF5 hackers, please note that whenever making a change across all frameworks you should also remember attica, outside your frameworks/ subdir. Thanks a lot, I really appreciate it. Greetings, Frederik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review LibKdeAccessibilityClient
Søndag 7. oktober 2012 21.45.17 skrev Alexander Neundorf:
On Thursday 04 October 2012, Frederik Gladhorn wrote:
Hi,
so after we took the time to hack a bit more on the library in Randa,
I would be happy about more comments.
Why does it use KDEPIMLIBS_INSTALL_DIR ?
macro(MAKE_INSTALL_PATH_ABSOLUTE out in)
if (IS_ABSOLUTE ${in})# IS_ABSOLUTE is new since cmake 2.4.8
set(${out} ${in})
else()
set(${out} \${KDEPIMLIBS_INSTALL_DIR}/${in})
endif()
endmacro(MAKE_INSTALL_PATH_ABSOLUTE out in)
I would have expected ${CMAKE_INSTALL_PREFIX}.
Thanks, fixed.
Greetings
Frederik
Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review LibKdeAccessibilityClient
Hi, so after we took the time to hack a bit more on the library in Randa, I would be happy about more comments. The plan is to use it for our tools (currently Simon and Magnifier), so the only thing I didn't do is to change it to depend on ECM. I find the CMake part is quite nice now, it doesn't even require the tedious FindFoo.cmake files, instead it uses the target-exporting feature of cmake that Alex suggested (good stuff indeed). After realizing it was Qt only, we were bold enough to rename it to QAccessibilityClient. Especially Peter reviewing and using it for Simon makes me feel relatively good about the lib, since it confirms its usefullness. The manual test in there is turning into a full accessibility debugging tool, another thing turning out better than I initially expected :) Give it a look when bored, it's fun to play with and works with Gnome and KDE apps (assuming you have qt- at-spi and libatspi2). Greetings Frederik On Thursday 23. August 2012 22.41.46 Kevin Ottens wrote: Hello, On Thursday 16 August 2012 09:29:27 Frederik Gladhorn wrote: Feedback is much appreciated. If you aim at releasing with KDE Frameworks, I would like to see the following happening: * Stick to the new CMake ways we use in KDE Frameworks (means depending on CMake 2.8.9 and ECM 0.0.5 for now); * Fix the issues raised by Alex (obviously); * Change the name to kaccessibilityclient to be more aligned with how we're naming the other frameworks. The first point could be a problem I guess if you aim at releasing before KDE Frameworks 5.0 as ECM is not widespread in distros yet. My 0.02€ Regards. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review LibKdeAccessibilityClient
Hi, a few of us trying to improve accessibility of KDE worked on a little library, LibKdeAccessibilityClient. What it does is making the AT-SPI over DBus protocol easy to use for KDE apps. This is the accessibility framework that we share with Gnome. It enables two way communication between apps and assistive tools. The first users for it would be the magnifiers in KWin and KMag - they can follow the focus with it. Further users will be screen readers and Simon with the AT-SPI plugin to dynamically create vocabulary for the running application's actions. I'd like to ask for initial review in order to move this tiny lib to kdesupport/frameworks. It's Qt-only and actually only consists of two public classes. Due to the underlying AT-SPI being Linux-only it's not cross platform in the sense that a windows implementation would need a completely different backend (IAccessible(2) or UIA). At this time there is not much sense in that since accessibility tools on Windows are more advanced at the moment and not something we are interested in providing at this time. We'll be writing up a nice tutorial on techbase the next days, for now the library comes with a few auto-tests and one example application that lets one browse the running applications accessibility interfaces. Some of the improvements in that library were made by Amandeep as part of his summer of code project (with Sebastian mentoring). Feedback is much appreciated. Greetings Frederik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
