D12650: Fix incorrect version in @since tag

2018-05-01 Thread Huon Imberger
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:b506a48214a0: Fix incorrect version in @since tag 
(authored by huoni).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12650?vs=33466&id=33468

REVISION DETAIL
  https://phabricator.kde.org/D12650

AFFECTED FILES
  src/kiconloader.h

To: huoni, #frameworks, cfeck
Cc: michaelh, bruns


D12650: Fix incorrect version in @since tag

2018-05-01 Thread Huon Imberger
huoni created this revision.
huoni added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
huoni requested review of this revision.

REVISION SUMMARY
  The following functions only appeared in v5.39, however their @since
  tag specified v5.38.
  
  `KIconLoader::setCustomPalette()`
  `KIconLoader::customPalette()`
  `KIconLoader::resetPalette()`

TEST PLAN
  Ensure the above functions didn't exist in v5.38

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12650

AFFECTED FILES
  src/kiconloader.h

To: huoni, #frameworks
Cc: michaelh, bruns


D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Huon Imberger
huoni added a comment.


  FWIW, I run Arch, and never use Desktop View and therefore the Desktop folder.
  I //do// have `~/Desktop`, but I do not have the places entries by default.
  
  I definitely +1 this change, but it has to be robust and deal with any 
combination of pre-existing distro defaults.

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg
Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham