D16684: Updated with petroleum industry units

2018-11-06 Thread Joao Oliveira 
joaonetto added a comment.


  Done, can land now

REPOSITORY
  R292 KUnitConversion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-06 Thread Joao Oliveira 
joaonetto edited the summary of this revision.

REPOSITORY
  R292 KUnitConversion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto updated this revision to Diff 44918.

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44917&id=44918

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability_p.h
  src/unit.h
  src/volume.cpp

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto updated this revision to Diff 44917.
joaonetto marked 3 inline comments as done.
joaonetto added a comment.


  permeability.h renamed to permeability_p.h and change Darcy to start at 33000

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44914&id=44917

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability_p.h
  src/unit.h
  src/volume.cpp

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto updated this revision to Diff 44914.
joaonetto marked an inline comment as done.
joaonetto added a comment.


  Reviewed with comments made on this diff.

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44906&id=44914

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability.h
  src/unit.h
  src/volume.cpp

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto updated this revision to Diff 44906.
joaonetto added a comment.


  Couldn't update D16681 , creating new 
revision

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44905&id=44906

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability.h
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto updated this revision to Diff 44905.
joaonetto added a comment.


  Updated with permeability source code

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44904&id=44905

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability.h
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto updated this revision to Diff 44904.
joaonetto added a comment.


  - Updated source code with permeability class

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44903&id=44904

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability.h
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto created this revision.
joaonetto added a project: Frameworks.
joaonetto requested review of this revision.

REVISION SUMMARY
  Added a new volume unity Oil Barrels and a new permeability class that 
handles Darcy and MiliDarcys.

REPOSITORY
  R292 KUnitConversion

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16684: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto edited the summary of this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto updated this revision to Diff 44901.
joaonetto added a comment.


  Updating D16681 : Updated with petroleum 
industry units

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16681?vs=44899&id=44901

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16681

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

2018-11-05 Thread Joao Oliveira 
joaonetto created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
joaonetto requested review of this revision.

REVISION SUMMARY
  Added a new volume unity Oil Barrels and a new permeability class that 
handles Darcy and MiliDarcys.

REPOSITORY
  R292 KUnitConversion

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16681

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/length.cpp
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns