D16395: Update the "About KDE" text

[Julian Schraner]

xyquadrat added a comment.


  > KDE is a cooperative enterprise in which no single entity controls the 
efforts or efforts or products of KDE to the exclusion of others.
  
  I think this sentence is too complex. I'd suggest writing something like "KDE 
is a cooperative enterprise: nobody controls all efforts or products. Instead, 
we work together to achieve our common goals."

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D14674: handle non-ASCII encodings of file names in tar archives

[Julian Schraner]

xyquadrat added a comment.


  Two links that might be useful when writing the unit test:
  https://community.kde.org/Guidelines_and_HOWTOs/UnitTests
  https://wiki.qt.io/Writing_Unit_Tests
  Also, there are already a few unit tests in this repo that you could take a 
look at.
  
  Thank you for your patch!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14674

To: ibragimovrinat, dfaure, kossebau
Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, 
ngraham, bruns

D12321: Hide file preview when icon is too small

[Julian Schraner]

xyquadrat added a comment.


  In D12321#249981 , @ngraham wrote:
  
  > Fabulous. I agree with @rkflx that before committing this, we should also 
prepare a similar patch for Dolphin to unify the behaviors.
  
  
  That would be great, as this would solve bug 350932 
 & keep the behavior consistent 
across applications.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin
Cc: xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns