D14631: Adds a new RenameDialog to KIO with more options for batch renaming
luco added a comment. @emateli Thank you, I do understand that `BatchMoveJob` could be more versatile for a various kind of operations, but couldn't it be easier to just edit the `BatchRenameJob`'s hardcoded logic and make it more parametric? If I understand correctly you're referring to the fact that the ctor of `BatchRenameJob` is accepting a QChar and it only substitutes it with numbers, wouldn't be easier to edit that logic instead? I'm asking because I think you already have considered this option and concluded that it was not worth it REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin Cc: luco, nicopons, meven, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D14631: Adds a new RenameDialog to KIO with more options for batch renaming
luco added a comment. @emateli Thank you for your response, I saw that patch and I sincerely don't understand the reason why you're writing a completely different job (`BatchMoveJob`) when the required operation is exactly a `BatchRenameJob`. I'm asking this because I've never used a "batch rename" feature to move files to a different folder, I always used that to rename multiple files with a regex pattern or a numbering sequence instead, but maybe it's just me. Do you think an initial implementation of your GUI with the standard `BatchRenameJob` could work? What problems could appear? I see the usefulness of the `BatchMoveJob`, but I can't see how is that related to this patch! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin Cc: luco, nicopons, meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D14631: Adds a new RenameDialog to KIO with more options for batch renaming
luco added a comment. @emateli Are you still working on this? I'd love to see this feature implemented, I wanted to start by myself then on the Matrix Dolphin channel they suggested seeing this patch and it's awesome! Could you use some help? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin Cc: luco, nicopons, meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
