D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli updated this revision to Diff 46321. lsartorelli added a comment. Added @since and @author in the header documentation REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=46248=46321 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli added a comment. Usually the message should be always shown, but I think there there are some exceptions. - for Kate the message is supposed to be off till its code base is upgraded with the removal of ts own popup. - for dolphin the message should be shown only if the menu bar and the tool bar are hided at the same time. (in this case a better message could be shown) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli updated this revision to Diff 46248. lsartorelli added a comment. Hi, you are right, I did not realize a bit of mess in between my revisions. Now all the requests should have been fulfilled properly. Thanks for this massive support and please, just let me know if I need to fix something else. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45934=46248 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli marked an inline comment as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli updated this revision to Diff 45934. lsartorelli marked an inline comment as done. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45874=45934 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli marked an inline comment as done. lsartorelli added inline comments. INLINE COMMENTS > aacid wrote in ktoggleshowmenubaraction.cpp:77 > If shortcut() returns a QKeySequence (i think it does), you want > toString(NativeText) > > Not a native speaker but i don't think "typing" is what you want, i'd say > "pressing". > > Also what if there's no shortcut? Do you suggest to add a warning in case of no shortcut? The only options I am thinking of are to tell the user add the missing shortcut via system settings, to tell the user to modify the config file for current app or I don't know REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli updated this revision to Diff 45874. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45821=45874 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli updated this revision to Diff 45821. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45812=45821 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli marked 3 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli added inline comments. INLINE COMMENTS > cfeck wrote in ktoggleshowmenubaraction.h:28 > reminds > > Additionally, "show back" does not sound like proper english, but I am not a > native english speaker. Unfortunately, me too, ... any suggestion is appreciated REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli updated this revision to Diff 45812. lsartorelli marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45811=45812 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli updated this revision to Diff 45811. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45807=45811 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli added a dependent revision: D17016: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17014: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli added a dependent revision: D17016: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17014 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli updated this revision to Diff 45807. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=45798=45807 REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli added a dependent revision: D17014: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17014: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli created this revision. lsartorelli added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide a common message ,encapsulated into the ShowMenuBarAction, with a reminder about how to re-enable the menu bar with a keyboard shortcut sequence. The message dialog is optional by default and can be enabled if needed. The message dialog pops up only after the menu bar become hided. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17014 AFFECTED FILES autotests/kstandardactiontest.cpp src/kstandardaction.cpp src/kstandardaction.h To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17014: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli added a dependency: D17013: Show menu bar, how to re-enable, common shortcut dialog. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17014 To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17013: Show menu bar, how to re-enable, common shortcut dialog
lsartorelli created this revision. lsartorelli added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide a common message ,encapsulated into the ShowMenuBarAction, with a reminder about how to re-enable the menu bar with a keyboard shortcut sequence. The message dialog is optional by default and can be enabled if needed. The message dialog pops up only after the menu bar become hided. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 AFFECTED FILES src/CMakeLists.txt src/ktoggleshowmenubaraction.cpp src/ktoggleshowmenubaraction.h To: lsartorelli, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D15644: Provide option to hide menu bar for Ksysguard
lsartorelli marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D15644: Provide option to hide menu bar for Ksysguard
lsartorelli updated this revision to Diff 42368. lsartorelli added a comment. little clean up CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42350=42368 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp gui/ksysguard.h To: lsartorelli, ngraham, #plasma, #frameworks Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D15644: Provide option to hide menu bar for Ksysguard
lsartorelli updated this revision to Diff 42350. lsartorelli added a comment. Removed unused parameter in toggleShowMenuBar() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42298=42350 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp gui/ksysguard.h To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D15644: Provide option to hide menu bar for Ksysguard
lsartorelli added a comment. Thank you very much, I am so happy and proud for my first patch. Here my details: Name: Luca Surname: Sartorelli Mail: dj3...@gmail.com And here is the patch for gwenview: https://phabricator.kde.org/D15747 Just added you as reviewer 2 secs ago REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D15644: Provide option to hide menu bar for Ksysguard
lsartorelli updated this revision to Diff 42298. lsartorelli added a comment. Added remainder message box with keyboard shortcut, to have back the menu bar. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42101=42298 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp gui/ksysguard.h To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D15644: Provide option to hide menu bar for Ksysguard
lsartorelli added a comment. Hi Nathaniel, thanks for all the support. I can understand and agree with your concerns. Not sure but maybe an option could be to add the hide menu bar entry in the setting menu via kxmlguiwindow and another entry to unhide it maybe can be putted in the context menu on the window title bar. Just an idea, that requires wider discussions and knowledges. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D15644: Provide option to hide menu bar for Ksysguard
lsartorelli retitled this revision from "Provide option to hide menu bar for Ksysguard - Bug 395349" to "Provide option to hide menu bar for Ksysguard". lsartorelli edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D15644: Provide option to hide menu bar for Ksysguard - Bug 395349
lsartorelli updated this revision to Diff 42101. lsartorelli retitled this revision from "Bug 395349" to "Provide option to hide menu bar for Ksysguard - Bug 395349". lsartorelli edited the summary of this revision. lsartorelli added a comment. Thank you, for all the feedback. Yes, I have to admit the Diff 42047, was the proper patch while Diff 42048 was just an attempt to clean it a little bit. Sorry, I did a bit of a mess with the diffs and all the tools that are new me. Here is patch that should work CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42048=42101 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp gui/ksysguard.h To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support
> On Aug. 10, 2015, 11:45 p.m., Michael Pyne wrote: > > I'm not the reviewer for kdelibs4support but I have used Taglib; the change > > looks good to me. Please can you submit it, I don't have commit rights. Thank you - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/#review83685 --- On Aug. 10, 2015, 9:56 a.m., Luca Sartorelli wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124684/ > --- > > (Updated Aug. 10, 2015, 9:56 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs4support > > > Description > --- > > Wrong string comparison of taglib version > > > Diffs > - > > cmake/modules/FindTaglib.cmake 5bbb8ee > > Diff: https://git.reviewboard.kde.org/r/124684/diff/ > > > Testing > --- > > Run cmake with kdesrc-build on debian strecth > taglib version correctly found and parsed > > > Thanks, > > Luca Sartorelli > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124682: Cmake fail to parse proper taglib version - extra-cmake-modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124682/ --- (Updated Aug. 11, 2015, 8:11 a.m.) Review request for KDE Frameworks. Repository: extra-cmake-modules Description --- Wrong string comparison of taglib version Diffs - attic/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124682/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/ --- (Updated Aug. 10, 2015, 9:56 a.m.) Review request for KDE Frameworks. Repository: kdelibs4support Description --- Wrong string comparison of taglib version Diffs - cmake/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124684/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
