D27504: smb faster copy to local

[Marijo Mustac]

mmustac added a comment.


  Those look very lovely.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, 
kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D22884: [RFC] Don't show title on page by default

[Marijo Mustac]

mmustac added a comment.


  I agree that it looks quite strange or at least unusual to me.
  Find myself always sliding to the left do regonize which topic is selected 
currently it seems not self explaining and I would miss the header.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22884

To: ngraham, #vdg, mart
Cc: mmustac, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D20693: Remove pixelated border

[Marijo Mustac]

mmustac added a comment.


  @ngraham: Fo sure, I will add my post from the forum here for better 
reference.
  
  > Today I thougtht about the design of the "Get new Hot Stuff" dialog. I 
think there is some room for improvements and to get a better overview.
  >  I tried to put my thought into a quick mockup. There are two screenshots 
to compare.
  > 
  > At first I think the "Get new Hot Stuff" needs to be an own application. No 
we have the KDE Store. Google has it's Play Store, Apple it's Appstore but what 
has KDE ?
  >  You could start the KDE Store directly or all other places would link to 
it's section. The first dropdown menu would provide access to all other 
categorys.
  >  The filter become also a dropdown menu and with the option to choose if I 
want to have an ascending or descening sorting.
  > 
  > The "new stuff" would be displayed in two columns to see more content at 
one time.
  >  Search is displayed at the bottom and a "filter by" option would you a 
quick overview about "all", "uninstalled" or "installed" content.
  >  And some smaller changes, you will see.
  
  F6791329: plasma-5.8-hotnewstuff-NEW.png 


REPOSITORY
  R304 KNewStuff

BRANCH
  no-pixelated-border (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: mmustac, ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, 
ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Marijo Mustac]

mmustac added a comment.


  We could also make the permissions interactive and explaining at the same 
time.
  I could imagine something like this:
  F6790404: permissions.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac added a comment.


  I would not close the bug yet. Unfortunately I am busy at the moment so I 
can't tell you when I will find to take a deeper look at the main problem from 
the bug:
  Although we have support for the template directory now, it is still very 
difficult to display your own templates in the menu. At least I will try to 
solve this problem without breaking some of those bugfixes which disabled this 
feature in the past.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

To: mmustac, #frameworks, dfaure
Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac added a comment.


  @dfaure Can you commit these changes as I don't have the access to ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

To: mmustac, #frameworks, dfaure
Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac marked 5 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

To: mmustac, #frameworks, dfaure
Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac updated this revision to Diff 35173.
mmustac added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  Updated to the latest comments.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10363?vs=26753&id=35173

REVISION DETAIL
  https://phabricator.kde.org/D10363

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: mmustac, #frameworks, dfaure
Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac marked an inline comment as done.
mmustac added a comment.


  No problem David, it's okay :)
  I will work on your suggestions and update this revision accordingly.
  
  > But actually, shouldn't we still have New Folder and New Text File at the 
top before everything else?
  
  Kai mentioned he wants them directly underneath the "new folder" so I changed 
it.
  Where should I place them finally ?
  
  I think it woulnd't be a good thing to mix the system templates directly with 
the user templates.
  So I can place the user templates on the first position underneath the folder 
like it is now, or underneath all system templates (like before). 
  Personally I would be okay with both options. When you say I should revert it 
again I will do this. Should I keep the seperator then?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

To: mmustac, #frameworks, dfaure
Cc: broulik, ngraham, michaelh, bruns

D12077: Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs

[Marijo Mustac]

mmustac added a comment.


  Great, I even didn't know that this was possible *lol*
  But wouldn't it be more consistent with dolphin to add the list view also ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12077

To: ngraham, #frameworks
Cc: mmustac, broulik, michaelh, ngraham, bruns

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Marijo Mustac]

mmustac added a comment.


  I have two questions regarding this "open with" topic.
  Is the displayed app the one which is also set as default for this file type 
or the first alternative (2nd app) ? If it's the default one why should someone 
make a right click on a file to open it with his/her default app instead of 
making a single/double click on it?
  The second point: Shouldn't the "Open with" stuff be at the very beginning of 
the menu when we have a file selected for quick access? (1. opening, 2. create 
new files (for folders), 3. direct file operations, 4. additional file 
operations, 5. everything else)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

D10508: Add icons for KStandardActions Deselect and Replace

[Marijo Mustac]

mmustac edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

[Marijo Mustac]

mmustac created this revision.
mmustac added reviewers: KTextEditor, ngraham.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
mmustac requested review of this revision.

REVISION SUMMARY
  This patch adds some more icons to the menus.
  One in the file menu, one in the bookmark menu and some in the tool menu.
  
  Example:
  F5711485: tools.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10509

AFFECTED FILES
  src/utils/katebookmarks.cpp
  src/view/kateview.cpp

To: mmustac, #ktexteditor, ngraham
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D10508: Add icons for KStandardActions Deselect and Replace

[Marijo Mustac]

mmustac added a comment.


  I can't access the link at the moment but changed the title according ;)
  And kate picks up this change automatically because they relay on this 
framework already or did I get you wrong?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: Add icons for KStandardActions Deselect and Replace

[Marijo Mustac]

mmustac retitled this revision from "[KStandardAction] Add additional icons to 
menus" to "Add icons for KStandardActions Deselect and Replace".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: [KStandardAction] Add additional icons to menus

[Marijo Mustac]

mmustac created this revision.
mmustac added reviewers: Frameworks, ngraham.
Restricted Application added a project: Frameworks.
mmustac requested review of this revision.

REVISION SUMMARY
  I added also here the icons for the "replace" and "deselect" action.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

AFFECTED FILES
  src/kstandardaction_p.h

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10494: update handle- icons for kirigami

[Marijo Mustac]

mmustac added a comment.


  I agree with Andreas and think that the new icon is a huge improvement. +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: mmustac, ngraham, #frameworks, michaelh

D10365: New icon for Elisa music player

[Marijo Mustac]

mmustac added a comment.


  Old-school rules! Also just think of the floppy 💾 disk icon which is mostly 
everywhere the save icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf, progwolff

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac marked 6 inline comments as done.
mmustac added inline comments.

INLINE COMMENTS

> dfaure wrote in knewfilemenu.cpp:904
> the 2nd arg isn't necessary, just do line.mid(19)

It is because we need to get rid of the " before and at the end of the path.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

To: mmustac, #frameworks, dfaure
Cc: broulik, ngraham, michaelh

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac updated this revision to Diff 26753.
mmustac added a comment.


  Addressed the mentioned issues.
  F5698366: Screenshot_20180208_103832.png 


REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10363?vs=26702&id=26753

REVISION DETAIL
  https://phabricator.kde.org/D10363

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: mmustac, #frameworks, dfaure
Cc: broulik, ngraham, michaelh

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac added a comment.


  @dfaure Thank you for your answer :-)
  As I am still at the beginnings I am really grateful for such constructive 
and valuable feedback like yours it helps me to become better and improve my 
code.
  
  Regarding your points:
  First of all I agree that a nice name istead of a simple file name is much 
better on the other side there could only be one template with this name and if 
this one is choosen very well then it's hard to guess that this template is for 
but I think this shouldn't be the case so often.
  When I started my journey with Linux it begin with Gnome2, over the time I 
moved to Gnome3 but had more and more issues and so I switched to KDE and 
Plasma then I read an article about the early 5.0 versions, ssaw some 
schreenshots and felt like: You have to use this, it's beautiful! (I never 
liked how oxygen looked like and as teen and linux noob in the past I didn't 
even know how to change the look and so never took a deeper look into the worlf 
od KDE ... what a shame) Du shorten the things a little bit ... I liked the way 
templates are handled in Gnome, you just put your custom files into the folder 
and they appear in the menu, even with the folder hirarchy if you had one und 
this is something I missed a lot in the beginning when I switched to Plasma. 
Until a few days I even don't know that a customazation was possible at all ^^
  I was thinking about a display name which gets the name for the mimetipe and 
adds the file name to it, if this is possible so get something like: "HTML 
FIle: StartPage.html"
  
  Then you have reservations about file support in KDE dirs and that's okay I 
think. This patch adds no support for "normal" files and I don't plan to add it 
to this revision. Maybe a second patch will follow which enables this feature 
again, but I didn't achive anything that worked correct until now. But lets 
move forward, should I be able to make this happen I could limit this support 
to the local template folder which does make a lot of sense for me too.
  
  The reason I added this to the installedTemplates was that I can then easiely 
use the KDirWatch and new files would be detected automatically which is 
important because otherwise the whole function does not make sense for me.
  At least I don't know any and was not able to find something. If there would 
be something it would be great to addapt it, because a great workflow would be:
  Drag'n Drop a file (or create a new one) to the template dir
  A dialog would open where the user can enter a nice name, maybe a comment 
also and after that the local file would be moved to an .source dir and the 
.desktop file would be greated on the fly like you said
  This would be awesome :)
  
  I will work on your improvements regarding the code. Most of them I didn't 
know I took a look and similar code, searched in the documentation of QT and 
just wanted to make it safe and clean but great if I can get rid of most of 
them which will make it even simpler ;-)
  Just one note for this point:
  
  > the 2nd arg isn't necessary, just do line.mid(19)
  
  I can't get rid of these because a normal entry in the user-dirs.dirs looks 
like: XDG_TEMPLATES_DIR="$HOME/Templates" so I have to remove the " before and 
at the end of the path.
  
  Sorry for the wall of text ^^

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

To: mmustac, #frameworks, dfaure
Cc: broulik, ngraham, michaelh

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac added a comment.


  @broulik Thanks :-)
  My idea was to add a submenu "own templates" to the menu but this would 
greatly exceed my knowledge. At the moment this is more try, error and 
debgugging, learning by doing ^^
  Will try to improve this match further.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

To: mmustac, #frameworks
Cc: broulik, ngraham, michaelh

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

To: mmustac, #frameworks
Cc: michaelh, ngraham

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

[Marijo Mustac]

mmustac created this revision.
mmustac added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
mmustac requested review of this revision.

REVISION SUMMARY
  This patch adds the support for templates in the XDG_TEMPLATES_DIR location 
which points in default to:
  [en] /home/user/templates
  [de] /home/user/Vorlagen
  As is all templates have to be a .desktop file maybe a second patch will 
follow changing this but it seems to be tricky without breaking something.
  This is a first step in resolving bug: #191632

TEST PLAN
  Add new valid .desktop file to your template folder -> shows up in the menu

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10363

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: mmustac, #frameworks
Cc: michaelh, ngraham

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[Marijo Mustac]

mmustac added a comment.


  Does this patch then also affects the speed of the copy operation?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks
Cc: mmustac