D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag
mthw added a comment. @davidedmundson I hoped this could make it into 5.71 or is it too late now? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag
mthw added a comment. Do I need to change anything or is this acceptable? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag
mthw added a comment. @davidedmundson What do you think about this patch? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag
mthw added a comment. This patch also fixes buttons in kded dialogs like the wifi password dialog. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, zzag Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag
mthw added a comment. I don't know enough about kded to answer your question. I just know this fixes the issue and it works fine with other apps, which may or may not be relevant. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag
mthw added a reviewer: Frameworks. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag
mthw created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mthw requested review of this revision. REVISION SUMMARY When using fractional scaling, icons in titlebar appmenu are blurred in all apps. This patch fixes the issue. TEST PLAN No side effects. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D29815 AFFECTED FILES src/kded.cpp To: mthw Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D23926: Move "Details" tab to second place in Properties dialog
mthw abandoned this revision. mthw added a comment. I don't have the time (nor skill really) to work on this. Feel free to take over if you want to. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw updated this revision to Diff 77450. mthw added a comment. Sorry about that, I should have checked waht I am sending. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=77445=77450 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23926 AFFECTED FILES src/widgets/kpropertiesdialog.cpp src/widgets/kpropertiesdialog.h To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw updated this revision to Diff 77445. mthw added a comment. I don't really know how to do a rebase propertly so I hope I managed to do the same manually. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=77388=77445 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23926 AFFECTED FILES src/widgets/kpropertiesdialog.cpp src/widgets/kpropertiesdialog.h To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw updated this revision to Diff 77388. mthw added a comment. - Made recomemded changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=66003=77388 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23926 AFFECTED FILES src/widgets/kpropertiesdialog.cpp src/widgets/kpropertiesdialog.h To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw added a comment. @meven So, the first version of this diff is good enough? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D27247: Unify the look of all icons containing (no sign)
mthw updated this revision to Diff 75443. mthw added a comment. Name should be correct now. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75434=75443 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons-dark/actions/16/font-disable.svg icons-dark/actions/16/mail-mark-junk.svg icons-dark/actions/22/font-disable.svg icons-dark/actions/22/mail-mark-junk.svg icons-dark/actions/24/audio-volume-muted.svg icons-dark/actions/24/mail-mark-junk.svg icons-dark/actions/32/mail-mark-junk.svg icons-dark/status/16/audio-volume-muted.svg icons-dark/status/16/microphone-sensitivity-muted.svg icons-dark/status/22/audio-volume-muted.svg icons-dark/status/22/microphone-sensitivity-muted.svg icons/actions/16/font-disable.svg icons/actions/16/mail-mark-junk.svg icons/actions/22/font-disable.svg icons/actions/22/mail-mark-junk.svg icons/actions/24/audio-volume-muted.svg icons/actions/24/mail-mark-junk.svg icons/actions/32/mail-mark-junk.svg icons/status/16/audio-volume-muted.svg icons/status/16/microphone-sensitivity-muted.svg icons/status/22/audio-volume-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw, #vdg, #plasma, ngraham, ndavis Cc: meven, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Unify the look of all icons containing (no sign)
mthw updated this revision to Diff 75434. mthw added a comment. Changed git name, nothing else REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75406=75434 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons-dark/actions/16/font-disable.svg icons-dark/actions/16/mail-mark-junk.svg icons-dark/actions/22/font-disable.svg icons-dark/actions/22/mail-mark-junk.svg icons-dark/actions/24/audio-volume-muted.svg icons-dark/actions/24/mail-mark-junk.svg icons-dark/actions/32/mail-mark-junk.svg icons-dark/status/16/audio-volume-muted.svg icons-dark/status/16/microphone-sensitivity-muted.svg icons-dark/status/22/audio-volume-muted.svg icons-dark/status/22/microphone-sensitivity-muted.svg icons/actions/16/font-disable.svg icons/actions/16/mail-mark-junk.svg icons/actions/22/font-disable.svg icons/actions/22/mail-mark-junk.svg icons/actions/24/audio-volume-muted.svg icons/actions/24/mail-mark-junk.svg icons/actions/32/mail-mark-junk.svg icons/status/16/audio-volume-muted.svg icons/status/16/microphone-sensitivity-muted.svg icons/status/22/audio-volume-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw, #vdg, #plasma, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Unify the look of all icons containing (no sign)
mthw added a comment. @ndavis I've set my name, do I need to "arc diff" again or something else? REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Unify the look of all icons containing (no sign)
mthw added a comment. Since you accepted, can you also commit this, please? REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Unify the look of all icons containing (no sign)
mthw updated this revision to Diff 75406. mthw added a comment. Fixed REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75389=75406 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons-dark/actions/16/font-disable.svg icons-dark/actions/16/mail-mark-junk.svg icons-dark/actions/22/font-disable.svg icons-dark/actions/22/mail-mark-junk.svg icons-dark/actions/24/audio-volume-muted.svg icons-dark/actions/24/mail-mark-junk.svg icons-dark/actions/32/mail-mark-junk.svg icons-dark/status/16/audio-volume-muted.svg icons-dark/status/16/microphone-sensitivity-muted.svg icons-dark/status/22/audio-volume-muted.svg icons-dark/status/22/microphone-sensitivity-muted.svg icons/actions/16/font-disable.svg icons/actions/16/mail-mark-junk.svg icons/actions/22/font-disable.svg icons/actions/22/mail-mark-junk.svg icons/actions/24/audio-volume-muted.svg icons/actions/24/mail-mark-junk.svg icons/actions/32/mail-mark-junk.svg icons/status/16/audio-volume-muted.svg icons/status/16/microphone-sensitivity-muted.svg icons/status/22/audio-volume-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Unify the look of all icons containing (no sign)
mthw updated this revision to Diff 75389. mthw added a comment. Changes to "font-disable" and "mail-mark-junk" are now included too. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75334=75389 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons-dark/actions/16/font-disable.svg icons-dark/actions/16/mail-mark-junk.svg icons-dark/actions/22/font-disable.svg icons-dark/actions/22/mail-mark-junk.svg icons-dark/actions/24/mail-mark-junk.svg icons-dark/actions/32/mail-mark-junk.svg icons-dark/status/16/audio-volume-muted.svg icons-dark/status/16/microphone-sensitivity-muted.svg icons-dark/status/22/audio-volume-muted.svg icons-dark/status/22/microphone-sensitivity-muted.svg icons/actions/16/font-disable.svg icons/actions/16/mail-mark-junk.svg icons/actions/22/font-disable.svg icons/actions/22/mail-mark-junk.svg icons/actions/24/mail-mark-junk.svg icons/actions/32/mail-mark-junk.svg icons/status/16/audio-volume-muted.svg icons/status/16/microphone-sensitivity-muted.svg icons/status/22/audio-volume-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Unify the look of all icons containing (no sign)
mthw added a comment. I also made adjustments to "font-disable" and "mail-mark-junk", do you want me to include them? After that all icons containing will be the same. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Unify the look of all icons containing (no sign)
mthw retitled this revision from "Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"" to "Unify the look of all icons containing (no sign)". mthw edited the summary of this revision. mthw edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"
mthw updated this revision to Diff 75334. mthw added a comment. Also made changes to "audio-volume-muted" REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75302=75334 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons-dark/status/16/audio-volume-muted.svg icons-dark/status/16/microphone-sensitivity-muted.svg icons-dark/status/22/audio-volume-muted.svg icons-dark/status/22/microphone-sensitivity-muted.svg icons/status/16/audio-volume-muted.svg icons/status/16/microphone-sensitivity-muted.svg icons/status/22/audio-volume-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"
mthw updated this revision to Diff 75302. mthw added a comment. color="" removed, also version removed as it wasn't there before. Anything else? REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75294=75302 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons-dark/status/16/microphone-sensitivity-muted.svg icons-dark/status/22/microphone-sensitivity-muted.svg icons/status/16/microphone-sensitivity-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"
mthw updated this revision to Diff 75294. mthw edited the summary of this revision. mthw added a comment. Work in progress, making recomended changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75251=75294 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons-dark/status/16/microphone-sensitivity-muted.svg icons-dark/status/22/microphone-sensitivity-muted.svg icons/status/16/microphone-sensitivity-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"
mthw edited the summary of this revision. mthw edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"
mthw edited the summary of this revision. mthw edited the test plan for this revision. mthw added reviewers: VDG, Plasma. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"
mthw updated this revision to Diff 75251. mthw added a comment. Also change Dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75250=75251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons-dark/status/16/microphone-sensitivity-muted.svg icons-dark/status/22/microphone-sensitivity-muted.svg icons/status/16/microphone-sensitivity-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"
mthw created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mthw requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES icons/status/16/microphone-sensitivity-muted.svg icons/status/22/microphone-sensitivity-muted.svg To: mthw Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D23926: Move "Details" tab to second place in Properties dialog
mthw added a comment. Any progress on this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw added a comment.
> 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd
want to do something more like this:
>
>
>
> if (plugin == "details" /* this is pseudocode */) {
> q->insertPluginAt(plugin, 1);
> } else {
> q->insertPlugin(plugin);
> }
>
>
> I'm actually not sure how to check for what the plugin is though. Maybe
someone from #frameworks
D23926: Move "Details" tab to second place in Properties dialog
mthw updated this revision to Diff 66003. mthw added a comment. Don't move the commented-out code, better description in header, formatting. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=65988=66003 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23926 AFFECTED FILES src/widgets/kpropertiesdialog.cpp src/widgets/kpropertiesdialog.h To: mthw, #dolphin, #frameworks, #vdg, ngraham Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw updated this revision to Diff 65988. mthw added a comment. Changes made, if clause still not there REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=65986=65988 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23926 AFFECTED FILES src/widgets/kpropertiesdialog.cpp src/widgets/kpropertiesdialog.h To: mthw, #dolphin, #frameworks, #vdg, ngraham Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw added a comment. I didn't know what to do with this > ...check to see if the plugin we've just created is the Details plugin,... Also the "Generator" should probably go back where it was right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw updated this revision to Diff 65986. mthw added a comment. Do you mean something like this? Only a wild guess, C lang is not my strength. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=65977=65986 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23926 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: mthw, #dolphin, #frameworks, #vdg, ngraham Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
D23926: Move "Details" tab to second place in Properties dialog
mthw edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D23926: Move "Details" tab to second place in Properties dialog
mthw edited the summary of this revision. mthw added a reviewer: Dolphin. mthw added a project: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D23926: Move "Details" tab to second place in Properties dialog
mthw created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mthw requested review of this revision. REVISION SUMMARY This change moves the "Details" tab to second place because it makes more sense. //more later REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23926 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: mthw Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
