D6366: Fix configure with Qt5Multimedia disabled.
This revision was automatically updated to reflect the committed changes. Closed by commit R286:f30fede21bf0: Fix configure with Qt5Multimedia disabled. (authored by palimaka). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6366?vs=15810&id=15821 REVISION DETAIL https://phabricator.kde.org/D6366 AFFECTED FILES CMakeLists.txt To: palimaka, #frameworks, mgallien Cc: mgallien, #frameworks
D6366: Fix configure with Qt5Multimedia disabled.
palimaka created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY When passed -DBUILD_TESTING=OFF -DCMAKE_DISABLE_FIND_PACKAGE_Qt5Multimedia=ON, CMake failed because find_package(Qt5 COMPONENTS MULTIMEDIA) was treated as required due to the previous find_package(Qt5 REQUIRED COMPONENTS Xml) call. Finding Qt5Multimedia directly via its own config file ensures that it really is treated as optional. TEST PLAN Configures and builds both with and without Qt5Multimedia enabled. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6366 AFFECTED FILES CMakeLists.txt To: palimaka, #frameworks Cc: #frameworks
D6249: FindQHelpGenerator: avoid picking up Qt4 version
palimaka added a comment. Sorry for the delay, I was away. Thanks for pushing! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system
D6249: FindQHelpGenerator: avoid picking up Qt4 version
palimaka updated this revision to Diff 15514. palimaka added a comment. Fix indentation. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6249?vs=15512&id=15514 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 AFFECTED FILES find-modules/FindQHelpGenerator.cmake To: palimaka, #frameworks, kossebau Cc: asturmlechner, #build_system
D6249: FindQHelpGenerator: avoid picking up Qt4 version
palimaka added a reviewer: kossebau. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau Cc: asturmlechner, #build_system
D6249: FindQHelpGenerator: avoid picking up Qt4 version
palimaka created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY Passing NO_DEFAULT_PATH ignores $PATH and ensures that we use the previously-detected Qt5 binary path. TEST PLAN qhelpgenerator is now picked up from the same location as Qt5::qmake. Before, anything in $PATH was preferred even if it was the Qt 4 version. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 AFFECTED FILES find-modules/FindQHelpGenerator.cmake To: palimaka, #frameworks Cc: #build_system
Re: Review Request 128922: Remove invalid directory from index.theme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128922/ --- (Updated Sept. 29, 2016, 4:28 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Andreas Kainz. Changes --- Submitted with commit 7648c0005fafd5a6834d2479796c3717b77e5549 by Michael Palimaka to branch master. Repository: oxygen-icons5 Description --- This removes the directory "base/" from index.theme. The presence of this directory causes warnings like "Gtk-WARNING **: Theme directory base/ of theme oxygen has no size field". This is similar to RR 127839 for breeze-icons. Diffs - index.theme 2fc77f7 Diff: https://git.reviewboard.kde.org/r/128922/diff/ Testing --- Warning disappears, oxygen icons still appear in a GTK application. Thanks, Michael Palimaka
Review Request 128922: Remove invalid directory from index.theme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128922/ --- Review request for KDE Frameworks and Andreas Kainz. Repository: oxygen-icons5 Description --- This removes the directory "base/" from index.theme. The presence of this directory causes warnings like "Gtk-WARNING **: Theme directory base/ of theme oxygen has no size field". This is similar to RR 127839 for breeze-icons. Diffs - index.theme 2fc77f7 Diff: https://git.reviewboard.kde.org/r/128922/diff/ Testing --- Warning disappears, oxygen icons still appear in a GTK application. Thanks, Michael Palimaka
Re: Review Request/New Framework: KF5::SyntaxHighlighting
Hi, On 11/09/16 01:47, Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) Thanks a lot for working on this. I noticed that KF5SyntaxHighlightingConfig.cmake.in searches for Qt5Widgets, but that doesn't seem to used in any public part of the framework (only tests). Also, some tests are failing here. Best regards, Michael
Re: Review Request 128814: Add Qt5Network as a public dependency.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128814/
---
(Updated Sept. 2, 2016, 6:15 p.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 99f220a81e82b2114f408823cdaa13a002e4fae5 by Michael
Palimaka to branch master.
Repository: attica
Description
---
Attica uses Qt5Network in its public API, so it must declare it as a public
dependency otherwise consumers could fail to build if Qt5Network is not already
found elsewhere in the dependency tree.
Diffs
-
KF5AtticaConfig.cmake.in 078d03c416316fc446b40405cb35f23665f5ed86
Diff: https://git.reviewboard.kde.org/r/128814/diff/
Testing
---
Consider this test case:
```cmake
project(test)
find_package(ECM 1.7.0 REQUIRED NO_MODULE)
find_package(KF5Attica REQUIRED)
set(test_SRCS test.cpp)
add_executable(test ${test_SRCS})
target_link_libraries(test KF5::Attica)
```
Before the change it fails to build with ``ld: cannot find -lQt5::Network``,
after the change it passes.
Thanks,
Michael Palimaka
Review Request 128814: Add Qt5Network as a public dependency.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128814/
---
Review request for KDE Frameworks.
Repository: attica
Description
---
Attica uses Qt5Network in its public API, so it must declare it as a public
dependency otherwise consumers could fail to build if Qt5Network is not already
found elsewhere in the dependency tree.
Diffs
-
KF5AtticaConfig.cmake.in 078d03c416316fc446b40405cb35f23665f5ed86
Diff: https://git.reviewboard.kde.org/r/128814/diff/
Testing
---
Consider this test case:
```cmake
project(test)
find_package(ECM 1.7.0 REQUIRED NO_MODULE)
find_package(KF5Attica REQUIRED)
set(test_SRCS test.cpp)
add_executable(test ${test_SRCS})
target_link_libraries(test KF5::Attica)
```
Before the change it fails to build with ``ld: cannot find -lQt5::Network``,
after the change it passes.
Thanks,
Michael Palimaka
Re: Review Request 128192: Remove man pages for scripts that no longer exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128192/ --- (Updated June 16, 2016, 5:02 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Alex Merry and Olivier Churlaud. Changes --- Submitted with commit e34c35ec98c260c87171e81b134e771f689e0180 by Michael Palimaka to branch master. Repository: kapidox Description --- kgenapidox and kgenframeworksapidox were removed in bb4063f5d9f9015b86dbc3a48a424c8cb1a8193f. Diffs - docs/kgenapidox.1 919d6c68d3f2775a4fdff8551941600be18f9acd docs/kgenframeworksapidox.1 5a4c638b2974ce905093f48f707db58e56179756 setup.py 607388bb6339a7c1ea81b1ec58690df3fed12252 Diff: https://git.reviewboard.kde.org/r/128192/diff/ Testing --- Builds and installs correctly to temporary directory. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128192: Remove man pages for scripts that no longer exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128192/ --- Review request for KDE Frameworks, Alex Merry and Olivier Churlaud. Repository: kapidox Description --- kgenapidox and kgenframeworksapidox were removed in bb4063f5d9f9015b86dbc3a48a424c8cb1a8193f. Diffs - docs/kgenapidox.1 919d6c68d3f2775a4fdff8551941600be18f9acd docs/kgenframeworksapidox.1 5a4c638b2974ce905093f48f707db58e56179756 setup.py 607388bb6339a7c1ea81b1ec58690df3fed12252 Diff: https://git.reviewboard.kde.org/r/128192/diff/ Testing --- Builds and installs correctly to temporary directory. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127895: Remove unused dependencies and translation handling.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127895/ --- (Updated May 11, 2016, 6:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b50958516e6cf05f04ff92437e04228950a0ddec by Michael Palimaka to branch master. Repository: frameworkintegration Description --- These are no longer used since 5ddb0b262dc409071f556dbd3f94799136b60909. Diffs - CMakeLists.txt 753177a101e965a86f48915ea0ab723f16c46d1a autotests/CMakeLists.txt 8874f61daca2a5fdeb69faae80183802b0e63969 src/Messages.sh 5ee7c10ef734e30d70491acd6e5ecc52d3c41186 Diff: https://git.reviewboard.kde.org/r/127895/diff/ Testing --- Inspected source, builds, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127895: Remove unused dependencies and translation handling.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127895/ --- Review request for KDE Frameworks. Repository: frameworkintegration Description --- These are no longer used since 5ddb0b262dc409071f556dbd3f94799136b60909. Diffs - CMakeLists.txt 753177a101e965a86f48915ea0ab723f16c46d1a autotests/CMakeLists.txt 8874f61daca2a5fdeb69faae80183802b0e63969 src/Messages.sh 5ee7c10ef734e30d70491acd6e5ecc52d3c41186 Diff: https://git.reviewboard.kde.org/r/127895/diff/ Testing --- Inspected source, builds, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Qt 5.6/QtWebkit
On 17/03/16 03:59, René J. V. Bertin wrote: > Aleix Pol wrote: > > >> >> https://code.qt.io/cgit/qt/qtwebkit.git/ > > Right, thanks, I'd seen that one too (there's also a clone on github but it > isn't clear how recent/unmodified that one is). > > What I didn't yet see is if there's a way to do tarball fetches from > code.qt.io > that correspond to a specific commit, tag or release (purely for convenience > in a > packaging script)? > > R. There is what appears to be a qtwebkit-5.6.0 final tarball released at the same time as 5.6.0_rc - https://download.qt.io/development_releases/qt/5.6/5.6.0-rc/submodules/qtwebkit-opensource-src-5.6.0.tar.xz ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127100: Remove unused dependencies in kactivities
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127100/ --- (Updated March 1, 2016, 1:44 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit efc193d9de78d5bf208733ad12151e8ba758ee14 by Michael Palimaka to branch master. Repository: kactivities Description --- Appears to be unused since the repo split. Diffs - CMakeLists.txt 62e1c19c7ed137719d8536812a709599ed9b6beb src/imports/CMakeLists.txt bf75bc61bc40f30170e0e8b6218ce9e8d2f25026 src/lib/CMakeLists.txt b5f16d5b3abc976922801deb38012cbaae469f9c Diff: https://git.reviewboard.kde.org/r/127100/diff/ Testing --- Inspected source, builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127100: Remove unused dependencies in kactivities
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127100/ --- Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities Description --- Appears to be unused since the repo split. Diffs - CMakeLists.txt 62e1c19c7ed137719d8536812a709599ed9b6beb src/imports/CMakeLists.txt bf75bc61bc40f30170e0e8b6218ce9e8d2f25026 src/lib/CMakeLists.txt b5f16d5b3abc976922801deb38012cbaae469f9c Diff: https://git.reviewboard.kde.org/r/127100/diff/ Testing --- Inspected source, builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126868: Update docs for KCrash::Initialize.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126868/ --- (Updated Jan. 24, 2016, 12:32 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 63b4394d97a7478da095c52356d7b16b8798824b by Michael Palimaka to branch master. Repository: kcrash Description --- Currently the platform plugin makes no such call so this is the only way to ensure that the crash handler is always launched. As discussed on the mailing list, simply linking to KCrash is not enough. Many distributions build their packages with --as-needed which causes the link to be broken as, without any library usage, it appears to be unused. https://mail.kde.org/pipermail/kde-frameworks-devel/2015-September/026973.html https://mail.kde.org/pipermail/kde-frameworks-devel/2015-November/028630.html Diffs - src/kcrash.h e2b59f219edaba8abfb0f5e100d5b6b41223db50 Diff: https://git.reviewboard.kde.org/r/126868/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 126868: Update docs for KCrash::Initialize.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126868/ --- Review request for KDE Frameworks and David Faure. Repository: kcrash Description --- Currently the platform plugin makes no such call so this is the only way to ensure that the crash handler is always launched. As discussed on the mailing list, simply linking to KCrash is not enough. Many distributions build their packages with --as-needed which causes the link to be broken as, without any library usage, it appears to be unused. https://mail.kde.org/pipermail/kde-frameworks-devel/2015-September/026973.html https://mail.kde.org/pipermail/kde-frameworks-devel/2015-November/028630.html Diffs - src/kcrash.h e2b59f219edaba8abfb0f5e100d5b6b41223db50 Diff: https://git.reviewboard.kde.org/r/126868/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Icons missing
On 06/12/15 23:56, Thorsten Zachmann wrote: > Hello all, > > I use a separate user for running calligra. I use ssh -X to login from my > normal desktop user to my kde running user. However when I start any > kde application I have no icons. With strace I can see it searches for icons > in the hicolor folder instead of breeze. > With the help of David Faure I found out the the icons are shown as expected > when I call > > export KDE_FULL_SESSION=true > > before starting the application. > > I think using an application via ssh -X is used quite often and it should > work > out of the box with the need of setting any special export. Maybe you have an > idea on how the behaviour can be improved. > > Please CC me as I'm not subscribed to the list. > > Thorsten Zachmann This is a really nasty regression compared to KDE 4, and I'm surprised we don't hear about it more often. Unfortunately I don't have any solution to suggest. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126054: Missed doctool usage.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126054/ --- (Updated Nov. 13, 2015, 4:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Changes --- Submitted with commit 0d22a5f5bc1d0c5842ba13e979ebdd13036e5e36 by Michael Palimaka to branch master. Repository: kconfigwidgets Description --- kdoctools_install fails if KF5DocTools is missing or disabled. Diffs - CMakeLists.txt e7ce4fe3e6e7537d675bb475734b19c97a2b4db5 Diff: https://git.reviewboard.kde.org/r/126054/diff/ Testing --- Configures with and without KF5DocTools. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 126054: Missed doctool usage.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126054/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kconfigwidgets Description --- kdoctools_install fails if KF5DocTools is missing or disabled. Diffs - CMakeLists.txt e7ce4fe3e6e7537d675bb475734b19c97a2b4db5 Diff: https://git.reviewboard.kde.org/r/126054/diff/ Testing --- Configures with and without KF5DocTools. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124043: Remove unused dependency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124043/ --- (Updated June 9, 2015, 6:49 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Laurent Montel. Changes --- Submitted with commit c4be53bbcd233d3392bb01f8e0da5f9bb3ad9731 by Michael Palimaka to branch master. Repository: ktextwidgets Description --- It is no longer required since 0f10c6e5c34100043e6bc444ec1fcebe791c21a9. Diffs - CMakeLists.txt 06bf429e5177532394bf7de4435c7db160dce50c src/CMakeLists.txt 3c7b93999a6de400f23d9d64b8dadf65d0fb8fb2 src/widgets/ktextedit.cpp 078ab83fefb30e6a3888d8c7f3167ffeea1344b5 Diff: https://git.reviewboard.kde.org/r/124043/diff/ Testing --- Builds. Inspected source and binary links. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124043: Remove unused dependency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124043/ --- Review request for KDE Frameworks and Laurent Montel. Repository: ktextwidgets Description --- It is no longer required since 0f10c6e5c34100043e6bc444ec1fcebe791c21a9. Diffs - CMakeLists.txt 06bf429e5177532394bf7de4435c7db160dce50c src/CMakeLists.txt 3c7b93999a6de400f23d9d64b8dadf65d0fb8fb2 src/widgets/ktextedit.cpp 078ab83fefb30e6a3888d8c7f3167ffeea1344b5 Diff: https://git.reviewboard.kde.org/r/124043/diff/ Testing --- Builds. Inspected source and binary links. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 13, 2015, 5:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b87835cc7bdf869624b77fea7e6b7b0526c33ec6 by Michael Palimaka to branch master. Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 13, 2015, 5:13 p.m.) Review request for KDE Frameworks. Changes --- Eliminate ifdefs. Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs (updated) - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 12, 2015, 5:12 p.m.) Review request for KDE Frameworks. Summary (updated) - Use QTemporaryFile instead of hardcoding a temporary file Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123737: Update URL to something that's fetchable.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- Review request for KDE Frameworks. Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates the source URL to something fetchable. This also affects kdelibs. Diffs - tests/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.
> On May 12, 2015, 3:49 p.m., Jan Kundrát wrote: > > Was the old code a part of some release? If yes, this should get a CVE > > security announcement because it allows a local attacker to e.g. force you > > to overwirte some of your user's files. It looks like it was introduced in 999e774b3ce117598df2029364bd10f4347be81c and released in 0.2.0 and later. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/#review80247 --- On May 12, 2015, 12:49 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123724/ > --- > > (Updated May 12, 2015, 12:49 p.m.) > > > Review request for KDE Frameworks and KDEPIM. > > > Repository: kpeople > > > Description > --- > > Hardcoding files like this seems like a bad idea. > > > Diffs > - > > autotests/persondatatests.h 30eeeb5cd647c713f1b438543a54516ced9f3ede > autotests/persondatatests.cpp 73098d3717509ad80761bbd02000b4ce5060bbb2 > autotests/personsmodeltest.h 5b8879521f334459c4f73c2708b3368c543e40a3 > autotests/personsmodeltest.cpp b19d1baf8a2c2e617d4b6128df29fbab3b8e61a7 > > Diff: https://git.reviewboard.kde.org/r/123724/diff/ > > > Testing > --- > > Tests still pass. > > > Thanks, > > Michael Palimaka > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/ --- (Updated May 12, 2015, 12:49 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and KDEPIM. Changes --- Submitted with commit 0c71246a330946333b7c95ab78eac80bf4f5641d by Michael Palimaka to branch master. Repository: kpeople Description --- Hardcoding files like this seems like a bad idea. Diffs - autotests/persondatatests.h 30eeeb5cd647c713f1b438543a54516ced9f3ede autotests/persondatatests.cpp 73098d3717509ad80761bbd02000b4ce5060bbb2 autotests/personsmodeltest.h 5b8879521f334459c4f73c2708b3368c543e40a3 autotests/personsmodeltest.cpp b19d1baf8a2c2e617d4b6128df29fbab3b8e61a7 Diff: https://git.reviewboard.kde.org/r/123724/diff/ Testing --- Tests still pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople Description --- Hardcoding files like this seems like a bad idea. Diffs - autotests/persondatatests.h 30eeeb5cd647c713f1b438543a54516ced9f3ede autotests/persondatatests.cpp 73098d3717509ad80761bbd02000b4ce5060bbb2 autotests/personsmodeltest.h 5b8879521f334459c4f73c2708b3368c543e40a3 autotests/personsmodeltest.cpp b19d1baf8a2c2e617d4b6128df29fbab3b8e61a7 Diff: https://git.reviewboard.kde.org/r/123724/diff/ Testing --- Tests still pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123630: Remove unused dependency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123630/ --- (Updated May 5, 2015, 2:16 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 87099296158ae3a8807b93fedd9dcfdeb5642085 by Michael Palimaka to branch master. Repository: kross Description --- Nothing references it, so remove it. Diffs - CMakeLists.txt 215d753bc1a86eab0aa875e20ba677a056c3bd95 Diff: https://git.reviewboard.kde.org/r/123630/diff/ Testing --- Builds, tests pass, inspected source and output binaries. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123630: Remove unused dependency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123630/ --- Review request for KDE Frameworks. Repository: kross Description --- Nothing references it, so remove it. Diffs - CMakeLists.txt 215d753bc1a86eab0aa875e20ba677a056c3bd95 Diff: https://git.reviewboard.kde.org/r/123630/diff/ Testing --- Builds, tests pass, inspected source and output binaries. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123265: Remove unused dependency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123265/ --- (Updated April 6, 2015, 1:50 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 6c27a4f33467b8da91243d2890a3e06f0823182f by Michael Palimaka to branch master. Repository: knotifyconfig Description --- It's no longer used since 3155bb05a88ea60b7d388231ffdfe9497773bf2e. Diffs - CMakeLists.txt 020a340beeb16cd71a1dda1ed6b1c20400c5c3c2 src/knotifyconfigelement.cpp 6f3f5d05b3bbb11e8b3a03a24c82432bf152fe05 Diff: https://git.reviewboard.kde.org/r/123265/diff/ Testing --- Inspected source, builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123265: Remove unused dependency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123265/ --- Review request for KDE Frameworks. Repository: knotifyconfig Description --- It's no longer used since 3155bb05a88ea60b7d388231ffdfe9497773bf2e. Diffs - CMakeLists.txt 020a340beeb16cd71a1dda1ed6b1c20400c5c3c2 src/knotifyconfigelement.cpp 6f3f5d05b3bbb11e8b3a03a24c82432bf152fe05 Diff: https://git.reviewboard.kde.org/r/123265/diff/ Testing --- Inspected source, builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Syncing ECM release number with KF5
On 04/04/15 19:44, David Faure wrote: > On Saturday 28 March 2015 05:49:01 Michael Palimaka wrote: >> On 28/03/15 03:48, Alex Merry wrote: >>> On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote: >>>> Hello, >>>> >>>> ECM release numbers are in sync with KF5 release numbers, except for the >>>> major component. >>>> >>>> This means that if you want to build the 5.x.y release you have to >>>> download >>>> the 1.x.y release of ECM. That doubles the complexity of your script >>>> which >>>> downloads the tarball to build it. >>>> >>>> That is bad and it is not necessary. >>>> >>>> Let's sync the major number for the next release. >>>> >>>> At some point the reason to make them out of sync was to be able to make >>>> ECM releases more frequently. That is very rare because KF5 releases are >>>> happening every month. If ECM needs to make an out of band release, it >>>> can use the 4th version number component. >>> >>> I have no particular objection, although I think "doubling the complexity" >>> of scripts is overstating things a little. >>> >>> Alex >> >> Is ECM actually part of KF5, or just happens to be released alongside >> it? (I thought the latter, hence the different version). > > The initial idea was "it' happens to be released alongside, when necessary". > > I.e. as a "marketing" message: you can use ECM without using KF5. > But, well, this modularity exists for the rest of KF5 too (you can use > KArchive without using KIO), so this would still be clear if the version > number was aligned. > > I also saw it as a way to not include it if it didn't change, but in practice > there's always at least one change every month, usually more ;) > >> FWIW the different version doesn't bother me at all as a downstream. > > And it doesn't bother me as the release dude - I have one if() in the version > file ;) (so, I also disagree with "doubles the complexity"). > > But since both Stephen Kelly and Alex Merry (maintainers of ECM) are in > favour > of switching, I'll make the switch. > Will ECM move from kdesupport to frameworks too? ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Syncing ECM release number with KF5
On 02/04/15 21:29, Stephen Kelly wrote: >> I have no particular objection, > > So, what needs to be done to get this synced up? Bump the version in > the CMakeLists.txt and update some release-tarball-creating script? > David I guess the latter is for you? > > Thanks, > > Steve. Can we at least find out why the versioning was different in the first place. It would be nice to know the reason before we change anything. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Syncing ECM release number with KF5
On 28/03/15 03:48, Alex Merry wrote: > On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote: >> Hello, >> >> ECM release numbers are in sync with KF5 release numbers, except for the >> major component. >> >> This means that if you want to build the 5.x.y release you have to download >> the 1.x.y release of ECM. That doubles the complexity of your script which >> downloads the tarball to build it. >> >> That is bad and it is not necessary. >> >> Let's sync the major number for the next release. >> >> At some point the reason to make them out of sync was to be able to make ECM >> releases more frequently. That is very rare because KF5 releases are >> happening every month. If ECM needs to make an out of band release, it can >> use the 4th version number component. > > I have no particular objection, although I think "doubling the complexity" of > scripts is overstating things a little. > > Alex Is ECM actually part of KF5, or just happens to be released alongside it? (I thought the latter, hence the different version). FWIW the different version doesn't bother me at all as a downstream. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122206: [kio] Make tests optional
> On March 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: > > I know this is merged already but this patch is being applied to every KDE > > package and I want to keep the discussion in a single place. > > > > We already have a toggle option in CMake that is "BUILD_TESTING". If Gentoo > > wants to not build the tests (I'm not judging if they should, let them be > > free to do it), they can just set BUILD_TESTING to OFF. I understand that > > CMake will still try to find Qt5Test and fail, but here is where I think we > > got it wrong: > > > > This patch does the following: > > if (Qt5Test is not found) > > BUILD_TESTING = OFF > > > > What I think this patch should be doing is this: > > if (BUILD_TESTING == OFF) > > Don't look for Qt5Test > > > > Did I miss something or this seems more reasonable to you guys as well? One of the original versions of these test patches looked something like: if (BUILD_TESTING) add_subdirectory(autotests) endif () with `find_package(Qt5Test)` inside the autotests directory. While this is used a bit in frameworks, it was rejected from a lot of plasma packages because it relies on a magic variable (although it is defined by ECM). As a result there's a whole range of approaches across frameworks/plasma/apps all doing the same thing. It would be nice if we could agree on something and be consistent. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review77603 --- On Feb. 7, 2015, 12:14 a.m., Andreas Sturmlechner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122206/ > --- > > (Updated Feb. 7, 2015, 12:14 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > --- > > [kio] Make tests optional > This is a small patch to CMakeLists.txt to only depend on Qt5Test if > BUILD_TESTING. > > > Diffs > - > > CMakeLists.txt c1ed03f6cac648517828aec60e896baf9fbcfd9d > > Diff: https://git.reviewboard.kde.org/r/122206/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sturmlechner > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122843: Remove redundant build interface.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122843/ --- (Updated March 6, 2015, 4:51 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdeclarative Description --- QuickAddons_BINARY_DIR was undefined causing -I/.. to be passed to the compiler, which can cause a build failure. Since the build interface is redundant, just remove it. Diffs - src/quickaddons/CMakeLists.txt 3c7a34b89a77e09221e2b44688a6bd9123f8aec5 Diff: https://git.reviewboard.kde.org/r/122843/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122843: Remove redundant build interface.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122843/ --- (Updated March 6, 2015, 4:44 p.m.) Review request for KDE Frameworks. Summary (updated) - Remove redundant build interface. Repository: kdeclarative Description (updated) --- QuickAddons_BINARY_DIR was undefined causing -I/.. to be passed to the compiler, which can cause a build failure. Since the build interface is redundant, just remove it. Diffs (updated) - src/quickaddons/CMakeLists.txt 3c7a34b89a77e09221e2b44688a6bd9123f8aec5 Diff: https://git.reviewboard.kde.org/r/122843/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122843: Mark QuickAddons as its own project.
> On March 6, 2015, 4:17 p.m., Aleix Pol Gonzalez wrote: > > src/quickaddons/CMakeLists.txt, line 22 > > <https://git.reviewboard.kde.org/r/122843/diff/1/?file=353379#file353379line22> > > > > Isn't this redundant, then? It builds fine with it removed. I don't know enough about it to comment otherwise. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122843/#review77117 ------- On March 6, 2015, 4:07 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122843/ > --- > > (Updated March 6, 2015, 4:07 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > Otherwise, QuickAddons_BINARY_DIR is undefined causing -I/.. to be passed to > the > compiler, which can cause a build failure. > > > Diffs > - > > src/quickaddons/CMakeLists.txt 3c7a34b89a77e09221e2b44688a6bd9123f8aec5 > > Diff: https://git.reviewboard.kde.org/r/122843/diff/ > > > Testing > --- > > > Thanks, > > Michael Palimaka > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122843: Mark QuickAddons as its own project.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122843/ --- Review request for KDE Frameworks. Repository: kdeclarative Description --- Otherwise, QuickAddons_BINARY_DIR is undefined causing -I/.. to be passed to the compiler, which can cause a build failure. Diffs - src/quickaddons/CMakeLists.txt 3c7a34b89a77e09221e2b44688a6bd9123f8aec5 Diff: https://git.reviewboard.kde.org/r/122843/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121773: Fix build without X.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/ --- (Updated Jan. 2, 2015, 2:03 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdesu Description --- This fixes breakage introduced by 5de62b90fdaece965876af8f991d48640f21 since HAVE_X11 is always defined (0 or 1), and reverts 163d9f1598596cfe8090f21c2562e25e64ad151b since it's just a workaround for OSX for the aforementioned breakage. Diffs - src/kdesud/kdesud.cpp 337e37a50b9d10ae8c0839f6d26e67de6a9418d9 Diff: https://git.reviewboard.kde.org/r/121773/diff/ Testing --- Build passes again, both with and without X. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121773: Fix build without X.
> On Dec. 31, 2014, 12:52 p.m., Jeremy Whiting wrote: > > src/kdesud/kdesud.cpp, line 76 > > <https://git.reviewboard.kde.org/r/121773/diff/1/?file=337535#file337535line76> > > > > Why not use if HAVE_X11 && !defined(Q_OS_MAC) to keep that fix in place? !defined(Q_OS_MAC) was only added after the incorrect logic defined(HAVE_X11) was introduced (because defined(HAVE_X11) is always true). HAVE_X11 will always be false on OSX since find_package(X11) always fails. This is consistent with the rest of kdesu, as well as other frameworks with optional X. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/#review72841 ------- On Dec. 31, 2014, 10:23 a.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121773/ > --- > > (Updated Dec. 31, 2014, 10:23 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdesu > > > Description > --- > > This fixes breakage introduced by 5de62b90fdaece965876af8f991d48640f21 > since HAVE_X11 is always defined (0 or 1), and reverts > 163d9f1598596cfe8090f21c2562e25e64ad151b > since it's just a workaround for OSX for the aforementioned breakage. > > > Diffs > - > > src/kdesud/kdesud.cpp 337e37a50b9d10ae8c0839f6d26e67de6a9418d9 > > Diff: https://git.reviewboard.kde.org/r/121773/diff/ > > > Testing > --- > > Build passes again, both with and without X. > > > Thanks, > > Michael Palimaka > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121773: Fix build without X.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/ --- Review request for KDE Frameworks. Repository: kdesu Description --- This fixes breakage introduced by 5de62b90fdaece965876af8f991d48640f21 since HAVE_X11 is always defined (0 or 1), and reverts 163d9f1598596cfe8090f21c2562e25e64ad151b since it's just a workaround for OSX for the aforementioned breakage. Diffs - src/kdesud/kdesud.cpp 337e37a50b9d10ae8c0839f6d26e67de6a9418d9 Diff: https://git.reviewboard.kde.org/r/121773/diff/ Testing --- Build passes again, both with and without X. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: qca-qt5 package name
On 17/12/14 22:47, Harald Sitter wrote: > alohas. > > recently the QCA maintainer and I got into a discussion [1] whether a > qca-qt5 library should be a different config inside the same cmake > package or an independent one (detailed discussion in the longest > comment thread of the review). > >> find_package(Qca NAMES Qca-qt5 Qca-QT5 Qca-5 Qca REQUIRES) > > or > >> find_package(Qca-qt5) > > former is very much in line with the maintainer's expectation of how > qca is supposed to have any odd suffix supplied by the distro [2] that > would eventually disappear, whereas my thinking in latter is that if > distros start shipping a suffixed version it is here to stay and > really should not be considered a configuration within the regular QCA > package. > > any thoughts on whether one is more desirable than the other? I am not > quite sure what one would generally consider proper here. > > [1] https://git.reviewboard.kde.org/r/121323/ > [2] https://git.reviewboard.kde.org/r/121168/ > > HS > The latter is consistent with many other libraries (eg. phonon) and is the best solution from a practical point of view. The maintainer's solution makes it very difficult for downstream as it requires every single consuming package in mixed Qt4/Qt5 system to be patched (as well as other reasons I won't rehash here). I believe a good compromise is to replace QCA_SUFFIX=whatever with some new option like QCA_QT5_SUFFIX which sets a static suffix. A common suffix will improve compatibility between distributions as well as make it easier for consuming applications that support both Qt4/Qt5 build. Plus, it's still in the spirit of the maintainer's preferred solution (prefix-based, optional, & easily removed in the future if/when Qt4 support is dropped). ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Split kde-baseapps?
Hi, Are there any plans to split frameworks-based kde-baseapps? Best regards, Michael ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119410: Document KDED dependency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119410/ --- (Updated July 23, 2014, 9:50 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- It looks like org.kde.kded5 is called via dbus in a few places, for example in src/widgets/jobuidelegate.cpp. If this is the case, it should be documented so we know to ensure it's available. Diffs - metainfo.yaml 102380eca8c77a34f4ab5c687a51952168b34225 Diff: https://git.reviewboard.kde.org/r/119410/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119410: Document KDED dependency.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119410/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- It looks like org.kde.kded5 is called via dbus in a few places, for example in src/widgets/jobuidelegate.cpp. If this is the case, it should be documented so we know to ensure it's available. Diffs - metainfo.yaml 102380eca8c77a34f4ab5c687a51952168b34225 Diff: https://git.reviewboard.kde.org/r/119410/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119198: Don't search default paths when finding lconvert.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/ --- (Updated July 13, 2014, 3:25 p.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one will be used instead of the one alongside Qt5::lrelease. This could cause Qt4 lconvert to be incorrectly used on some systems. Diffs - modules/ECMPoQmTools.cmake 3ce695817cb3da5ec9eebec86e632438c5941ee6 modules/ECMCreateQmFromPoFiles.cmake 4a31a93e7900780dc5b9424b148f19f5c22061af Diff: https://git.reviewboard.kde.org/r/119198/diff/ Testing --- When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119198: Don't search default paths when finding lconvert.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one will be used instead of the one alongside Qt5::lrelease. This could cause Qt4 lconvert to be incorrectly used on some systems. Diffs - modules/ECMPoQmTools.cmake 3ce695817cb3da5ec9eebec86e632438c5941ee6 modules/ECMCreateQmFromPoFiles.cmake 4a31a93e7900780dc5b9424b148f19f5c22061af Diff: https://git.reviewboard.kde.org/r/119198/diff/ Testing --- When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61923 --- Build is failing now when BUILD_EXAMPLES is turned on. - Michael Palimaka On July 7, 2014, 7:28 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119043/ > --- > > (Updated July 7, 2014, 7:28 p.m.) > > > Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and > Christophe Giboudeaux. > > > Repository: polkit-qt-1 > > > Description > --- > > added exported targets, simplify main CMakeLists... > > > Diffs > - > > CMakeLists.txt 021bf88 > PolkitQt-1Config.cmake.in 8b722a6 > agent/CMakeLists.txt f1ba438 > core/CMakeLists.txt e9b3ebb > gui/CMakeLists.txt 10b06ae > polkit-qt-1.pc.cmake 2f33204 > polkit-qt-agent-1.pc.cmake 6ccc6dd > polkit-qt-core-1.pc.cmake a9e0750 > polkit-qt-gui-1.pc.cmake 6b9c2cf > polkit-qt5-1.pc.cmake PRE-CREATION > polkit-qt5-agent-1.pc.cmake PRE-CREATION > polkit-qt5-core-1.pc.cmake PRE-CREATION > polkit-qt5-gui-1.pc.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119043/diff/ > > > Testing > --- > > builds, cmake files visually inspected, seem fine > > > Thanks, > > Hrvoje Senjan > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kcrash test failure
On 05/04/2014 06:48 PM, David Faure wrote: > On Monday 31 March 2014 17:21:44 Jonathan Riddell wrote: >> Anyone seen this test failure in kcrash? I only get it on i386 >> >> http://paste.kde.org/pccpojfwd > > Is this still an issue? The pastebin expired so I don't know what it was > about. > It is still failing here for me: * Start testing of KCrashTest * Config: Using QtTest library 5.2.1, Qt 5.2.1 PASS : KCrashTest::initTestCase() QDEBUG : KCrashTest::testAutoRestart() ""Qt Warning - invalid keysym: dead_actute" Could not find drkonqi at /usr/local/lib64/libexec/drkonqi QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-michael' KCrash: Attempting to start /home/michael/dev/kde/frameworks/kcrash/autotests/test_crasher from kdeinit Warning: connect() failed: : No such file or directory KCrash: Attempting to start /home/michael/dev/kde/frameworks/kcrash/autotests/test_crasher directly KCrash: crashing... crashRecursionCounter = 2 KCrash: Application Name = test_crasher path = /home/michael/dev/kde/frameworks/kcrash/autotests pid = 5026 KCrash: Arguments: /home/michael/dev/kde/frameworks/kcrash/autotests/test_crasher AR " FAIL! : KCrashTest::testAutoRestart() Compared values are not the same Actual (QString(logData)) : starting AR Expected (QString(expectedOutput)): starting AR autorestarted AR Loc: [/home/michael/dev/kde/frameworks/kcrash/autotests/kcrashtest.cpp(76)] ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/ --- (Updated April 26, 2014, 5:39 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kconfig Description --- Rename kreadconfig and kwriteconfig for coinstallability with kde-runtime4. There seems to be usage in only plasma-workspace that will require updating. Diffs - src/kreadconfig/CMakeLists.txt 434f33a1fb62c5429fe60c5cb4458a804cba7fdd src/kreadconfig/kreadconfig.cpp 3505ac3eca9d2ce2152801f29a87d8bf689ad6f1 Diff: https://git.reviewboard.kde.org/r/117792/diff/ Testing --- Builds, installs, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/ --- Review request for KDE Frameworks. Repository: kconfig Description --- Rename kreadconfig and kwriteconfig for coinstallability with kde-runtime4. There seems to be usage in only plasma-workspace that will require updating. Diffs - src/kreadconfig/CMakeLists.txt 434f33a1fb62c5429fe60c5cb4458a804cba7fdd src/kreadconfig/kreadconfig.cpp 3505ac3eca9d2ce2152801f29a87d8bf689ad6f1 Diff: https://git.reviewboard.kde.org/r/117792/diff/ Testing --- Builds, installs, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117602: Remove more UPnP stuff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/ --- (Updated April 25, 2014, 3:03 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Àlex Fiestas. Repository: solid Description --- Since the UPnP backend was removed, it looks like this other UPnP stuff can go too. Diffs - KF5SolidConfig.cmake.in a767f1963816a1f706ee6a4871f0ba95745b7151 cmake/FindHUpnp.cmake 8b34c2e8279c0cf21f2703e1cd5b22c3c35891dc src/solid/backends/fstab/fstabdevice.h cd8d92622ae35230cf9e90422a68260c1bab1bdb src/solid/config-solid.h.cmake 84d12604e0177d5af7108daf11b9b99be33468d5 src/solid/managerbase.cpp 66338125df7eb58fefb31c423b37258b9b96f1da src/solid/networkshare.h 6d8ab1e914d0f2fc570a48b4959aed99f3859c15 Diff: https://git.reviewboard.kde.org/r/117602/diff/ Testing --- Builds, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117599: Improve tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117599/ --- (Updated April 17, 2014, 4:27 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: plasma-framework Description --- Move some stray tests to the root directory in line with other tests. Diffs - src/plasmaquick/autotests/CMakeLists.txt 9a54d186359729fe37d0fe03c7faee1e478bf3af src/plasmaquick/CMakeLists.txt 0b43f9156f3b4c32ad0a7f9a1ffcb55ff29e1a9c src/declarativeimports/core/tests/sortfiltermodeltest.h src/declarativeimports/core/tests/sortfiltermodeltest.cpp f4f930c2ec3abffed4773e6f2340693117426dd5 src/declarativeimports/core/tests/modeltest.cpp src/declarativeimports/core/tests/modeltest.h src/declarativeimports/core/tests/manual/dialog_positioning.qml src/declarativeimports/core/tests/dynamictreemodel.cpp src/declarativeimports/core/tests/dynamictreemodel.h src/declarativeimports/core/tests/CMakeLists.txt 9fc9f894a4b8131f5870a839e892de6cf6e9026e src/declarativeimports/core/CMakeLists.txt 044e043cf980d54448495dbe4450b892907ecf39 autotests/CMakeLists.txt e5db1c5290f421da4606c9a0a0bc673fe61f94da CMakeLists.txt 3052efc471cfd6518f0c82148eb08409da56b6bf src/plasmaquick/autotests/packageurlinterceptortest.h src/plasmaquick/autotests/packageurlinterceptortest.cpp d39a89aaba811b1ab1045be2b5dbe0d279a39235 Diff: https://git.reviewboard.kde.org/r/117599/diff/ Testing --- Builds, tests still pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117602: Remove more UPnP stuff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: solid Description --- Since the UPnP backend was removed, it looks like this other UPnP stuff can go too. Diffs - KF5SolidConfig.cmake.in a767f1963816a1f706ee6a4871f0ba95745b7151 cmake/FindHUpnp.cmake 8b34c2e8279c0cf21f2703e1cd5b22c3c35891dc src/solid/backends/fstab/fstabdevice.h cd8d92622ae35230cf9e90422a68260c1bab1bdb src/solid/config-solid.h.cmake 84d12604e0177d5af7108daf11b9b99be33468d5 src/solid/managerbase.cpp 66338125df7eb58fefb31c423b37258b9b96f1da src/solid/networkshare.h 6d8ab1e914d0f2fc570a48b4959aed99f3859c15 Diff: https://git.reviewboard.kde.org/r/117602/diff/ Testing --- Builds, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117599: Improve tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117599/ --- Review request for KDE Frameworks. Repository: plasma-framework Description --- Move some stray tests to the root directory in line with other tests. Diffs - src/plasmaquick/autotests/CMakeLists.txt 9a54d186359729fe37d0fe03c7faee1e478bf3af src/plasmaquick/CMakeLists.txt 0b43f9156f3b4c32ad0a7f9a1ffcb55ff29e1a9c src/declarativeimports/core/tests/sortfiltermodeltest.h src/declarativeimports/core/tests/sortfiltermodeltest.cpp f4f930c2ec3abffed4773e6f2340693117426dd5 src/declarativeimports/core/tests/modeltest.cpp src/declarativeimports/core/tests/modeltest.h src/declarativeimports/core/tests/manual/dialog_positioning.qml src/declarativeimports/core/tests/dynamictreemodel.cpp src/declarativeimports/core/tests/dynamictreemodel.h src/declarativeimports/core/tests/CMakeLists.txt 9fc9f894a4b8131f5870a839e892de6cf6e9026e src/declarativeimports/core/CMakeLists.txt 044e043cf980d54448495dbe4450b892907ecf39 autotests/CMakeLists.txt e5db1c5290f421da4606c9a0a0bc673fe61f94da CMakeLists.txt 3052efc471cfd6518f0c82148eb08409da56b6bf src/plasmaquick/autotests/packageurlinterceptortest.h src/plasmaquick/autotests/packageurlinterceptortest.cpp d39a89aaba811b1ab1045be2b5dbe0d279a39235 Diff: https://git.reviewboard.kde.org/r/117599/diff/ Testing --- Builds, tests still pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kdeinit5 binary and man page in different repos
Hi, I noticed that kdeinit5 is in kinit, and its man page appears to be in kservice. I guess the man page should be moved, but I'm not sure of the best procedure with regards to preserving history etc. Best regards, Michael ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117391: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117391/ --- (Updated April 7, 2014, 3:43 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: plasma-framework Description --- Remove unused dependencies. Move two to examples/, since they are only required for that. Diffs - CMakeLists.txt a2793839d1dc8d698f8a5cca986533f5ba12f62f examples/CMakeLists.txt 99ef4cef9e03130356db82dc06b2797c14857c9c Diff: https://git.reviewboard.kde.org/r/117391/diff/ Testing --- Inspected source. Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117392: Rename kdebugdialog to avoid collision
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117392/ --- (Updated April 7, 2014, 2:40 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- Rename kdebugdialog to kdebugdialog5 to avoid collision with kde4libs-based kde-runtime. Diffs - src/kdebugdialog/CMakeLists.txt 9abc9bd7eb846f733d3d17d3760b7225a056a144 Diff: https://git.reviewboard.kde.org/r/117392/diff/ Testing --- Installs. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117392: Rename kdebugdialog to avoid collision
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117392/ --- Review request for KDE Frameworks. Repository: kde4support Description --- Rename kdebugdialog to kdebugdialog5 to avoid collision with kde4libs-based kde-runtime. Diffs - src/kdebugdialog/CMakeLists.txt 9abc9bd7eb846f733d3d17d3760b7225a056a144 Diff: https://git.reviewboard.kde.org/r/117392/diff/ Testing --- Installs. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117391: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117391/ --- Review request for KDE Frameworks. Repository: plasma-framework Description --- Remove unused dependencies. Move two to examples/, since they are only required for that. Diffs - CMakeLists.txt a2793839d1dc8d698f8a5cca986533f5ba12f62f examples/CMakeLists.txt 99ef4cef9e03130356db82dc06b2797c14857c9c Diff: https://git.reviewboard.kde.org/r/117391/diff/ Testing --- Inspected source. Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kcrash test failure
On 04/01/2014 03:21 AM, Jonathan Riddell wrote: > Anyone seen this test failure in kcrash? I only get it on i386 > > http://paste.kde.org/pccpojfwd > > Jonathan > I can reproduce consistently on amd64. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117190: Improve tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/ --- (Updated March 31, 2014, 2:52 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- Make it possible to avoid building tests. QtConcurrent is only required for tests. Diffs - CMakeLists.txt 71fe6d6158eaaba18ffc55d1489d9e9edc84a242 autotests/CMakeLists.txt 91e3db469cfa508be9659f0f977d03454a2144dd Diff: https://git.reviewboard.kde.org/r/117190/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117190: Improve tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/ --- Review request for KDE Frameworks. Repository: kde4support Description --- Make it possible to avoid building tests. QtConcurrent is only required for tests. Diffs - CMakeLists.txt 71fe6d6158eaaba18ffc55d1489d9e9edc84a242 autotests/CMakeLists.txt 91e3db469cfa508be9659f0f977d03454a2144dd Diff: https://git.reviewboard.kde.org/r/117190/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117146: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- (Updated March 30, 2014, 2:03 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- * Comment out xcb include, since its only usage is ifdefd out * Remove KF5 dependencies that are not used * The KF5::ItemViews link was only indirectly used to link against KIO, but that's fixed there now Diffs - CMakeLists.txt ef8bfede0b878b2c853a8cd17b0c36c997f5a9dc src/CMakeLists.txt f21e7ddfb20337337bef344f877ac8b8f68640fe src/kdeui/kglobalsettings.cpp 8de898639e4236659291fc2297dab312a0db7357 Diff: https://git.reviewboard.kde.org/r/117146/diff/ Testing --- Builds. Inspected source. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117146: Remove unused dependencies
> On March 29, 2014, 12:02 a.m., Aleix Pol Gonzalez wrote: > > src/kdeui/kglobalsettings.cpp, line 61 > > <https://git.reviewboard.kde.org/r/117146/diff/1/?file=258003#file258003line61> > > > > Why comment it? We either need it or don't need it... I did this so that it's "there but not there", like the ifdefd out code that was the xcb consumer. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/#review54518 ------- On March 28, 2014, 6:55 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117146/ > --- > > (Updated March 28, 2014, 6:55 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kde4support > > > Description > --- > > * Comment out xcb include, since its only usage is ifdefd out > * Remove KF5 dependencies that are not used > * The KF5::ItemViews link was only indirectly used to link against KIO, but > that's fixed there now > > > Diffs > - > > CMakeLists.txt ef8bfede0b878b2c853a8cd17b0c36c997f5a9dc > src/CMakeLists.txt f21e7ddfb20337337bef344f877ac8b8f68640fe > src/kdeui/kglobalsettings.cpp 8de898639e4236659291fc2297dab312a0db7357 > > Diff: https://git.reviewboard.kde.org/r/117146/diff/ > > > Testing > --- > > Builds. Inspected source. > > > Thanks, > > Michael Palimaka > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117146: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- Review request for KDE Frameworks. Repository: kde4support Description --- * Comment out xcb include, since its only usage is ifdefd out * Remove KF5 dependencies that are not used * The KF5::ItemViews link was only indirectly used to link against KIO, but that's fixed there now Diffs - CMakeLists.txt ef8bfede0b878b2c853a8cd17b0c36c997f5a9dc src/CMakeLists.txt f21e7ddfb20337337bef344f877ac8b8f68640fe src/kdeui/kglobalsettings.cpp 8de898639e4236659291fc2297dab312a0db7357 Diff: https://git.reviewboard.kde.org/r/117146/diff/ Testing --- Builds. Inspected source. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117145: Make ItemViews a public dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117145/ --- (Updated March 28, 2014, 6:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- It's required by kdirsortfilterproxymodel which is publicly available. Diffs - KF5KIOConfig.cmake.in f4395a1f461c9aee74d85baba7c81aab19a7fea5 src/filewidgets/CMakeLists.txt 680b48c9941ed23d818432fbdf8c9402976ba946 Diff: https://git.reviewboard.kde.org/r/117145/diff/ Testing --- kde4support builds against it without needing to explicitly try to link against ItemViews which is otherwise not needed there. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117145: Make ItemViews a public dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117145/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- It's required by kdirsortfilterproxymodel which is publicly available. Diffs - KF5KIOConfig.cmake.in f4395a1f461c9aee74d85baba7c81aab19a7fea5 src/filewidgets/CMakeLists.txt 680b48c9941ed23d818432fbdf8c9402976ba946 Diff: https://git.reviewboard.kde.org/r/117145/diff/ Testing --- kde4support builds against it without needing to explicitly try to link against ItemViews which is otherwise not needed there. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117135: Remove fake MIME types
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117135/ --- (Updated March 28, 2014, 3:02 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Michael Pyne. Repository: kcoreaddons Description --- These fake MIME types cause warnings when running update-mime-database. I would also add a porting notes entry under "KDECore changes" advising to change uri/foo -> x-scheme-handler/foo, all/allfiles -> application/octet-stream, & all/all -> application/octet-stream+inode/directory. Diffs - src/mimetypes/kde5.xml 778cf4e01c07c948b5c11bd9c3cdacd9edef8835 Diff: https://git.reviewboard.kde.org/r/117135/diff/ Testing --- I couldn't find left-over references to these MIME types in frameworks-ported stuff using lxr. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117135: Remove fake MIME types
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117135/ --- Review request for KDE Frameworks, David Faure and Michael Pyne. Repository: kcoreaddons Description --- These fake MIME types cause warnings when running update-mime-database. I would also add a porting notes entry under "KDECore changes" advising to change uri/foo -> x-scheme-handler/foo, all/allfiles -> application/octet-stream, & all/all -> application/octet-stream+inode/directory. Diffs - src/mimetypes/kde5.xml 778cf4e01c07c948b5c11bd9c3cdacd9edef8835 Diff: https://git.reviewboard.kde.org/r/117135/diff/ Testing --- I couldn't find left-over references to these MIME types in frameworks-ported stuff using lxr. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117019: Remove fake defaultMimetype entries from protocols files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117019/ --- (Updated March 28, 2014, 2:14 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- While looking into the issue, I turned up https://git.reviewboard.kde.org/r/101231/. So, this removes defaultMimetype entries referencing fake types which are apparently not actually required (I assume this is still true). Diffs - src/ioslaves/protocols/rtspu.protocol 9cc9299f6bbe9dedb3103ff0d08f1f495428754e src/ioslaves/protocols/rtspt.protocol 9e4fe96261e9e6477f2f61801928394678a38fb4 src/ioslaves/protocols/pnm.protocol 3ca3a7d23e961171caca0647ee2a23a2e3fba722 src/ioslaves/protocols/mmsu.protocol deda935fc51235be1fea0ff96ac6c5739759817c src/ioslaves/protocols/mmst.protocol 1f0f7636b7647b0853a10e50d51ecf4b33be441e src/ioslaves/protocols/mms.protocol 79599ead181c9e6ee90eca08f09a097caee98c21 Diff: https://git.reviewboard.kde.org/r/117019/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117019: Remove fake defaultMimetype entries from protocols files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117019/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- While looking into the issue, I turned up https://git.reviewboard.kde.org/r/101231/. So, this removes defaultMimetype entries referencing fake types which are apparently not actually required (I assume this is still true). Diffs - src/ioslaves/protocols/rtspu.protocol 9cc9299f6bbe9dedb3103ff0d08f1f495428754e src/ioslaves/protocols/rtspt.protocol 9e4fe96261e9e6477f2f61801928394678a38fb4 src/ioslaves/protocols/pnm.protocol 3ca3a7d23e961171caca0647ee2a23a2e3fba722 src/ioslaves/protocols/mmsu.protocol deda935fc51235be1fea0ff96ac6c5739759817c src/ioslaves/protocols/mmst.protocol 1f0f7636b7647b0853a10e50d51ecf4b33be441e src/ioslaves/protocols/mms.protocol 79599ead181c9e6ee90eca08f09a097caee98c21 Diff: https://git.reviewboard.kde.org/r/117019/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116957/ --- (Updated March 24, 2014, 9:48 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs - src/kio/kfiledialog.h ccf327fe78acf71918578bbb72578c83f7dacd92 tests/kfstest.cpp b85b5372afe6106568c26c73f1eab97bfa90c9ce Diff: https://git.reviewboard.kde.org/r/116957/diff/ Testing --- kfstest still behaves as expected. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116958: Update comment referencing fake MIME types
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116958/ --- (Updated March 24, 2014, 9:45 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kservice Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservicetypeprofile.h d14955d112e973d45a1387ee6db79b0c09949b23 Diff: https://git.reviewboard.kde.org/r/116958/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Unknown media types
On 03/16/2014 09:46 PM, David Faure wrote: > On Saturday 15 March 2014 19:24:08 Michael Palimaka wrote: >> Hi, >> >> kcoreaddons installs /usr/share/mime/packages/kde5.xml which causes the >> following warnings when update-mime-database is executed: >> >> Unknown media type in type 'all/all' >> Unknown media type in type 'all/allfiles' >> Unknown media type in type 'uri/mms' >> Unknown media type in type 'uri/mmst' >> Unknown media type in type 'uri/mmsu' >> Unknown media type in type 'uri/pnm' >> Unknown media type in type 'uri/rtspt' >> Unknown media type in type 'uri/rtspu' >> >> This has been around for a long time, but are they actually used by >> anything anymore and if not, is this a good opportunity to clean it up? > > The question comes up regularly, but it would be useful if you could actually > do some research on who uses these uri/ mimetypes. On the Ubuntu bug about this, I found a reference to the freedesktop spec[1] which suggests these should probably be x-scheme-handler/foo instead. Checking lxr, usage is: * matching oxygen-icons eg. /22x22/mimetypes/uri-mmst.png (and a script in calligra that checks against oxygen-icons) * kplayer * kio/src/ioslaves/protocols/foo.protocol * kde-dev-scripts list of what appears to be mime types renamed kde 3 -> 4 * Some old emerge stuff So, can we just change the kio .protocol files and document that on the porting notes? [1]: http://standards.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html#id2711002 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116961: Replace fake MIME type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116961/ --- (Updated March 22, 2014, 2:48 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. There are a few other references to "all/all", "all/allfiles", and "all/" in this repo. I didn't touch them since it wasn't suggested to do so on the mailing list post, and I'm not too familiar with this code. Diffs - src/filewidgets/kfilefiltercombo.cpp a800b38a50a4cb3c7b89928e09b6be9d8bc19ca0 Diff: https://git.reviewboard.kde.org/r/116961/diff/ Testing --- Played with some consumers of filewidgets which seems to behave normally, but again I'm not particularly familiar with what's happening here. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116961: Replace fake MIME type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116961/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. There are a few other references to "all/all", "all/allfiles", and "all/" in this repo. I didn't touch them since it wasn't suggested to do so on the mailing list post, and I'm not too familiar with this code. Diffs - src/filewidgets/kfilefiltercombo.cpp a800b38a50a4cb3c7b89928e09b6be9d8bc19ca0 Diff: https://git.reviewboard.kde.org/r/116961/diff/ Testing --- Played with some consumers of filewidgets which seems to behave normally, but again I'm not particularly familiar with what's happening here. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116958: Update comment referencing fake MIME types
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116958/ --- Review request for KDE Frameworks. Repository: kservice Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservicetypeprofile.h d14955d112e973d45a1387ee6db79b0c09949b23 Diff: https://git.reviewboard.kde.org/r/116958/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116957/ --- (Updated March 21, 2014, 5:05 p.m.) Review request for KDE Frameworks. Changes --- Update diff to include amending a comment. Repository: kde4support Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs (updated) - src/kio/kfiledialog.h ccf327fe78acf71918578bbb72578c83f7dacd92 tests/kfstest.cpp b85b5372afe6106568c26c73f1eab97bfa90c9ce Diff: https://git.reviewboard.kde.org/r/116957/diff/ Testing --- kfstest still behaves as expected. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116957/ --- Review request for KDE Frameworks. Repository: kde4support Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs - tests/kfstest.cpp b85b5372afe6106568c26c73f1eab97bfa90c9ce Diff: https://git.reviewboard.kde.org/r/116957/diff/ Testing --- kfstest still behaves as expected. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116899: Remove unused QtWidgets dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116899/ --- (Updated March 21, 2014, 2 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kinit Description --- It looks to be unused currently, so remove it. Diffs - CMakeLists.txt b5ec044da270bda4536d31e021d11f2a89c838d9 Diff: https://git.reviewboard.kde.org/r/116899/diff/ Testing --- Inspected source. A build test is difficult since some of kinit's dependencies have QtWidgets as a public dependency. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116899: Remove unused QtWidgets dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116899/ --- Review request for KDE Frameworks. Repository: kinit Description --- It looks to be unused currently, so remove it. Diffs - CMakeLists.txt b5ec044da270bda4536d31e021d11f2a89c838d9 Diff: https://git.reviewboard.kde.org/r/116899/diff/ Testing --- Inspected source. A build test is difficult since some of kinit's dependencies have QtWidgets as a public dependency. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Unknown media types
Hi, kcoreaddons installs /usr/share/mime/packages/kde5.xml which causes the following warnings when update-mime-database is executed: Unknown media type in type 'all/all' Unknown media type in type 'all/allfiles' Unknown media type in type 'uri/mms' Unknown media type in type 'uri/mmst' Unknown media type in type 'uri/mmsu' Unknown media type in type 'uri/pnm' Unknown media type in type 'uri/rtspt' Unknown media type in type 'uri/rtspu' This has been around for a long time, but are they actually used by anything anymore and if not, is this a good opportunity to clean it up? Best regards, Michael ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116079: Be more explicit with QFile include
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116079/ --- (Updated Feb. 26, 2014, 4:36 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and David Faure. Repository: kio Description --- global.h is a public header, so not being more explicit with includes could cause a build failure for consumers. This should probably go into kdelibs too. Diffs - src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159 Diff: https://git.reviewboard.kde.org/r/116079/diff/ Testing --- Builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDNSSD merge
On 02/27/2014 12:36 AM, Nicolas Lécureuil wrote: > Le mercredi 26 février 2014 11:54:16 Alex Merry a écrit : >> On 26/02/14 10:01, Alex Merry wrote: >>> Actually, having slept on it, my suggestion is: >>> >>> - rename kdnssd to zeroconf-ioslave >>> - rename kdnssd-framework to kdnssd >>> - merge the frameworks branch of zeroconf-ioslave into kio >> >> I don't think the last part is necessarily a blocker, either (although >> it's easy enough to do). As with the kde-runtime stuff, it's not really >> an issue if it gets delayed until 5.1. >> >> The repo name changes are going to be the painful parts. > > > Hi, > > as there is already a kdnssd tarball for kde 4, i think this would be safer > to > keep the -framework in the name. > > regards > Nicolas. > Note that we already had such a change made with kwallet. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116079: Be more explicit with QFile include
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116079/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- global.h is a public header, so not being more explicit with includes could cause a build failure for consumers. This should probably go into kdelibs too. Diffs - src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159 Diff: https://git.reviewboard.kde.org/r/116079/diff/ Testing --- Builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Runtime conflict with KF5Plasma and KDE 4 in same prefix
On 02/24/2014 05:41 AM, Martin Graesslin wrote: > On Monday 24 February 2014 05:33:37 Michael Palimaka wrote: >> Hi, >> >> I have run into a strange issue when KDE 4 and KF5Plasma are installed >> into the same prefix (I can reliably reproduce the issue by >> installing/uninstalling KF5Plasma and restarting KDE). >> >> Simply, the vertical bar key "|" does not work - it prints nothing. If I >> run xev from konsole it detects the keypress, but in any other >> application it is as if I never pressed the key at all. >> >> Any ideas? > > we hit this problem last week and figured out that it seems to be > kglobalacceld. Try killing the 5 variant and see whether it fixes it. > > Cheers > Martin I don't have any stuff from kde-runtime/frameworks currently, so the only kglobalaccel binary I have is from KDE 4. I have since been able to reproduce the issue manually by restarting kglobalaccel and manually launching plasma-shell (which apparently puts itself into xdg autostart?) which immediately crashes: QML debugging is enabled. Only use this in a safe environment. "Qt Warning - invalid keysym: dead_actute" Could not find drkonqi at /usr/lib64/kde5/libexec/drkonqi QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-michael' Added File "/home/michael/.config/plasmarc" NotExisting for "" ["KDirWatch-1"] Added Dir "/home/michael/.config" for "/home/michael/.config/plasmarc" [""] "default" Trying to open ksycoca from "/home/michael/.cache/ksycoca5" KServiceTypeTrader: serviceType "Plasma/LayoutTemplate" not found Failed to load the OSD script file from "" QQmlComponent: Component is not ready Error: file:///home/michael/foo/contents/loader.qml: File not found We have no shell handlers installed Application::crashHandler() called with signal 6; recent crashes: 1 KCrash: Application 'plasma-shell' crashing... Aborted ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Runtime conflict with KF5Plasma and KDE 4 in same prefix
Hi, I have run into a strange issue when KDE 4 and KF5Plasma are installed into the same prefix (I can reliably reproduce the issue by installing/uninstalling KF5Plasma and restarting KDE). Simply, the vertical bar key "|" does not work - it prints nothing. If I run xev from konsole it detects the keypress, but in any other application it is as if I never pressed the key at all. Any ideas? Best regards, Michael ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115909: Remove unused dependency from krunner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/ --- (Updated Feb. 22, 2014, 3:42 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: krunner Description --- There does not appear to be any actual KCompletion usage, so remove it. Diffs - src/runnercontext.cpp 8b7461459ead6ff8c18549531f1b5c9baf1df3fa CMakeLists.txt ebae16d0610c5c53aac34e9134db5d4b0e47903b src/CMakeLists.txt 0f8221fc175f51da32a5abcc96bdeca2c9b0e17b src/abstractrunner.h cee292812075db59c13703de37dc1e983c3d8968 src/runnercontext.h c6441b7a1bb92df5549d26f45183c1ff7ce157e6 Diff: https://git.reviewboard.kde.org/r/115909/diff/ Testing --- Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115485: Porting KTranscript from KJS to QtScript
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50535 --- If this is tier 1 now, please don't forget to update the wiki and the yaml file. - Michael Palimaka On Feb. 22, 2014, 2:15 p.m., Kevin Krammer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115485/ > --- > > (Updated Feb. 22, 2014, 2:15 p.m.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > --- > > Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a > tier1 framework. > Needs more testing and likely fixing > > > Diffs > - > > autotests/CMakeLists.txt c4d6b9b > src/CMakeLists.txt 9e3ce9f > src/ktranscript.cpp b9e0551 > CMakeLists.txt 06fb696 > > Diff: https://git.reviewboard.kde.org/r/115485/diff/ > > > Testing > --- > > Unittest runs, but the test script is very minimal and would need to be > extendedb by someone who understands the scripting requirements. > There is also a weird crash at test shutdown, in QThreadStorage. As far as I > can tell I did not change anything related to threads though. > > > Thanks, > > Kevin Krammer > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115863: Improve khtml dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/ --- (Updated Feb. 20, 2014, 3:47 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- - QtTest is only required for autotests - QtX11Extras is only required for X11 builds, and for tests - Remove KCrash, KDBusAddons, KGuiAddons, KInit, and KItemViews as they are not used Diffs - CMakeLists.txt 8ced64f9b80123e45c319357d829c45641ed9d4d autotests/CMakeLists.txt 33f1ecb7ba65f223baef242eb21cd34457b020da tests/CMakeLists.txt 8fc438fa932ec43492b6c2a8e5bc8f0337550d1a Diff: https://git.reviewboard.kde.org/r/115863/diff/ Testing --- Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115863: Improve khtml dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/ --- (Updated Feb. 20, 2014, 3:01 p.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Don't find dependencies that are used but not explicitly linked against. Adding the remaining dependencies and their explicit links can be for a future review request. Repository: khtml Description --- - QtTest is only required for autotests - QtX11Extras is only required for X11 builds, and for tests - Remove KCrash, KDBusAddons, KGuiAddons, KInit, and KItemViews as they are not used Diffs (updated) - CMakeLists.txt 8ced64f9b80123e45c319357d829c45641ed9d4d autotests/CMakeLists.txt 33f1ecb7ba65f223baef242eb21cd34457b020da tests/CMakeLists.txt 8fc438fa932ec43492b6c2a8e5bc8f0337550d1a Diff: https://git.reviewboard.kde.org/r/115863/diff/ Testing --- Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115909: Remove unused dependency from krunner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/ --- Review request for KDE Frameworks. Repository: krunner Description --- There does not appear to be any actual KCompletion usage, so remove it. Diffs - src/runnercontext.cpp 8b7461459ead6ff8c18549531f1b5c9baf1df3fa CMakeLists.txt ebae16d0610c5c53aac34e9134db5d4b0e47903b src/CMakeLists.txt 0f8221fc175f51da32a5abcc96bdeca2c9b0e17b src/abstractrunner.h cee292812075db59c13703de37dc1e983c3d8968 src/runnercontext.h c6441b7a1bb92df5549d26f45183c1ff7ce157e6 Diff: https://git.reviewboard.kde.org/r/115909/diff/ Testing --- Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115863: Improve khtml dependencies
> On Feb. 19, 2014, 3:21 p.m., Alex Merry wrote:
> > CMakeLists.txt, lines 23-32
> > <https://git.reviewboard.kde.org/r/115863/diff/1/?file=244733#file244733line23>
> >
> > KCompletion, KConfig[Widgets] and KCoreAddons are used, but never
> > linked against. So there's not much point searching for them: we're
> > already depending on them being bought in by other libraries.
>
> Michael Palimaka wrote:
> The listed frameworks are directly used. I don't see how linking or not
> makes a difference - khtml will fail to build without them. If we trust that
> one dependency will always bring in some other dependencies that we happen to
> also use, I am sure there are others we could remove too.
>
> Alex Merry wrote:
> Well, my view is that you can either find them and link against them
> (explicit dependencies), or not find or link against them (implicitly trust
> that the libraries you *do* link against bring them in). Finding them and
> not linking against them just seems a bit pointless.
>
> Michael Palimaka wrote:
> A dependency can still be explicit even though a binary link isn't
> required, for example:
>
> src/rendering/render_form.cpp:#include
> src/rendering/render_form.cpp:KService::List providers =
> KServiceTypeTrader::self()->query("SearchProvider");
> src/rendering/render_form.cpp:foreach (const KService::Ptr
> &provider, providers) {
>
> If you feel that strongly about it though, I'll drop those changes. They
> additions don't affect me at all, I just was aiming for a 'correct' change
> since I was touching this framework anyway.
>
> Alex Merry wrote:
> Yes, but this code won't work unless you link against KF5::Service,
> either explicitly or implicitly. If it's explicit, you should also have
> find_package(KF5Service). If it's implicit, you're depending on one of your
> explicit dependencies including KF5::Service in its link interface anyway, in
> which case that dependency will also pull in the KF5Service package.
>
> I mean, in the end it doesn't matter that much. I'm not going to say
> "don't ship it unless you do this". But I think that searching for packages
> in CMake and then not making any use of those packages in CMake (even if it
> doesn't make any difference to whether the package is required) just clutters
> things up unnecessarily.
>
> Michael Palimaka wrote:
> Sorry, I just realised I misunderstood your original comment. The final
> product does actually link to KCompletion etc. but indeed they are not
> explicitly marked that way. I guess for the case of KCompletion the link is
> happening anyway because it is a public dependency of KTextWidgets.
>
> Alex Merry wrote:
> Yes, that's exactly it. Sorry for not being clearer.
So, should the explicit link be added, or just forget about it for now? :-)
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115863/#review50260
---
On Feb. 18, 2014, 8:01 a.m., Michael Palimaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115863/
> ---
>
> (Updated Feb. 18, 2014, 8:01 a.m.)
>
>
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: khtml
>
>
> Description
> ---
>
> - QtTest is only required for autotests
> - QtX11Extras is only required for X11 builds, and for tests
> - Remove KCrash, KDBusAddons, KGuiAddons, KInit, and KItemViews as they are
> not used
>
>
> Diffs
> -
>
> CMakeLists.txt 3a3dbab90e6572cf953ba5edc1fcb60a7e30b493
> autotests/CMakeLists.txt 33f1ecb7ba65f223baef242eb21cd34457b020da
> tests/CMakeLists.txt 8fc438fa932ec43492b6c2a8e5bc8f0337550d1a
>
> Diff: https://git.reviewboard.kde.org/r/115863/diff/
>
>
> Testing
> ---
>
> Builds. Tests pass.
>
>
> Thanks,
>
> Michael Palimaka
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
