D18379: Add tools icon

2019-01-19 Thread Root 
rooty added a comment.


  nice, +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18379

To: ndavis, #vdg
Cc: rooty, kde-frameworks-devel, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-08 Thread Root 
rooty updated this revision to Diff 49041.
rooty added a comment.


  Fix blunder and bring back search field, place "Search..." in search field

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18046?vs=48876=49041

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18046

AFFECTED FILES
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchlinewidget.cpp

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root 
rooty added inline comments.

INLINE COMMENTS

> pino wrote in kpluginselector.cpp:261
> a) explicit is better than implicit
> b) "shorter" makes sense only when thinking for English, not for other 
> languages

a) not always - there's very little nuance here, and there's nothing to be 
gained by adding the word plugins (except for reinforcing that the word is a 
verb and that it's transitive), that's why we don't use "Type to"... besides, 
if we did make it explicit, we'd have to use "Search applications, places, 
actions etc." in kicker, "Search clipboard contents" in clipboard etc.

b) "search" is a simpler and far less restrictive idea than "search plugins" in 
whatever language we're talking about or in, it's a single idea that doesn't 
call for a direct object and doubles as a noun (検索, Suche, Busca etc.)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root 
rooty added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root 
rooty added inline comments.

INLINE COMMENTS

> pino wrote in kpluginselector.cpp:261
> why not "Search plugins..."?

i think it's because it's self-evident (and shorter)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root 
rooty added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root 
rooty added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18045

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root 
rooty added reviewers: VDG, Plasma, kde-frameworks-devel.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root 
rooty added reviewers: VDG, Plasma, kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18045

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root 
rooty added reviewers: VDG, Plasma, kde-frameworks-devel.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root 
rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch removes the "Search:" portion of Activities (in System Settings, 
Desktop Behavior --> Workspace) and adds "Search..." to the search field.

REPOSITORY
  R276 KItemViews

BRANCH
  kitemviews-searchellipsis (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18046

AFFECTED FILES
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchlinewidget.cpp

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root 
rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch adds the ellipsis to the search label of the Cookies section of 
Network --> Settings.

REPOSITORY
  R241 KIO

BRANCH
  kio-searchellipsis (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18045

AFFECTED FILES
  src/kcms/kio/kcookiespolicies.ui

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root 
rooty added a comment.


  In D18043#388194 , @shubham wrote:
  
  > I don't think so, next time when you can push this type of change 
(ellipsis) directly, there is a task about it if you know.
  
  
  Cool!

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty
Cc: shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root 
rooty added a comment.


  In D18043#388191 , @shubham wrote:
  
  > +1
  
  
  hey i ... accidentally ran arc diff without arc feature? is that a problem?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty
Cc: shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root 
rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch adds an ellipsis to the search labels in KPluginSelector (and the 
elements that call for it, e.g. KWin Scripts).

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18043

AFFECTED FILES
  src/kpluginselector.cpp

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Root 
rooty added a comment.


  In D17906#388052 , @mart wrote:
  
  > can we still keep as light the first level of heading, which is huge (and 
use that sparsingly) and go to levels from 2 onwards where needed smaller and 
bigger?
  
  
  nope, very much against this idea... it //might// work if we used segoe ui, 
but that's about the only instance in which it would

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D17924: Better plasma-media-center icon

2019-01-03 Thread Root 
rooty added a comment.


  +1 loving the new icon

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17924

To: GB_2, #breeze, #vdg
Cc: rooty, ngraham, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-02 Thread Root 
rooty added a dependent revision: D17916: [Login and lock screens] Do not use 
light font styles for the sddm clock.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: cfeck, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17905: [frameworks] Do not use light font styles for headings (1/3)

2019-01-02 Thread Root 
rooty added a dependent revision: D17916: [Login and lock screens] Do not use 
light font styles for the sddm clock.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-02 Thread Root 
rooty added a dependent revision: D17916: [Login and lock screens] Do not use 
light font styles for the sddm clock.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty updated this revision to Diff 48502.
rooty added a comment.


  Removed empty line (formerly line 242)

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17907?vs=48497=48502

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17907

AFFECTED FILES
  src/ktitlewidget.cpp

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: cfeck, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty edited the summary of this revision.
rooty edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty edited reviewers, added: VDG, Plasma; removed: cfeck.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, #frameworks, #vdg, #plasma, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty retitled this revision from "[frameworks] Do not use light font styles 
for headings (3/3)" to "[KWidgetsAddons] Do not use light font styles for 
headings (3/3)".
rooty edited reviewers, added: Frameworks; removed: kde-frameworks-devel.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, cfeck, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [frameworks] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, cfeck, kde-frameworks-devel
Cc: michaelh, ngraham, bruns

D17905: [frameworks] Don't use light font styles for headings (1/3)

2019-01-01 Thread Root 
rooty added a dependent revision: D17907: [frameworks] Do not use light font 
styles for headings (3/3).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [frameworks] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, cfeck, kde-frameworks-devel
Cc: michaelh, ngraham, bruns

D17907: [frameworks] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty added dependencies: D17906: [kirigami] Don't use light font styles for 
headings (2/3), D17905: [frameworks] Don't use light font styles for headings 
(1/3).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, cfeck, kde-frameworks-devel
Cc: michaelh, ngraham, bruns

D17907: [frameworks] Do not use light font styles for headings (3/3)

2019-01-01 Thread Root 
rooty created this revision.
rooty added reviewers: ngraham, cfeck, kde-frameworks-devel.
Herald added a project: Frameworks.
rooty requested review of this revision.

REVISION SUMMARY
  This patch brings back regular font styles for headings to KTitleWidget for 
the sake of consistency with QML,
  where they were also reintroduced in favor of better legibility.
  
  BUG: 402730
  
  FIXED-IN: 5.54

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17907

AFFECTED FILES
  src/ktitlewidget.cpp

To: rooty, ngraham, cfeck, kde-frameworks-devel
Cc: michaelh, ngraham, bruns

D17623: Add YaST and new preference icons

2018-12-29 Thread Root 
rooty added a comment.


  +1 for the icons, really nice icons

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: rooty, sitter, fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns