D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-18 Thread Tien Do Nam 
tienisto marked 2 inline comments as done.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-18 Thread Tien Do Nam 
tienisto added a comment.


  In D24746#549960 , @ngraham wrote:
  
  > [...]
  >  If we improve the properties dialog for disks in general, that will also 
improve the display for other kinds of disks and mounted volumes.
  >  What do you think?
  
  
  I like this idea. However this is exceeds my skill set :)

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-18 Thread Tien Do Nam 
tienisto edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-18 Thread Tien Do Nam 
tienisto updated this revision to Diff 68263.
tienisto added a comment.


  show 'Mounted on' again

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24746?vs=68228=68263

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-18 Thread Tien Do Nam 
tienisto added a comment.


  In D24746#549637 , @meven wrote:
  
  > I would suggest keeping "Location" and "Mounted on" fields to actually 
display '/' to the user.
  
  
  To me users should know that / is the root folder and has the highest level 
in the directory structure. And that the location of '/' is '/' is quite 
confusing.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-18 Thread Tien Do Nam 
tienisto marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-18 Thread Tien Do Nam 
tienisto updated this revision to Diff 68228.
tienisto added a comment.


  use 'Unknown' instead of 'unknown'

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24746?vs=68206=68228

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-17 Thread Tien Do Nam 
tienisto edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-17 Thread Tien Do Nam 
tienisto updated this revision to Diff 68206.
tienisto added a comment.


  use root folder icon

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24746?vs=68205=68206

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-17 Thread Tien Do Nam 
tienisto updated this revision to Diff 68205.
tienisto added a comment.


  cleanup

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24746?vs=68199=68205

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-17 Thread Tien Do Nam 
tienisto added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kpropertiesdialog.cpp:1172
> Probably not so obvious for new Linux users; especially those coming from 
> windows where things are represented as C:\, D:\ ... etc.

I think new linux users don't even know what mounting means :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-17 Thread Tien Do Nam 
tienisto edited the summary of this revision.
tienisto added a reviewer: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

2019-10-17 Thread Tien Do Nam 
tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tienisto requested review of this revision.

REVISION SUMMARY
  special ui changes if root directory is selected

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23969: [kpropertiesdialog] add icons for the size section

2019-09-15 Thread Tien Do Nam 
tienisto retitled this revision from "add icons for kpropertiesdialog" to 
"[kpropertiesdialog] add icons for the size section".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23969

To: tienisto, #vdg, ngraham
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23969: add icons for kpropertiesdialog

2019-09-15 Thread Tien Do Nam 
tienisto edited the summary of this revision.
tienisto added a reviewer: ngraham.
tienisto added projects: Dolphin, VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23969

To: tienisto, #vdg, ngraham
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23969: add icons for kpropertiesdialog

2019-09-15 Thread Tien Do Nam 
tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tienisto requested review of this revision.

REVISION SUMMARY
  add icons for two buttons in the "size" section

TEST PLAN
  Open properties of a folder and see those icons under "General/size"

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23969

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns