Re: Review Request 117624: Make documentation generation python3 compatible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117624/ --- (Updated April 18, 2014, 8:58 a.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Add simple changes to the documentation generation scripts to make them compatible with python3. Diffs - docs/sphinx/conf.py.in 24ba82c817b150784d0179be899402660d91a362 docs/sphinx/ecm.py 9b76e1a9bf20aba358bf62f75b7e21277e0c9c9c Diff: https://git.reviewboard.kde.org/r/117624/diff/ Testing --- Documentation built successfully with python3.3 and python2.7. Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117624: Make documentation generation python3 compatible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117624/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Add simple changes to the documentation generation scripts to make them compatible with python3. Diffs - docs/sphinx/conf.py.in 24ba82c817b150784d0179be899402660d91a362 docs/sphinx/ecm.py 9b76e1a9bf20aba358bf62f75b7e21277e0c9c9c Diff: https://git.reviewboard.kde.org/r/117624/diff/ Testing --- Documentation built successfully with python3.3 and python2.7. Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ --- (Updated Jan. 17, 2014, 7:59 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- Declare the correct Qt version the pkg-config file. Qt4 is called QtCore whereas Qt5 is called Qt5Core. Declaring QtCore when building with Qt5 will either link to Qt4 when both are installed and a project depending on QCA is resolving dependencies via pkg-config or will fail because of missing dependencies if Qt4 is not installed. Diffs - CMakeLists.txt 87b0702 qca2.pc.cmake 22004cc Diff: https://git.reviewboard.kde.org/r/115050/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ --- (Updated Jan. 17, 2014, 1:03 a.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Move set(QCA_QT_PC_VERSION "QtCore") to else(Qt5Core_FOUND). Repository: qca Description --- Declare the correct Qt version the pkg-config file. Qt4 is called QtCore whereas Qt5 is called Qt5Core. Declaring QtCore when building with Qt5 will either link to Qt4 when both are installed and a project depending on QCA is resolving dependencies via pkg-config or will fail because of missing dependencies if Qt4 is not installed. Diffs (updated) - CMakeLists.txt 87b0702 qca2.pc.cmake 22004cc Diff: https://git.reviewboard.kde.org/r/115050/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115050: Declare the correct Qt version in QCA pkg-config file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ --- Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- Declare the correct Qt version the pkg-config file. Qt4 is called QtCore whereas Qt5 is called Qt5Core. Declaring QtCore when building with Qt5 will either link to Qt4 when both are installed and a project depending on QCA is resolving dependencies via pkg-config or will fail because of missing dependencies if Qt4 is not installed. Diffs - CMakeLists.txt 87b0702 qca2.pc.cmake 22004cc Diff: https://git.reviewboard.kde.org/r/115050/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112874: Allow disabling of QCA plugins during build.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Nov. 13, 2013, 1:17 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo. Diffs - CMakeLists.txt bdb77b4 INSTALL cf847a0 plugins/CMakeLists.txt 6e8a7a2 plugins/qca-botan/CMakeLists.txt 1b9607c plugins/qca-cyrus-sasl/CMakeLists.txt b36cbcf plugins/qca-gcrypt/CMakeLists.txt f5c73bd plugins/qca-gnupg/CMakeLists.txt 7f46abf plugins/qca-nss/CMakeLists.txt 805567d plugins/qca-ossl/CMakeLists.txt 6b5c69c plugins/qca-pkcs11/CMakeLists.txt b220926 plugins/qca-wincrypto/CMakeLists.txt c0ab378 Diff: http://git.reviewboard.kde.org/r/112874/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112874: Allow disabling of QCA plugins during build.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Oct. 13, 2013, 2:06 p.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Replaced option with correct set > Also cmake must be fail if BUILD_PLUGINS it not 'all' and some plugin can't > be built. It fails, e.g. when botan headers are missing https://gist.github.com/xhochy/4340e8ff0e79c6419833 Repository: qca Description --- Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo. Diffs (updated) - CMakeLists.txt bdb77b4 INSTALL cf847a0 plugins/CMakeLists.txt 6e8a7a2 plugins/qca-botan/CMakeLists.txt 1b9607c plugins/qca-cyrus-sasl/CMakeLists.txt b36cbcf plugins/qca-gcrypt/CMakeLists.txt f5c73bd plugins/qca-gnupg/CMakeLists.txt 7f46abf plugins/qca-nss/CMakeLists.txt 805567d plugins/qca-ossl/CMakeLists.txt 6b5c69c plugins/qca-pkcs11/CMakeLists.txt b220926 plugins/qca-wincrypto/CMakeLists.txt c0ab378 Diff: http://git.reviewboard.kde.org/r/112874/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112874: Allow disabling of QCA plugins during build.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Oct. 13, 2013, 11:32 a.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Add "all" as a value for BUILD_PLUGINS to specify to build all known plugins. If plugin is not listed in the list of available plugins, CMake will complain about it. Add a brief description of BUILD_PLUGINS to README. (If a plugin can't be compiled because of missing dependencies, cmake will fail with an error message) Repository: qca Description --- Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo. Diffs (updated) - CMakeLists.txt bdb77b4 INSTALL cf847a0 plugins/CMakeLists.txt 6e8a7a2 plugins/qca-botan/CMakeLists.txt 1b9607c plugins/qca-cyrus-sasl/CMakeLists.txt b36cbcf plugins/qca-gcrypt/CMakeLists.txt f5c73bd plugins/qca-gnupg/CMakeLists.txt 7f46abf plugins/qca-nss/CMakeLists.txt 805567d plugins/qca-ossl/CMakeLists.txt 6b5c69c plugins/qca-pkcs11/CMakeLists.txt b220926 plugins/qca-wincrypto/CMakeLists.txt c0ab378 Diff: http://git.reviewboard.kde.org/r/112874/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112874: Allow disabling of QCA plugins during build.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Sept. 28, 2013, 1:15 p.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Proposal #3: Like in your comment, I made it accept a list, so that the usage changes to cmake ../../qca '-DBUILD_PLUGINS=logger;softstore;ossl;pkcs11;botan;gnupg;cyrus-sasl;gcrypt;nss' (Sorry for uploading 3 diffs at once but I do not know how to better upload 3 alternative patches to reviewboard) Description --- Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo. Diffs (updated) - plugins/CMakeLists.txt eed741e plugins/qca-botan/CMakeLists.txt 1b9607c plugins/qca-cyrus-sasl/CMakeLists.txt b36cbcf plugins/qca-gcrypt/CMakeLists.txt f5c73bd plugins/qca-gnupg/CMakeLists.txt 7f46abf plugins/qca-nss/CMakeLists.txt 805567d plugins/qca-ossl/CMakeLists.txt 6b5c69c plugins/qca-pkcs11/CMakeLists.txt b220926 plugins/qca-wincrypto/CMakeLists.txt c0ab378 Diff: http://git.reviewboard.kde.org/r/112874/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112874: Allow disabling of QCA plugins during build.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Sept. 28, 2013, 1:11 p.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Proposal #2: Use ECMOptionalAddSubdirectory from extra-cmake-modules for calling cmake like this: cmake -DDISABLE_ALL_OPTIONAL_SUBDIRECTORIES=TRUE -DBUILD_ossl=TRUE Description --- Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo. Diffs (updated) - cmake/modules/ECMOptionalAddSubdirectory.cmake PRE-CREATION plugins/CMakeLists.txt eed741e Diff: http://git.reviewboard.kde.org/r/112874/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112874: Allow disabling of QCA plugins during build.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- (Updated Sept. 28, 2013, 1:10 p.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Proposal #1: For each plugin, create an option to enable it. Description --- Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo. Diffs (updated) - plugins/CMakeLists.txt eed741e Diff: http://git.reviewboard.kde.org/r/112874/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112874: Allow disabling of QCA plugins during build.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112874/ --- Review request for KDE Frameworks and Ivan Romanov. Description --- Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo. Diffs - plugins/CMakeLists.txt eed741e Diff: http://git.reviewboard.kde.org/r/112874/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
