D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:c2e0be30f87f: Use bold italic at 100% for sect4 titles, 
and bold 100% for sect5 titles (authored by yurchor).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28304?vs=78544=78545

REVISION DETAIL
  https://phabricator.kde.org/D28304

AFFECTED FILES
  common/en/kde-docs.css

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Yuri Chornoivan]

yurchor updated this revision to Diff 78544.
yurchor added a comment.


  Fixed definitions as suggested.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28304?vs=78537=78544

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28304

AFFECTED FILES
  common/en/kde-docs.css

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D28304

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Yuri Chornoivan]

yurchor created this revision.
yurchor added reviewers: Documentation, danders.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  Now the titles are small and hard to distinguish.
  
  BUG: 419256

TEST PLAN
  Replace kde-docs.css in your system to see the results.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28304

AFFECTED FILES
  common/en/kde-docs.css

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D27185: Use the right translation catalog to show translations

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:8f382ef18606: Use the right translation catalog to show 
translations (authored by yurchor).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27185?vs=75082=75214#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27185?vs=75082=75214

REVISION DETAIL
  https://phabricator.kde.org/D27185

AFFECTED FILES
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: yurchor, #frameworks, #localization, davidedmundson
Cc: davidedmundson, victorr, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27185: Use the right translation catalog to show translations

[Yuri Chornoivan]

yurchor added a reviewer: Localization.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27185

To: yurchor, #frameworks, #localization
Cc: victorr, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27185: Use the right translation catalog to show translations

[Yuri Chornoivan]

yurchor created this revision.
yurchor added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  Now translations for QML are not shown. Patch by Victor Ryzhykh

TEST PLAN
  Run the new KNewStuff window using some locale (pt, uk, sv, etc.)

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27185

AFFECTED FILES
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: yurchor, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> dfaure wrote in kfileplacesmodel.cpp:275
> This is more commonly written as "static const"

This does not work. Our translation system cannot extract from something like

I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop"))

all the strings below with I18NC_NOOP should be left as is. Thanks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24349

To: ahmadsamir, dfaure, #frameworks
Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25530: Sonnet: Add locales that are missing in QLocale

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> loader.cpp:255
> +{QLatin1String("cv"),  {QStringLiteral("Чӑвашла"),   
> QString()}},  //Chuvash
> +{QLatin1String("cv_RU"),   {QStringLiteral("Чӑвашла"),   
> QStringLiteral("Росси́я")}},
> +{QLatin1String("grc"), {QStringLiteral("Αρχαία Ελληνικά"),   
> QString()}},  //Ancient Greek

This should be "Россия" (without the accent).

> loader.cpp:261
> +{QLatin1String("koi"), {QStringLiteral("коми"),  
> QString()}},  //Komi
> +{QLatin1String("koi_RU"),  {QStringLiteral("коми"),  
> QStringLiteral("Росси́я")}},
> +{QLatin1String("lb"),  {QStringLiteral("Lëtzebuergesch"),
> QString()}},  //Luxembourgish

Same here

> loader.cpp:273
> +{QLatin1String("udm"), {QStringLiteral("удмурт"),
> QString()}},  //Udmurt
> +{QLatin1String("udm_RU"),  {QStringLiteral("удмурт"),
> QStringLiteral("Росси́я")}},
> +};

Same here

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new Template for KCM's.

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> main.qml:37
> +QQC2.Label {
> +text: i18n("Exemple KCM that does nothing")
> +}

Typo: Exemple -> Example

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava
Cc: yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D23465: Add new non standard mime type for ROOT cern files

[Yuri Chornoivan]

yurchor added a comment.


  In D23465#519576 , @alexde wrote:
  
  > In D23465#519544 , @ltoscano 
wrote:
  >
  > > The idea is good, but it should be proposed to shared-mime-info 
repository instead. As far as I remember from the previous discussions, this 
file is meant to contain a limited number of entities and possibiy disappear 
over time.
  >
  >
  >
  >
  > In D23450#519519 , @yurchor 
wrote:
  >
  > > Personally, I like these icons and they can be easily used on the system 
(shared-mime-info) or KDE level (kcoreaddons) level with very minor patching, 
imho.
  >
  >
  > Thank you for your answers. Due to lack of experience and limited amount of 
time on my side, can you please guide, how I accomplish this surely trivial 
task?
  >  Do I only need to open a modified PR against 
https://gitlab.freedesktop.org/xdg/shared-mime-info/blob/master/freedesktop.org.xml.in?
  
  
  Yes. The maintainers of shared-mime-info will tell you if the type is right 
(I think, that it would be better to use , 
similar to PDF, but I might be wrong).
  
  > After that I can abandon this merge request again here?
  
  If the MR on freedesktop will be merged, yes.
  
  >   Do I need to change the naming of the icons again, [[ 
https://phabricator.kde.org/D23464 | which I commited today ]] or do I need to 
submit them to freedesktop as well? :-)
  
  It depends on what type will be recommended by shared-mime-info maintainers. 
No, there is no sense to submit icons to shared-mime-info. The icons should be 
reviewed here by our VDG team but their names should be chosen according to the 
type in shared-mime-info package.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23465

To: alexde, #vdg
Cc: yurchor, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23450: Icons for ROOT cern files.

[Yuri Chornoivan]

yurchor added a comment.


  Just a side note.
  
  Personally, I like these icons and they can be easily used on the system 
(shared-mime-info) or KDE level (kcoreaddons) level with very minor patching, 
imho.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23450

To: alexde, #vdg, ngraham, ndavis
Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23450: Icons for ROOT cern files.

[Yuri Chornoivan]

yurchor added a comment.


  In D23450#519095 , @alexde wrote:
  
  > For some reason if I try to set the icons for ".root" files, they are shown 
in the dialog box, the icon can be set, but they are not shown in Dolphin. Has 
anyone an idea what I am doing wrong?
  
  
  It seems that there is no such MIME type yet. It should be added as something 
like "application/root" (icons should be renamed too, e.g. 
application-root.svg) here
  
  
https://gitlab.freedesktop.org/xdg/shared-mime-info/blob/master/freedesktop.org.xml.in
  
  or here
  
  https://cgit.kde.org/kcoreaddons.git/tree/src/mimetypes/kde5.xml

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23450

To: alexde, #vdg, ngraham, ndavis
Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> asemke wrote in kxmlgui_unittest.cpp:1089
> there is no declension in Russian for the nominative case. The name of the 
> month is январь and not января, but it is первого января (on January 1st) and 
> not первого январь.
> 
> https://doc.qt.io/qt-5/qlocale.html#monthName - QLocale must return the name 
> of the month, meaning the nominative case  and not one of its declensions.

AFAIK this is broken on Qt level. Cf. calendar widget in KOrganizer (Ukrainian)

F7273188: cal.png 

https://bugs.kde.org/show_bug.cgi?id=256952

There are new specifiers for the primary and alternative month names in glibc 
but Qt does not implement them (must be something like " " instead of 
" " in formatting). Rafal Luzynski (the author of the glibc patch) in a 
private message (2018-01-25) promised me to send the patch for Qt but this has 
not happened yet.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: yurchor, apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:f0bdbcbf982f: Add FictionBook 2 icons (authored by 
yurchor).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64286=64328

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/22/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/32/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/64/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/64/application-x-zip-compressed-fb2.svg
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor updated this revision to Diff 64286.
yurchor added a comment.


  Use black "fb" for 32px and 64px breeze-dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64281=64286

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/22/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/32/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/64/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/64/application-x-zip-compressed-fb2.svg
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor updated this revision to Diff 64281.
yurchor added a comment.


  Realign 32px versions, replace 16px and 22px with icons proposed by Noah 
Davis, add dark versions

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64236=64281

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/22/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/32/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons-dark/mimetypes/64/application-x-fictionbook+xml.svg
  icons-dark/mimetypes/64/application-x-zip-compressed-fb2.svg
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor reclaimed this revision.
yurchor added a comment.
This revision now requires changes to proceed.


  Unexpected free time.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor abandoned this revision.
yurchor added a comment.


  I have no time to redo this now. Sorry.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor updated this revision to Diff 64236.
yurchor added a comment.


  Optimize SVG with svgcleaner + svgo

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64212=64236

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor updated this revision to Diff 64212.
yurchor added a comment.


  Use blue background

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64206=64212

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor updated this revision to Diff 64206.
yurchor added a comment.


  Total unbrutalization

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64186=64206

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor updated this revision to Diff 64186.
yurchor added a comment.


  Be consistent with existing book-style icons.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64152=64186

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor updated this revision to Diff 64152.
yurchor added a comment.


  Remove extra font dependencies

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64148=64152

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor created this revision.
yurchor added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  FictionBook 2 icons from Okular (design by Vladimir Prohorenkov, my 
implementation).

TEST PLAN
  See the image attached.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22521: Fix a mistake with "Pb"

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R292:dce763feb436: Fix minor typos (authored by yurchor).

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22521?vs=61949=61955

REVISION DETAIL
  https://phabricator.kde.org/D22521

AFFECTED FILES
  src/binary_data.cpp

To: ppeter, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a6a153629ecc: Add an icon for Thunderbolt KCM (authored 
by yurchor).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20672?vs=56598=56599

REVISION DETAIL
  https://phabricator.kde.org/D20672

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-thunderbolt.svg
  icons/preferences/32/preferences-desktop-thunderbolt.svg

To: yurchor, #vdg, ndavis, ngraham
Cc: abetts, ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor added a comment.


  In D20672#453068 , @abetts wrote:
  
  > Sorry for coming this late into the conversation. I was wondering if the 
spear in the bolt can be changed to be horizontal? It would be more visually 
consistent with the angle that the lightning bold is. The back of the arrow |>, 
that needs to be horizontal.
  
  
  Initially, that was repainted official designation of Thunderbolt connectors:
  
  https://upload.wikimedia.org/wikipedia/commons/a/a8/Thunderbolt_Connertor.jpg
  
  Thunderbolt official logo:
  
  https://upload.wikimedia.org/wikipedia/commons/6/67/Thunderbolt.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg, ndavis, ngraham
Cc: abetts, ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor updated this revision to Diff 56598.
yurchor added a comment.


  Use plain SVG

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20672?vs=56590=56598

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20672

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-thunderbolt.svg
  icons/preferences/32/preferences-desktop-thunderbolt.svg

To: yurchor, #vdg, ndavis, ngraham
Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg, ndavis
Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor updated this revision to Diff 56590.
yurchor added a comment.


  1. Fix diameter.
  2. Add copy for dark.
  3. Use non-transparent gradient.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20672?vs=56576=56590

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20672

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-thunderbolt.svg
  icons/preferences/32/preferences-desktop-thunderbolt.svg

To: yurchor, #vdg, ndavis
Cc: ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg
Cc: filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor updated this revision to Diff 56576.
yurchor added a comment.


  Darker top

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20672?vs=56559=56576

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20672

AFFECTED FILES
  icons/preferences/32/preferences-desktop-thunderbolt.svg

To: yurchor, #vdg
Cc: filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor updated this revision to Diff 56559.
yurchor added a comment.


  Smaller, add gradient

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20672?vs=56556=56559

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20672

AFFECTED FILES
  icons/preferences/32/preferences-desktop-thunderbolt.svg

To: yurchor, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor updated this revision to Diff 56556.
yurchor added a comment.


  Use the official blue background

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20672?vs=56553=56556

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20672

AFFECTED FILES
  icons/preferences/32/preferences-desktop-thunderbolt.svg

To: yurchor, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20672: Add an icon for Thunderbolt KCM

[Yuri Chornoivan]

yurchor created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  An icon for D19011 

TEST PLAN
  none

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20672

AFFECTED FILES
  icons/preferences/32/preferences-desktop-thunderbolt.svg

To: yurchor
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20018: Update URLs to use https

[Yuri Chornoivan]

yurchor accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R264 KApiDox

BRANCH
  arcpatch-D20018

REVISION DETAIL
  https://phabricator.kde.org/D20018

To: vkrause, yurchor
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D20018: Update URLs to use https

[Yuri Chornoivan]

yurchor requested changes to this revision.
yurchor added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> argparserutils.py:62
>'generate dependency diagrams.\n'
> -  'See .')
> +  'See .')
>  exit(1)

https://www.graphviz.org/download/

> Doxyfile.global:2
>  # Default settings for KDE projects
> -# See http://www.stack.nl/~dimitri/doxygen/manual/config.html for help
> +# See https://www.stack.nl/~dimitri/doxygen/manual/config.html for help
>  

http://www.doxygen.nl/manual/config.html

> library.html:22
>
> -  KDE's  href="http://community.kde.org/Policies/Library_Documentation_Policy;>Doxygen 
> guidelines are available online.
> +  KDE's  href="https://community.kde.org/Policies/Library_Documentation_Policy;>Doxygen
>  guidelines are available online.
>

https://community.kde.org/Frameworks/Frameworks_Documentation_Policy

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D20018

To: vkrause, yurchor
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D19992: Update URLs to use https

[Yuri Chornoivan]

yurchor accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19992

To: vkrause, yurchor
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D19992: Update URLs to use https

[Yuri Chornoivan]

yurchor added a comment.


  Thanks in advance for fixing the Techbase link.

INLINE COMMENTS

> install-compile.docbook:4
>  For information on how to compile and install  
> -applications visit the http://techbase.kde.org/;>
> +applications visit the https://techbase.kde.org/;>
>   Techbase

Moved from techbase to community: 
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source

> install-compile.docbook:5
> +applications visit the https://techbase.kde.org/;>
>   Techbase
>  

 Community wiki

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19992

To: vkrause
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D19895: Use https for links in the UI and documentation

[Yuri Chornoivan]

yurchor accepted this revision.
yurchor added a comment.
This revision is now accepted and ready to land.


  Thanks from the doc team.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19895

To: vkrause, yurchor
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D19557: Update css

[Yuri Chornoivan]

yurchor accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Yuri Chornoivan]

yurchor added a comment.


  In D19557#428394 , @ltoscano wrote:
  
  > Apart from the VDG, I'm sure that @yurchor can give some hints, as he 
manages the templates used to generate the PDFs.
  
  
  I have no objections. This part is not used for PDFs, btw. ;)

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D17734: Add Opus support for KIO AudioCD

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R342:ed3eb5a6a3e9: Add Opus support for KIO AudioCD (authored 
by yurchor).

REPOSITORY
  R342 KIO AudioCD

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17734?vs=48392=50906

REVISION DETAIL
  https://phabricator.kde.org/D17734

AFFECTED FILES
  CMakeLists.txt
  HACKING
  kcmaudiocd/kcmaudiocd.cpp
  plugins/CMakeLists.txt
  plugins/opus/CMakeLists.txt
  plugins/opus/Messages.sh
  plugins/opus/audiocd_opus_encoder.kcfg
  plugins/opus/audiocd_opus_encoder.kcfgc
  plugins/opus/encoderopus.cpp
  plugins/opus/encoderopus.h
  plugins/opus/encoderopusconfig.ui

To: yurchor, #kde_applications, #frameworks, aacid
Cc: aacid, ngraham, cfeck

D17969: Use a Kolf icon with nice background and shadows

[Yuri Chornoivan]

yurchor added a comment.


  +1 Much better than old, as for me.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17969

To: trickyricky26, #vdg, #kde_games
Cc: yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D17726: Add helper function to disable redirections (useful for kde-open)

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> krun.h:158
> +/**
> + * Sets wether KRun should follow URLs redirections.
> + * This is enabled by default

Typo: wether -> whether

> krun.h:160
> + * This is enabled by default
> + * @param b wether to follow redirections or not.
> + */

Typo: wether -> whether

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17726

To: achauvel, dfaure, #frameworks, cfeck
Cc: yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D17620: Make setHelp() public

[Yuri Chornoivan]

yurchor added a comment.


  In D17620#378112 , @aacid wrote:
  
  > In D17620#378110 , @yurchor 
wrote:
  >
  > > Abandoned due to the policy violation. Despite of the handful help pages 
invocation, it is obvious that this change will never happen.
  > >
  > > Just a side note: the protected method is useless and can be removed 
without loss of any functionality because all known setHelp()'s are commented 
now with hopeless messages like "TODO: port to kf5".
  >
  >
  > Yuri, you keep doing aggressive comments like this, your patches are 
interesting, but honestly i don't know if for me it's worthwhile helping you, 
if every so often you complain about how much everything is broken when it is 
not.
  >
  > Of course the method is not useless, this method is trivially usable by 
just having a class that inherits from KConfigDialog like Okular and i'm sure 
lots of other apps do.
  
  
  Ok. Sorry. Thanks for the useful clarification. Please do not help me. You 
need not to do so.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D17620

To: yurchor, #frameworks
Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17620: Make setHelp() public

[Yuri Chornoivan]

yurchor abandoned this revision.
yurchor added a comment.


  Abandoned due to the policy violation. Despite of the handful help pages 
invocation, it is obvious that this change will never happen.
  
  Just a side note: the protected method is useless and can be removed without 
loss of any functionality because all known setHelp()'s are commented now with 
hopeless messages like "TODO: port to kf5".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D17620

To: yurchor, #frameworks
Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17620: Make setHelp() public

[Yuri Chornoivan]

yurchor created this revision.
yurchor added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  Sometimes it is useful to connect configuration dialogs directly with the 
corresponding section in the manual (KmPlot, KAnagram). It was easy before KF 5:
  
m_settingsDialog->setHelp("configuration", QLatin1String("kmplot"));
  
  but now setHelp is protected and this is an untrivial task.

TEST PLAN
  The code just moved to public slots, should work as expected.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D17620

AFFECTED FILES
  src/kconfigdialog.h

To: yurchor, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14733: [KFormat] Add human readable list displaying function

[Yuri Chornoivan]

yurchor added a comment.


  +1

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14733

To: safaalfulaij, #frameworks
Cc: yurchor, bruns, kde-frameworks-devel, michaelh, ngraham

D17301: add documentation to result class

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> result.h:56
> + *
> + * \p property This specifies a property name. It should be one of the
> + * properties from the list of properties from KFileMetaData.

This should be `\param`

https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdp

https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdparam

> result.h:59
> + *
> + * \p value The value of the property
> + */

Same here.

> result.h:67
> + *
> + * \p text The text that will be appended to the document
> + */

Same here.

> result.h:80
> + * will be saved.
> + * \p doc The Baloo::Document
> + */

Same here.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16350: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is invoked with an anchor

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:8a9cec559211: Allow KHelpCenter to open the right pages 
of KDE help when KHelpClient is… (authored by yurchor).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16350?vs=44126=44145#toc

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16350?vs=44126=44145

REVISION DETAIL
  https://phabricator.kde.org/D16350

AFFECTED FILES
  src/khelpclient.cpp

To: yurchor, #documentation, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D16350: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is invoked with an anchor

[Yuri Chornoivan]

yurchor updated this revision to Diff 44126.
yurchor added a comment.


  Save some clazy's kittens by using overloaded arg().

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16350?vs=44014=44126

REVISION DETAIL
  https://phabricator.kde.org/D16350

AFFECTED FILES
  src/khelpclient.cpp

To: yurchor, #documentation, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16350: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is invoked with an anchor

[Yuri Chornoivan]

yurchor created this revision.
yurchor added reviewers: Documentation, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  The current KDE help is built up to contain the anchors to its topics in the 
following way
  
  help://.html (for separate pages)
  
  example:
  
  https://docs.kde.org/trunk5/en/applications/dolphin/using-dolphin.html
  
  or
  
  help:// (for sections)
  
  example:
  
  
https://docs.kde.org/trunk5/en/applications/dolphin/location-bar.html#location-bar-bread-crumb
  
  It is impossible to build such schemes with the current code. It works only 
for schemes help://index.html#. This scheme is nowhere to be 
found in our current catalog.

TEST PLAN
  1. Compile and install some application with two non-empty arguments in the 
KHelpClient::invokeHelp call (e.g. Kalzium from git/master).
  2. Open a page with the "Help" button (Tools -> Perform Calculation in 
Kalzium). Push the button.
  3. The corresponding page of the manual should be opened.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D16350

AFFECTED FILES
  src/khelpclient.cpp

To: yurchor, #documentation, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15105: add JSON to general.entities

[Yuri Chornoivan]

yurchor accepted this revision as: yurchor.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15105

To: lueck, #documentation, yurchor
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13227: update mailto kioslave docbook

[Yuri Chornoivan]

yurchor accepted this revision as: yurchor.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13227

To: lueck, #frameworks, #documentation, yurchor
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

Re: [kde-doc-english] docbook location issues in workspace repos

[Yuri Chornoivan]

написане Tue, 06 May 2014 22:23:34 +0300, Burkhard Lück
lu...@hube-lueck.de:


Am Dienstag, 6. Mai 2014, 22:18:51 schrieb Yuri Chornoivan:

написане Tue, 06 May 2014 21:58:37 +0300, Burkhard Lück

lu...@hube-lueck.de:
 Am Dienstag, 6. Mai 2014, 19:55:02 schrieb Burkhard Lück:
 Hi

 attached the updated list of docbooks in kf5 workspace repos with the
 issue,
 that the code is in different repos.

 Sorry, attached the wrong file, correct file attached.

 Aleix suggested on kde-frameworks-devel create an epics page such as
 this
 one [1], so that he  can keep track of all the things to be done.

 Any takers?

 Thanks.

 [1]  
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization


Hi,

I will do this. The results will be here:

http://community.kde.org/Frameworks/Epics/Docbook_Location_Problems


Thanks a lot Yuri, please send a note when the page is ready and cc kde-
frameworks-devel



Looks like the initial version is done now.

Thanks for your consideration.

Best regards,
Yuri
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel