[Differential] [Commented On] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk added a comment.


  FYI: There are more issues in other frameworks, the next deadlock is in 
kiconthemes...

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2142

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, dfaure, vonreth, graesslin
Cc: graesslin, #frameworks
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[Differential] [Commented On] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk added a comment.


  Waiting for a +1 from David.
  
  There's one possible point of regression, namely if `KGlobalAccel::self()` is 
being used after qApp ran all the post routines (and 
`KGlobalAccelPrivate::cleanup()` has been invoked already). Not sure if this is 
a problem, though.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2142

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, dfaure, vonreth, graesslin
Cc: graesslin, #frameworks
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel