kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfiledialog.cpp:607
> +    if (d->native) {
> +        return;
> +    }

Should we rather check for `!d->w` here and below? Would make more sense IMO.

REPOSITORY
  R239  KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D2075

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jonathans, #frameworks, dfaure, kfunk
Cc: kfunk, aacid

Reply via email to