Re: A new tier1 for icontheme.rcc handling
Hello Hannah, On mercredi 24 janvier 2018 10:32:17 CET Hannah von Reth wrote: > Hi Matthieu, > > On 21/01/2018 21:19, Matthieu Gallien wrote: > > Hello, > > > > On jeudi 18 janvier 2018 08:45:51 CET Hannah von Reth wrote: > >> Hi everyone. > >> > >> Only some few of you will be aware of KIconThemes ability to load binary > >> icon themes automagically. > >> > >> https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 > >> > >> The code looks for a icontheme.rcc and sets it as default theme. > >> > >> On Windows and Mac we rely on that code as it is more feasible to > >> install that one > >> file with an single application installer. This code also ensures that > >> the theme path is set, > >> which on Linux is done by the qpa. > >> > >> The problem with the current solution is that it only allows one single > >> theme and is in a tier3 > >> framework. > >> > >> I recently talked to David Faure and we agreed that it would be best to > >> put those few line of code into a new > >> created tier1 framework, with an explicit call instead of the magical > >> loading. > >> > >> The explicit call would allow to specify the theme loaded and we can > >> still maintain the current behaviour by putting a call to > >> that new framework into KIconThemes. > >> > >> Now we need a name for that tier1 framework and ideally someone who > >> steps up for the once in a lifetime chance to become > >> maintainer of a glorious new tier1 framework. > > > > Thanks for the work on this. > > > > If nobody steps up, I can volunteer to maintain it if people are OK with > > this. The workload should be low ? > > > > I depend on this code for a good windows support. This is important for > > me. > > You would be more than welcome :) Sorry for my late replay. Is there already a repository with work going on ? I would like to work on that because I am trying my best to have feature parity for my application on all supported platforms. Do you have any plans on how work could be organized ? > >> Cheers, > >> > >> Hannah > > > > Best regards > > > > -- > > Matthieu Gallien > > Cheers, > > Hannah Best regards -- Matthieu Gallien
Re: A new tier1 for icontheme.rcc handling
Hi Matthieu, On 21/01/2018 21:19, Matthieu Gallien wrote: > Hello, > > On jeudi 18 janvier 2018 08:45:51 CET Hannah von Reth wrote: >> Hi everyone. >> >> Only some few of you will be aware of KIconThemes ability to load binary >> icon themes automagically. >> >> https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 >> >> The code looks for a icontheme.rcc and sets it as default theme. >> >> On Windows and Mac we rely on that code as it is more feasible to >> install that one >> file with an single application installer. This code also ensures that >> the theme path is set, >> which on Linux is done by the qpa. >> >> The problem with the current solution is that it only allows one single >> theme and is in a tier3 >> framework. >> >> I recently talked to David Faure and we agreed that it would be best to >> put those few line of code into a new >> created tier1 framework, with an explicit call instead of the magical >> loading. >> >> The explicit call would allow to specify the theme loaded and we can >> still maintain the current behaviour by putting a call to >> that new framework into KIconThemes. >> >> Now we need a name for that tier1 framework and ideally someone who >> steps up for the once in a lifetime chance to become >> maintainer of a glorious new tier1 framework. > Thanks for the work on this. > > If nobody steps up, I can volunteer to maintain it if people are OK with > this. > The workload should be low ? > > I depend on this code for a good windows support. This is important for me. You would be more than welcome :) >> Cheers, >> >> Hannah > Best regards > > -- > Matthieu Gallien Cheers, Hannah signature.asc Description: OpenPGP digital signature
Re: A new tier1 for icontheme.rcc handling
Hello, On jeudi 18 janvier 2018 08:45:51 CET Hannah von Reth wrote: > Hi everyone. > > Only some few of you will be aware of KIconThemes ability to load binary > icon themes automagically. > > https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 > > The code looks for a icontheme.rcc and sets it as default theme. > > On Windows and Mac we rely on that code as it is more feasible to > install that one > file with an single application installer. This code also ensures that > the theme path is set, > which on Linux is done by the qpa. > > The problem with the current solution is that it only allows one single > theme and is in a tier3 > framework. > > I recently talked to David Faure and we agreed that it would be best to > put those few line of code into a new > created tier1 framework, with an explicit call instead of the magical > loading. > > The explicit call would allow to specify the theme loaded and we can > still maintain the current behaviour by putting a call to > that new framework into KIconThemes. > > Now we need a name for that tier1 framework and ideally someone who > steps up for the once in a lifetime chance to become > maintainer of a glorious new tier1 framework. Thanks for the work on this. If nobody steps up, I can volunteer to maintain it if people are OK with this. The workload should be low ? I depend on this code for a good windows support. This is important for me. > Cheers, > > Hannah Best regards -- Matthieu Gallien
Re: A new tier1 for icontheme.rcc handling
+1 for the name kiconsupport as Ben suggested. Em 19 de jan de 2018 21:49, "Ben Cooksley" escreveu: On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth wrote: > Hi everyone. Hi Hannah, > > Only some few of you will be aware of KIconThemes ability to load binary > icon themes automagically. > > https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 > > The code looks for a icontheme.rcc and sets it as default theme. > > On Windows and Mac we rely on that code as it is more feasible to > install that one > file with an single application installer. This code also ensures that > the theme path is set, > which on Linux is done by the qpa. > > The problem with the current solution is that it only allows one single > theme and is in a tier3 > framework. > > I recently talked to David Faure and we agreed that it would be best to > put those few line of code into a new > created tier1 framework, with an explicit call instead of the magical > loading. > > The explicit call would allow to specify the theme loaded and we can > still maintain the current behaviour by putting a call to > that new framework into KIconThemes. > > Now we need a name for that tier1 framework and ideally someone who > steps up for the once in a lifetime chance to become > maintainer of a glorious new tier1 framework. While I can't be the maintainer for the framework, to get the ball rolling may I suggest the name of 'kiconsupport' for the Framework? > > Cheers, > > Hannah > Cheers, Ben
Re: A new tier1 for icontheme.rcc handling
On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth wrote: > Hi everyone. Hi Hannah, > > Only some few of you will be aware of KIconThemes ability to load binary > icon themes automagically. > > https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 > > The code looks for a icontheme.rcc and sets it as default theme. > > On Windows and Mac we rely on that code as it is more feasible to > install that one > file with an single application installer. This code also ensures that > the theme path is set, > which on Linux is done by the qpa. > > The problem with the current solution is that it only allows one single > theme and is in a tier3 > framework. > > I recently talked to David Faure and we agreed that it would be best to > put those few line of code into a new > created tier1 framework, with an explicit call instead of the magical > loading. > > The explicit call would allow to specify the theme loaded and we can > still maintain the current behaviour by putting a call to > that new framework into KIconThemes. > > Now we need a name for that tier1 framework and ideally someone who > steps up for the once in a lifetime chance to become > maintainer of a glorious new tier1 framework. While I can't be the maintainer for the framework, to get the ball rolling may I suggest the name of 'kiconsupport' for the Framework? > > Cheers, > > Hannah > Cheers, Ben
A new tier1 for icontheme.rcc handling
Hi everyone. Only some few of you will be aware of KIconThemes ability to load binary icon themes automagically. https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 The code looks for a icontheme.rcc and sets it as default theme. On Windows and Mac we rely on that code as it is more feasible to install that one file with an single application installer. This code also ensures that the theme path is set, which on Linux is done by the qpa. The problem with the current solution is that it only allows one single theme and is in a tier3 framework. I recently talked to David Faure and we agreed that it would be best to put those few line of code into a new created tier1 framework, with an explicit call instead of the magical loading. The explicit call would allow to specify the theme loaded and we can still maintain the current behaviour by putting a call to that new framework into KIconThemes. Now we need a name for that tier1 framework and ideally someone who steps up for the once in a lifetime chance to become maintainer of a glorious new tier1 framework. Cheers, Hannah signature.asc Description: OpenPGP digital signature
