Re: Aw: Re: kcm_bluetooth changed ?

2022-02-13 Thread Martin Koller 
On Sonntag, 13. Februar 2022 19:27:22 CET alexander.loh...@gmx.de wrote:
> Hello,
>  
> Usually the KCMs are opened by starting kcmshell or systemsettings with the 
> module names as arguments,
> meaning we resolve the location of the KCMs internally and don't require 
> changes for consumers. kcmshell also checks if the plugin id
> would match if the "kcm_" prefix is to the module name prepended, 
> consequently "kcmshell5 bluetooth" works in both Plasma 5.23 and 5.24.
>  
> > If KDE/plamsa is such a moving target where  can not rely on compatibility 
> > even between minor versions, that is really not fun
>  
> Looking at liquidshell, there are multiple  cases where the available KCMs 
> are checked at runtime to be compatible with old Plasma versions. While 
> having to do this is not ideal, it is not anything new.
> Luckily most of the changes to port the KCMs to the new metadata approach 
> have already landed.
> The KWin KCMs remain though, when porting those I will make sure to create a 
> accompanying MR in liquidshell.

thanks!

> PS: You can check if the KPluginMetaData object is valid, instead of checking 
> if the name is not empty :).

ok. I took the code I was told works ...

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\- against proprietary attachments

Frühstück, Geschenkideen, Accessoires, Kulinarisches: www.lillehus.at

Aw: Re: kcm_bluetooth changed ?

2022-02-13 Thread Alexander . Lohnau 

Hello,

 

Usually the KCMs are opened by starting kcmshell or systemsettings with the module names as arguments,

meaning we resolve the location of the KCMs internally and don't require changes for consumers. kcmshell also checks if the plugin id

would match if the "kcm_" prefix is to the module name prepended, consequently "kcmshell5 bluetooth" works in both Plasma 5.23 and 5.24.

 

> If KDE/plamsa is such a moving target where  can not rely on compatibility even between minor versions, that is really not fun

 

Looking at liquidshell, there are multiple  cases where the available KCMs are checked at runtime to be compatible with old Plasma versions. While having to do this is not ideal, it is not anything new.

Luckily most of the changes to port the KCMs to the new metadata approach have already landed.
The KWin KCMs remain though, when porting those I will make sure to create a accompanying MR in liquidshell.

 

PS: You can check if the KPluginMetaData object is valid, instead of checking if the name is not empty :).

 

Regards
Alex


 
 

Gesendet: Sonntag, 13. Februar 2022 um 14:41 Uhr
Von: "Fusion Future" 
An: "Martin Koller" 
Cc: kde-frameworks-devel@kde.org, plasma-de...@kde.org, alexander.loh...@gmx.de
Betreff: Re: kcm_bluetooth changed ?

On 2022/2/13 21:31, Martin Koller wrote:
> But still I wonder if such a change is something like breaking ABI compatibility.
> If KDE/plamsa is such a moving target where I can not rely on compatibility even
> between minor versions, that is really not fun.
>

Perhaps the breakage is due to these commits [1-3]. Need to ask
Alexander Lohnau if there is a proper solution. I added him to the Cc list.

Sorry for the inconvenience.

[1]
https://invent.kde.org/plasma/bluedevil/-/commit/ac71faf781e1b3690f33bf54f27eeaaee7ec30e3
[2]
https://invent.kde.org/plasma/bluedevil/-/commit/87ad90b54592817d77d50c4284ff899659fa0550
[3]
https://invent.kde.org/plasma/bluedevil/-/commit/62856fe4d95ab4c1b795cf487ea0dbc61459412c