Re: Bring kdewin back?

2013-10-15 Thread David Faure
On Monday 14 October 2013 18:42:02 Nicolás Alvarez wrote:
 I'm now getting several
 errors related to the lack of symbolic links (such as no lstat).

Isn't that easy to fix, though?

On Windows: skip symlink support.

And lstat calls can be ported to QFileInfo if it helps portability, otherwise 
I suppose the file could have a local indirection like:
#ifdef Q_OS_WIN
#define MY_STAT QT_STAT
#else
#define MY_STAT QT_LSTAT
#endif

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Bring kdewin back?

2013-10-14 Thread Nicolás Alvarez
Hi,

While trying to get KDE Frameworks to build on Windows, I found the
codebase of KDirWatch is full of Unixisms. I did a few improvements
towards getting it to build on Windows, but I'm now getting several
errors related to the lack of symbolic links (such as no lstat). It's
clear this code couldn't have possibly worked on Windows directly, and
the only way it ever worked is through the use of kdewin to provide
Unix-like compatibility headers.

Other libraries have similar problems. It seems to me that someone
removed the dependency on kdewin without making the code actually work
without it. Why was it removed? Where can I find the discussion about
it, if there was any? If the intention is getting rid of the kdewin
dependency, can we *temporarily* bring it back to get things to work
again, and then remove it *progressively* as things get fixed?

-- 
Nicolás
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Bring kdewin back?

2013-10-14 Thread Aleix Pol
On Mon, Oct 14, 2013 at 11:42 PM, Nicolás Alvarez nicolas.alva...@gmail.com
 wrote:

 Hi,

 While trying to get KDE Frameworks to build on Windows, I found the
 codebase of KDirWatch is full of Unixisms. I did a few improvements
 towards getting it to build on Windows, but I'm now getting several
 errors related to the lack of symbolic links (such as no lstat). It's
 clear this code couldn't have possibly worked on Windows directly, and
 the only way it ever worked is through the use of kdewin to provide
 Unix-like compatibility headers.

 Other libraries have similar problems. It seems to me that someone
 removed the dependency on kdewin without making the code actually work
 without it. Why was it removed? Where can I find the discussion about
 it, if there was any? If the intention is getting rid of the kdewin
 dependency, can we *temporarily* bring it back to get things to work
 again, and then remove it *progressively* as things get fixed?

 --
 Nicolás
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Hi Nicolás,
It's good to know that there's somebody out there taking care of kf5 on
windows. I'm unsure of what to say, though. Maybe you can come up with a
list of issues so that we can fix them? At least some output log could be
useful...

We'll be working on making the different frameworks compilable separately
soon enough (actually this should already be the case, although I've seen
problems coming up), maybe it will be easier then to try to compile them
one by one and come up with something easier to digest. There are things in
kdelibs/frameworks that are of no use on windows (thinking of
frameworksintegration, for example).

Hope this helps :)

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Bring kdewin back?

2013-10-14 Thread Nicolás Alvarez
2013/10/14 Aleix Pol aleix...@kde.org:
 It's good to know that there's somebody out there taking care of kf5 on
 windows. I'm unsure of what to say, though. Maybe you can come up with a
 list of issues so that we can fix them? At least some output log could be
 useful...

I'm now working on http://community.kde.org/Frameworks/Windows

 We'll be working on making the different frameworks compilable separately
 soon enough (actually this should already be the case, although I've seen
 problems coming up), maybe it will be easier then to try to compile them one
 by one and come up with something easier to digest. There are things in
 kdelibs/frameworks that are of no use on windows (thinking of
 frameworksintegration, for example).

frameworksintegration is faaar away. Currently only half the tier1
libraries build, the rest of the tiers aren't even enabled.

-- 
Nicolás
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Bring kdewin back?

2013-10-14 Thread Kevin Ottens
Hello,

On Monday 14 October 2013 18:42:02 Nicolás Alvarez wrote:
 While trying to get KDE Frameworks to build on Windows, I found the
 codebase of KDirWatch is full of Unixisms. I did a few improvements
 towards getting it to build on Windows, but I'm now getting several
 errors related to the lack of symbolic links (such as no lstat). It's
 clear this code couldn't have possibly worked on Windows directly, and
 the only way it ever worked is through the use of kdewin to provide
 Unix-like compatibility headers.
 
 Other libraries have similar problems. It seems to me that someone
 removed the dependency on kdewin without making the code actually work
 without it. Why was it removed? Where can I find the discussion about
 it, if there was any?

Yes it has been discussed, I don't have the thread handy. The point was that 
it wasn't really acceptable to have that extra-dependency in the tier scheme. 
We've been working on removing as many unixisms as possible, apparently not 
enough but we didn't get many people looking at how it was building on 
windows. I'm glad someone finally does.

 If the intention is getting rid of the kdewin dependency, can we
 *temporarily* bring it back to get things to work again, and then remove it
 *progressively* as things get fixed?

If that makes your job easier, I don't see any problem at reintroducing it 
temporarily and fix it progressively. It needs someone to actively monitor the 
progress in that direction though, I'm not well equipped to do that ATM.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel