Re: Changes to networkmanager-qt - breakage in plasma-workspace

2018-04-02 Thread Jan Grulich
Hi,

On pátek 30. března 2018 15:39:59 CEST you wrote:
> krop already fixed that
> 
> On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote:
> > Hi Jan,
> > 
> > It seems that as part of your recent changes to networkmanager-qt to
> > increase the dependency to 1.0.0 you've made some other changes which
> > mean the appropriate include paths are no longer being provided to
> > projects that depend on networkmanager-qt.
> > 
> > This has the unfortunate effect that plasma-workspace is no longer
> > able to build on the CI system.
> > 
> > The error is:
> > 
> > In file included from /usr/include/libnm/nm-object.h:29:0,
> > 
> >  from /usr/include/libnm/nm-access-point.h:29,
> >  from /usr/include/libnm/NetworkManager.h:26,
> >  from
> > 
> > /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt
> > /ipconfig.h:31,> 
> >  from
> > 
> > /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt
> > /device.h:33,> 
> >  from
> > 
> > /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt
> > /manager.h:31,> 
> >  from
> > 
> > /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/NetworkManagerQt
> > /Manager:1,> 
> >  from /home/jenkins/workspace/Dependency Build Plasma
> > 
> > kf5-qt5
> > SUSEQt5.9/plasma-workspace/dataengines/geolocation/geolocation.cpp:25:
> > /usr/include/libnm/nm-types.h:24:10: fatal error: gio/gio.h: No such file
> > or directory
> > 
> > Could you please take a look?
> > 
> > Thanks,
> > Ben

Sorry for late response, I wasn't checking my mail during holidays. Seems that 
the problem is already solved, thank you for that, next time I'll be more 
careful.

Regards,
Jan




Re: Changes to networkmanager-qt - breakage in plasma-workspace

2018-04-01 Thread Christophe Giboudeaux
Hi,

On vendredi 30 mars 2018 00:21:41 CEST Ben Cooksley wrote:
> Hi Jan,
> 
> It seems that as part of your recent changes to networkmanager-qt to
> increase the dependency to 1.0.0 you've made some other changes which
> mean the appropriate include paths are no longer being provided to
> projects that depend on networkmanager-qt.
> 
> This has the unfortunate effect that plasma-workspace is no longer
> able to build on the CI system.
> 

FTR:

I pushed an emergency fix last night. plasma-nm and plasma-workspace can be 
built without issue.

Christophe





Re: Changes to networkmanager-qt - breakage in plasma-workspace

2018-03-30 Thread Allen Winter
krop already fixed that

On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote:
> Hi Jan,
> 
> It seems that as part of your recent changes to networkmanager-qt to
> increase the dependency to 1.0.0 you've made some other changes which
> mean the appropriate include paths are no longer being provided to
> projects that depend on networkmanager-qt.
> 
> This has the unfortunate effect that plasma-workspace is no longer
> able to build on the CI system.
> 
> The error is:
> 
> In file included from /usr/include/libnm/nm-object.h:29:0,
>  from /usr/include/libnm/nm-access-point.h:29,
>  from /usr/include/libnm/NetworkManager.h:26,
>  from
> /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/ipconfig.h:31,
>  from
> /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/device.h:33,
>  from
> /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/manager.h:31,
>  from
> /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1,
>  from /home/jenkins/workspace/Dependency Build Plasma
> kf5-qt5 SUSEQt5.9/plasma-workspace/dataengines/geolocation/geolocation.cpp:25:
> /usr/include/libnm/nm-types.h:24:10: fatal error: gio/gio.h: No such
> file or directory
> 
> Could you please take a look?
> 
> Thanks,
> Ben
> 







Changes to networkmanager-qt - breakage in plasma-workspace

2018-03-29 Thread Ben Cooksley
Hi Jan,

It seems that as part of your recent changes to networkmanager-qt to
increase the dependency to 1.0.0 you've made some other changes which
mean the appropriate include paths are no longer being provided to
projects that depend on networkmanager-qt.

This has the unfortunate effect that plasma-workspace is no longer
able to build on the CI system.

The error is:

In file included from /usr/include/libnm/nm-object.h:29:0,
 from /usr/include/libnm/nm-access-point.h:29,
 from /usr/include/libnm/NetworkManager.h:26,
 from
/home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/ipconfig.h:31,
 from
/home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/device.h:33,
 from
/home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/manager.h:31,
 from
/home/jenkins/install-prefix/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1,
 from /home/jenkins/workspace/Dependency Build Plasma
kf5-qt5 SUSEQt5.9/plasma-workspace/dataengines/geolocation/geolocation.cpp:25:
/usr/include/libnm/nm-types.h:24:10: fatal error: gio/gio.h: No such
file or directory

Could you please take a look?

Thanks,
Ben