D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c44784c98fcb: Dont cache the targetUrlList() result locally, return them from the locally… (authored by markg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10256?vs=26394=26395 REVISION DETAIL https://phabricator.kde.org/D10256 AFFECTED FILES src/core/kfileitemlistproperties.cpp To: markg, dfaure Cc: #frameworks, michaelh, ngraham
D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. If urlList() is called often, then this is actually slower (targetUrlList() has to iterate and convert). But yeah I doubt it is called often... REPOSITORY R241 KIO BRANCH KFileItemListProperties_optimizations (branched from master) REVISION DETAIL https://phabricator.kde.org/D10256 To: markg, dfaure Cc: #frameworks, michaelh, ngraham
D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'
markg edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10256 To: markg, dfaure Cc: #frameworks, michaelh, ngraham
D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'
markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY Small performance improvement of just not caching the targetUrlList() result. The only use for that list was returning it in KFileItemListProperties::urlList() so we might as well just call m_items.targetUrlList() there and not save it locally. This came up as redundant list creation when figuring out where all the QUrl objects came from in a drag/drop action in Dolphin. TEST PLAN I did not benchmark this, seems rather trivial. Ran the testcases (most relevant is probablt KFileItemTest), all pass just fine. REPOSITORY R241 KIO BRANCH KFileItemListProperties_optimizations (branched from master) REVISION DETAIL https://phabricator.kde.org/D10256 AFFECTED FILES src/core/kfileitemlistproperties.cpp To: markg, dfaure Cc: #frameworks, michaelh, ngraham