D10257: KUrlMimeData: fix handling of PreferLocalUrls
dfaure marked an inline comment as done.
dfaure added inline comments.
INLINE COMMENTS
> mwolff wrote in kurlmimedata.cpp:67
> future cleanup: remove all the `QString::fromLatin1(s_...)` in this file with
> a call to `QString kdeUriListMime() { return QStringLiteral("..."); }`
OK, done in
https://commits.kde.org/kcoreaddons/49dc2cff8105304cd726a5c927956e0b4d1250e2
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D10257
To: dfaure, mwolff, jtamate, markg
Cc: markg, ngraham, #frameworks, michaelh
D10257: KUrlMimeData: fix handling of PreferLocalUrls
mwolff added inline comments.
INLINE COMMENTS
> kurlmimedata.cpp:67
> +QList uris;
> +const QByteArray ba =
> mimeData->data(QString::fromLatin1(s_kdeUriListMime));
> +// Code from qmimedata.cpp
future cleanup: remove all the `QString::fromLatin1(s_...)` in this file with a
call to `QString kdeUriListMime() { return QStringLiteral("..."); }`
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D10257
To: dfaure, mwolff, jtamate, markg
Cc: markg, ngraham, #frameworks, michaelh
D10257: KUrlMimeData: fix handling of PreferLocalUrls
This revision was automatically updated to reflect the committed changes. Closed by commit R244:a7384f1817e5: KUrlMimeData: fix handling of PreferLocalUrls (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10257?vs=26397=26555#toc REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10257?vs=26397=26555 REVISION DETAIL https://phabricator.kde.org/D10257 AFFECTED FILES autotests/kurlmimedatatest.cpp autotests/kurlmimedatatest.h src/lib/io/kurlmimedata.cpp To: dfaure, mwolff, jtamate, markg Cc: markg, ngraham, #frameworks, michaelh
D10257: KUrlMimeData: fix handling of PreferLocalUrls
jtamate accepted this revision. jtamate added a comment. Looks good (and symmetric). Is it difficult to create a new test? REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10257 To: dfaure, mwolff, jtamate, markg Cc: markg, ngraham, #frameworks, michaelh
D10257: KUrlMimeData: fix handling of PreferLocalUrls
markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks OK to me. Had to read up on the KDE urls and local urls first though :) Funny side note. Those that text/uri-list can contain comments! https://tools.ietf.org/html/rfc2483#section-5 But judging from the qmimedata.cpp file, Qt also doesn't check for that (or i didn't find it, possible as well). REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10257 To: dfaure, mwolff, jtamate, markg Cc: markg, ngraham, #frameworks, michaelh
D10257: KUrlMimeData: fix handling of PreferLocalUrls
dfaure updated this revision to Diff 26397. dfaure added a comment. remove unrelated change REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10257?vs=26396=26397 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10257 AFFECTED FILES src/lib/io/kurlmimedata.cpp To: dfaure, mwolff, jtamate Cc: #frameworks, michaelh, ngraham
D10257: KUrlMimeData: fix handling of PreferLocalUrls
dfaure created this revision. dfaure added reviewers: mwolff, jtamate. Restricted Application added a project: Frameworks. dfaure requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/R244:18e4d245d3d595cdc17ad40aa88495d6d2c30bf7 didn't quite have the right logic after all TEST PLAN Unittest passes (but this commit proves that it doesn't cover all cases...) REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10257 AFFECTED FILES KF5CoreAddonsMacros.cmake src/lib/io/kurlmimedata.cpp To: dfaure, mwolff, jtamate Cc: #frameworks, michaelh, ngraham
