D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:f0a96f5f85cb: change 32px icons for playlist shuffle and 
repeat (authored by astippich).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10292?vs=29110&id=30868

REVISION DETAIL
  https://phabricator.kde.org/D10292

AFFECTED FILES
  icons-dark/actions/32/media-playlist-normal.svg
  icons-dark/actions/32/media-playlist-repeat.svg
  icons-dark/actions/32/media-playlist-shuffle.svg
  icons-dark/actions/32/media-repeat-all.svg
  icons-dark/actions/32/media-repeat-none.svg
  icons/actions/32/media-playlist-normal.svg
  icons/actions/32/media-playlist-repeat.svg
  icons/actions/32/media-playlist-shuffle.svg
  icons/actions/32/media-repeat-all.svg
  icons/actions/32/media-repeat-none.svg

To: astippich, #breeze, #vdg, andreaska, andreask, ngraham
Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich added a comment.


  Thanks a lot!

REPOSITORY
  R266 Breeze Icons

BRANCH
  playlist_shuffle_repeat

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask, ngraham
Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Andreas Kainz]

andreask accepted this revision.
andreask added a comment.
This revision is now accepted and ready to land.


  sorry for the late approve.

REPOSITORY
  R266 Breeze Icons

BRANCH
  playlist_shuffle_repeat

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask, ngraham
Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Ben Cooksley]

bcooksley added a comment.


  It is currently pending on @andreask reviewing it, as they have previously 
requested changes.
  
  It also needs @andreaska to review it (not sure if this is correct?)
  
  Phabricator only considers something ready for landing once all reviewers 
have approved it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask, ngraham
Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich added a comment.


  Can I land this? phabricator doesn't show it as accepted though

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask, ngraham
Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich added a comment.


  ping @andreask

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask, ngraham
Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Agreed. They look great to me!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask, ngraham
Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Nathaniel Graham]

ngraham added a comment.


  Agreed. Can you post screenshots of all the icons? I'll evaluate.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich added a comment.


  after D11049  where the frames for the 
media buttons were removed I think this is quite needed for a consistent look 
and feel. I also added 32px version for no repeat and no shuffle which I need 
for a toggle button for #elisa 
  
  F5747288: Screenshot_20180309_193754.png 

  
  F5747290: Screenshot_20180309_193801.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich updated this revision to Diff 29110.
astippich added a comment.


  - add more 32px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10292?vs=26512&id=29110

BRANCH
  playlist_shuffle_repeat

REVISION DETAIL
  https://phabricator.kde.org/D10292

AFFECTED FILES
  icons-dark/actions/32/media-playlist-normal.svg
  icons-dark/actions/32/media-playlist-repeat.svg
  icons-dark/actions/32/media-playlist-shuffle.svg
  icons-dark/actions/32/media-repeat-all.svg
  icons-dark/actions/32/media-repeat-none.svg
  icons/actions/32/media-playlist-normal.svg
  icons/actions/32/media-playlist-repeat.svg
  icons/actions/32/media-playlist-shuffle.svg
  icons/actions/32/media-repeat-all.svg
  icons/actions/32/media-repeat-none.svg

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich added a comment.


  Thanks for the feedback! 
  So the correct fix would be to change the 22px and 24px icons to use circles 
around the icons?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Andreas Kainz]

andreask requested changes to this revision.
andreask added a comment.
This revision now requires changes to proceed.


  only in 16px there is no circle and in general I'm not really happy to have 
no circle around the icon. maybe for repeat and shuffle it will work but 
play/pause are more intuitive with circle than without.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska, andreask
Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich updated this revision to Diff 26512.
astippich added a comment.


  update to 1px of line width, was 1.5 due to the scaling

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10292?vs=26497&id=26512

BRANCH
  playlist_shuffle_repeat

REVISION DETAIL
  https://phabricator.kde.org/D10292

AFFECTED FILES
  icons-dark/actions/32/media-playlist-repeat.svg
  icons-dark/actions/32/media-playlist-shuffle.svg
  icons/actions/32/media-playlist-repeat.svg
  icons/actions/32/media-playlist-shuffle.svg

To: astippich, #breeze, #vdg, andreaska
Cc: #frameworks, michaelh, ngraham

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska
Cc: #frameworks, michaelh, ngraham

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich added a comment.


  Before: 
  F5691700: Screenshot_20180204_134019.png 

  
  F5691702: Screenshot_20180204_134042.png 

  
  After, which is also how the 24px and lower icons look like:
  F5691706: Screenshot_20180204_134204.png 

  
  F5691708: Screenshot_20180204_134227.png 

  
  Mouse cursors not included of course :)
  Disclaimer: I'm in no way a graphic designer.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10292

To: astippich, #breeze, #vdg, andreaska
Cc: #frameworks, michaelh, ngraham

D10292: change 32px icons for playlist shuffle and repeat

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: Breeze, VDG, andreaska.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
astippich requested review of this revision.

REVISION SUMMARY
  the 32px icons for media-playlist-shuffle and media-playlist-repeat look 
totally different than the icons with sizes < 24px.
  Also, they do not fit with the current design with their sharp corners. 
Change to the design of the smaller icons. Icons were created using a scaled 
version of the 24px icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  playlist_shuffle_repeat

REVISION DETAIL
  https://phabricator.kde.org/D10292

AFFECTED FILES
  icons-dark/actions/32/media-playlist-repeat.svg
  icons-dark/actions/32/media-playlist-shuffle.svg
  icons/actions/32/media-playlist-repeat.svg
  icons/actions/32/media-playlist-shuffle.svg

To: astippich, #breeze, #vdg, andreaska
Cc: #frameworks, michaelh, ngraham