D10325: [KFileWidget] Hide places frame and header
This revision was automatically updated to reflect the committed changes. Closed by commit R241:a3e2b24b17ee: [KFileWidget] Hide places frame and header (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10325?vs=26642&id=27706 REVISION DETAIL https://phabricator.kde.org/D10325 AFFECTED FILES src/filewidgets/CMakeLists.txt src/filewidgets/kfilewidget.cpp src/filewidgets/kfilewidgetdocktitlebar.cpp src/filewidgets/kfilewidgetdocktitlebar_p.h To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D10325: [KFileWidget] Hide places frame and header
broulik added a comment. If no Frameworks dev objects within next few days this will be pushed REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D10325: [KFileWidget] Hide places frame and header
broulik added inline comments. INLINE COMMENTS > apol wrote in kfilewidget.cpp:1351 > Does it really make sense that it's a dock if it can't be interacted with? I don't know. You can still resize the panel, I also wanted to keep the patch as unintrusive as possible. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D10325: [KFileWidget] Hide places frame and header
apol added inline comments.
INLINE COMMENTS
> kfilewidget.cpp:1351
> placesDock = new QDockWidget(i18nc("@title:window", "Places"), q);
> -placesDock->setFeatures(QDockWidget::DockWidgetClosable);
> +placesDock->setFeatures(QDockWidget::NoDockWidgetFeatures);
> +placesDock->setTitleBarWidget(new
> KDEPrivate::KFileWidgetDockTitleBar(placesDock));
Does it really make sense that it's a dock if it can't be interacted with?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D10325: [KFileWidget] Hide places frame and header
markg added a comment.
In https://phabricator.kde.org/D10325#201884, @broulik wrote:
> > Would it be possible to show it as if it were locked? That would solve
all the issues with it, right?
>
> I don't get it. That "lock" feature is entirely a Dolphin invention. It
does exactly what I do here:
>
> void DolphinDockWidget::setLocked(bool lock)
> {
> ...
> if (lock) {
> ...
> setTitleBarWidget(m_dockTitleBar);
> setFeatures(QDockWidget::NoDockWidgetFeatures);
>
>
> with `m_dockTitleBar` being a custom widget for some added padding
Looks like i was looking at the wrong picture. I was looking as your
**after** image and comparing that to the "locked" state in dolphin.
The image i was expecting is the one you call "crammed at the top" :)
Imho, the "crammed at the top" version looks best as the "after" one just has
some weird empty room above the panel now. But feel free to use the one you
think fits best.
A suggestion though if you do choose for the "after" version. Would it be
possible to rearrange the layout then?
So:
- move the actions to the top, right above the panel.
- move the location bar next to the actions
I think that would look nice :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10325: [KFileWidget] Hide places frame and header
broulik updated this revision to Diff 26642. broulik retitled this revision from "RFC: [KFileWidget] Hide places frame and header" to "[KFileWidget] Hide places frame and header". broulik edited the test plan for this revision. broulik added a comment. - Add custom widget for added spacing, fixes the items glued to the top when borders are enabled, see updated Test Plan for new screenshots REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10325?vs=26590&id=26642 REVISION DETAIL https://phabricator.kde.org/D10325 AFFECTED FILES src/filewidgets/CMakeLists.txt src/filewidgets/kfilewidget.cpp src/filewidgets/kfilewidgetdocktitlebar.cpp src/filewidgets/kfilewidgetdocktitlebar_p.h To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
