D10365: New icon for Elisa music player

2018-03-08 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:26866bfffa86: New icon for Elisa music player (authored 
by paullesur, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10365?vs=26705=29040

REVISION DETAIL
  https://phabricator.kde.org/D10365

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien, ngraham
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, nhuisman, ursjoss, jussiv, paullesur, michaelh, ognarb, 
kmf


D10365: New icon for Elisa music player

2018-03-08 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  I'm ok with it. Landing now.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien, ngraham
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, nhuisman, ursjoss, jussiv, paullesur, michaelh, ognarb, 
kmf


D10365: New icon for Elisa music player

2018-03-08 Thread Matthieu Gallien
mgallien added a comment.


  I believe there was no objections to this choice of icon. Can we ensure this 
gets landed soon ? I would prefer to be able to have the new icon as soon as 
possible.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, nhuisman, ursjoss, jussiv, paullesur, michaelh, ognarb, 
kmf


D10365: New icon for Elisa music player

2018-02-22 Thread Matthieu Gallien
mgallien added a comment.


  In D10365#206602 , @mgallien wrote:
  
  > In D10365#205750 , @andreask 
wrote:
  >
  > > can we get it now to master?
  > >
  > > @paullesur is hopefully interested in other icon's too.
  >
  >
  > @paullesur do you have a KDE contributor account ? If not, I cannot push 
due to life events pushing me away from keyboard.
  
  
  @paullesur ping ?

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf


D10365: New icon for Elisa music player

2018-02-14 Thread Matthieu Gallien
mgallien added a comment.


  In D10365#205750 , @andreask wrote:
  
  > can we get it now to master?
  >
  > @paullesur is hopefully interested in other icon's too.
  
  
  @paullesur do you have a KDE contributor account ? If not, I cannot push due 
to life events pushing me away from keyboard.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf, progwolff


D10365: New icon for Elisa music player

2018-02-13 Thread Andreas Kainz
andreask added a comment.


  can we get it now to master?
  
  @paullesur is hopefully interested in other icon's too.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf, progwolff


D10365: New icon for Elisa music player

2018-02-12 Thread Marijo Mustac
mmustac added a comment.


  Old-school rules! Also just think of the floppy  disk icon which is mostly 
everywhere the save icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf, progwolff


D10365: New icon for Elisa music player

2018-02-11 Thread Paul Lesur
paullesur added a comment.


  In D10365#203797 , @januz wrote:
  
  > Agree with the text not being useful for small sizes, but it could look 
good for a large logo-style image (like say, a 256px logo on the 
wiki/homepage). 
  >  A cassette is definitely an interesting idea for an icon. At least it's 
not another musical note or play icon 

 :)
  >
  > It's true that it's old school, but we also use CDs for albums which is 
also kind of old school now, so it's not totally off. Green is ok too, since 
the CDs and their background are all green (and blueish). You could also mixing 
it with some subtle blue/cyan tints in there.
  >
  > Also, I think if we're going 80s we should go all the way. Instead of a 
gradient (green to white), consider using some 80s motif like the vanishing 
lines in here:
  >  
https://www.google.com.ar/search?dcr=0=imgo%3A1=isch=1=zzp-WvW5MsPCwATB-LGwAQ=awesome+mix+vol+2=awesome+mix_l=psy-ab.3.1.0l10.345494.346631.0.348056.11.9.0.2.2.0.144.983.4j5.9.00...1c.1.64.psy-ab..1.10.890...0i67k1.0.QW76y1ueao8#imgrc=66ooLxhTsA9q2M
  >
  > You should probably limit it to 1-2 lines for the smaller sizes though. You 
could probably replace the text with the lines/motif in small sizes too.
  >
  > More ideas for that: 
https://www.google.com.ar/search?dcr=0=imgo%3A1=isch=1=Rj1-WvPjLYaTwgTj1p2YCw=80s+cassette=80s+cassette_l=psy-ab.3..0l2j0i30k1l4j0i8i30k1l2.18392.20298.0.20566.12.12.0.0.0.0.115.1019.11j1.12.00...1c.1.64.psy-ab..0.12.1013...0i67k1j0i10i24k1.0.PyemoiQ5FVk
  >
  > BTW, love your avatar!
  
  
  I followed your advice, here is a big version and a preview in my application 
launcher 
  F5705811: Big2.png 
  F5705810: Screenshot_20180211_200206.png 

  
  In D10365#203820 , @mgallien wrote:
  
  > Thanks for your work. I am hesitant about the choice of an audio tape. I 
fear people under 30 will not recognize it.
  >  I would like to propose trying the tape with the current color and we can 
revisit this decision in 6 months.
  >  I agree on the text removal and your choice of color is good for me.
  
  
  I understand your concern. However we could say the same thing about vinyls, 
and many apps are using vinyls as icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mgallien, januz, astippich, andreask, andreaska, ltoscano, ngraham, 
#frameworks, paullesur, michaelh, ognarb, kmf, progwolff


D10365: New icon for Elisa music player

2018-02-10 Thread Matthieu Gallien
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Thanks for your work. I am hesitant about the choice of an audio tape. I fear 
people under 30 will not recognize it.
  I would like to propose trying the tape with the current color and we can 
revisit this decision in 6 months.
  I agree on the text removal and your choice of color is good for me.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mgallien, januz, astippich, andreask, andreaska, ltoscano, ngraham, 
#frameworks, paullesur, michaelh, ognarb, kmf, progwolff


D10365: New icon for Elisa music player

2018-02-09 Thread Diego Gangl
januz added a comment.


  Agree with the text not being useful for small sizes, but it could look good 
for a large logo-style image (like say, a 256px logo on the wiki/homepage). 
  A cassette is definitely an interesting idea for an icon. At least it's not 
another musical note or play icon 

 :)
  
  It's true that it's old school, but we also use CDs for albums which is also 
kind of old school now, so it's not totally off. Green is ok too, since the CDs 
and their background are all green (and blueish). You could also mixing it with 
some subtle blue/cyan tints in there.
  
  Also, I think if we're going 80s we should go all the way. Instead of a 
gradient (green to white), consider using some 80s motif like the vanishing 
lines in here:
  
https://www.google.com.ar/search?dcr=0=imgo%3A1=isch=1=zzp-WvW5MsPCwATB-LGwAQ=awesome+mix+vol+2=awesome+mix_l=psy-ab.3.1.0l10.345494.346631.0.348056.11.9.0.2.2.0.144.983.4j5.9.00...1c.1.64.psy-ab..1.10.890...0i67k1.0.QW76y1ueao8#imgrc=66ooLxhTsA9q2M
  
  You should probably limit it to 1-2 lines for the smaller sizes though. You 
could probably replace the text with the lines/motif in small sizes too.
  
  More ideas for that: 
https://www.google.com.ar/search?dcr=0=imgo%3A1=isch=1=Rj1-WvPjLYaTwgTj1p2YCw=80s+cassette=80s+cassette_l=psy-ab.3..0l2j0i30k1l4j0i8i30k1l2.18392.20298.0.20566.12.12.0.0.0.0.115.1019.11j1.12.00...1c.1.64.psy-ab..0.12.1013...0i67k1j0i10i24k1.0.PyemoiQ5FVk
  
  BTW, love your avatar!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska
Cc: januz, astippich, andreask, andreaska, ltoscano, ngraham, #frameworks, 
paullesur, michaelh, ognarb, kmf, progwolff, mgallien


D10365: New icon for Elisa music player

2018-02-09 Thread Paul Lesur
paullesur added a comment.


  In https://phabricator.kde.org/D10365#203432, @astippich wrote:
  
  > I was a little bit hesitant at first, but I'm starting to like the idea of 
a cassette as an icon for Elisa. But I think the text in the icon is not 
required. It will usually be so small that no-one can read it.
  >  Anyways, Matthieu should have a comment about this.
  
  
  Yes you're right, the text makes the icon more cluttered. I could remove the 
text or draw some kind of stylized text that would read better.
  
  I'm not sure about the color, is green OK ?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska
Cc: astippich, andreask, andreaska, ltoscano, ngraham, #frameworks, paullesur, 
michaelh, ognarb, januz, kmf, progwolff, mgallien


D10365: New icon for Elisa music player

2018-02-09 Thread Alexander Stippich
astippich added a comment.


  I was a little bit hesitant at first, but I'm starting to like the idea of a 
cassette as an icon for Elisa. But I think the text in the icon is not 
required. It will usually be so small that no-one can read it.
  Anyways, Matthieu should have a comment about this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska
Cc: astippich, andreask, andreaska, ltoscano, ngraham, #frameworks, paullesur, 
michaelh, ognarb, januz, kmf, progwolff, mgallien


D10365: New icon for Elisa music player

2018-02-07 Thread Andreas Kainz
andreask added a comment.


  Elisa is a new music player app (yes another one) cassettes are old-school 
yes, but the benefit is that it look like an old (stable well developed) app in 
addition it's way more unique than other music player apps.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska
Cc: andreask, andreaska, ltoscano, ngraham, #frameworks, paullesur, michaelh, 
ognarb, januz, kmf, progwolff, mgallien


D10365: New icon for Elisa music player

2018-02-07 Thread Paul Lesur
paullesur added reviewers: Breeze, VDG, Elisa, andreaska.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska
Cc: andreaska, ltoscano, ngraham, #frameworks, paullesur, michaelh, ognarb, 
januz, kmf, progwolff, andreask, mgallien


D10365: New icon for Elisa music player

2018-02-07 Thread Paul Lesur
paullesur added a subscriber: andreaska.
paullesur added a comment.


  In https://phabricator.kde.org/D10365#202503, @ngraham wrote:
  
  > Hmm, the old-skool cassette doesn't really blend in with Elisa's sleek, 
modern appearance IMHO.
  
  
  My first try for Elisa's icon looked like a small guitar amp. But after 
discussion,  @andreaska of the Breeze team suggested that I make this 
cassette-shaped icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur
Cc: andreaska, ltoscano, ngraham, #frameworks, paullesur, michaelh, ognarb, 
januz, kmf, progwolff, andreask, mgallien


D10365: New icon for Elisa music player

2018-02-07 Thread Luigi Toscano
ltoscano added a comment.


  But the 80s are back :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur
Cc: ltoscano, ngraham, #frameworks, paullesur, michaelh, ognarb, januz, kmf, 
progwolff, andreask, mgallien


D10365: New icon for Elisa music player

2018-02-07 Thread Luigi Toscano
ltoscano added a project: Elisa.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur
Cc: ngraham, #frameworks, michaelh, ognarb, januz, kmf, progwolff, andreask, 
mgallien


D10365: New icon for Elisa music player

2018-02-07 Thread Nathaniel Graham
ngraham added a comment.


  Hmm, the old-skool cassette doesn't really blend in with Elisa's sleek, 
modern appearance IMHO.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur
Cc: ngraham, #frameworks, michaelh


D10365: New icon for Elisa music player

2018-02-07 Thread Paul Lesur
paullesur added a comment.


  In https://phabricator.kde.org/D10365#202483, @ngraham wrote:
  
  > Screenshot please!
  
  
  F5697207: Screenshot_20180207_121553.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur
Cc: ngraham, #frameworks, michaelh


D10365: New icon for Elisa music player

2018-02-07 Thread Nathaniel Graham
ngraham added a comment.


  Screenshot please!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur
Cc: ngraham, #frameworks, michaelh


D10365: New icon for Elisa music player

2018-02-07 Thread Paul Lesur
paullesur created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
paullesur requested review of this revision.

REVISION SUMMARY
  New icon for Elisa music player

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: paullesur
Cc: #frameworks, michaelh, ngraham