D10376: kio_file: skip error handling for initial perms during file copy

2018-02-07 Thread David Faure 
dfaure created this revision.
dfaure added reviewers: chinmoyr, markg, jtamate.
Restricted Application added a project: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  This reverts the parts of 
https://phabricator.kde.org/R241:13ab6a85bbb8502fe47935f92f466e0223baa2ac which 
touched this code, there
  didn't use to be any error handling for this call, on purpose.
  This is just the initial permissions for the newly created file we are
  going to copy to; if the filesystem doesn't support permissions, we can
  still proceed.

TEST PLAN
  Copying a file to a VFAT partition no longer leads to an empty file.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10376

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: dfaure, chinmoyr, markg, jtamate
Cc: #frameworks, michaelh, ngraham

D10376: kio_file: skip error handling for initial perms during file copy

2018-02-07 Thread Jaime Torres Amate 
jtamate accepted this revision.
jtamate added a comment.
This revision is now accepted and ready to land.


  Even moving to a ntfs filesystem without the rights to change owner doesn't 
end in an empty file.
  Very good job.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10376

To: dfaure, chinmoyr, markg, jtamate
Cc: #frameworks, michaelh, ngraham

D10376: kio_file: skip error handling for initial perms during file copy

2018-02-08 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10376

To: dfaure, chinmoyr, markg, jtamate
Cc: #frameworks, michaelh, ngraham