D10508: [KStandardAction] Add additional icons to menus

2018-02-14 Thread Nathaniel Graham 
ngraham added a comment.


  Also, you don't need "[KStandardAction]" in the title. A better commit 
message would indicate the actual icons. Maybe something like this:
  
  "Add icons for KStandardActions Deselect and Replace"
  
  See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: [KStandardAction] Add additional icons to menus

2018-02-14 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great! Do you know how to deploy this patch such that apps e.g. Kate 
can pick up the change?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: [KStandardAction] Add additional icons to menus

2018-02-14 Thread Marijo Mustac 
mmustac created this revision.
mmustac added reviewers: Frameworks, ngraham.
Restricted Application added a project: Frameworks.
mmustac requested review of this revision.

REVISION SUMMARY
  I added also here the icons for the "replace" and "deselect" action.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

AFFECTED FILES
  src/kstandardaction_p.h

To: mmustac, #frameworks, ngraham
Cc: michaelh