D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

2018-03-06 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  I don't see why this would be silently discarded. The input shape has nothing 
to do with the window mask (e.g. rounded border depending on theme).

TEST PLAN
  - Created a dialog with `NoBackground` and instead a fully custom background 
and made it click-through successfully
  - Changing the property at runtime still update sfine
  - OSD is still click-through as before

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11102

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma
Cc: #frameworks, michaelh

D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

2018-03-15 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11102

To: broulik, #plasma, mart
Cc: #frameworks, michaelh, ngraham

D11102: [Dialog] Allow setting outputOnly for NoBackground dialog

2018-03-15 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:049aa5677de3: [Dialog] Allow setting outputOnly for 
NoBackground dialog (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11102?vs=28869&id=29590

REVISION DETAIL
  https://phabricator.kde.org/D11102

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: #frameworks, michaelh, ngraham