D11342: Include the "stdcpp-path" in the json file

2018-03-14 Thread Aleix Pol Gonzalez
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
apol requested review of this revision.

REVISION SUMMARY
  qmake also generates it and androiddeployqt consumes it.

TEST PLAN
  built and ran kalgebra

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11342

AFFECTED FILES
  toolchain/deployment-file.json.in

To: apol, #frameworks
Cc: #build_system, michaelh, ngraham


D11342: Include the "stdcpp-path" in the json file

2018-03-15 Thread Volker Krause
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Looks sane to me. Probably needs to be adjusted for clang support eventually 
though.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11342

To: apol, #frameworks, vkrause
Cc: vkrause, #build_system, michaelh, ngraham


D11342: Include the "stdcpp-path" in the json file

2018-03-15 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:7f865cf2b2c3: Include the "stdcpp-path" in the 
json file (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11342?vs=29537&id=29598

REVISION DETAIL
  https://phabricator.kde.org/D11342

AFFECTED FILES
  toolchain/deployment-file.json.in

To: apol, #frameworks, vkrause
Cc: vkrause, #build_system, michaelh, ngraham


D11342: Include the "stdcpp-path" in the json file

2018-03-15 Thread Aleix Pol Gonzalez
apol added a comment.


  In D11342#226449 , @vkrause wrote:
  
  > Looks sane to me. Probably needs to be adjusted for clang support 
eventually though.
  
  
  Correct, it needs a full refactoring of the script though.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11342

To: apol, #frameworks, vkrause
Cc: vkrause, #build_system, michaelh, ngraham