D11361: add a version containmentForScreen with activity

2018-03-15 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mart requested review of this revision.

REVISION SUMMARY
  add a version of containmentForScreen which it has the activity.
  which is correct as the activity id of containments in in libplasma side.
  this ensure the correctness of shellCorona createContainmentForActivity
  as now it works also for activities different from the current one

TEST PLAN
  tried with an old plasmashell and is perfectly retrocompatible

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/containmentForScreen

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma
Cc: #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-03-15 Thread Marco Martin 
mart added a dependent revision: D11333: introduce the function 
containmentGraphicsItemPreview.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma
Cc: #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-03-15 Thread Marco Martin 
mart edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma
Cc: #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-03-29 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Either Corona tracks which containment are on which containment or 
ShellCorona does.
  
  Having
  
QHash > m_desktopContainments;
  
  in ShellCorona and

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-03-30 Thread Marco Martin 
mart updated this revision to Diff 30914.
mart added a comment.


  - Merge branch 'master' into arcpatch-D11361
  - add containmentsForActivity and containmentsForScreen

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11361?vs=29622&id=30914

BRANCH
  arcpatch-D11361

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-03-30 Thread Marco Martin 
mart updated this revision to Diff 30915.
mart added a comment.


  - only consider desktop containments

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11361?vs=30914&id=30915

BRANCH
  arcpatch-D11361

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-03-30 Thread Marco Martin 
mart added a comment.


  so, i tried to remove m_desktopContainments in D11801 
, using the new query functions i added 
here.
  
  all seems to keep working, hopefully makes things a bit more robust

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-03-30 Thread Marco Martin 
mart added a dependent revision: D11801: remove m_desktopContainments.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-04-03 Thread Marco Martin 
mart updated this revision to Diff 31200.
mart added a comment.


  - make sure the new containment has the proper activity

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11361?vs=30915&id=31200

BRANCH
  arcpatch-D11361

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-04-11 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D11361

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham, bruns

D11361: add a version containmentForScreen with activity

2018-04-11 Thread David Edmundson 
davidedmundson added a comment.


  > tried with an old plasmashell and is perfectly retrocompatible
  
  Please make sure that includes comprehensively trying adding and removing 
screens and activities.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D11361

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham, bruns

D11361: add a version containmentForScreen with activity

2018-04-16 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bfa19dbc8fc7: add a version containmentForScreen with 
activity (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11361?vs=31200&id=32263#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11361?vs=31200&id=32263

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham, bruns