D11732: Improve protocols documentation
This revision was automatically updated to reflect the committed changes. Closed by commit R127:272112a07f07: Improve protocols documentation (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11732?vs=30925&id=33400 REVISION DETAIL https://phabricator.kde.org/D11732 AFFECTED FILES src/client/protocols/output-management.xml src/client/protocols/outputdevice.xml To: romangg, #frameworks, davidedmundson Cc: davidedmundson, michaelh, bruns
D11732: Improve protocols documentation
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH improveOutputManagementDoc REVISION DETAIL https://phabricator.kde.org/D11732 To: romangg, #frameworks, davidedmundson Cc: davidedmundson, michaelh, bruns
D11732: Improve protocols documentation
romangg added a comment. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11732 To: romangg, #frameworks Cc: davidedmundson, michaelh, ngraham, bruns
D11732: Improve protocols documentation
romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice.xml:67 > earlier you changed all the "compositor" to "server" The usage of terms compositor and server is not clearly regulated in the Wayland world besides that these terms describe the same "application" (for example KWin). I try to use "server" whenever I talk about this application communicating with clients and "compositor" whenever I talk about this application in its capability of arranging surfaces to a final output image. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11732 To: romangg, #frameworks Cc: davidedmundson, michaelh, ngraham
D11732: Improve protocols documentation
romangg updated this revision to Diff 30925. romangg marked an inline comment as done. romangg added a comment. - Say properties REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11732?vs=30673&id=30925 BRANCH improveOutputManagementDoc REVISION DETAIL https://phabricator.kde.org/D11732 AFFECTED FILES src/client/protocols/output-management.xml src/client/protocols/outputdevice.xml To: romangg, #frameworks Cc: davidedmundson, michaelh, ngraham
D11732: Improve protocols documentation
davidedmundson added inline comments. INLINE COMMENTS > outputdevice.xml:67 > > -This describes the transform that a compositor will apply to a > +This describes the transform, that a compositor will apply to a > surface to compensate for the rotation or mirroring of an earlier you changed all the "compositor" to "server" > outputdevice.xml:160 > +other output property change have been applied later on. > +This allows to see changes to the output properties as atomic, > +even if they multiple events successively announce them. you've changed 1/2 properties ->events tbh, properties was fine, everything is events in wayland terms,but semantically they're still properties and it separates them from the "done" event REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11732 To: romangg, #frameworks Cc: davidedmundson, michaelh, ngraham
D11732: Improve protocols documentation
romangg added a comment. Currently I'm reading through these protocols for my 5.13 color correction work and I was wondering about the output management related protocol documentation, which seems to me faulty in large areas. In fact it seems to me so wrong, that I'm asking myself if I just don't understand it fully. Since I haven't yet written Wayland protocols please take this into account when reviewing my changes. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11732 To: romangg, #frameworks Cc: michaelh, ngraham
D11732: Improve protocols documentation
romangg created this revision. romangg added a reviewer: Frameworks. Restricted Application added a project: Frameworks. romangg requested review of this revision. REVISION SUMMARY Improves the outputmanagement and outputdevice protocol documentation. REPOSITORY R127 KWayland BRANCH improveOutputManagementDoc REVISION DETAIL https://phabricator.kde.org/D11732 AFFECTED FILES src/client/protocols/output-management.xml src/client/protocols/outputdevice.xml To: romangg, #frameworks Cc: michaelh, ngraham
