D11734: Have KIO build for Android

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a486fd6b2776: Have KIO build for Android (authored by 
apol).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11734?vs=31305=31335

REVISION DETAIL
  https://phabricator.kde.org/D11734

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h
  src/widgets/kurlcompletion.cpp
  src/widgets/previewjob.cpp

To: apol, #frameworks, aacid
Cc: aacid, michaelh, ngraham

D11734: Have KIO build for Android

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11734

To: apol, #frameworks, aacid
Cc: aacid, michaelh, ngraham

D11734: Have KIO build for Android

[Aleix Pol Gonzalez]

apol updated this revision to Diff 31305.
apol added a comment.


  Include comment saying that method won't work on Android

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11734?vs=30676=31305

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11734

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h
  src/widgets/kurlcompletion.cpp
  src/widgets/previewjob.cpp

To: apol, #frameworks
Cc: aacid, michaelh, ngraham

D11734: Have KIO build for Android

[Albert Astals Cid]

aacid added a comment.


  In D11734#236186 , @apol wrote:
  
  > In D11734#235886 , @aacid wrote:
  >
  > > Would it make sense do document the classes/methods that won't work in 
Android?
  >
  >
  > I was about to do that, but I feel a bit weird because it's as if the rest 
would work, which I cannot ensure.
  
  
  Right
  
  > PreviewJob will work, just without the shared memory, which in Android 
doesn't really matter.
  > 
  >   diff --git a/src/core/kmountpoint.h b/src/core/kmountpoint.h
  >   index 1762ae8d..ef7bd8cc 100644
  >   --- a/src/core/kmountpoint.h
  >   +++ b/src/core/kmountpoint.h
  >   @@ -83,6 +83,8 @@ public:
  > * This function gives a list of all currently used mountpoints. 
(mtab)
  > * @param infoNeeded Flags that specify which additional information
  > * should be fetched.
  >   + *
  >   + * @note this method is not supported on Android
  
  supported -> implemented? or "@note this method returns an empty list on 
Androd" ? I'd like to introduce some "if you want to help let's fix it", but 
probably a bit too long for a @note ?
  
  >*/
  >   static List currentMountPoints(DetailsNeededFlags infoNeeded = 
BasicInfoNeeded);
  > 
  > 
  >

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11734

To: apol, #frameworks
Cc: aacid, michaelh, ngraham

D11734: Have KIO build for Android

[Aleix Pol Gonzalez]

apol added a comment.


  In D11734#235886 , @aacid wrote:
  
  > Would it make sense do document the classes/methods that won't work in 
Android?
  
  
  I was about to do that, but I feel a bit weird because it's as if the rest 
would work, which I cannot ensure.
  
  PreviewJob will work, just without the shared memory, which in Android 
doesn't really matter.
  
diff --git a/src/core/kmountpoint.h b/src/core/kmountpoint.h
index 1762ae8d..ef7bd8cc 100644
--- a/src/core/kmountpoint.h
+++ b/src/core/kmountpoint.h
@@ -83,6 +83,8 @@ public:
  * This function gives a list of all currently used mountpoints. (mtab)
  * @param infoNeeded Flags that specify which additional information
  * should be fetched.
+ *
+ * @note this method is not supported on Android
  */
 static List currentMountPoints(DetailsNeededFlags infoNeeded = 
BasicInfoNeeded);

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11734

To: apol, #frameworks
Cc: aacid, michaelh, ngraham

D11734: Have KIO build for Android

[Albert Astals Cid]

aacid added a comment.


  Would it make sense do document the classes/methods that won't work in 
Android?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11734

To: apol, #frameworks
Cc: aacid, michaelh, ngraham

D11734: Have KIO build for Android

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11734

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kmountpoint.cpp
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h
  src/widgets/kurlcompletion.cpp
  src/widgets/previewjob.cpp

To: apol, #frameworks
Cc: michaelh, ngraham