D11822: Make the word/char count a global preference
aacid closed this revision. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11822 To: wsdfhjxc, #ktexteditor, #kate, mwolff, cullmann Cc: kwrite-devel, kde-frameworks-devel, mwolff, dhaumann, cullmann, ngraham, michaelh, kevinapavew, bruns, demsking, sars, #frameworks
D11822: Make the word/char count a global preference
cullmann accepted this revision. cullmann added a comment. Yeah, makes sense. Thanks for the contribution. REPOSITORY R39 KTextEditor BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11822 To: wsdfhjxc, #ktexteditor, #kate, mwolff, cullmann Cc: mwolff, dhaumann, cullmann, ngraham, #frameworks, michaelh, kevinapavew, demsking, sars
D11822: Make the word/char count a global preference
mwolff added subscribers: cullmann, dhaumann, mwolff. mwolff accepted this revision as: mwolff. mwolff added a comment. This revision is now accepted and ready to land. I'm not using that feature, but code-wise this lgtm - but please wait for @dhaumann or @cullmann to give their +1 too REPOSITORY R39 KTextEditor BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11822 To: wsdfhjxc, #ktexteditor, #kate, mwolff Cc: mwolff, dhaumann, cullmann, ngraham, #frameworks, michaelh, kevinapavew, demsking, sars
D11822: Make the word/char count a global preference
ngraham added a comment. Works for me, and this seems more user-friendly than having to manually toggle it for every document. Also this change makes that huge View many a tiny bit smaller and less intimidating. +1. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11822 To: wsdfhjxc, #ktexteditor, #kate Cc: ngraham, #frameworks, michaelh, kevinapavew, demsking, cullmann, sars, dhaumann
D11822: Make the word/char count a global preference
ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11822 To: wsdfhjxc, #ktexteditor, #kate Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D11822: Make the word/char count a global preference
wsdfhjxc created this revision. wsdfhjxc added reviewers: KTextEditor, Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. wsdfhjxc requested review of this revision. REVISION SUMMARY This is an attempt to make the word/char count in the status bar a global preference covering the whole editor instead of a temporary menu option activated on demand for individual documents. BUG: 386897 TEST PLAN 1. Open Kate. 2. Open two new documents. 3. Go to Settings -> Configure Kate -> Appearance. 4. Check the "Show Word Count" option and apply changes. 5. Word counter in the status bar is shown across all documents. 6. Open another new document and observe the word counter. 7. Close Kate and open it once again. 8. The word counter is still there. REPOSITORY R39 KTextEditor BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11822 AFFECTED FILES src/dialogs/katedialogs.cpp src/dialogs/textareaappearanceconfigwidget.ui src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/kateview.cpp To: wsdfhjxc, #ktexteditor, #kate Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann