D12071: add a new ConstrainedSquare formfactor

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mart requested review of this revision.

REVISION SUMMARY
  It will make possible for applets to know they are in a systray-like
  situation

TEST PLAN
  it will need the systray to actually make use of this

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12071

AFFECTED FILES
  src/plasma/plasma.h

To: mart, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Commit message could see some "bug:388995" :)
  
  "ConstrainedSquare" sounds like there could be other "Contrained*" in the 
future? Why this term combination instead of just "Square"?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12071

To: mart, #plasma
Cc: kossebau, #frameworks, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

[Marco Martin]

mart edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12071

To: mart, #plasma
Cc: kossebau, #frameworks, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

[Marco Martin]

mart added a comment.


  suggests that is more about it being constrained both horizontally and 
vertically than being a square, which may not be a given (the actual name comes 
from an old enum value in Plasma 4 that was AspectRatio)
  is i think the most correct name, even if less intuitive would be just 
"constrained"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12071

To: mart, #plasma
Cc: kossebau, #frameworks, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> plasma.h:89
>   for the desktop or the particular device. */
> +ConstrainedSquare /**When the applet is constrained both vertically 
> and horizontally,
> + and can't grow in neither directions, such as those 
> hosted in the SystemTray @since 5.46*/

Lacks < on the comment.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12071

To: mart, #plasma
Cc: apol, kossebau, #frameworks, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D12071#243259 , @mart wrote:
  
  > suggests that is more about it being constrained both horizontally and 
vertically than being a square, which may not be a given (the actual name comes 
from an old enum value in Plasma 4 that was AspectRatio)
  >  is i think the most correct name, even if less intuitive would be just 
"constrained"
  
  
  If so, let's change it to "Constrained" then, if there is a chance that the 
ratio can be different from 1:1.
  Though, what about "Bounded" instead? Non-native speaker myself, but possibly 
sounds more close to real-estate boundaries also for others and might be more 
intuitive than the more abstract "constrained", which could refer to any kind 
of constraints. Also is the term used elsewhere in Qt API, also for the same 
purpose of describing limits.
  
  Any plans to have fullscreen applets one day? There it would also be some 
vertically & horizontally constrained formfactor, would/should this new 
formfactor type also be used for such, or would there then be similar variants 
like there is for "Planar" with "Application" and "MediaCenter"?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12071

To: mart, #plasma
Cc: Zren, apol, kossebau, #frameworks, michaelh, bruns