D12216: Don't need to run previous iterations commands again

2018-04-14 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Frameworks, arojas.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  BUG: 393141

TEST PLAN
  Tested building plasma-workspace, it was clearly faster (although it
  would have finished eventually)

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12216

AFFECTED FILES
  cmake/build-pofiles.cmake

To: apol, #frameworks, arojas
Cc: michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

2018-04-15 Thread Antonio Rojas 
arojas added a comment.


  Works for me, thanks

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12216

To: apol, #frameworks, arojas
Cc: michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

2018-04-16 Thread Aleix Pol Gonzalez 
apol added a comment.


  Landing, I'm unsure if it's worth re-spinning.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12216

To: apol, #frameworks, arojas
Cc: michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

2018-04-16 Thread Heiko Becker 
heikobecker added a comment.


  In D12216#247225 , @apol wrote:
  
  > I'm unsure if it's worth re-spinning ki18n.
  
  
  It's already out, so it would need a .1, but it may be worth it as it appears 
builds are hanging otherwise.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12216

To: apol, #frameworks, arojas
Cc: heikobecker, michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

2018-04-16 Thread Harald Sitter 
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Definitely worth a .1

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12216

To: apol, #frameworks, arojas, sitter
Cc: sitter, heikobecker, michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

2018-04-16 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:9c32bdab29b3: Don't need to run previous iterations 
commands again (authored by apol).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12216?vs=32157&id=32277

REVISION DETAIL
  https://phabricator.kde.org/D12216

AFFECTED FILES
  cmake/build-pofiles.cmake

To: apol, #frameworks, arojas, sitter
Cc: sitter, heikobecker, michaelh, ngraham, bruns